139556 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Volker Lendecke	bea01e845c	vfs: Convert streams_xattr_get_name() to return 0/errno ... This function is pretty simple, this avoids a few calls to map_errno_from_nt_status in the callers Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	7430831f88	smbd: Convert get_ea_value_fsp() to return 0/errno ... Avoid a map_errno_from_nt_status() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	eecdd0fb59	smbd: Convert refuse_symlink_fsp() to bool ... I want to simplify get_ea_value_fsp next Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	4b3b283b1f	smbd: Simplify make_connection_snum() ... Avoid nested if's, don't check for ISDIR twice Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	47c8d9b62a	pylibsmb: Add NFS reparse tag types ... To be used in tests later Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	3dc89edf9c	libsmb: Fix a "cast increases required alignment" warning ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	6c8d817f00	libsmb: Fix trailing whitespace ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	4f727b919a	lsasrv: Simplify dcesrv_lsa_AddRemoveAccountRights() ... Use dom_sid_string_buf, no need to talloc. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	7c4d1f9de1	lib: Simplify nybble_to_hex_* ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	542cf01bfe	ldb: User hexchars_upper from replace.h ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	fd5562bee7	libreplace: Introduce hexchars_{upper|lower} ... We use that in quite a few places in our code. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	72ff0312d1	libcli: Convert an int to a size_t ... More appropriate for an array length Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	83582d417c	lib: Modernize a DEBUG ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	83bb0c4ae6	idl: Fix trailing whitespace ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:35 +00:00
Volker Lendecke	804568a1d7	lib: simplify smbpasswd_sethexpwd() with hex_encode_buf() ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:34 +00:00
Volker Lendecke	282a5778fb	lib: simplify smbpasswd_gethexpwd() with strhex_to_str() ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:34 +00:00
Volker Lendecke	3a5068f294	libcli: Try to fix CID 1609583 Overflowed constant ... Coverity does not like the --i Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:34 +00:00
Volker Lendecke	8a64775334	vfs_fruit: Align a few integer types ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:34 +00:00
Volker Lendecke	63f0b59cbe	vfs_fruit: Simplify filter_empty_rsrc_stream() ... Inspired by Coverity finding CID 1609584 Overflowed constant -- not sure it fixes it. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:34 +00:00
Volker Lendecke	ccb6e6634a	libndr: Early overflow detection ... This is an addition without an overflow check. Do it right there. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:34 +00:00
Volker Lendecke	5d19591e75	libndr: Simplify data flow in ndr_push_relative_ptr2 ... Consolidate saving/replacing ndr->offset right around the push_uint32 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>	2024-11-12 12:09:34 +00:00
Douglas Bagnall	b80afa1ca0	libgpo:admx:: s/the the\b/the/ ... Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Nov 12 09:21:53 UTC 2024 on atb-devel-224	2024-11-12 09:21:53 +00:00
Thomas Klausner	04e0fb9b2d	lib/replace: memset_explicit() only takes three arguments ... Signed-off-by: Thomas Klausner <wiz@gatalith.at> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Nov 11 16:47:46 UTC 2024 on atb-devel-224	2024-11-11 16:47:46 +00:00
Volker Lendecke	1c859ec1db	WHATSNEW: Add client netlogon ping protocol parameter ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Nov 11 15:15:29 UTC 2024 on atb-devel-224	2024-11-11 15:15:29 +00:00
Volker Lendecke	47d7e86a62	tests: Run ad members with new netlogon ping protocol settings ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	f151f462d5	libcli: Make cldap_error_reply() static to cldap_server.c ... Only used there Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	39c4e80455	libcli: Remove two unused functions ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	6d19d4ab7b	libnet: Simplify becomeDC ... Checking for "" does not need a call to strcmp Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	f78a44fce6	docs: Fix a typo in a parameter file name ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	2459337a58	libcli: Move "struct cldap_netlogon" definition to torture ... This structure is only used in torture/ldap/netlogon.c now for historic reasons. Replacing it with something else would be the right thing to do... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	be846bf5a2	libcli: Remove cldap_netlogon() and friends ... Replaced with netlogon_pings() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	4aff4c749b	torture4: Replace direct netlogon ping calls with netlogon_pings() ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	d260478195	torture4: Add ldap.netlogon-ping test ... This will supersede the direct cldap based netlogon tests Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	462748afed	torture4: Use netlogon_pings() in rpc.lsa tests ... Allow LDAPS netlogon ping Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	63b5b5d05b	torture4: Use netlogon_pings_send/recv in bench-cldap ... This slightly changes behaviour: It uses separate client sockets per ping instead of just one, but it allows to compare CLDAP with LDAP and LDAPS (spoiler: LDAPS is *much* slower...) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	74cec52bab	libnet4: Use netlogon_pings() in finddcs_cldap ... Enable LDAPS lookups Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	e7844537b6	libnet4: Use netlogon_pings() in unbecome_dc ... Enable LDAPS lookups Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	bfa6f18a0e	libnet4: Use netlogon_pings() in become_dc ... Allow LDAPS netlogon pings Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	42cafe481d	libnet4: Use netlogon_pings() in findsite ... Enable LDAPS lookups Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	3ecb665422	libnet: Initialize variables in libnet_FindSite() ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	dcc2767185	libnet: Simplify error return in libnet_FindSite() ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	ccfbb5c2ed	libnet: Save a few lines with talloc_move() ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	eb8767a076	libads: Move check_cldap_reply_required_flags() to netlogon_ping.c ... netlogon_ping.c depends on it but itself has fewer dependencies than cldap.c, so we can use it in more places Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	fc7c55c938	libads: Simplify ads_fill_cldap_reply() ... Both callers now guarantee via the filter in netlogon_pings() that the reply contains DCs that have the required flags set. Remove those checks from ads_fill_cldap_reply() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	759665fcf2	libads: Pass "required_flags" through ads_cldap_netlogon_5() ... ... down to netlogon_pings(). Passing 0 right now, this will change for some callers Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	808b79b4a9	libads: Pass "required_flags" through ads_cldap_netlogon() ... ... down to netlogon_pings() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	b802870966	libads: Make ads_cldap_netlogon() static ... Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	523a1c6fa1	libads: remove cldap_multi_netlogon ... Replaced by netlogon_pings() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	8bededd1b3	libsmb: Use netlogon_pings() in dsgetdcname ... Use parallel requests and req_flags filtering provided by netlogon_pings() Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00
Volker Lendecke	cb00b78fa0	kerberos: Use netlogon_pings() ... This also makes sure we've got a KDC via DS_KDC_REQUIRED Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>	2024-11-11 14:03:04 +00:00