Volker Lendecke
a1a81ef785
Revert "s3: Make the implicit reference to Protocol in mask_match() explicit"
...
This reverts commit e23d8a3d1f558a7e98ef2afd71e1d15c5b3a71bc.
2009-11-23 16:35:00 +01:00
Volker Lendecke
d6e55d8ec0
Revert "s3: Make the implicit reference to Protocol in mask_match_list() explicit"
...
This reverts commit 1e22899d268ae5a089f941a204413c07ee64fc78.
2009-11-23 16:35:00 +01:00
Volker Lendecke
5c4885a26b
Revert "s3: Make the implicit reference to Protocol in is_in_path() explicit"
...
This reverts commit f7b4151a64d8c6851e62255a7139fd00a5fc63a3.
2009-11-23 16:35:00 +01:00
Volker Lendecke
7930206f5c
Revert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit"
...
This reverts commit 6a149022976fe6a5579ec9afc7a4d2dcb44dc8af.
2009-11-23 16:34:59 +01:00
Volker Lendecke
0f8e2a6ebb
Revert "s3: Move the global variable Protocol to struct smbd_server_connection"
...
This reverts commit c85a4c9ba4a7de65a7850f6f9708df66bd24deea.
2009-11-23 16:34:59 +01:00
Volker Lendecke
664bc885d9
s3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever
2009-11-23 14:22:54 +01:00
Volker Lendecke
e8ef799c4b
s3: Move a variable declaration to its only use
2009-11-23 14:22:54 +01:00
Günther Deschner
513d6da404
s3-printing: remove duplicate code while cleaning up driver structs.
...
Guenther
2009-11-23 12:57:46 +01:00
Günther Deschner
800d6b7820
s3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.
...
Guenther
2009-11-23 12:20:24 +01:00
Günther Deschner
6364c271c4
s3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.
...
Guenther
2009-11-23 12:19:19 +01:00
Günther Deschner
ec56895bde
s3-printing: use spoolss types and structs while getting and deleting drivers.
...
Guenther
2009-11-23 12:19:11 +01:00
Günther Deschner
68cc1166d9
s3-printing: use spoolss types and structs while adding drivers.
...
Guenther
2009-11-23 12:19:04 +01:00
Günther Deschner
d464151f3b
s3-spoolss: fix spoolss_EnumPrinterKey client and server code.
...
Guenther
2009-11-23 11:44:43 +01:00
Volker Lendecke
579bb30188
s3: Fix bug 6338 -- net rpc trustdom list always display "none"
2009-11-22 22:42:02 +01:00
Volker Lendecke
e28545e854
s3: Fix some nonempty blank lines
2009-11-21 23:19:50 +01:00
Volker Lendecke
384f303c2c
s3: Remove a struct typedef
2009-11-21 23:19:50 +01:00
Volker Lendecke
cf2febf3d1
s3: Make alloc_sub_basic() static
2009-11-21 20:54:10 +01:00
Volker Lendecke
c85a4c9ba4
s3: Move the global variable Protocol to struct smbd_server_connection
2009-11-21 20:49:17 +01:00
Volker Lendecke
6a14902297
s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit
2009-11-21 20:49:17 +01:00
Volker Lendecke
f7b4151a64
s3: Make the implicit reference to Protocol in is_in_path() explicit
2009-11-21 20:49:17 +01:00
Volker Lendecke
1e22899d26
s3: Make the implicit reference to Protocol in mask_match_list() explicit
2009-11-21 20:49:17 +01:00
Volker Lendecke
e23d8a3d1f
s3: Make the implicit reference to Protocol in mask_match() explicit
2009-11-21 20:49:16 +01:00
Volker Lendecke
b79bcd972c
s3: Fix some nonempty blank lines
2009-11-21 20:49:16 +01:00
Volker Lendecke
97525d0a0e
s3: Avoid two calls to strcmp()
2009-11-21 20:49:16 +01:00
Volker Lendecke
e6f95967cc
s3: Fix a bool/enum mismatch
2009-11-21 20:49:16 +01:00
Volker Lendecke
37e4e387db
s3: Convert cli_get_fs_attr_info to the async API
2009-11-21 14:01:56 +01:00
Volker Lendecke
5a1606269a
s3: Tune if-conditions in a very hot codepath
...
This looks innocent, but it is visible in a netbench run. Due to boolean
short-circuiting we don't have to execute the conditions on the right-hand side
of the &&. So putting the less likely condition left gains a bit.
2009-11-21 12:15:39 +01:00
Volker Lendecke
91ccaa87da
s3: Remove a pointless memset
...
We are assigning the complete structure now (we used to assign individual
fields), so this is obsolete.
2009-11-21 11:57:07 +01:00
Volker Lendecke
f0a933d140
s3: Cache brlock.tdb entries for the fast read&write strict locking code path
...
For a netbench run this gains around 2% user-space CPU, fetching a 100MB file
takes around 4% less.
2009-11-21 11:40:13 +01:00
Kai Blin
43ed7a413d
ntlm_auth: use data_blob_talloc() to allocate session key
...
Thanks to Shibu Piriyath <shibunair80@ymail.com> for spotting the issue.
2009-11-21 07:29:33 +01:00
Jeremy Allison
54ba3f522b
Fix logic bug where high bits tests was being
...
done on both Windows and POSIX mkdirs instead of
only on Windows mkdir (as intended). The variable
"file_attributes" had already had FILE_FLAG_POSIX_SEMANTICS
removed above in the function if it had already been set.
Jeremy.
2009-11-20 17:23:20 -08:00
Michael Adam
446ed18eb6
s3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901 )
...
Michael
2009-11-21 00:49:29 +01:00
Michael Adam
4afffc96ee
s3:fix endianness bug in dbwrap_change_uint32_atomic() (bug #6901 )
...
Michael
2009-11-21 00:49:28 +01:00
Günther Deschner
eea5a166e7
s3-build: delete more object files for "make clean".
...
Guenther
2009-11-20 15:49:48 +01:00
Michael Adam
7153200f21
s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_db_init
...
When idmap backend is specified as
idmap backend = ldap:"ldap://server1 ldap://server2"
then currently "ldap://server1 ldap://server2" was passed to
ldap_initialize including the quotes, leading to an ldap error.
Michael
2009-11-20 13:17:23 +01:00
Michael Adam
6a59db9a2e
s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_alloc_init
...
When idmap alloc backend is specified as
idmap alloc backend = ldap:"ldap://server1 ldap://server2"
then currently "ldap://server1 ldap://server2" was passed to
ldap_initialize including the quotes, leading to an ldap error.
Michael
2009-11-20 13:17:22 +01:00
Volker Lendecke
c4c984d97d
s3: Avoid races to change the machine password in winbind
...
The machine password handler has code to deal with every node in the cluster
trying to change the machine password at the same time. However, it is not very
nice to the DC if everyone tries this simultaneously. This adds a random 0-255
second offset to our timed event. When this fires a bit later than strictly
calculated, someone else might have stepped in and have already changed it. The
timed event handler will handle this gracefully, it won't even try to do it
again.
2009-11-19 19:04:39 +01:00
Volker Lendecke
882350b0ab
s3: Protect against flooding the DC with pwchange requests
...
When there is a temporary problem changing passwords we flooded the DC with
pwchange requests. This gives the DC a 60-second break to recover.
2009-11-19 19:04:39 +01:00
Volker Lendecke
4d0ebc90dc
s3: Re-check the timeout in machine_password_change_handler()
...
Someone else might have come in between and changed the password since we
created that timed request
2009-11-19 19:04:39 +01:00
Volker Lendecke
d0ef9fbce6
s3: Add some debugs to the winbind machine pwchange machinery
2009-11-19 19:04:39 +01:00
Volker Lendecke
d3d37acb99
s3: Factor timeval_string out of current_timestring()
2009-11-19 19:04:38 +01:00
Volker Lendecke
d4312e776b
s3: Do not kill the whole smb session if a machine pwchange failed
2009-11-19 19:04:38 +01:00
Michael Adam
557535302c
s3:pdb_ldap: fix a comment typo
...
Michael
2009-11-19 17:55:47 +01:00
Michael Adam
457055871a
s3: shortcut uid_to_sid when "ldapsam:trusted = yes"
...
The normal uid_to_sid behaviour is to call sys_getpwuid()
to get the name for the given uid and then call the
getsampwnam passdb method for the resulting name.
In the ldapsam:trusted case we can reduce the uid_to_sid
operation to one simple search for the uidNumber attribute
and only get the sambaSID attribute from the correspoinding
LDAP object. This reduces the number of ldap roundtrips
for this operation.
Michael
2009-11-19 17:55:47 +01:00
Günther Deschner
fc9f199f26
s3-build: really fix build of winbind_krb5_locator.
...
Guenther
2009-11-19 13:48:44 +01:00
Günther Deschner
bf45447aaa
s3-build: make sure to remove libds and client object files on make clean.
...
Guenther
2009-11-19 13:48:33 +01:00
Volker Lendecke
d1c34d4054
s3: Replace some create_synthetic_smb_fname() calls
...
In very hot codepaths like the statcache copy_smb_filename and the subsequent
recursive talloc_free is noticable in the CPU load.
2009-11-18 23:16:13 +01:00
Volker Lendecke
f6650f5d19
s3: Do not talloc in readdir
...
This is a hot codepath (called from the stat cache)
2009-11-18 23:16:13 +01:00
Michael Adam
aea3a8f501
s3:load_interfaces(): use function gfree_interfaces() that we have.
...
To reduce code duplication.
Michael
2009-11-18 22:19:18 +01:00
Jeremy Allison
7407b526e3
Start removing SMB_STRUCT_STAT variables except for
...
the directory enumeration code (which needs it).
Jeremy.
2009-11-17 16:06:08 -08:00