Nadezhda Ivanova
d300085868
Changed passwords.py to use the correct account as acl checks now pass.
2010-07-05 00:20:37 +03:00
Nadezhda Ivanova
81240b13b3
s4-dsdb: Implementation of User-Change-Password and User-Force-Password-Change
...
These CARs need to be checked on password change and password reset operations.
Apparently the password attributes are not influenced by Write Property.
Single detele operations and modifications of dBCSPwd are let through to the
password_hash module. This is determined experimentally.
2010-07-05 00:17:38 +03:00
Matthias Dieter Wallnöfer
343e9320ba
s4:subtree_rename LDB module - Cosmetic fixes
2010-07-04 22:05:18 +02:00
Matthias Dieter Wallnöfer
7d483cdc04
s4:subtree_delete LDB module - fix comments and add my copyright
...
(I've introduced the subtree delete mechanism)
2010-07-04 22:05:17 +02:00
Matthias Dieter Wallnöfer
83dedef2c7
s4:wb_cmd_list_groups.c - don't crash when we don't get any group at all
2010-07-04 22:05:17 +02:00
Matthias Dieter Wallnöfer
680453a906
s4:wb_cmd_list_groups.c - indentation and comment fixes
2010-07-04 22:05:17 +02:00
Matthias Dieter Wallnöfer
b0bba4003e
s4:libnet - add missing "talloc_free"s for "c" contexts on "recv" operations
2010-07-04 22:05:17 +02:00
Matthias Dieter Wallnöfer
6dc1c70876
s4:torture/rpc/samlogon.c - strip trailing whitespaces
2010-07-03 21:10:18 +02:00
Matthias Dieter Wallnöfer
e2e09f5c45
s4:torture/rpc/samlogon.c - provide a function which sets and afterwards resets the minimum password age
...
This is needed since we on s4 do now use the Windows Server standard of 1 day.
2010-07-03 21:04:47 +02:00
Matthias Dieter Wallnöfer
f41d9eb8dc
s4:dsdb/tests/python/ldap_schema.py - remove a now useless "schemaUpdateNow" request
...
"schemaUpdateNow" on s4 is now a non-op and therefore not strictly needed anymore.
2010-07-03 15:37:45 +02:00
Matthias Dieter Wallnöfer
465c601071
s4:urgent_replication.py test - remove unneeded "relax" control parameters
2010-07-03 15:30:20 +02:00
Matthias Dieter Wallnöfer
326aac06f5
s4:schema_load LDB module - fix a segfault condition on schema refresh
...
The schema refresh operation itself starts requests from the top of the LDB
modules stack (see call "dsdb_schema_set_attributes" - search operations).
This doesn't work well when these do perform "dsdb_get_schema" calls. Since the
new schema isn't marked as "refreshed" atm (but in fact it still is - we didn't
terminate the reload/refresh yet) we could perform other calls to
"dsdb_schema_refresh" and run into serious trouble (segfault).
2010-07-03 15:28:57 +02:00
Matthias Dieter Wallnöfer
02eab66026
s4:schema_set.c - Fix a comment
2010-07-03 14:53:03 +02:00
Matthias Dieter Wallnöfer
d1ee7ab16e
s4:dsdb_schema_set_attributes - remove unneeded filter criterias
...
We already choose the right entry by specifying the right basedn with scope
"LDB_SCOPE_BASE".
2010-07-03 14:53:02 +02:00
Matthias Dieter Wallnöfer
368aa25f7c
s4:dsdb_module_load_partition_usn - check for "res->count" equal/unequal to 1
2010-07-03 12:47:46 +02:00
Matthias Dieter Wallnöfer
4df9757b48
s4:schema_set.c - fix typo
2010-07-03 12:36:34 +02:00
Matthias Dieter Wallnöfer
de81160e75
s4:schema_load.c - jump to "failed" on an error condition
2010-07-03 12:35:16 +02:00
Matthias Dieter Wallnöfer
43b0c314d8
s4:setup/provision_basedn_modify.ldif - set "minPwdAge" to the right value
...
Now we should have fixed all password related tests to cooperate with this value
2010-07-03 11:38:54 +02:00
Matthias Dieter Wallnöfer
c0ee606474
s4:pwsettings net utility - change also here the "minPwdAge" to be the real default
...
Which is one day.
2010-07-03 11:38:54 +02:00
Matthias Dieter Wallnöfer
ec9fa906c7
s4:dsdb/tests/passwords.py - set and reset the "minPwdAge" properly
...
After a patch proposal of Nadya and some reflection I think that it's really
worth to change all tests which need a "0" "minPwdAge" to set it manually and
reset the default afterwards.
So we can finally introduce the default "minPwdAge" on provision.
Patch proposal by: Nadya Ivanova
2010-07-03 11:28:21 +02:00
Nadezhda Ivanova
86cde0a7dc
Tests for user-change-password and force-password-change access rights
2010-07-02 16:38:05 +03:00
Anatoliy Atanasov
62341537d7
s4/schema: remove unnecessary deletion of dsdb_schema cached pointer
...
This is needed so we can find and free old schemas based using
the cached pointer
2010-07-02 11:55:33 +03:00
Günther Deschner
6da040261d
s4-smbtorture: enable extended SetValue test against Samba3.
...
Guenther
2010-07-02 10:50:21 +02:00
Andrew Tridgell
84c5dd1e4b
s4-ldb: fixed error handling in openldap backend
...
fixed several bugs in error handling. the ldb context was used without
being initialised in the error paths, and several error paths did not
set an ldb error string.
2010-07-02 12:49:04 +10:00
Andrew Tridgell
277a9b4aac
s4-ldb: fixed the parsing of references in the openldap backend
...
We need to use ldap_parse_reference() not ldap_parse_result()
2010-07-02 12:49:04 +10:00
Andrew Tridgell
f9022a1a30
s4-dsdb: fixed use after free of sasl mechanisms opaque
...
the supportedSASLMechanisms opaque must live for at least as long as
the ldb, or we can crash when the first connection is torn down
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-07-02 12:49:04 +10:00
Andrew Tridgell
2671b5aeb0
s4-dsdb: fixed spelling of supportedSASLMechanisms
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-07-02 12:49:04 +10:00
Andrew Bartlett
c48279896d
s4:dsdb Ensure we free old schema copies
...
It was reported by aatanasov that we kept around one whole schema per
modification made. This does not fix that, but I hope moves us closer
to a fix
The most important part of the fix is that:
- if (schema_out != schema_in) {
- talloc_unlink(schema_in, ldb);
- }
was the wrong way around. This is now handled in the schema_set calls.
Andrew Bartlett
2010-07-02 10:08:16 +10:00
Kamen Mazdrashki
5a66edc99e
s4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function call
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:08:12 +10:00
Kamen Mazdrashki
73474998e1
s4-source4/dsdb/samdb/ldb_modules/util.c Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:08:07 +10:00
Kamen Mazdrashki
682f7a5338
s4-source4/dsdb/samdb/ldb_modules/subtree_delete.c: Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:08:02 +10:00
Kamen Mazdrashki
bf373d5c29
s4-source4/dsdb/samdb/ldb_modules/schema_load.c: Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:57 +10:00
Kamen Mazdrashki
7c653c429a
s4-source4/dsdb/samdb/ldb_modules/samldb.c: Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:53 +10:00
Kamen Mazdrashki
0e023f2340
s4-source4/dsdb/samdb/ldb_modules/samba3sid.c: Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:48 +10:00
Kamen Mazdrashki
30a69eb4a0
s4-source4/dsdb/samdb/ldb_modules/rootdse.c: Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:43 +10:00
Kamen Mazdrashki
68c6e607d9
s4-source4/dsdb/samdb/ldb_modules/ridalloc.c: Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:39 +10:00
Kamen Mazdrashki
f3f87e8dee
s4-source4/dsdb/samdb/ldb_modules/repl_meta_data.c: Use DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:34 +10:00
Kamen Mazdrashki
b29921b82e
s4-dsdb/samdb/ldb_modules/linked_attributes.c: make use of DSDB_FLAG_NEXT_MODULE flag
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:27 +10:00
Kamen Mazdrashki
f570eec264
s4/dsdb: Add DSDB_FLAG_NEXT_MODULE flag
...
Although it is not currently used in implementation,
my intention is for callers to clearly state what
action they want to execute.
Currently when a caller wants to pass the call to the next
module in the chain, this flag is either omitted or 0 is used
(which is somewhat hacky, isn't it)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:07:09 +10:00
Matthias Dieter Wallnöfer
c2e2f783d0
s4:dsdb/tests/python/passwords.py - add the right result codes for user password changes
...
They will be enabled once the ACL modules supports it. It was my fault to not
import them earlier.
2010-07-01 17:23:01 +02:00
Matthias Dieter Wallnöfer
21c2155126
s4:lib/registry/ldb.c - free some "msg" objects earlier through explicit "talloc_free"s
...
No other functional change
2010-07-01 16:35:12 +02:00
Matthias Dieter Wallnöfer
de8a339cdf
s4:registry - move some common constraint checks to the "local" backend
...
They should also be enforced when we don't use "ldb".
2010-07-01 15:48:06 +02:00
Matthias Dieter Wallnöfer
d81e2af69d
s4:lib/registry/tests/registry.c - test recursive key generation
2010-07-01 15:48:05 +02:00
Matthias Dieter Wallnöfer
ae50385d52
s4:registry - on key add operations we have to handle with paths not always only a name
...
Recursive key generations are allowed.
2010-07-01 15:48:05 +02:00
Matthias Dieter Wallnöfer
781ea5be13
s4:lib/registry/local.c - support recursive key generation
...
Code taken from "local_open_key".
2010-07-01 15:48:05 +02:00
Matthias Dieter Wallnöfer
809c747900
s4:lib/registry/ldb.c - refactor "reg_path_to_ldb"
...
This makes it easier to understand and would also support splitting in more
DN components.
2010-07-01 15:48:04 +02:00
Matthias Dieter Wallnöfer
50ae292e60
s4:lib/registry/ldb.c - use "ldb_path" rather than "ldap_path" as LDB key varibale identifiers
2010-07-01 15:48:04 +02:00
Matthias Dieter Wallnöfer
d0e877e785
s4:lib/registry/ldb.c - "ldb_add_key" - fix talloc handling
...
- free "msg" when possible
- prevent "talloc_strdup"s where not necessary
2010-07-01 15:48:04 +02:00
Günther Deschner
6961048487
s4-smbtorture: in extended setvalue winreg test, reduce max random buffer length to 16 bytes.
...
Guenther
2010-06-30 21:46:09 +02:00
Günther Deschner
e1c185d07d
s4-smbtorture: enable QueryMultipleValues{2} torture tests against samba3.
...
Guenther
2010-06-30 21:46:08 +02:00