Günther Deschner
21b083a647
s3-svcctl: Fix _svcctl_EnumServicesStatusW() crash bug on too small buffer.
...
Guenther
2009-04-07 01:16:30 +02:00
Tim Prouty
9d2d07503a
s3 onefs: Simplify level 2 oplock self-contention
...
This removes all oplock dependence on locking.tdb
2009-04-06 13:53:45 -07:00
Tim Prouty
651fa0964a
s3 oplocks: Refactor level II oplock contention
2009-04-06 13:53:45 -07:00
Günther Deschner
12d9765177
s3-samr: add support for _samr_Connect3() while planning to pass a s4 smbtorture test.
...
Guenther
2009-04-06 22:37:11 +02:00
Volker Lendecke
1c4027678e
Correct sync wrappers in cli_pipe.c
2009-04-06 21:32:08 +02:00
Volker Lendecke
3084d49cc0
Add a bad hack to enable level 2 oplocks in torture_open_connection_share
2009-04-06 21:32:08 +02:00
Volker Lendecke
0c353b5711
Make cli_oplock_ack async
2009-04-06 21:32:08 +02:00
Volker Lendecke
64ce0e4645
Add async oplock waiter
2009-04-06 21:32:08 +02:00
Volker Lendecke
cb120b4df6
Never hand out 0xffff as a mid
...
This is used for oplock replies
2009-04-06 21:32:07 +02:00
Volker Lendecke
64067f9204
Remove async_req based async libsmb infrastructure
2009-04-06 21:32:07 +02:00
Volker Lendecke
86b09e84ae
Re-add the CHAIN1 test
2009-04-06 21:32:07 +02:00
Volker Lendecke
025eb40fbc
Convert cli_open to tevent_req
2009-04-06 21:32:07 +02:00
Volker Lendecke
31910810cf
Convert cli_close to tevent_req
2009-04-06 21:32:07 +02:00
Volker Lendecke
ad695b2525
Streamline cli_push sync wrapper
2009-04-06 21:32:07 +02:00
Volker Lendecke
097db28c5d
Convert cli_write_andx to tevent_req
2009-04-06 21:32:07 +02:00
Volker Lendecke
17b8d05b62
Streamline cli_pull sync wrapper
2009-04-06 21:32:07 +02:00
Volker Lendecke
c23ccff13a
Convert cli_read_andx to tevent_req
2009-04-06 21:32:07 +02:00
Volker Lendecke
ca7cd350a6
Convert cli_ntcreate to tevent_req
2009-04-06 21:32:07 +02:00
Volker Lendecke
807328ce6d
Convert cli_tcon_andx to tevent_req
2009-04-06 21:32:07 +02:00
Volker Lendecke
03becb5066
Convert cli_negprot to tevent_req
2009-04-06 21:32:06 +02:00
Volker Lendecke
95c792b6af
Convert cli_session_setup_guest to tevent_req
2009-04-06 21:32:06 +02:00
Volker Lendecke
7ef78bd7b5
Convert cli_trans to tevent_req
2009-04-06 21:32:06 +02:00
Volker Lendecke
dec928e884
Convert cli_echo to tevent_req
2009-04-06 21:32:06 +02:00
Volker Lendecke
0a4cdad324
Remove the CHAIN1 test -- will come back later
2009-04-06 21:32:06 +02:00
Volker Lendecke
8bdac3615a
Add new async libsmb infrastructure
...
I know this is just yet another iteration, but I like this one much better than
the one that exists right now :-)
It will do trans and echo requests without a _recv helper and without
unnecessary memcpy().
2009-04-06 21:32:06 +02:00
Volker Lendecke
ad29104d3d
Add read_smb_send/recv, dumping keepalives
2009-04-06 21:32:05 +02:00
Andrew Bartlett
2050187673
s3:libads Make ads_get_dn() take a talloc context
...
Also remove ads_memfree(), which was only ever a wrapper around
SAFE_FREE, used only to free the DN from ads_get_ds().
This actually makes libgpo more consistant, as it mixed a talloc and a
malloc based string on the same element.
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
2009-04-06 15:54:41 +02:00
Andrew Bartlett
89278b1819
s3:printing Convert nt_printer_publish_ads() to use talloc better
...
In particular, this removes one more user of pull_utf8_allocate()
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
2009-04-06 14:56:29 +02:00
Andrew Bartlett
9512640155
s3:smbldap Remove smbldap_get_dn
...
This removes one more caller to pull_utf8_allocate()
Signed-off-by: Günther Deschner <gd@samba.org>
2009-04-06 14:52:51 +02:00
Volker Lendecke
a2d5fe4a05
Make some functions static to vfs_gpfs.c
2009-04-06 13:29:59 +02:00
Volker Lendecke
f2e17a4b24
Add prototype for smbd_gpfs_get_realfilename_path
2009-04-06 13:29:59 +02:00
Volker Lendecke
54c2fe6583
Fix two c++ warnings in vfs_gpfs.c
2009-04-06 13:29:59 +02:00
Volker Lendecke
15f6d5e805
Use the server config file for smbpasswd -a user in make test
...
Without this, smbpasswd generated a SID for the netbios name TORTURE_6. This SID
somehow ended up in the user's token for quite a number of tests, leading to
NT_STATUS_ACCESS_DENIED. I haven't fully understood what is going on here, but
with this patch I could not reproduce the ACCESS_DENIED anymore. It might be
coincidence and this patch does not fix anything, but for me it does not really
hurt either.
Metze, please check!
Volker
2009-04-05 17:31:40 +02:00
Volker Lendecke
e5c7df34f2
Remove a silly check
...
This does not increase security, and if later error messages suck, we have to
fix those.
2009-04-05 17:04:28 +02:00
Volker Lendecke
ba408a2c82
Remove async_req dependency from cli_pull_trans
2009-04-05 16:07:41 +02:00
Volker Lendecke
3b0572bf91
Fix smbd crash for close_on_completion
...
handle_trans() can talloc_free "conn" if the client requests
close_on_completion. "state" is a talloc_child of conn, so it will be gone when
we later free state->data et al.
2009-04-05 14:34:14 +02:00
Volker Lendecke
0421fa90ce
Keep the forked-smbd stdout reader around longer
2009-04-05 13:52:46 +02:00
Volker Lendecke
6d760a4a9f
Ensure 0-termination for the forked-smbd debug output
2009-04-05 13:52:46 +02:00
Volker Lendecke
ac4c319ed7
Pass the current debuglevel down to the forked smbd
2009-04-05 13:52:46 +02:00
Günther Deschner
df29f49edd
s3-samr: add support for setting password hashes via samr_SetUserInfo level 21.
...
Guenther
2009-04-03 13:14:26 +02:00
Volker Lendecke
7ee4f168d8
Use cluster-aware procid_is_me instead of comparing pid's
2009-04-03 12:19:20 +02:00
Volker Lendecke
b63cd72ae4
Use procid_str in debug messages for better cluster-debuggability
2009-04-03 12:19:20 +02:00
Günther Deschner
621d40332a
s3-build: fix the build after tsocket changes.
...
Metze, please check.
Guenther
2009-04-03 00:30:58 +02:00
Günther Deschner
31ab1d6a64
s3-lsa: use LSA_ROLE definitions in _lsa_QueryInfoPolicy().
...
Guenther
2009-04-02 22:52:52 +02:00
Günther Deschner
168eb23252
s3-lsa: don't SAFE_FREE talloced structs.
...
Guenther
2009-04-02 22:50:44 +02:00
Günther Deschner
37aff885a6
s3-spoolss: implement _spoolss_GetPrinterDriver2 level 101 (Bug #5140 ).
...
Guenther
2009-04-02 12:46:04 +02:00
Jeremy Allison
c57b32c5ab
Allow pdbedit to change a user rid/sid. Based on a fix from Alexander Zagrebin <alexz@visp.ru>.
...
Jeremy.
2009-04-01 20:21:02 -07:00
Jeremy Allison
1258ed8b1c
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
2009-04-01 20:20:44 -07:00
Tim Prouty
87fe4d732d
s3 onefs: Quiet a log message about oplocks being requested on streams
2009-04-01 20:06:18 -07:00
Michael Adam
36c1a52a57
s3:net conf: don't store share names as lower case, but as given.
...
Michael
2009-04-02 00:30:13 +02:00
Jeremy Allison
aef0bdc6a1
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
2009-04-01 14:03:17 -07:00
Günther Deschner
01a942d8ab
s3-auth: rename static smb_create_user(). Sorry...
...
Guenther
2009-04-01 21:44:14 +02:00
Günther Deschner
5cdf75e679
s3-libnet-samsync: return appropriate error code in fetch_sam_entry().
...
Guenther
2009-04-01 19:12:19 +02:00
Günther Deschner
e18f57fd36
s3-libnet-samsync: use smb_create_user().
...
Guenther
2009-04-01 19:12:19 +02:00
Günther Deschner
d0e1ff4aff
s3-passdb: add smb_create_user().
...
Guenther
2009-04-01 19:12:19 +02:00
Günther Deschner
e4802bfcad
s3-libnet-samsync: some pure cosmetics.
...
Guenther
2009-04-01 19:12:19 +02:00
Günther Deschner
af78240cbe
s3-libnet-samsync: use parent talloc context for libnet_samsync_passdb.
...
Guenther
2009-04-01 19:12:18 +02:00
Jeremy Allison
eaddcfef1b
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
2009-04-01 09:16:41 -07:00
Günther Deschner
264b28ec09
s3-libnet: only call libnet_dssync_process() startup and shutdown callbacks when filled in.
...
Guenther
2009-04-01 16:58:48 +02:00
Volker Lendecke
ffdc2a3fe8
Print an error if trying a merged build without a system kerberos lib
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-04-01 16:31:10 +02:00
Michael Adam
6edaf6188c
s3: fix the fix for bug #6195 - dont let smbd child processes panic
...
This patch makes sure the original and temporary TDBs are closed
_before_ the rename. Originally, the open TDB was renamed, and so
the name passdb.tdb.tmp stayed around in the db context. Hence
upon client connect, the smbd children died because reinit_after_fork()
calling tdb_reopen_all() would try to reopen passdb.tdb.tmp which
existed no longer...
Michael
2009-04-01 12:26:36 +02:00
Michael Adam
1e92ddd405
s3:build: add targets to show how libraries will be built / linked
...
showlibtalloc, showlibtdb, ... and one overall showlibs target.
Michael
2009-04-01 10:41:35 +02:00
Michael Adam
99b486a056
s3:build: don't build the static libs unconditionally
...
Michael
2009-04-01 10:41:35 +02:00
Michael Adam
b79157f602
s3:build: add LIBSMBCLIENT_LIBS and LIBSMBSHAREMODES_LIBS to Makefile
...
for completeness
Michael
2009-04-01 10:41:34 +02:00
Michael Adam
15ef346f9f
s3:build: no need to set LIBFOO_STATIC to the object collection any more
...
now that the @LIBFOO_STATIC@ entries have vanished from the object lists.
Just use the static library.
Michael
2009-04-01 10:41:34 +02:00
Michael Adam
993c87495b
s3:build: rename WINBIND_LIBS -> LIBWBCLIENT_LIBS for unification
...
Michael
2009-04-01 10:41:34 +02:00
Michael Adam
baf39de623
s3:build: unify linking of libwbclient with a @LIBWBCLIENT_TARGET@
...
just like for the libs configured with SMB_LIBRARY().
This makes @LIBWBCLIENT_STATIC@ vanish from the object collections.
Michael
2009-04-01 10:41:33 +02:00
Michael Adam
f9eb77477b
s3:build: first cut at fixing linking of shared/static libs internally
...
This is based on a patch from the debian packages
by Steve Langasek <vorlon@debian.org>.
It removes the static libs from the object collections.
For those libs that are set up with SMB_LIBRARY().
Michael
2009-04-01 10:41:33 +02:00
Jeremy Allison
1e742660bf
Tidy up some convert_string_internal error cases, found by Andrew Bartlett.
...
Jeremy.
2009-03-31 18:28:49 -07:00
Tim Prouty
7424665061
s3 onefs: Add missing newlines to debug statements in the onefs module
2009-03-31 17:31:50 -07:00
Zack Kirsch
bfc7bb49ff
s3 onefs: Async failures are resulting in SMB_ASSERT->smb_panic while running many of the LOCK torture tests.
...
Return true from the onefs cancel function if we've errored, which can happen
when the CBRL domain is configured to only give out 1 lock. :)
2009-03-31 17:29:07 -07:00
Volker Lendecke
62f12e2322
Fix an uninitialized variable valgrind error
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-03-31 21:19:15 +02:00
Michael Adam
d8425032cc
s3:build: fix build of pam_winbind.so with static linking
...
Static talloc libs were missing since conversion to talloc.
Michael
2009-03-31 16:55:40 +02:00
Michael Adam
9aab2631c6
s3:build: add a SHOWCFLAGS target for debugging how CFLAGS are assebled
...
Michael
2009-03-31 08:51:40 +02:00
Michael Adam
b2e8bc28a5
s3:build: line-wrap assignment of FLAGS for readability
...
Michael
2009-03-31 08:51:40 +02:00
Jeremy Allison
9be2e2fdce
Ensure files starting with multiple dots are hidden
...
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
2009-03-30 15:05:39 -07:00
Björn Jacke
4b184eaea1
s3/cups: add encryption support
2009-03-30 11:11:19 +02:00
Volker Lendecke
4b8e4ea728
Fix a debug msg typo
2009-03-29 00:53:04 +01:00
Jeremy Allison
0b890ae19a
Fix the problem of 3.0.x passdb databases being version
...
3 but using a different hash calculation than 3.2.x passwd
databases (also version 3). Introduces a minor version
number.
Jeremy.
2009-03-27 21:29:37 -07:00
Scott Urban
ee22c417f3
s3: added per-client statistics to onefs perfcount module
...
* we now track, uid, remote ip, and local ip per CIFS operation
* removed perfcount_set_client() from perfcount interface as it's
unecessary
2009-03-27 17:33:26 -07:00
Derrell Lipman
c33f3d5cba
[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno
...
Fixed.
It turns out there were a number of places where cli_resolve_path() was called
and the error path upon that function failing did not set errno. There were a
couple of places the failure handling code did set errno to ENOENT, so I made
them all consistent, although I think better errno choices for this condition
exist, e.g. EHOSTUNREACH.
Derrell
2009-03-27 18:02:46 -04:00
Volker Lendecke
4b88f2c17e
Fix external np read after conversion to tevent_req
2009-03-27 21:12:17 +01:00
Jeremy Allison
d942d248d6
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly. For the clustering case.
...
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
2009-03-27 12:13:13 -07:00
Björn Jacke
66b97d36b9
s3: ifdef sendfile code that's only used in other ifdef'ed sendfile code
...
This fixes a "defined but not used" compile warning.
2009-03-27 13:41:35 +01:00
Stefan Metzmacher
424370274a
s3:build: make it possible to pass down CTAGS_OPTIONS or ETAGS_OPTIONS
...
metze
2009-03-27 12:19:10 +01:00
Volker Lendecke
9e70a960b7
Fix the build of nfsv4_acls.c
...
.. after adding smb_iconv_convenience to ndr_size_security_descriptor()
2009-03-27 11:10:50 +01:00
Jeremy Allison
1f83aafac8
Try and fix the build farm RAW-STREAMS errors. Ordering of
...
modules shouldn't matter, so as vfs_streams_depot doesn't
implement get/setxattrs then call into the full VFS stack
at the top.
Jeremy
2009-03-26 15:30:42 -07:00
Jeremy Allison
e235b4628b
Revert 757d403dff
- module
...
order shouldn't matter & I have a more correct fix for this.
Jeremy.
2009-03-26 14:48:34 -07:00
Jeremy Allison
757d403dff
This should fix the build farm RAW-STREAMS failure. streams_depot.so
...
depends on xattrs, and xattr_tdb was pushed *first* in the stack...
Jeremy.
2009-03-26 14:34:25 -07:00
Jeremy Allison
94ba56b2bd
Fix bug #6224 - nmbd waits 5 minutes at startup before checking if it needs to run elections
...
Fix logic bug that causes nmbd to wait 5 minutes before
looking for a master browser. This one is *old* :-). Thanks
for Simo for bugging me on this.
Jeremy.
2009-03-26 12:28:40 -07:00
Jelmer Vernooij
494e471d74
configure: Use m4 defines for minimum library versions rather than shell
...
variables, so the values rather than the variable names show up in
configure output.
2009-03-26 16:28:45 +01:00
Jelmer Vernooij
30a3dec549
Merge branch 'master' of ssh://git.samba.org/data/git/samba into displaysec
2009-03-26 15:28:18 +01:00
Volker Lendecke
2d087a0c15
Fix a talloc/malloc screwup in file_lines_pload
...
Another bug due to careless merge to /lib :-(((
Volker
2009-03-26 14:58:38 +01:00
Volker Lendecke
c164c0c20a
Fix a scary "fill_share_mode_lock failed" message
...
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.
Change the corresponding debug message to level 10 and explain more.
2009-03-26 12:30:44 +01:00
Günther Deschner
56d74b6212
s3-libnetapi: fix creds in libnetapi_open_ipc_connection().
...
Jeremy, this broke with 8dd1faaa29
. Not sure if
other users broke as well with that change.
Guenther
2009-03-26 10:43:18 +01:00
Günther Deschner
fe340eb92f
s3:rpc_parse: remove unused init_unistr().
...
Guenther
2009-03-26 10:42:13 +01:00
Günther Deschner
24d5229a81
s3-net: Fix Bug #6102 . NetQueryDisplayInformation could return wrong information.
...
Guenther
2009-03-26 10:29:57 +01:00
Volker Lendecke
a20a710c94
Avahi disables a timer by tv=NULL in avahi_timeout_update(), do not crash
2009-03-26 10:05:27 +01:00
Jeremy Allison
202228d48b
Ensure we never enter VFS_CREATE without having initialized
...
sbuf as invalid (if not already read via stat()). Still trying
to find the build farm RAW-STREAM errors and it's happening
in a openX call....
Jeremy.
2009-03-25 21:48:37 -07:00
Michael Adam
5adeaea664
Revert "s3/swat: don't link against zlib"
...
This reverts commit 8532faffd0
.
swat needs zlib through ../librpc/ndr/ndr_compression.c, function
ndr_pull_compression_mszip_chunk(). This fails to link at least
on our build farm bsd boxes.
Michael
2009-03-26 01:31:44 +01:00