Günther Deschner
a62cc2ce44
samba: pass down size_t instead of int to add_string_to_array().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Nov 17 19:53:22 CET 2014 on sn-devel-104
2014-11-17 19:53:22 +01:00
David Disseldorp
b7caabdb9e
libgpo: replace dup_sec_desc() usage
...
Use security_descriptor_copy() instead, which is also provided by
libcli.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2014-05-28 17:52:13 +02:00
Garming Sam
952bc3cad0
Remove a number of NT_STATUS_HAVE_NO_MEMORY_AND_FREE macros from the codebase.
...
Following the current coding guidelines, it is considered bad practice to return from
within a macro and change control flow as they look like normal function calls.
Change-Id: I133eb5a699757ae57b87d3bd3ebbcf5b556b0268
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-03-05 16:33:21 +01:00
Günther Deschner
8e5f4eab76
libgpo: apply some const.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jan 7 18:52:42 CET 2014 on sn-devel-104
2014-01-07 18:52:42 +01:00
Günther Deschner
88a0c401fc
libgpo: only use libgpo/gpext/gpext.h where really needed.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:39 +01:00
Günther Deschner
c3f9d9929c
libgpo: allow to pass down a list of deleted GPOs in gpo_process_gpo_list().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:39 +01:00
Günther Deschner
a78b4d4f65
libgpo: remove some unused code and remove that important FIXME note.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:39 +01:00
Günther Deschner
f6bc219850
libgpo: directly call gpext_process_extension() from gpo_process_gpo_list.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
685da81365
libgpo: implement CSE filtering in gpext_process_extension().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
bb351dec9b
libgpo: remove gpext_process_gpo_list_with_extension in favor of gpext_process_extension.
...
gpext_preocess_extension properly deals with GPO lists now.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
1010a01119
libgpo: remove extension_guid and snapin_guid (the tool guid) from the process callback.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
a9cb3031bc
libgpo: allow to pass down deleted and changed gpo list to CSE plugins.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
19268c5c26
libgpo/gpext: add new gpext_check_gpo_for_gpext_presence() helper function.
...
It will be used to inspect single members of a gpo list for the presence of a CSE guid.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
288e883fb0
libgpo: add gpo_copy().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
57498dc569
libgpo: make gpo_get_gp_ext_from_gpo public.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
3ef7919e3a
libgpo: make gpo_process_a_gpo() static to the util code.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
0a15360f35
libgpo: remove unused gp_registry_entry2 struct.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
9a4e007d90
libgpo: remove ads reference from dump calls and make them take const structs.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
c39425f14b
libgpo: prefix some more calls with gpext_.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
69997e2911
libgpo: rename debug_gpext_header to gpext_debug_header.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2014-01-07 16:59:38 +01:00
Günther Deschner
ec790f84be
libgpo: remove unused process_group_policy2 callback from CSE module API.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Dec 18 16:45:20 CET 2013 on sn-devel-104
2013-12-18 16:45:20 +01:00
Günther Deschner
65a3ed5134
libgpo: remove some unnecessary usage of ADS_STATUS.
...
Use NTSTATUS instead.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-18 14:48:24 +01:00
Günther Deschner
172d6cd0d0
libgpo: remove unrequired references to ads_struct.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-18 14:48:24 +01:00
Günther Deschner
e3be1d1188
libgpo: clean up CSE api, remove unrequired references to ads_struct.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-18 14:48:24 +01:00
Günther Deschner
8fef712eff
libgpo: clean up CSE module api, remove unrequired references to ads_struct.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-18 14:48:24 +01:00
Günther Deschner
103e672ef5
libgpo: support probing for parameters in gp_inifile_get functions.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-18 14:48:24 +01:00
Günther Deschner
785c3c12a9
libgpo: check for talloc failures in ini file parsing routines.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-18 14:48:24 +01:00
Günther Deschner
12c7b9498c
libgpo: add gp_inifile_getbool().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-12 13:34:51 +01:00
Günther Deschner
c329a6abcc
libgpo: fix segfault in gpo_process_gpo_list().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-12 13:34:50 +01:00
Günther Deschner
bc870ee845
libgpo: remove use of deprecated talloc functions.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-12 13:34:50 +01:00
Günther Deschner
feffac8068
libgpo: remove unused libgpo wscript_build.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-12 13:34:50 +01:00
Günther Deschner
36abc1c4e6
libgpo: use existing connection to the ds for the sysvol queries.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-12 13:34:50 +01:00
Günther Deschner
24cc4d5ac1
libgpo: remove unused loadparm_context from functions.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-12-12 13:34:50 +01:00
Andreas Schneider
90cbfc96d1
Make sure to set umask() before calling mkstemp().
...
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Mar 6 01:16:34 CET 2013 on sn-devel-104
2013-03-06 01:16:34 +01:00
Andreas Schneider
e4649da0c7
libgpo: Make it clear that we want to fall trough here.
...
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-21 13:56:01 +01:00
Jeremy Allison
526e875cec
Check error returns from strupper_m() (in all reasonable places).
2012-08-09 12:06:54 -07:00
Andrew Bartlett
f3562424b6
lib/param: Move all enum declarations to lib/param
...
This is in preperation for the parameter table being made common.
Andrew Bartlett
Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
2012-07-24 11:01:17 +02:00
Björn Jacke
43c56dc425
s3: fix build without ads support
...
when we have no ads support we don't have the ads_get_sid_token symbol used in
this unused code :-)
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Jun 13 21:20:15 CEST 2012 on sn-devel-104
2012-06-13 21:20:15 +02:00
Andrew Bartlett
f6e0532024
build: Remove SMB_STRUCT_DIR define
2012-04-05 02:39:09 +02:00
Andrew Bartlett
2320b2144f
build: Remove SMB_STRUCT_DIRENT define
2012-04-05 02:39:09 +02:00
Andrew Bartlett
3e8a6e5760
build: Remove sys_closedir wrapper
2012-04-05 02:39:09 +02:00
Andrew Bartlett
afdb78075c
build: Remove sys_readdir wrapper
2012-04-05 02:39:09 +02:00
Andrew Bartlett
fe526bb32b
build: Remove sys_opendir wrapper
2012-04-05 02:39:09 +02:00
Andrew Bartlett
a005acfe8e
libgpo: call security_token_has_sid() directly
2011-09-08 19:33:13 +10:00
Andrew Bartlett
68e0b262be
build: Remove _SAMBA_BUILD == 4 from libgpo
...
This code has no hope of building against the samba4 libs (it has been
disabled for a very long time, and files referenced don't exist etc),
and with the common build there simply is no need.
Andrew Bartlett
2011-07-06 12:59:49 +10:00
Andrew Bartlett
a1f04e8abc
libcli/util Rename common map_nt_error_from_unix to avoid duplicate symbol
...
The two error tables need to be combined, but for now seperate the names.
(As the common parts of the tree now use the _common function,
errmap_unix.c must be included in the s3 autoconf build).
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jun 20 08:12:03 CEST 2011 on sn-devel-104
2011-06-20 08:12:03 +02:00
Andrew Bartlett
74eed8f3ed
s3-param Remove special case for global_myname(), rename to lp_netbios_name()
...
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.
Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
ad0a07c531
s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653
s3-talloc Change TALLOC_ARRAY() to talloc_array()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
de46ad9084
lib/util use modules_path(), data_path() and shlib_ext() from source3
...
This brings these helpful utility functions in common, as they are not
based on either loadparm system.
(The 'modules dir' parameter from Samba4 will shortly be removed, so
there is no loss in functionality)
Andrew Bartlett
2011-06-06 17:37:51 +10:00