1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Commit Graph

79 Commits

Author SHA1 Message Date
Jeremy Allison
b0ba4a5621 CVE-2013-4408:s3:Ensure LookupSids replies arrays are range checked.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
2013-12-09 07:05:46 +01:00
Michael Adam
00c674985f wbinfo: fix output of wbinfo --sid-to-name for sids of type DOMAIN
to print only the domain name and not "DOMIN\<SID>".

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-11-13 11:40:28 +01:00
Michael Adam
f7240932af wbinfo: fix output of "--lookup-sids" to use the configured winbind separator
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-11-13 11:40:28 +01:00
Michael Adam
fdf28f0898 wbinfo: fix ouptput of --lookup-sids for sids of type DOMAIN
To print only the domain name and not "DOMIN\<SID>".

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-11-13 11:40:28 +01:00
Andreas Schneider
f908e6b0c5 nsswitch: Add OPT_KRB5CCNAME to avoid an error message.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10048

Reviewed-by: Günther Deschner <gd@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jul 26 17:40:26 CEST 2013 on sn-devel-104
2013-07-26 17:40:25 +02:00
Günther Deschner
73e6feff9b wbinfo: allow to define a custom krb5ccname for kerberized pam auth.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2013-07-23 15:39:14 -07:00
Andreas Schneider
33bce26fcf nsswitch: Don't enumerate all domains with wbinfo -u|-g.
By default wbinfo -u|-g should only enumerate the domain winbindd is
joined to. The command can be harmfull if you have e.g. 30 domains and
700k users. Then the parent will collect all information and the
oom-killer will kill winbind. As we still want to support it, you can
enable it the old behaviour with wbinfo --domain='*' -u. This is
a measure that sysadmins don't shoot themself.

https://bugzilla.samba.org/show_bug.cgi?id=10034

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jul 18 11:54:58 CEST 2013 on sn-devel-104
2013-07-18 11:54:56 +02:00
Andrew Bartlett
2c70b0edcf nsswitch: Remove #if SAMBA_BUILD_ >= 4 now we only have the waf build
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>

Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-05-28 12:17:12 +10:00
David Disseldorp
0fa404c7d5 Bug 9807 - wbinfo: fix segfault in wbinfo_pam_logon
wbinfo_pam_logon() incorrectly assumes that wbcLogonUser() always
returns an allocated wbcAuthErrorInfo struct on failure.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 17 21:29:29 CEST 2013 on sn-devel-104
2013-04-17 21:29:29 +02:00
Andreas Schneider
301a3cb4af wbinfo: Fix several memory leaks.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22 16:36:13 +01:00
Andreas Schneider
b8ed2efb50 nsswitch: Cleanup code in parse_wbinfo_domain_user().
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-12 15:00:02 +01:00
Andreas Schneider
04c0d4878e wbinfo: Use new samba_getpass() function.
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
2012-12-03 14:35:08 +01:00
Daniel Liberman
27bc6cffaa Extending space for fqdn in wbinfo --trusted-domains in verbose mode
Microsoft documentation states that maximum fqdn length is 64 characters, so extending DNS Domain column to 65 characters.

Signed-off-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug 23 03:49:00 CEST 2012 on sn-devel-104
2012-08-23 03:49:00 +02:00
Christof Schmitt
4c8616f0c8 wbinfo: Improve output of wbinfo --ping-dc
Use wbcPingDc2 to get the DC name and print it.

Cleanup error messages: Remove "Could not ping our DC", there is always
a more specific message.  Avoid printing "failed to call wbcPingDc" in
case the ping has been attempted and it returns an error, the error is
already printed.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2012-08-15 11:44:43 +10:00
Volker Lendecke
e5825ab22d wbinfo: Fix Coverity ID 242684 Resource leak 2012-05-15 22:03:24 +02:00
Volker Lendecke
c5eab2e9ac wbinfo: Fix Coverity ID 242685 Resource leak 2012-05-15 22:03:24 +02:00
Andrew Bartlett
078db8f6c9 build: build wbinfo only once in the waf build
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Oct  8 04:52:03 CEST 2011 on sn-devel-104
2011-10-08 04:52:03 +02:00
Andrew Tridgell
dbbb69e572 wbclient: added support for handling WBC_ID_TYPE_BOTH mappings
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
2011-09-23 00:16:41 +02:00
Andrew Bartlett
2742ec0e34 Remove strlower_m() and strupper_m() from source4 and common code.
This function is problematic because a string may expand in size when
changed into upper or lower case.  This will then push characters off
the end of the string in the s3 implementation, or panic in the former
s4 implementation.

Andrew Bartlett
2011-05-03 07:37:07 +02:00
Volker Lendecke
b8dc235b08 nsswitch: Add wbinfo --sids-to-unix-ids
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
69ba25948a nsswitch: wbinfo --lookup-sids
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-13 14:13:25 -07:00
Volker Lendecke
40306f2247 s3: Fix Coverity ID 2220: RESOURCE_LEAK 2011-03-30 09:58:35 +02:00
Volker Lendecke
a56eb9b887 s3: Fix Coverity ID 2221: RESOURCE_LEAK 2011-03-30 09:58:35 +02:00
Volker Lendecke
9a97a8307c s3: Fix Coverity ID 2222: RESOURCE_LEAK 2011-03-30 09:58:35 +02:00
Volker Lendecke
12bf847058 s3: Fix Coverity ID 2223: RESOURCE_LEAK 2011-03-30 09:58:35 +02:00
Volker Lendecke
85ee3360e1 wbinfo: Use wbcSidToStringBuf 2011-03-05 14:29:33 +01:00
Volker Lendecke
d34092e919 wbinfo: Fix a debug message 2011-03-05 14:29:33 +01:00
Volker Lendecke
181b23ceed nsswitch: wbcFreeMemory deals fine with NULL 2011-03-05 14:29:32 +01:00
Michael Adam
4242d633d8 Revert "wbinfo: remove --set-uid-mapping - winbindd does not implement that any more."
This reverts commit 0e90d01d53.

Undo the library version bump.
2011-02-10 13:57:32 +01:00
Michael Adam
70ebfc16b4 Revert "wbinfo: remove --set-gid-mapping - winbindd does not implement that any more."
This reverts commit 9de1fd4352.

Undo the library version bump.
2011-02-10 13:57:32 +01:00
Michael Adam
71ce276c12 Revert "wbinfo: remove --remove-uid-mapping - winbindd does not implement that any more."
This reverts commit 36e2baa8da.

Undo the library version bump.
2011-02-10 13:57:32 +01:00
Michael Adam
1ea1043f8d Revert "wbinfo: remove --remove-gid-mapping - winbindd does not implement that any more."
This reverts commit 48ad64aa78.

Undo the library version bump.
2011-02-10 13:57:32 +01:00
Michael Adam
76ea4fd03a Revert "nsswitch: remove unused code from wbinfo.c"
This reverts commit 3bdd2efff8.

Undo the library version bump.
2011-02-10 13:57:31 +01:00
Günther Deschner
3bdd2efff8 nsswitch: remove unused code from wbinfo.c
Guenther
2011-02-02 14:59:19 +01:00
Michael Adam
48ad64aa78 wbinfo: remove --remove-gid-mapping - winbindd does not implement that any more. 2011-01-27 21:43:49 +01:00
Michael Adam
36e2baa8da wbinfo: remove --remove-uid-mapping - winbindd does not implement that any more. 2011-01-27 21:43:49 +01:00
Michael Adam
9de1fd4352 wbinfo: remove --set-gid-mapping - winbindd does not implement that any more. 2011-01-27 21:43:49 +01:00
Michael Adam
0e90d01d53 wbinfo: remove --set-uid-mapping - winbindd does not implement that any more. 2011-01-27 21:43:48 +01:00
Volker Lendecke
7f87d58900 s3: Add wbinfo --dc-info
wbinfo --dc-info prints the current DC name and IP address. This helps
diagnosing problems that might happen when a later wbinfo --ping-dc fails.

This patch started out by using the SAF and NBT cache entires, but those are
relatively short-lived. So I decided to invent a new gencache entry with a very
long timeout. We need to go via the gencache because when for some reason a
winbind child process is stuck, we can't query it for the current DC it's
connected to. This must eventually go away again when we have a fully async
winbind.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 19 08:40:28 CET 2011 on sn-devel-104
2011-01-19 08:40:28 +01:00
Volker Lendecke
af4a5f4c13 s3: Add -P as an alias for --ping-dc
This is a much less intrusive version of the DC connectivity check
than wbinfo -t is. Make it simple to use.
2010-12-19 23:25:06 +01:00
Volker Lendecke
4dcd5ac442 s3: Do not directly log off after a pam_logon 2010-09-13 10:05:42 -07:00
Volker Lendecke
2ef4acb2bd s3: Fix wbinfo arg for --pam-logon 2010-09-13 10:05:41 -07:00
Volker Lendecke
7277c9e5ad s3: Fix messsssages 2010-09-09 14:59:07 -07:00
Andreas Schneider
ce2a086119 s3-popt: Only include popt-common.h when needed. 2010-08-05 12:08:31 +02:00
Volker Lendecke
e17ce247a3 wbinfo: Fix error messages 2010-07-03 22:42:52 +02:00
Andreas Schneider
790d01cb2e wbinfo: Document the deprecated sequence option correctly.
I didn't find a way in popt to hide it.
2010-06-23 11:01:58 +02:00
Kai Blin
765e9c7c67 wbinfo: Add better libwbclient error reporting 2010-05-17 10:50:45 +02:00
Volker Lendecke
4c7cc8bb63 Revert "nsswitch: Fix a memleak in wbinfo"
This reverts commit a97f2a0a9c.

This was not a memleak, it was a valgrind false positive. We store "details" in
a static.
2010-04-24 12:41:47 +02:00
Volker Lendecke
c04ce964e9 nsswitch: Add wbinfo --pam-logon
This does a wbcLogonUser with credential caching
2010-04-19 14:27:24 +02:00
Volker Lendecke
a97f2a0a9c nsswitch: Fix a memleak in wbinfo 2010-04-18 15:25:02 +02:00