1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Commit Graph

41 Commits

Author SHA1 Message Date
Samuel Cabrero
8cdb4f2985 netapi: Pass net's cmdline credentials to libnetapi_net_init()
Avoid unnecessary credentials allocation and initialization by passing the
net's cmdline creds to libnetapi_net_init() directly.

Fixes the problem of running cli_credentials_guess() (which runs password
callbacks) twice, one for the net's cmdline creds and a second time for the
creds initialized in libnetapi_net_init(), just to override them immediately
after.

Example:

$ export PASSWD_FD=0
$ ./bin/net offlinejoin composeodj <...>
foo
bar

Password is read from STDIN twice.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-09-11 02:42:41 +00:00
Samuel Cabrero
5cad827810 netapi: Pass loadparm_context to libnetapi_net_init()
The net's tool cmdline lp_ctx can be reused, no need to init a new one except
for external library users.

Signed-off-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-09-11 02:42:41 +00:00
Stefan Metzmacher
1fdf1d55a5 CVE-2022-38023 s3:net: add and use net_warn_member_options() helper
This makes sure domain member related 'net' commands print warnings
about unsecure smb.conf options.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15240

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2022-12-13 13:07:29 +00:00
Andreas Schneider
ea071d278a s3:utils: Use connection and credentials parser in net util
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2021-05-28 02:55:31 +00:00
Andreas Schneider
2bfe37e069 s3:utils: Use libnetapi_set_creds() in net_dom
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2021-03-30 05:48:37 +00:00
Günther Deschner
a9b20c647e werror: replace WERR_SETUP_NOT_JOINED with WERR_NERR_SETUPNOTJOINED in source3/utils/
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:32 +02:00
Andrew Bartlett
9729bdf89f s3-utils/net: pass struct ndr_interface_table down
This will allow the target service (as determined from the IDL) to be
passed to GSSAPI (rather than the current, incorrect, "cifs").

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:24 +01:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h
Guenther
2011-05-06 16:37:18 +02:00
Günther Deschner
1232fb5a1e s3-rpc_client: remove some more obsolete cli_X.h header files.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 11:18:44 CET 2011 on sn-devel-104
2011-01-28 11:18:44 +01:00
Andrew Bartlett
88d020ade0 s3-netapi Add libnetapi_net_init(), don't double-init common Samba subsystems
The issue here is that libnet and net were both trying to load the
smb.conf files, the case tables and set the debug levels.  The set of
the debug levels caused problems, because it would force the level to
0, not (say) 10 as requested on the command line.

This regression was apparently introduced in
cf4de8ec2c when eliminating
AllowDebugChange.

Andrew Bartlett
2010-11-24 08:37:04 +01:00
Günther Deschner
002ac5681f s3-net: only include netapi header when needed.
Guenther
2010-08-06 15:43:38 +02:00
Günther Deschner
c6ebab846d s3: only include gen_ndr headers where needed.
This shrinks include/includes.h.gch by the size of 7 MB and reduces build time
as follows:

ccache build w/o patch
real    4m21.529s
ccache build with patch
real    3m6.402s

pch build w/o patch
real    4m26.318s
pch build with patch
real    3m6.932s

Guenther
2010-05-06 00:22:59 +02:00
Kai Blin
66de52c4f4 s3 net: Fix compile warnings 2010-01-19 14:48:34 +01:00
Björn Jacke
bd3c922e2b s3/net: split up some printable stings to ease i18n
If we put strings like "Usage:" into separate _() macros and not the whole
"Usage:..." string we can cover much more messages by only one single
translation. The drawback is that the message in the sources looks less pretty.
2010-01-18 23:45:05 +01:00
Günther Deschner
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
Guenther
2009-11-26 20:03:17 +01:00
Volker Lendecke
b02c46bef9 Revert "s3: Make run_rpc_command take strings instead of a ndr_interface_table"
This reverts commit 53f2a1595e.
2009-11-08 19:43:46 +01:00
Volker Lendecke
53f2a1595e s3: Make run_rpc_command take strings instead of a ndr_interface_table 2009-11-08 13:12:15 +01:00
Kai Blin
bdb23c73d9 s3 net: i18n support for net dom 2009-07-30 09:10:03 +02:00
Kai Blin
8f5ef10633 Revert "net: Use samba default command line arguments."
This reverts commit fb262f79fa
and related commits c36031778e
72fd5fa6bb and
38cd0e086f

This change caused more trouble than it solved. We need to do this differently.
Reverting so we don't accidently release this.
2009-07-22 13:39:34 +02:00
Kai Blin
fb262f79fa net: Use samba default command line arguments.
Attention:

The meaning of the -N flag changed.
To get the old meaning for net groupmap set, use the long option --ntname
The long option for using kerberos changed from --kerberos to --use-kerberos

net rpc commands will now prompt for a password if none is given.

As a benefit, net will now accept an authentication file like other samba
command line tools. So no need to specify the password on the command line in
scripts anymore.

This should fix bug #6357

Signed-off-by: Kai Blin <kai@samba.org>
2009-05-25 23:35:38 +02:00
Günther Deschner
b1a4649438 s3-net: add "net dom renamecomputer" to rename machines in a domain.
dmarkey, please test :)

Guenther
2009-05-11 10:55:40 +02:00
Günther Deschner
ab4b8c9c04 s3-netapi: Fix Bug #6309: support remote unjoining of Windows 2003 or greater.
Found by David Markey <admin@dmarkey.com>. Thanks!

Guenther
2009-04-30 23:40:09 +02:00
Günther Deschner
c464969b64 net: use NETSETUP flags consistently.
Guenther
(This used to be commit f48e0cacdf)
2008-09-08 10:17:21 +02:00
Günther Deschner
e710a87177 netapi: use NETSETUP join flags in examples.
Guenther
(This used to be commit 2f6f888d9c)
2008-08-29 13:58:06 +02:00
Günther Deschner
52a8501515 netapi: when using NetApi functions forward net's kerberos setting.
Guenther
(This used to be commit d46f648d2e)
2008-07-31 15:26:15 +02:00
Zach Loafman
863a6aa07e Fix warnings on FreeBSD-based platforms
Fix two shadowed declaration warnings on FreeBSD-based platform:
'reboot' is a 4.0BSD syscall in unistd.h and 'tcp_seq' is a typedef in
netinet/tcp.h.
(This used to be commit 14d2a4da1d)
2008-07-22 15:00:48 +02:00
Volker Lendecke
f23567fcb9 Refactoring: run_rpc_command uses ndr_syntax_id instead of pipe_idx
(This used to be commit 850166ec0d)
2008-07-21 14:36:28 +02:00
Kai Blin
255bdb2602 net: Rename functable3 to functable, get rid of old functables
(This used to be commit bb7c5fc4ec)
2008-06-10 09:48:21 +02:00
Kai Blin
7ba0724f80 net: Make "net dom" use functable3
(This used to be commit 11d692de73)
2008-06-10 09:46:37 +02:00
Kai Blin
0210f7af91 net: The top level help function for net cmd is always net_cmd_usage
(This used to be commit f7d0903a58)
2008-05-20 14:28:12 +02:00
Günther Deschner
9530c26c4c net: use the netapi_ctx from the net_context struct.
Guenther
(This used to be commit ff8a9655cc)
2008-05-16 11:58:24 +02:00
Kai Blin
f576910944 net: Remove globals
(This used to be commit 1e9319cf88)
2008-05-10 09:22:27 +02:00
Günther Deschner
0a362a94c8 net/libnetapi: Include netapi headers early and free on exit.
Guenther
(This used to be commit 020b1e6431)
2008-04-16 02:16:08 +02:00
Günther Deschner
4a8e6c9a91 Use libnetapi_get_error_string() in "net dom" commands.
Guenther
(This used to be commit 58048f0c57)
2008-02-28 17:05:38 +01:00
Günther Deschner
efcf285e27 Fix libnetapi error string callers.
Guenther
(This used to be commit 1ad7a0a361)
2008-01-11 15:28:24 +01:00
Günther Deschner
9fc2c21fa6 Fix net_dom_join & net_dom_unjoin.
Guenther
(This used to be commit 6dd17e4840)
2007-12-22 00:37:02 +01:00
Günther Deschner
dab660b9dc Move NetJoinDomain and friends to NET_API_STATUS and the static libnetapi_ctx.
Guenther
(This used to be commit e640c3a4a7)
2007-12-21 15:29:10 +01:00
Günther Deschner
10f1cdc797 Some cleanups for "net dom join".
Guenther
(This used to be commit 3f426f394f)
2007-12-12 00:58:58 +01:00
Günther Deschner
e9e182feda Actually implement reboot feature for net dom join/unjoin.
Guenther
(This used to be commit bbbeeba163)
2007-12-03 11:17:57 +01:00
Günther Deschner
c88263ab9e Add "net dom unjoin" code.
Guenther
(This used to be commit 58d49023b9)
2007-11-30 22:25:01 +01:00
Günther Deschner
4b60045066 Add "net dom join" code.
Guenther
(This used to be commit 177dab0ce3)
2007-11-30 22:25:01 +01:00