1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-07 20:23:50 +03:00
Commit Graph

25 Commits

Author SHA1 Message Date
Stefan Metzmacher
a5ea82bb05 r19192: merge from samba4:
ensure that data values from ldap libs are null terminated, to allow
ldb_msg_find_attr_as_string() to work correctly.

Thanks to Jim Myers for spotting this!

metze
2007-10-10 12:15:21 -05:00
Stefan Metzmacher
93a0fe093b r19191: merge from samba4:
fix checker warnings

metze
2007-10-10 12:15:21 -05:00
Stefan Metzmacher
b81cae4180 r19190: merge from samba4:
remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.

metze
2007-10-10 12:15:21 -05:00
Stefan Metzmacher
256b838201 r19185: merge comment from samba4
metze
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
71e1f8550f r19183: merge from samba4:
don't crash on invalid utf8 chars

metze
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
dd9d469eef r19182: merge from samba4:
add ldb_set_create_perms() function to set the create_perms after
ldb_init() and before ldb_connect()

metze
2007-10-10 12:15:20 -05:00
Stefan Metzmacher
6bc42f31ce r19163: pass always a mem_ctx to functions and a ldb_context where needed
It would be nice if someone can merge that to samba4,
otherwise I'll merge that to samba4 on monday

metze
2007-10-10 12:15:19 -05:00
Stefan Metzmacher
e4f2183684 r19145: talloc_reference() can fail!
metze
2007-10-10 12:15:16 -05:00
Stefan Metzmacher
db40552d94 r19137: that looks nicer:-)
metze
2007-10-10 12:15:16 -05:00
Stefan Metzmacher
0523ad2493 r19135: fix bugs...
- passing mem_ctx as ldb_context is a bad idea!
- naming a static function talloc_ is also bad and misleading

metze
2007-10-10 12:15:15 -05:00
Volker Lendecke
c879ed3d1e r19133: More C++ warnings -- Merge across? 2007-10-10 12:15:15 -05:00
Volker Lendecke
26f2cb71eb r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well?
I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
2007-10-10 12:15:15 -05:00
Stefan Metzmacher
7ba9fddacb r19124: merge from samba4:
pass LDFLAGS from configure to Makefile

metze
2007-10-10 12:15:14 -05:00
Volker Lendecke
7b6738522a r19079: talloc_array can fail 2007-10-10 12:15:09 -05:00
Volker Lendecke
c247cf3fba r19076: ldb_dn_copy_partial can fail 2007-10-10 12:15:09 -05:00
Volker Lendecke
0ab5d7692c r19075: Fix a potential NULL dereference 2007-10-10 12:15:08 -05:00
Volker Lendecke
ba18c58f1f r19072: Fix a potential NULL dereference. Simo/Tridge, not merging yet to 4_0, I'd
like you to comment.

Volker
2007-10-10 12:15:08 -05:00
Simo Sorce
df148a5def r19071: Backport to SAMBA_3_0 as well 2007-10-10 12:15:08 -05:00
Volker Lendecke
6a8937ed03 r19067: Fix a potential NULL dereference 2007-10-10 12:15:07 -05:00
Andrew Tridgell
dd8ec8725f r18939: don't rely on the umask being right in ldb creation. Both Samba3 and
Samba4 smbd force the umask to 0, which meant we ended up with ldb
being world writable.

This isn't really an ideal fix, as it means ldb no longer honors umask
(as it should do, like all good libraries).

Unfortunately the 'proper' fix is too complex for now

this also merges a tiny code style fix from s4 to s3
2007-10-10 12:14:49 -05:00
Andrew Tridgell
9e66df05a4 r18910: Change ldb_msg_add_string() to not actually add an attribute if the
string is zero length. This allows callers to not have to worry about
creating an invalid ldap attribute.

See extensive discussion on samba-technical list :-)
2007-10-10 12:14:45 -05:00
Stefan Metzmacher
63e5727471 r18901: try to fix the samba3 build without having ldap
vl: you were a few seconds faster than me...:-)

metze
2007-10-10 12:14:44 -05:00
Volker Lendecke
d0eef2f6e8 r18900: Next attempt to fix the Solaris build. Not sure about whether to merge this
one. Tridge? Metze?

Volker
2007-10-10 12:14:44 -05:00
Volker Lendecke
fd020a1998 r18889: Add some const. What's the policy here? Should I do this in Samba4 as well?
Volker
2007-10-10 12:14:41 -05:00
Andrew Tridgell
bbedf2e343 r18866: Jeremy and Volker have given the go-ahead on the group mapping ldb
code. Yay!

This first commit copies lib/ldb/ from Samba4. A huge congratulations
should go to Simo on this - he has put an enormous amount of work into
ldb, and it's great to see it go into the Samba3 tree.
2007-10-10 12:14:36 -05:00