1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
Commit Graph

251 Commits

Author SHA1 Message Date
Tim Prouty
10324b177e s3: Allow filename_convert() to pass through unix_convert_flags and let the caller know if the path has a wildcard
This also eliminates the need for resolve_dfspath().
2009-07-24 15:10:45 -07:00
Tim Prouty
00e267008d s3: Remove the now unused fname parameter from filename_convert() 2009-07-21 12:04:59 -07:00
Bo Yang
86865365ce S3: Small fix to get rid of annoying log message.
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-15 17:05:46 +08:00
Tim Prouty
0f6e10886f s3: Change some filename_convert to pass in NULL for char **fname argument 2009-07-06 15:38:41 -07:00
Jeremy Allison
d2da9dee68 Add some const to the stat struct in the dosmode calls.
Fix a couple more unix_convert uses to filename_convert.
Fix bug in acl_group_override() where an uninitialized
struct could be used. Move unix_convert with wildcard
use in SMBsearch reply to boilerplate code.
Jeremy.
2009-06-18 15:07:14 -07:00
Jeremy Allison
9b30c5c145 Fix msdfs after the change to smb_filename struct. We must *always*
pull the pathname, then call resolve_dfspath(), before unix_convert().
Jeremy.
2009-06-16 17:23:54 -07:00
Tim Prouty
04afa4b6b5 s3: Plumb smb_filename through SMB_VFS_CREATE_FILE 2009-06-12 16:14:50 -07:00
Tim Prouty
6088e554f5 s3: Make all callers of SMB_VFS_CREATEFILE call unix_convert first
This step is a requirement to change SMB_VFS_CREATEFILE to take an
smb_filename struct.
2009-06-10 13:13:26 -07:00
Jelmer Vernooij
f4195183a4 s3: Use common security_descriptor_equal(). 2009-04-21 18:17:40 +02:00
Volker Lendecke
5bc97e0cf2 Fix count in _srvsvc_NetDiskEnum()
Without this, remotely adding a share via MMC fails
2009-02-09 12:36:49 +01:00
Günther Deschner
b0f7137883 s3-srvsvc: remove all init_srvsvc* functions.
Guenther
2009-01-06 16:02:12 +01:00
Günther Deschner
a94157c759 s3-srvsvc: avoid all init_srvsvc* functions.
Guenther
2009-01-06 16:02:12 +01:00
Jelmer Vernooij
08259c1c52 Add iconv_convenience argument to size functions. 2009-01-01 04:45:33 +01:00
Günther Deschner
89e57a8fad s3-srvsvc: fix build warning.
Guenther
2008-12-09 12:41:00 +01:00
Todd Stecher
9985898e94 s3: Add support for access based share enumeration 2008-12-08 22:23:16 -08:00
Tim Prouty
5844012285 s3: Change SMB_VFS_CREATE_FILE to take a create_file_flags argument
This replaces the is_dos_path bool with a more future-proof argument.
The next step is to plumb INTERNAL_OPEN_ONLY through this flag instead
of overridding the oplock_request.
2008-12-03 17:51:44 -08:00
Tim Prouty
f995a7af2a s3: Add new "is_dos_path" argument to SMB_VFS_CREATE_FILE
Now unix paths can be differentiated from windows paths so the
underlying create_file implementations can convert paths correctly.
2008-12-03 17:50:37 -08:00
Tim Prouty
f38d7f20a8 s3: Add SMB_VFS_CREATE_FILE to the vfs layer
Modify all callers of create_file to go through SMB_VFS_CREATE_FILE
2008-12-03 17:50:17 -08:00
Volker Lendecke
907f126d3e Get rid of pipes_struct->pipe_user, we have server_info now --- YESSS! 2008-11-24 11:39:03 +01:00
Volker Lendecke
ed27d91068 Add auth_serversupplied_info to create_conn_struct
srvsvc needs it, as will printing
2008-11-23 22:41:59 +01:00
Jelmer Vernooij
f9fb9436ae Use WERR_FILE_EXISTS which is the equivalent of WERR_ALREADY_EXISTS
previously present in Samba 3.
2008-10-23 15:37:39 +02:00
Volker Lendecke
c530009401 Pass struct smb_request to file_free
on the way to get rid of chain_fsp
2008-10-13 19:32:38 +02:00
Jeremy Allison
543c6a02ae For the vfs_acl_xattr.c module, make sure we map GENERIC file and directory bits
to specific bits every time a security descriptor is set. The S4 torture suite proves
that generic bits are not returned when querying an ACL set using them (ie. only
the specific bits are stored on disk).
Jeremy.
2008-10-08 18:06:58 -07:00
Günther Deschner
f50ebbe29f s3-srvsvc: fix _srvsvc_NetShareAdd segfault.
parm_err is not a ref pointer.

Guenther
2008-09-26 18:34:21 +02:00
Volker Lendecke
2646fce633 Fix srvsvc_Net[Get|Set]FileSecurity
There were two bugs in those routines: They did not send INTERNAL_OPEN_ONLY to
open_file_ntcreate() and they did not chdir, so the file could never be found.

While there I decided to remove the become_root() calls and call create_file()
instead of the lower-level routines.
(This used to be commit 6697717384)
2008-07-27 17:59:15 +02:00
Volker Lendecke
c5401a2a46 Correct calculation of "remark" in srv_srvsvc_nt.c
Very likely the client is not interested in the values for the IPC$ share :-)
(This used to be commit 40ca5764cf)
2008-06-24 10:31:35 +02:00
Jeremy Allison
6811dc3fc2 Allow server manager to close open files selected by id.
Jeremy.
(This used to be commit 7eeed8bb41)
2008-05-27 11:25:46 -07:00
Jeremy Allison
d83931cb6e Remove MAX_SESS_ENTRIES and MAX_CONN_ENTRIES limits
as they are no longer needed now we have IDL marshalling.
Change the calculation of the 32-bit fileid we return
to a Windows client. We can't just use the generation
count as it starts at zero for every smbd - and this
command must enumerate all files open across all smbds.
We'd really like combination of process-id + dev + inode +
generation count to be unique, but as we can't fit that
into 32 bits just use 16 bits of pid + generation count.
Jeremy.
(This used to be commit 8b926d5a93)
2008-05-22 16:23:07 -07:00
Jeremy Allison
508d0310e7 Revert "Arggh. Got the path/user the wrong way around. IDL is correct :-)."
This reverts commit 1078b5c53a.

This message doesn't match the actual change.
(This used to be commit a65abb49cf)
2008-05-22 16:20:25 -07:00
Jeremy Allison
8c926ed0ea Arggh. Got the path/user the wrong way around. IDL is correct :-).
Jeremy.
(This used to be commit 1078b5c53a)
2008-05-22 16:19:26 -07:00
Jeremy Allison
ac65ed4aad Arggh. Got the path/user the wrong way around. IDL is correct :-).
Jeremy.
(This used to be commit 2281274480)
2008-05-22 14:36:09 -07:00
Jeremy Allison
537dc11bf4 Fix 2 bugs with displaying open file state. Firstly
the IDL is documented incorrectly in the MS-DOCS.
Username and path need to be reversed (yes I will
raise this with MS). Secondly, we need to check
access_mask for the permissions, not share_access
(share_access are the deny modes).
Jeremy.
(This used to be commit bdaad19f90)
2008-05-22 14:28:13 -07:00
Jeremy Allison
3f76504d92 Remove a couple of uses of SMB_VFS_GET_NT_ACL(), use
SMB_VFS_FGET_NT_ACL instead. I'd like to ultimately
remove SMB_VFS_GET_NT_ACL.
Jeremy.
(This used to be commit 4221937b68)
2008-05-09 11:14:45 -07:00
Jeremy Allison
00b2cdf75e Yay ! Remove a VFS entry. Removed the set_nt_acl() call,
this can only be done via fset_nt_acl() using an open
file/directory handle. I'd like to do the same with
get_nt_acl() but am concerned about efficiency
problems with "hide unreadable/hide unwritable" when
doing a directory listing (this would mean opening
every file in the dir on list).
Moving closer to rationalizing the ACL model and
maybe moving the POSIX calls into a posix_acl VFS
module rather than having them as first class citizens
of the VFS.
Jeremy.
(This used to be commit f487f742cb)
2008-05-08 18:09:07 -07:00
Jeremy Allison
b430b38220 Remove the "stat_open()" function, flag, and all associated code. It was only
being (correctly) used in the can_read/can_write checks for hide unreadable/unwritable
and this is more properly done using the functions in smbd/file_access.c.
Preparing to do NT access checks on all file access.
Jeremy.
(This used to be commit 6bfb06ad95)
2008-05-02 17:22:10 -07:00
Günther Deschner
a3991c9ef4 Fix SRVSVC ShareInfo level 502 server side handling.
Guenther
(This used to be commit 776facabf6)
2008-04-01 00:26:32 +02:00
Günther Deschner
9afc225b37 Fix SRVSVC ShareInfo max_users handling server side.
Guenther
(This used to be commit b4d944e724)
2008-04-01 00:26:32 +02:00
Günther Deschner
dbe34cf0ae Fix _srvsvc_NetShareSetInfo.
Guenther
(This used to be commit 2fd90b62d7)
2008-04-01 00:26:32 +02:00
Volker Lendecke
35cab4a8c2 Fix Coverity ID 548
Günther, please check -- in all infolevels we do a comment=talloc_strdup

Thanks,

Volker
(This used to be commit e2021c5b57)
2008-03-21 10:28:33 +01:00
Günther Deschner
7c8e66210d Add my copyright.
Guenther
(This used to be commit 4689057f63)
2008-03-21 04:16:22 +01:00
Günther Deschner
1dc52e8fbf Move MAX.*ENTRY definitions out of old rpc srvsvc parsing code.
Guenther
(This used to be commit 4e36657275)
2008-03-21 04:16:21 +01:00
Günther Deschner
08213f706e Use pidl for _srvsvc_NetSessEnum().
Guenther
(This used to be commit 5d14938b14)
2008-03-21 04:16:21 +01:00
Günther Deschner
a6bbefa1cb Use pidl for _srvsvc_NetConnEnum().
Guenther
(This used to be commit b8714e03e7)
2008-03-21 04:16:21 +01:00
Volker Lendecke
5346641c1c Fix an uninitialized variable warning
(This used to be commit 4cc09ec406)
2008-03-20 16:54:05 +01:00
Günther Deschner
63a6acdfa8 Use pidl for _srvsvc_NetFileEnum.
Guenther
(This used to be commit 6c6700ed71)
2008-03-19 02:18:46 +01:00
Michael Adam
16f4e059f7 init_srv_share_info_ctr: fix counting of services.
The number of services was recorded too early leading to
registry shares not showing up in browse lists.

Guenther - please check.

Michael
(This used to be commit 737e470e02)
2008-03-12 02:12:34 +01:00
Michael Adam
b371db93bb init_srv_share_info_ctr: Add debug messages.
Michael
(This used to be commit 8b2cc36ffc)
2008-03-12 02:12:34 +01:00
Günther Deschner
2a40d67041 Trying to fix resume_handling for srvsvc_NetShareEnumAll.
Guenther
(This used to be commit 874a0ffd7d)
2008-03-11 11:33:07 +01:00
Günther Deschner
b960bc265b Use pidl for _srvsvc_NetDiskEnum.
Guenther
(This used to be commit 933d546f86)
2008-03-11 10:48:52 +01:00
Günther Deschner
ca354276ca Use pidl for _srvsvc_NetSessDel().
Guenther
(This used to be commit 8a10bc13ae)
2008-03-10 03:43:39 +01:00