1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

21478 Commits

Author SHA1 Message Date
Stefan Metzmacher
acd3a2729e s4:wrepl_out_helpers: add a WREPLSRV_PUSH_NOTIFY_STAGE_WAIT_UPDATE stage
This makes the logic more consistent.

metze
2010-03-07 17:06:04 +01:00
Stefan Metzmacher
8c16d5e4dc s4:libcli/wrepl: add wrepl_socket_is_connected()
metze
2010-03-07 16:52:38 +01:00
Stefan Metzmacher
f1e28a0b41 s4:libcli/wrepl: make struct wrepl_request private to winsrepl.c
metze
2010-03-07 16:52:37 +01:00
Stefan Metzmacher
2450fc1c27 s4:libcli/wrepl: implement wrepl_request_send as a tevent_req based wrapper
metze
2010-03-07 16:52:36 +01:00
Stefan Metzmacher
cb4f269945 s4:libcli/wrepl: rename enum wrepl_request_state => enum wrepl_request_internal_state
metze
2010-03-07 16:52:36 +01:00
Stefan Metzmacher
311a60df9c s4:libcli/wrepl: move wrepl_request_send/recv => wrepl_request_internal_send/recv
metze
2010-03-07 16:52:35 +01:00
Stefan Metzmacher
fc41e4791f s4:torture/nbt: use wrepl_associate_stop() instead of build the request by hand
metze
2010-03-07 16:52:34 +01:00
Stefan Metzmacher
6dfc96c329 s4:torture/nbt: use wrepl_request() instead of wrepl_request_send() followed by wrepl_request_recv()
metze
2010-03-07 16:52:34 +01:00
Stefan Metzmacher
db051f0db6 s4:libcli/wrepl: add my copyright
metze
2010-03-07 16:52:32 +01:00
Matthias Dieter Wallnöfer
6870313db5 s4:lib/registry/ldb.c - fix trailing whitespaces 2010-03-06 19:59:10 +01:00
Matthias Dieter Wallnöfer
ed678a2234 s4:registry library - fix up "reg_ldb_set_value"
The previous logic was wrong since it tried to add empty data in some cases
which always ended in an error. This problem should be fixed with the new logic.
2010-03-06 19:59:04 +01:00
Matthias Dieter Wallnöfer
f5b86cdac5 s4:registry library - make "reg_ldb_pack/unpack_value" more robust
This to prevent segmentation faults, wrong server inputs ecc.
2010-03-06 19:58:57 +01:00
Matthias Dieter Wallnöfer
73e7aa863b s4:provision.reg - call us Windows 2008 from the current version point of view 2010-03-06 18:51:41 +01:00
Matthias Dieter Wallnöfer
89ab6818e1 s4:libregistry - change counters to be "unsigned"
Also the s4 registry library has to have "unsigned" counters like the Windows
one.
2010-03-06 17:48:25 +01:00
Matthias Dieter Wallnöfer
e10fa46f3e LDB:tools - change counters to be unsigned
In most cases we do count LDB objects which are enumerated within the "unsigned"
type. Therefore no need to use "signed" counters.
2010-03-06 11:35:17 +01:00
Matthias Dieter Wallnöfer
24049e8fc5 s4:lsa RPC - fix up "gendb_*" result codes
Make the resultcodes consistent: that means:
result < 0  -> NT_STATUS_INTERNAL_DB_CORRUPTION since our DB had a critical
               error
result >= 0 -> depends on the function usage. I tried to let the logic always as
               it was before.
2010-03-06 11:19:04 +01:00
Matthias Dieter Wallnöfer
a6cf89228f s4:lsa RPC - Change some counters to be "unsigned" where needed
The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.
2010-03-06 11:04:35 +01:00
Matthias Dieter Wallnöfer
9442a5593d s4:samr RPC - Change some counters to be "unsigned" where needed
The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.
2010-03-06 10:44:33 +01:00
Kamen Mazdrashki
95f2226265 s4/tort: fix annoying "union spoolss_PrinterInfo" undefined warnings
Signed-off-by: Günther Deschner <gd@samba.org>
2010-03-06 00:07:32 +01:00
Günther Deschner
58c9070746 s4-smbtorture: fix RPC-SPOOLSS-WIN after PrinterData IDL changes.
Guenther
2010-03-05 20:35:50 +01:00
Matthias Dieter Wallnöfer
f24dfbfb18 s4:drsuapi RPC - Change also here counters to "unsigned"
No need to have "signed" counters at those places.
2010-03-05 18:38:58 +01:00
Matthias Dieter Wallnöfer
61ae4be256 s4:dsdb/util - Change also here counters to "unsigned"
No need to have "signed" counters at those places.
2010-03-05 18:30:08 +01:00
Matthias Dieter Wallnöfer
3ec4c643a4 s4:repl - change also here the counter variables to "unsigned"
I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.
2010-03-05 18:28:35 +01:00
Matthias Dieter Wallnöfer
6a91bf60e2 s4:wrepl_server - change also here the counter variables to "unsigned"
I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.
2010-03-05 17:51:30 +01:00
Günther Deschner
91ff11d504 s4-spoolss: fix dcesrv_spoolss_GetPrinterData build.
really not my day today...

Guenther
2010-03-05 16:34:17 +01:00
Günther Deschner
6cbb8fdc48 s4-smbtorture: fix test_SetPrinterDataEx_matrix() call. sorry...
Guenther
2010-03-05 16:01:33 +01:00
Günther Deschner
d4db966c06 s4-smbtorture: when checking PrinterData matrix, include winreg cross reference checks.
Guenther
2010-03-05 15:19:50 +01:00
Günther Deschner
f385f4aeb0 s4-smbtorture: hand down printername to test_SetPrinterDataEx_matrix.
Guenther
2010-03-05 15:18:30 +01:00
Günther Deschner
c5fb6551d9 s4-smbtorture: add more paranoid checks for REG_DWORD SetPrinterDataEx tests.
Guenther
2010-03-05 15:18:17 +01:00
Günther Deschner
65f453ce71 s4-smbtorture: remove check for selfmade parsing artefact.
We were checking against a phenomenon that we created ourselves at the pidl
layer...

Guenther
2010-03-05 15:18:01 +01:00
Günther Deschner
f797ec9d81 s4-smbtorture: fix smbtorture after GetPrinterData{Ex} after IDL changes.
Guenther
2010-03-05 15:18:00 +01:00
Günther Deschner
8e499ec847 s4-spoolss: fix spoolss_GetPrinterData implementation after IDL change.
Guenther
2010-03-05 15:18:00 +01:00
Günther Deschner
ca319bfff2 s4-smbtorture: fix smbtorture after SetPrinterData{Ex} IDL changes.
Guenther
2010-03-05 15:17:59 +01:00
Matthias Dieter Wallnöfer
ce296d2a53 s4:dcesrv_samr_AddAliasMember - wrap a long "DEBUG" statement 2010-03-05 15:01:07 +01:00
Stefan Metzmacher
013184a182 s4:libcli/wrepl: convert wrepl_associate_stop_send to tevent_req
metze
2010-03-05 14:09:03 +01:00
Stefan Metzmacher
28033bf635 s4:libcli/wrepl: convert wrepl_connect_send to tevent_req
metze
2010-03-05 14:09:03 +01:00
Stefan Metzmacher
883b10983b s4:libcli/wrepl: convert wrepl_associate_send to tevent_req
metze
2010-03-05 14:09:02 +01:00
Stefan Metzmacher
2e24def806 s4:libcli/wrepl: convert wrepl_pull_table_send to tevent_req
metze
2010-03-05 14:09:02 +01:00
Stefan Metzmacher
50f1dc9db8 s4:libcli/wrepl: convert wrepl_pull_names_send to tevent_req
metze
2010-03-05 14:09:02 +01:00
Stefan Metzmacher
1a8815abd3 s4:libcli/wrepl: use UTIL_TEVENT
metze
2010-03-05 14:09:01 +01:00
Stefan Metzmacher
0dfc778915 s4:libcli/wrepl: avoid neested named structures
metze
2010-03-05 14:09:01 +01:00
Stefan Metzmacher
4c51c07380 s4:torture/nbt: avoid the usage of wrepl_pull_table_send()
metze
2010-03-05 14:09:00 +01:00
Matthias Dieter Wallnöfer
6f11818923 s4:kcc - Change some counter variables to be unsigned
The upper limits are unsigned variables therefore also the counter variables
need to be like that.
2010-03-05 13:38:01 +01:00
Matthias Dieter Wallnöfer
82c2448573 s4:samdb_privilege.c - Change two counter variables to unsigned
Also here in both cases the unsigned counter fits better than the signed one.
2010-03-05 13:38:00 +01:00
Matthias Dieter Wallnöfer
c695ce729b s4:cracknames - Change two counter variables to unsigned
In both cases the unsigned counter fits better:
- in the first one since we are counting LDB objects starting from 0
- in the second since we are counting an array starting from 0
2010-03-05 13:38:00 +01:00
Andrew Tridgell
e8788808da s4-pvfs_sys: build on systems without O_NOFOLLOW or O_DIRECTORY 2010-03-05 23:07:32 +11:00
Andrew Tridgell
568f0851f0 s4-pvfs_sys: talloc_free should be before errno restore
talloc can potentially change the errno
2010-03-05 23:07:32 +11:00
Andrew Tridgell
2c2156ea95 s4-pvfs: use pvfs_sys_fchmod() 2010-03-05 23:07:32 +11:00
Andrew Tridgell
dae9d20e14 s4-pvfs: set default for perm override based on system features
If the system has O_NOFOLLOW and O_DIRECTORY then we allow for
overrides by default. If not, then we disable by default, as we will
be more vulnerable to symlink attacks
2010-03-05 23:07:32 +11:00
Andrew Tridgell
f7c97c8597 s4-pvfs: use O_FOLLOW one level at a time for security overrides
To prevent symlink attacks we need to use O_NOFOLLOW one level at a
time when processing a root security override
2010-03-05 23:07:32 +11:00