1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-23 00:23:53 +03:00
Commit Graph

224 Commits

Author SHA1 Message Date
Gerald Carter
b6ceb8c2e5 * Fix DeletePrinterDataEx() to work with arbitrary registry keys
* Fix delete_all_printer_data() to accept a key name for partial tree
  deletions

* Fix EnumPrinterKey() to work with subkeys

* Fix DeletePrinterKey() to work with ful or partial registry
  trees

* Fix get_printer_subkeys() to return a list of unique keynames
  ( some were getting added twice due to subkeys names )

* fix a couple of typos for good measure
-
Gerald Carter
8799d4f7cc fix GetPrinterDataEx() to work with registry subkeys using a depth > 1 -
Gerald Carter
32a7083843 fix to allow EnumPrinterKey() to enumerate multiple levels of subkeys.
Works on the top level.  Needs more testing for levels > 1.
-
Gerald Carter
d59b0eb123 * the printing code should now be back to the working state it was
before the swap from NT_PRINTER_PARAM to REGISTRY_VALUE.

* XxxPrinterDataEx() functions have not been expanded to support
  keys other than SPOOL_PRINTERDATA_KEY yet

* fixed apparent long standing bug regarding the dependentfiles
  list in the DRIVER_INFO struct
-
Gerald Carter
7ba7c04c0e Fairly large change to printing code.
* removed support for PHANTOM_DEVMODE printer data

* s/NT_PRINTER_PARAM/REGISTRY_VALUE/g - This was a good bit
  of work.  Everything seems stable, but is not complete.

* support for printer data keys other than PrinterDriverData
  in the store and fetch routines.  Still needs to be plugged
  into the XxxPrinterDataEx() calls.

Tested against NT4.0 & 2k.  Like I said, it's not done, but doesn't
crash so it shouldn't upset anyone (unless you're trying to build
a Samba printer server off of HEAD).  More work to come.  Should
settle by Monday.


jerry
-
Gerald Carter
b6b64d06a6 one line merge from APP_HEAD -
Gerald Carter
9c6b930068 delete printer driver fix from APP_HEAD -
Gerald Carter
11ddfd9cfa printing change notification merge from APPLIANCE_HEAD -
Gerald Carter
26027ee42a couple of minor formatting fixes to help me see better. -
Gerald Carter
e62ae94823 another intermediate checkin on the way to enumerating forms
via the registry.  There is a seg fault here which shouldn't
bother anyone until I can get it fixed.  I just need
a check point in case I need to roll back to this version later on.
-
Gerald Carter
dcb6d70706 added copyright -
Gerald Carter
17bb780e13 last check in for tonight.
* DeletePrinterDriverEx() now has the ability to delete
    driver files.  I need to do some more testing
    tro veriofy that we are in fact not deleting a file out from
    under another driver, but it looks ok so far.

  * DeletePrinterDriver() noiw deletes all versions of the
    specified driver (cversion == 0, 1, 2, 3)
-
Gerald Carter
7207662504 all that is left to do is to actually perform the
file deletion now.  I have the file list.
One more commit should do it.
-
Gerald Carter
3fa6c31329 intermediate work on DeletePrinterDriverEx(). This call
will actually delete driver files ( not yet though I don't think).
Just wanted to get it in since Jeremy and I are both
working on nt_printing.c
-
Jeremy Allison
b0909cfa14 *Experimental* new large-scaling printer code. Splits printing.tdb into
a separate tdb per printer, but only keeps (currently one) tdb open at
a time (although this is easily changed by changing a #define). Needs
scalability testing with large numbers of printers now....
Jeremy.
-
Gerald Carter
b5bc8aa0f6 It's fairly obvious that no one has tried to upload a driver
to a Samba print server running HEAD in a while.  This has been broken
since tridge's changes to make_connection() to not do the chdir()
to the connect_path.  Sorry it took me so long to get around to fixing it.

The problem occured with our internal use of make_connection().

jerry
-
Gerald Carter
f753676286 printing merge from SAMBA_2_2. Ther server code looks to be in sync now.
Mostly formatting and s/free/SAFE_FREE/g changes with the two exceptions
being

  * John driver init changes
  * Tim's printer enumeration bug fix
-
Andrew Bartlett
96afea638e Globally replace 'global_sam_sid' with get_global_sam_sid(), a self
initialising function.  This patch thanks to the work of
"Stefan (metze) Metzmacher" <metze@metzemix.de>

This is partly to enable the transition to SIDs in the the passdb.

Andrew Bartlett
-
Jeremy Allison
32fa089ade Merged in printing fixes... There were many missing !
Jeremy
-
Tim Potter
bc673c4204 Merge of print server permission handling fixes from HEAD.
Unit tests rock!
-
Gerald Carter
233a24792e removed unnecessary memset -
Gerald Carter
d87aa35d48 specversion merge from SAMBA_2_2 -
Tim Potter
e66bdf1229 Stomped on some header file version numbers that have crept back in. -
Tim Potter
ddb5753e36 Added dos_errstr() function. Not all errors in list yet. -
Gerald Carter
5760315c1d syncing up printing code with SAMBA_2_2 (already done some merges
in the reverse).

  * add in new printer change notify code from SAMBA_2_2

  * add in se_map_standard() from 2.2 in _spoolss_open_printer_ex()

  * sync up the _print_queue_struct in smb.h (why did someone change the
    user/file names in fs_user/fs_file (or vice-versa) ? )

  * sync up some cli_spoolss_XXX functions
-
Tim Potter
d7efc5dd3d Backed out enumprinters stuff - leave it for another day. -
Tim Potter
dfd51bc8d0 Merge of enumprinters vs getprinter naming patch from 2.2 -
Jeremy Allison
51c3d35363 Fix from JohnR - Fixed SetPrinterData(magic key) to support zero length DEVMODE as is the case with the
Okidata Okipage 20 PCLXL Advanced printer driver.
-
Gerald Carter
9e96cbe241 merge from 2.2 -
Jeremy Allison
771ef92fc6 Bring printing in HEAD inline with 2.2.x and app-head.
Jeremy.
-
Tim Potter
6a58c9bd06 Removed version number from file header.
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
-
Gerald Carter
e3b87ffc8c merge from APPLIANCE_HEAD -
Andrew Bartlett
5fe1ea7f11 These changes commited on a 'no less broken' basis.
The previous code attempted to call winbind to find out the domain sid.  This
couldn't work for a number of reasons - not the least of which was that both
the client and server ends would reject any name (in this case domain name)
without a \ in it (or lp_winbind_seperator()).

I think this is what was intended to occour.  If there is still some need to
contact winbind for this information, I suggest a new call be created for this
- as it the server-side code doesn't allow for this information to be extracted
easily in any case.

Finally, it gets in the way of the default domain code a bit - hence why I was
actually looking at it...

Andrew Bartlett
-
Andrew Bartlett
f0137ac126 Change this code so that we don't do a lookup_name() on root.
This matches the lookup failure case in 2.2, and seems to make more sense than
giving the printer to 'world'.  (Avoiding this lookup makes some of my other
changes - including winbind default domains - a little easier).

In any case, tpot has promised to look at this and test it when he gets back to
work. :-)

Andrew Bartlett
-
Gerald Carter
8ed7c1ffad merge from 2.2 -
Gerald Carter
90a7a1840b merge from 2.2. of
* PRINTER_ATTRIBUTE's
  * "default devmode" parameter
-
Jeremy Allison
2603ab3c68 Round and round we go....
Jeremy.
-
Jeremy Allison
24ee18c77e Latest attempt at changeid.
Jeremy.
-
Jeremy Allison
3dec9cf99a When re-writing tdb version numbers as little endian int32, we must
change the version number also.
Jeremy.
-
Jeremy Allison
ec71f1732b Fixed all uses of tdb_fetch/store/_int to use explicit int32 little endian
in tdb's. All except winbindd_idmap.... Hmmmmmm.
Jeremy.
-
Jeremy Allison
9fb780d951 My previous fix had a bug....
This is SO NASTY as some drivers need this to change, others need it
static. This value will change every second, and I must hope that this
is enough..... DON'T CHANGE THIS CODE WITHOUT A TEST MATRIX THE SIZE OF
UTAH !
Jeremy.
-
Jeremy Allison
8e8d718160 Another attempt at getting changeid correct. Jerry / JF please check !
This fixes a driver init bug.
Jeremy.
-
Jeremy Allison
ccf07e2184 Caught one problem where a BOOL fn was returning 3 different values :-).
Roll on defined types :-).
Jeremy.
-
Jeremy Allison
10d72f0b01 Added get_called_name() function, which replaces global_myname in printing
code (one less global, hurrah !) - to allow NetBIOS aliasing to be used
with point and print.
Jeremy.
-
Jeremy Allison
ee8fd2690a Return called NetBIOS name if present in preference to global_myname.
Should allow print servers to work with NetBIOS aliases.
Needs testing.
Jeremy.
-
Tim Potter
690cc12bad Sed error. The status value in the PRINTER_INFO_2 structure isn't a WERROR
but a plain old uint32.
-
Jeremy Allison
a0cdec3acc Fixed nasty cast of tdb_delete in traversals.
Jeremy.
-
Jeremy Allison
7ce2d1fe37 Removed extra lp_adduser() call.
Fixed up error returns in get_correct_cversion().
Jeremy.
-
Gerald Carter
096d06a961 ChangeID fixe from APPLIANCE_HEAD -
Martin Pool
142d3dad0a Writing decimal constants as "02" has been shown to cause cancer in
rats.
-