Jeremy Allison
adf4833792
This patch looks bigger than it is. It does 2 things. 1). Renames smbpid -> smblctx in our locking code. 2). Widens smblctx to 64-bits internally. Preparing to use the SMB2 handle as the locking context.
...
Jeremy.
2010-05-07 06:20:50 -07:00
Jeremy Allison
4ad1943d29
Make us pass all SMB2 lock tests except MULTIPLE-UNLOCK and CONTEXT. Them next :-).
...
Jeremy.
2010-05-07 01:20:26 -07:00
Jeremy Allison
882fb1828f
Fix crash in cancel-tdis lock test. Correctly shut down connection.
...
Jeremy.
2010-05-07 00:33:59 -07:00
Jeremy Allison
1c7a60ef41
Fix cancel by close lock test.
...
Jeremy.
2010-05-06 15:39:21 -07:00
Jeremy Allison
a77a8a5e35
Fix more SMB2 locking. We still crash but this won't last :-).
...
Jeremy.
2010-05-06 08:22:13 -07:00
Jeremy Allison
d58b795587
Move to MS-FSA algorithm when checking for invalid lock range.
...
Satisfies SMB and SMB2.
Jeremy.
2010-05-05 15:57:57 -07:00
Günther Deschner
c6ebab846d
s3: only include gen_ndr headers where needed.
...
This shrinks include/includes.h.gch by the size of 7 MB and reduces build time
as follows:
ccache build w/o patch
real 4m21.529s
ccache build with patch
real 3m6.402s
pch build w/o patch
real 4m26.318s
pch build with patch
real 3m6.932s
Guenther
2010-05-06 00:22:59 +02:00
Jeremy Allison
d6a6362752
Get closer to passing SMB2 lock test. Still crashes but we get further.
...
More work to follow later.
Jeremy.
2010-05-05 14:54:31 -07:00
Jeremy Allison
d8ba02b73d
Return correct error on read request on directory.
...
Jeremy.
2010-05-05 09:50:48 -07:00
Jeremy Allison
19758b354d
Get in_minimum and EOF errors right.
...
Jeremy.
2010-05-05 09:47:49 -07:00
Jeremy Allison
4a97912baf
Client ignoring max write is a warning, not an error.
...
Jeremy.
2010-05-05 09:42:45 -07:00
Jeremy Allison
44e9a90b51
Start to pass the SMB2 read torture tests.
...
Jeremy.
2010-05-05 09:39:31 -07:00
Günther Deschner
8528e347cb
s3-lanman: use srvsvc for api_RNetShareAdd().
...
Guenther
2010-05-05 18:29:21 +02:00
Jeremy Allison
62143543ce
Fixed issue with return in a void function found by Björn JACKE <bj@SerNet.DE>
...
Jeremy.
2010-05-05 06:09:03 -07:00
Günther Deschner
4affc58c6a
s3-lanman: before trying to call spoolss_ClosePrinter make sure we have a connection.
...
Guenther
2010-05-03 17:04:00 +02:00
Günther Deschner
fe1617a818
s3-lanman: fix api_DosPrintQEnum().
...
This was a subtile bug where the OpenPrinter call (called directly via
dispatcher table) was modifiying r->in.printername in a way that all printers on
a server had the printername stripped off the server unc. Once we switch to full
NDR marshalling in inter RAP<->RPC server communication there is no danger
anymore to have these kind of nasty effects.
Guenther
2010-05-03 14:45:26 +02:00
Günther Deschner
fe33db6c06
s3-lanman: exit early for unsupported levels in api_PrintJobInfo().
...
Guenther
2010-05-03 14:43:34 +02:00
Jeremy Allison
f4092ecec7
Plumb the SMB2 front end into the blocking lock backend.
...
Metze, you'll probably be happier with this work as it
doesn't abuse tevent in the way you dislike. This is a
first cut at the code, which will need lots of testing
but I'm hoping this will give people an idea of where I'm
going with this.
Jeremy.
2010-04-30 21:03:20 -07:00
Simo Sorce
dffeb12f3d
smbd: move printfile_offset() within write_file()
2010-04-30 11:52:39 -07:00
Jeremy Allison
e90444319c
Carefully label SMB1-specific locking calls.
...
Jeremy.
2010-04-29 17:08:12 -07:00
Jeremy Allison
ebf6340bb5
Move the global blocking lock records into the smb1 state.
...
Jeremy
2010-04-29 16:50:15 -07:00
Jeremy Allison
1f69a7a80e
Attempt to fix bug #7399 - SMB2: QUERY_DIRECTORY is returning invalid values.
...
Based on an initial patch from Ira Cooper <samba@ira.wakeful.net>.
Jeremy.
2010-04-29 13:40:25 -07:00
Günther Deschner
9a313bbac0
s3-lanman: fix api_DosPrintQGetInfo().
...
Found by torture test.
Guenther
2010-04-29 13:47:33 +02:00
Günther Deschner
7e678ef0cf
s3-lanman: fix api_DosPrintQEnum.
...
Found by torture test.
Guenther
2010-04-29 12:05:42 +02:00
Jeremy Allison
4e7195be36
Update (C) for 2010.
...
Jeremy.
2010-04-28 14:56:12 -07:00
Günther Deschner
d53544800f
s3-lanman: support level 0 NetPrintQEnum RAP query.
...
Guenther
2010-04-28 23:23:38 +02:00
Jeremy Allison
ac09506d36
Connect set security descriptor into SMB2 code.
...
Jeremy.
2010-04-28 14:13:22 -07:00
Stefan Metzmacher
d5cc067367
s3:smbd: make fsp->fake_file_handle a talloc child of fsp
...
metze
2010-04-28 15:46:58 +02:00
Stefan Metzmacher
4783f84264
s3:smbd: add comment about returning STATUS_BUFFER_OVERFLOW in pipe_read_andx_done()
...
metze
2010-04-28 15:46:23 +02:00
Jeremy Allison
c9a3661c4b
Fix the "allow_smb2" bug being set to false that was driving me mad :-).
...
The first packet from a rebooted Win7 on an SMB2 connection is an SMB1
negprot...
Jeremy.
2010-04-27 22:15:17 -07:00
Jeremy Allison
4d1f0436bd
Don't return a potentially uninitialized NT_STATUS. We can now see user lists in Windows ACLs.
...
Jeremy.
2010-04-27 17:09:40 -07:00
Jeremy Allison
33256e41e1
Add debug statements so I can track the flow of RPC data.
...
Jeremy.
2010-04-27 17:07:44 -07:00
Günther Deschner
f56d9006d5
s3-lanman: use spoolss for api_WPrintDestGetInfo() and api_WPrintDestEnum().
...
With this, I think, all implemented RAP printing calls are routed over SPOOLSS.
Torture tests to follow...
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
c88ff10d69
s3-lanman: fix debug message in api_WPrintJobEnumerate().
...
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
566ea59b27
s3-lanman: remove a unnecessary memset in api_WPrintJobEnumerate().
...
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
fe1f503a95
s3-lanman: remove unused code.
...
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
f23bcb5c5e
s3-lanman: use spoolss for api_DosPrintQGetInfo and api_DosPrintQEnum.
...
Guenther
2010-04-28 01:27:40 +02:00
Jeremy Allison
f11a5d196d
Don't return an intermediate reply on async on a pipe call (Windows doesn't).
...
Jeremy.
2010-04-27 16:07:12 -07:00
Günther Deschner
f4f9d54721
s3-lanman: use spoolss for api_PrintJobInfo().
...
Guenther
2010-04-28 00:10:41 +02:00
Günther Deschner
2b7002f385
s3-lanman: remove unsupported print_job_set_place().
...
Guenther
2010-04-28 00:10:40 +02:00
Stefan Metzmacher
b764145ac8
s3:smbd: keep local and remote tsocket_address per connection
...
metze
2010-04-27 17:22:31 +02:00
Jeremy Allison
3f643f18d9
Correctly report share types (now Win7 makes RPC calls against us).
...
Jeremy.
2010-04-26 21:36:01 -07:00
Jeremy Allison
a94a4b788c
Plumb in get_nt_acl into SMB2.
...
Jeremy.
2010-04-26 20:11:59 -07:00
Günther Deschner
7259762909
s3: use generated rap header.
...
Guenther
2010-04-26 22:52:59 +02:00
Jeremy Allison
1055b3c229
When walking the SMB2 requests queue, ensure the request is still "in flight"
...
before examining the details.
SMB2 requests stay on the queue until their out.vector has been
send, only then are they talloc_free'd.
Thanks for Ira Cooper <ira@wakeful.net> for giving me the
backtrace showing this.
Jeremy.
2010-04-26 12:29:03 -07:00
Jeremy Allison
6beba782f1
Fix crash when rescheduling oplock open.
...
Jeremy.
2010-04-26 10:54:33 -07:00
Volker Lendecke
678a3c4e6d
s3: Simplify (bool != True) to !bool
2010-04-24 10:50:12 +02:00
Jeremy Allison
a796542a93
Implement oplocks within SMB2. Plumb into the existing SMB1 oplock system.
...
Seems to work but needs more tests (to be added).
Jeremy.
2010-04-24 00:29:41 -07:00
Jeremy Allison
247273196f
When sending the initial async response, this is never part of a chain.
...
Get the reply flags correct.
Jeremy.
2010-04-23 15:35:34 -07:00
Jeremy Allison
0e6f4ed703
Don't free the entire tevent_req on cancel, only the part we need (the immediate event).
...
Jeremy.
2010-04-23 15:34:58 -07:00