1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-23 00:23:53 +03:00
Commit Graph

240 Commits

Author SHA1 Message Date
Andrew Bartlett
ae470ff701 r16860: Fix (and reactivate) the RPC-SAMR test. We need to allow these sids
to be created as foreign, even if they are in a local domain.

Also we do need the user to exist for the life of the test, as we add
it to a group.

Andrew Bartlett
2007-10-10 14:09:54 -05:00
Andrew Bartlett
9d31b9f047 r16854: Fix the RPC-SAMR-PASSWORDS test. It failed because we allocated users
in the Builtin domain a SID from the global domain.

Andrew Bartlett
2007-10-10 14:09:54 -05:00
Andrew Bartlett
7674306e67 r16833: Add a base DN to more search calls, we need to look for an ID over the
whole tree here.

Andrew Bartlett
2007-10-10 14:09:49 -05:00
Andrew Bartlett
9fdbedafad r16831: Use a valid memory context (found by the IBM checker).
Andrew Bartlett
2007-10-10 14:09:48 -05:00
Andrew Bartlett
3e58350ec2 r16829: Fix a number of issues raised by the IBM checker, or gcc warnings.
In particular, this removes one use of the LDB_DN_NULL_FAILED macro,
which was being used on more than DNs, had an embedded goto, and
confused the IBM checker.

In the password_hash code, ensure that sambaAttr is not, before
checking the number of values.

In GENSEC, note that this switch value can't occour.  This seems to be
the only way to quiet both the IBM checker and gcc, as well as cope
with possibly invalid inputs.

Andrew Bartlet
2007-10-10 14:09:48 -05:00
Andrew Bartlett
10eeea6da4 r16827: Factor out some code into common samdb functions:
- creation of ForeignSecurityPrincipals
 - template duplication code

Rework much of the LSA server to pass the RPC-LSA test.  Much of the
server code was untested.  In implementing the LSA Accounts feature, I
have opted to have it only create entires when privilages are applied,
and not to delete entries, but to delete the privilages.

We skip some parts of the test, but it is much better than not testing
it at all.

Andrew Bartlett
2007-10-10 14:09:48 -05:00
Simo Sorce
b9b6bb3e89 r16784: - make some function in ldb static, they not need to be exported anywhere
- fix a bad segfault
  Andrew please make test before committing.

Simo.
2007-10-10 14:09:45 -05:00
Andrew Bartlett
87cac3529c r16771: Add const and some better debug messages.
Andrew Bartlett
2007-10-10 14:09:44 -05:00
Andrew Bartlett
e957f6f4c6 r16769: Working on fixing the RPC-SAMR test against Samba4. This fixes
password changes which only include the LM and NT hash, such as the
original ChangePassword.

It also fixes setting passwords on the BUILTIN domain.

Finally, the msDS-KeyVersionNumber is only incremented if not
explicity set by the modify.

Andrew Bartlett
2007-10-10 14:09:44 -05:00
Andrew Bartlett
b49a4fbb57 r16264: Add, but do not yet enable, the partitions module.
This required changes to the rootDSE module, to allow registration of
partitions.  In doing so I renamed the 'register' operation to
'register_control' and 'register_partition', which changed a few more
modules.

Due to the behaviour of certain LDAP servers, we create the baseDN
entry in two parts: Firstly, we allow the admin to export a simple
LDIF file to add to their server.  Then we perform a modify to add the
remaining attributes.

To delete all users in partitions, we must now search and delete all
objects in the partition, rather than a simple search from the root.
Against LDAP, this might not delete all objects, so we allow this to
fail.

In testing, we found that the 'Domain Controllers' container was
misnamed, and should be 'CN=', rather than 'OU='.

To avoid the Templates being found in default searches, they have been
moved to CN=Templates from CN=Templates,${BASEDN}.

Andrew Bartlett
2007-10-10 14:09:09 -05:00
Andrew Bartlett
42c2495683 r16263: A number of these searches need to be under the partitions DN, and the
other needs the default basedn.

Andrew Bartlett
2007-10-10 14:09:08 -05:00
Andrew Bartlett
2f104612cd r16240: Add better error reporting in the password_hash module
Remove duplicate attribute in search request

Search for the domain by NDR-encoded SID, not string (consistant with
the rest of the C code, and helps partially-constructed LDAP
backends).

Use the default basedn for the domain search.

Andrew Bartlett
2007-10-10 14:09:08 -05:00
Andrew Bartlett
af11f464a7 r16227: Don't segfault if the ldb_search() fails.
Andrew Bartlett
2007-10-10 14:09:06 -05:00
Andrew Bartlett
defa632988 r16159: Even more work on samldb error reporting. Make sure to get the
original error strings back to the callers.

Andrew Bartlett
2007-10-10 14:09:02 -05:00
Andrew Bartlett
2d2e71a2d5 r16129: Further clean up the samldb module.
This adds more/better setting of the ldb error string, and avoids
using gendb_search(), as this doens't return the error code.

Andrew Bartlett
2007-10-10 14:09:00 -05:00
Andrew Bartlett
2fe9de8105 r16125: Add another helpful utility function: samdb_msg_add_int()
Andrew Bartlett
2007-10-10 14:09:00 -05:00
Andrew Bartlett
3252e425b0 r16109: Make this module simpiler, don't intercept operations we are not going
to implement.

Andrew Bartlett
2007-10-10 14:09:00 -05:00
Andrew Bartlett
b31003403d r16108: Fixes from working with the partition module.
We were not using the correct baseDN for the templates search.  Using NULL is no longer valid (like against AD).

While chasing that down, return proper error codes, and use the
ldb_set_errstr() to get a good error string back up to the UI layer.

Andrew Bartlett
2007-10-10 14:08:59 -05:00
Andrew Bartlett
fbe7d0ca90 r16083: Make it possible to initialise a backend module, without it setting up
the whole ldb structure.

Because the sequence number was a fn pointer on the main ldb context,
turn it into a full request (currently sync).

Andrew Bartlett
2007-10-10 14:08:57 -05:00
Simo Sorce
795f8ebe8e r16070: Fix kludge_acls 2007-10-10 14:08:56 -05:00
Andrew Bartlett
25e8597545 r16069: Remove unused destructor and an unused variable.
Andrew Bartlett
2007-10-10 14:08:56 -05:00
Andrew Bartlett
4e39d7bb24 r16061: Prove that removing the objectClass list in the samldb module breaks things.
With this fix, we now correctly detect computers again, and get the
correct objectCategory, which is important for the OSX AD plugin.

Andrew Bartlett
2007-10-10 14:08:55 -05:00
Simo Sorce
d346531d0a r16042: Fix crashbug caused by incorret error reporting. 2007-10-10 14:08:52 -05:00
Simo Sorce
b52e5d6a0c r16036: Add a couple of new functions to corretly deal with timeouts.
Check timeouts are correctly verified.
Some minor fixed and removal of unused code.
2007-10-10 14:08:52 -05:00
Simo Sorce
959c8c35ef r16022: ooops, a bit too aggressive commit :-) 2007-10-10 14:08:51 -05:00
Simo Sorce
6b214f232e r16021: While studying how to make samldb really async I found a critical situation handled in the incorrect way.
A while(1) loop may end up looping forever consuming all valid RIDs because of a secondary bug.
And anyway nextRid is supposed to always give back a new unique RID, if someone messed up the database let him
fix the problem first, trying to be smart here would probably end up in worst results.

Simo.
2007-10-10 14:08:51 -05:00
Andrew Bartlett
ee6fe3a80f r15999: password_hash module changes:
- Quiet some IBM Checker warnings (enum mismatch)
 - Only search for the attributes we need
 - fix comments
 - fix copyrights

Andrew Bartlett
2007-10-10 14:08:47 -05:00
Simo Sorce
55d97ef88f r15944: rename LDB_ASYNC_ADD -> LDB_ADD, LDB_ASYNC_MODIFY -> LDB_MODIFY, etc... 2007-10-10 14:08:43 -05:00
Simo Sorce
51083de795 r15942: Remove the sync internal ldb calls altogether.
This means that some modules have been disabled as well as they
have not been ported to the async interface

One of them is the ugly objectclass module.
I hope that the change in samldb module will make the MMC happy
without the need of this crappy module, we need proper handling
in a decent schema module.

proxy and ldb_map have also been disabled
ldb_sqlite3 need to be ported as well (currenlty just broken).
2007-10-10 14:08:43 -05:00
Simo Sorce
f0c1d08d50 r15932: Remove per request creds
They have never benn used and make little sense too imo
2007-10-10 14:08:41 -05:00
Simo Sorce
7d65105e88 r15927: Optimize ldb module traverse while keeping the API intact.
I was sick of jumping inot each module for each request,
even the ones not handle by that module.
2007-10-10 14:08:41 -05:00
Simo Sorce
6af1d738b9 r15913: Error passing in the async code is not in agood shape
Start enhancing it and fix some problems with incorrect evalutaion of the codes

Implement rdn rename (async only)
2007-10-10 14:08:39 -05:00
Andrew Tridgell
1848078fee r15859: fixed a crash bug in the ldb password_hash module. This one is quite
sublte - please have a look at the change if you are not certain you
know the semantics of constant arrays declared on the stack (they must
be static if you return them from the function)
2007-10-10 14:08:33 -05:00
Simo Sorce
2e9a840bb9 r15804: Fix SAMLOGON test 2007-10-10 14:08:25 -05:00
Simo Sorce
8b2a563e71 r15795: Try to use the async code by default
It passess all my tests, but I still need to work on a lot of stuff.
Shouldn't impact anybody else work, so I want to commit now and see what happens

Will work to remove the old code from modules and backends soon, and make some
more restyling in ldb internals.

So, if there is something you don't like in this desgin please speak now.

Simo.
2007-10-10 14:08:21 -05:00
Simo Sorce
977982c884 r15789: hmm, damn, testing uncovcer all your bugs :-) 2007-10-10 14:08:20 -05:00
Simo Sorce
36537100db r15783: Fix previous commit, was the wrong way to deal with the problem 2007-10-10 14:08:19 -05:00
Simo Sorce
3c9434e264 r15782: More fixes for async cases 2007-10-10 14:08:19 -05:00
Simo Sorce
099d873ea5 r15761: Fix-as-you-go ...
Testing various async paths and uncovering bugs
2007-10-10 14:08:15 -05:00
Simo Sorce
b7d5f23257 r15725: First shot at making password_hash async
The async path is not yet enabled by default so it should make no harm
2007-10-10 14:08:09 -05:00
Stefan Metzmacher
73ca71b42b r15639: fix warnings
metze
2007-10-10 14:07:25 -05:00
Simo Sorce
7c050b541e r15582: Commit some forgotten stuff that have been setting on my private tree fro long 2007-10-10 14:06:00 -05:00
Andrew Bartlett
3d43e458a8 r15511: Using this name causes less warnings on the IBM checker, due to using
the original, rather than equivilant, enum type.

Andrew Bartlett
2007-10-10 14:05:44 -05:00
Jelmer Vernooij
c19c2b51d3 r15328: Move some functions around, remove dependencies.
Remove some autogenerated headers (which had prototypes now autogenerated by pidl)
Remove ndr_security.h from a few places - it's no longer necessary
2007-10-10 14:05:17 -05:00
Stefan Metzmacher
9611c8aa9c r15319: remove unneeded macros
metze
2007-10-10 14:05:14 -05:00
Jelmer Vernooij
f0afe9e2ff r15313: Fix some dependencies in dso mode 2007-10-10 14:05:09 -05:00
Jelmer Vernooij
6646384aaf r15298: Fix the build using a few hacks in the build system.
Recursive dependencies are now forbidden (the build system
will bail out if there are any).

I've split up auth_sam.c into auth_sam.c and sam.c. Andrew,
please rename sam.c / move its contents to whatever/wherever you think suits
best.
2007-10-10 14:05:04 -05:00
Jelmer Vernooij
5b3ab728ed r15297: Move create_security_token() to samdb as it requires SAMDB (and the rest of LIBSECURITY doesn't)
Make the ldb password_hash module only depend on some keys manipulation code, not full heimdal
Some other dependency fixes
2007-10-10 14:05:04 -05:00
Jelmer Vernooij
adc8a019b6 r15207: Introduce PRIVATE_DEPENDENCIES and PUBLIC_DEPENDENCIES as replacement
for REQUIRED_SUBSYSTEMS.
2007-10-10 14:04:18 -05:00
Stefan Metzmacher
92a0663812 r15076: give the correct return code
metze
2007-10-10 14:04:06 -05:00