Matthias Dieter Wallnöfer
afcf18f3c9
s4:samr RPC server - "SetUserInfo" - allow some more informations to be set
...
Taken from the s3 implementation.
2010-07-05 15:36:12 +02:00
Matthias Dieter Wallnöfer
95127b3f5f
s4:rpc_server/browser.c - remove unused code
...
Spotted by the Solaris 10 compiler
2010-06-29 22:32:05 +02:00
Matthias Dieter Wallnöfer
e5c5d371d1
s4:dcesrv_drsuapi.c - fix a counter variable
2010-06-28 14:51:09 +02:00
Matthias Dieter Wallnöfer
4826fdf95f
s4:lsa RPC server - Fix up "dcesrv_lsa_DeleteObject"
...
- Return always "NT_STATUS_OK" on success
- Remove "talloc_free"s on handles since the frees are automatically performed by
the DCE/RPC server code
2010-06-28 14:51:08 +02:00
Matthias Dieter Wallnöfer
d6098de507
s4:dcesrv_samr_SetUserInfo - implement right "pwdLastSet" behaviour
...
Behaviour as the torture SAMR passwords tests show.
2010-06-28 14:51:05 +02:00
Matthias Dieter Wallnöfer
3c1a9fb87f
s4:dcesrv_samr_SetUserInfo - deny operations when "fields_present" is 0
...
Taken from s3
2010-06-28 14:51:05 +02:00
Matthias Dieter Wallnöfer
ea83d21341
s4:dcesrv_samr_SetUserInfo - port the "SAMR_FIELD_LAST_PWD_CHANGE" check from s3 to s4
2010-06-28 14:51:04 +02:00
Matthias Dieter Wallnöfer
4c63bb312f
s4:dcesrv_samr_SetUserInfo - implement password set level 21
2010-06-28 14:51:04 +02:00
Matthias Dieter Wallnöfer
b705026771
s4:dcesrv_samr_SetUserInfo - implement case 18 which allows to reset the user password
2010-06-28 14:51:04 +02:00
Matthias Dieter Wallnöfer
8feda76d4f
s4:OemChangePasswordUser2 - return "NT_STATUS_WRONG_PASSWORD" when we haven't activated the the lanman auth
...
This is what s3 does.
2010-06-28 14:51:03 +02:00
Matthias Dieter Wallnöfer
8f20a5512a
s4:samr_password.c - add a function which sets the password through encrypted password hashes
...
Used for password sets on "samr_SetUserInfo" level 18 and 21.
2010-06-28 14:51:03 +02:00
Matthias Dieter Wallnöfer
6f6365daba
s4:rpc_server/srvsvc/dcesrv_srvsvc.c - remove unreachable code
2010-06-26 20:08:47 +02:00
Matthias Dieter Wallnöfer
f12dab8e00
s4:rpc_server/wkssvc/dcesrv_wkssvc.c - remove unreachable code
2010-06-26 20:08:47 +02:00
Matthias Dieter Wallnöfer
3c3ecf40e5
s4:rpc_server/lsa/dcesrv_lsa.c - remove unreachable code
2010-06-26 20:08:46 +02:00
Matthias Dieter Wallnöfer
d85d6054c9
s4:lsa/lsa_lookup.c - use a better type for the "rtype" of the wellknown SIDs
...
To suppress warnings on Solaris 10
2010-06-26 20:08:45 +02:00
Matthias Dieter Wallnöfer
3f2e9ce2b4
s4:rpc_server/drsuapi/drsutil.c - remove unreachable code
2010-06-26 19:46:33 +02:00
Matthias Dieter Wallnöfer
e5e4184e5a
s4:rpc_server/dcesrv_auth.c - remove unreachable code
2010-06-26 19:45:45 +02:00
Matthias Dieter Wallnöfer
eff7d2db31
s4:samr RPC server - make use of LDB constants in macros
2010-06-22 22:21:12 +02:00
Matthias Dieter Wallnöfer
2f49c8f58e
s4:samr RPC server - fix Solaris build warning
2010-06-20 22:33:01 +02:00
Matthias Dieter Wallnöfer
871cdec414
s4:registry RPC server - quite some build warnings on Solaris
2010-06-20 22:33:01 +02:00
Matthias Dieter Wallnöfer
82fd483758
s4:lsa_lookup.c - fix type argument
2010-06-20 22:33:00 +02:00
Matthias Dieter Wallnöfer
0bf26edf6c
s4:rpc_server/service_rpc.c - fix warnings on Solaris
2010-06-20 22:32:59 +02:00
Matthias Dieter Wallnöfer
c972e6ec23
s4:rpc_server/service_rpc.c - deactivate the 0-length struct
...
This should fix the build on Solaris
2010-06-20 22:32:59 +02:00
Matthias Dieter Wallnöfer
56e4822566
s4:dcesrv_netr_DsRAddressToSitenamesExW - fix the detection of the address family in a better way
...
Obviously the last attempt wasn't enough. Now we do really only read the first
byte in the address buffer which on little endian transmission does always
contain the address family (MS-NRPC 2.2.1.2.4.1).
This should now be working platform-independently.
2010-06-18 10:03:08 +02:00
Matthias Dieter Wallnöfer
d9c81e3ea5
s4:dcesrv_netr_DsRAddressToSitenamesExW - fix the read of the IP packet version
...
This should make it clearer by the use of the standardised "sa_family_t" type
and hopefully fixes the problems on platforms other than Linux (NetBSD in the
buildfarm for example).
2010-06-16 21:47:22 +02:00
Matthias Dieter Wallnöfer
1137e8e95e
s4:SAMR server - cosmetic fix
2010-06-14 11:41:32 +02:00
Matthias Dieter Wallnöfer
f0ab520f6e
s4:SAMR server - on alias search operations do never use the domain DN as base dn
...
Aliases (especially in the "builtin" domain) are often domain-independant.
2010-06-14 11:37:11 +02:00
Matthias Dieter Wallnöfer
731b4469cb
s4:dcesrv_samr_GetGroupsForUser - return error code if a SID wasn't found
...
This shouldn't happen since SIDs are mandatory for security objects
2010-06-12 17:50:52 +02:00
Matthias Dieter Wallnöfer
a67fa2db3b
s4:dcesrv_samr_QueryGroupMember/GetMembersInAlias - unify the structure
...
Mostly cosmetic fixes
2010-06-12 17:45:14 +02:00
Matthias Dieter Wallnöfer
d2c25e1b11
s4:dcesrv_samr_GetAliasMembership - provide a correct implementation
...
We could also have no valid SID specified at all and also then we have to
return an empty array with "NT_STATUS_OK". This shows the torture testsuite.
2010-06-12 16:45:48 +02:00
Matthias Dieter Wallnöfer
4a8ee9a333
s4:dcesrv_samr_EnumDomainGroups/Aliases - when we don't get a SID then the database is corrupted
...
Group/User/Alias entries do always have a SID (it's a mandatory attribute in the
SAM directory)!
2010-06-12 16:45:48 +02:00
Matthias Dieter Wallnöfer
4659b3c4fd
s4:dcesrv_samr_QueryAliasInfo - return "NT_STATUS_NO_SUCH_ALIAS" when it wasn't found
2010-06-12 16:45:48 +02:00
Matthias Dieter Wallnöfer
d2099a1def
s4:dcesrv_samr_QueryGroupInfo - make it more like "QueryAliasInfo"
2010-06-12 16:45:48 +02:00
Matthias Dieter Wallnöfer
776eb25ef7
s4:dcesrv_samr_QueryUserInfo - minor fixes
...
Return "NT_STATUS_NO_SUCH_USER" when user account doesn't exist.
2010-06-12 16:45:47 +02:00
Matthias Dieter Wallnöfer
cdecae6c03
s4:dcesrv_samr_QueryDomainInfo - allocate the "info" structure only when really needed
...
That means the allocation should move after the lookup (as it is on
"QueryUserInfo"). Return "NT_STATUS_NO_SUCH_DOMAIN" on an invalid domain.
2010-06-12 16:45:47 +02:00
Matthias Dieter Wallnöfer
0171f714b4
s4:dcesrv_samr_EnumDomainGroups - mostly small fixes
2010-06-12 16:45:47 +02:00
Matthias Dieter Wallnöfer
f2c3d39e72
s4:dcesrv_samr_EnumDomainAliases - return an empty array also when no entry was returned
2010-06-12 16:45:46 +02:00
Matthias Dieter Wallnöfer
5a1cb7029c
s4:dcesrv_samr_EnumDomainAliases - mostly small fixes
...
The biggest change consists in the implementation of the Windows Server
return size formula MIN(*r->out.num_entries, 1+(r->in.max_size/SAMR_ENUM_USERS_MULTIPLIER).
2010-06-12 16:45:46 +02:00
Matthias Dieter Wallnöfer
84bda98066
s4:dcesrv_samr_EnumDomainUsers - make this call look more similar to "EnumDomainGroups" and "EnumDomainAliases"
...
That means that the lookup is now also done by "samdb_search_domain" to be more
consistent.
2010-06-12 16:45:46 +02:00
Matthias Dieter Wallnöfer
9f95298864
s4:dcesrv_samr_Add/DeleteAliasMember - provide better NTSTATUS return codes when something didn't work
2010-06-10 16:22:08 +02:00
Matthias Dieter Wallnöfer
7374cd0358
s4:dcesrv_samr_GetAliasMembership - fix type of counter variables
2010-06-10 16:22:07 +02:00
Matthias Dieter Wallnöfer
34b43a8642
s4:dcesrv_samr_DeleteAliasMember - add more braces to fit better the coding styles
2010-06-10 16:22:07 +02:00
Matthias Dieter Wallnöfer
305f2c7043
s4:dcesrv_samr_AddAliasMembership - Merge the two error blocks into one
2010-06-10 16:22:07 +02:00
Matthias Dieter Wallnöfer
13b1f7a2b3
s4:dcesrv_samr_Add/DelGroupMember - remove the account type check
...
MS-SAMR 3.1.5.8 speaks from accounts which are not necessarely only users.
2010-06-10 16:22:06 +02:00
Matthias Dieter Wallnöfer
f95634dbe0
s4:dcesrv_samr_AddGroupMember - also the error code "LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS" is allowed
...
This is returned when the group is the primary group of the specified entry.
2010-06-10 16:22:06 +02:00
Matthias Dieter Wallnöfer
11e2608ba9
s3/s4:netrEnumerateTrustedDomains - this call returns a "NTSTATUS" result
...
See MS-NRPC 3.5.5.6.3.
2010-05-31 12:08:59 +02:00
Matthias Dieter Wallnöfer
0eec33417e
s4:dcesrv_netr_DsrEnumerateDomainTrusts - fix an integer type
2010-05-31 12:08:58 +02:00
Matthias Dieter Wallnöfer
55df7606e3
Revert "s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000"
...
This reverts commit 1cf5be39e30f9478606a5525eb7beeb21ee83c24.
My fix approach isn't such appreciated therefore revert this.
2010-05-30 14:53:36 +02:00
Matthias Dieter Wallnöfer
1cf5be39e3
s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000
...
Windows 2000 does strictly request header signing on some requests also if the
server doesn't provide it. But there is a small trick (don't reset the actual
session info) to make these special RPC operations work without a full header
signing implementation.
This fixes for example the list of domain groups in local groups when displayed
sing the local user/group management tool.
And this should finally fix bug #7113 .
The patch was inspired by another one by tridge and abartlet: http://gitweb.samba.org/samba.git/?p=tridge/samba.git;a=commitdiff;h=2dc19e2878371264606575d3fc09176776be7729
2010-05-30 12:39:30 +02:00
Simo Sorce
3c8dc5cd21
s4:smbd: Use tstream_npa_accept_existing to accept named pipe connections
...
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
2010-05-26 09:24:05 +02:00