1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Commit Graph

31624 Commits

Author SHA1 Message Date
Günther Deschner
357006bf07 s3-spoolss: Fix two uninitialized vars in spoolss util code.
Guenther
2010-04-09 18:44:19 +02:00
Günther Deschner
63b111bd32 s3: add iconv_convenience handle to pull/push sz helpers.
Guenther
2010-04-09 18:33:45 +02:00
Volker Lendecke
bfeab64ebf s3: Fix a typo 2010-04-09 16:49:49 +02:00
Volker Lendecke
c666b8af96 s3: Use talloc_tos() as talloc ctx for fd_lines_load() in map_username() 2010-04-09 14:09:23 +02:00
Volker Lendecke
d3e9e83d7e s3: TALLOC_FREE(command) correctly in map_username() 2010-04-09 14:08:00 +02:00
Jeremy Allison
08b24e923d Stop smb2 from calling into smb1 blocking lock request code.
Allocate a uint16_t internal SMB1 mid for an SMB2 request.
Add a back pointer from the faked up smb_request struct
to the smb2 request.

Getting ready to add restart code for blocking locks,
share mode violations and oplocks in SMB2.

Jeremy.
2010-04-08 22:15:55 -07:00
Jeremy Allison
3491f6d119 Simplify call_trans2qfilepathinfo() and smbd_do_qfilepathinfo()
Remove the bool ms_dfs_link parameter from smbd_do_qfilepathinfo.
It is not possible for this to be a DFS link. Remove the check_msdfs_link()
call from call_trans2qfilepathinfo() - the call to filename_convert()
above with a ucf_flags of zero *MUST* catch a DFS link and return
NT_STATUS_PATH_NOT_COVERED in this case, so the code below checking
for msdfs links is redundent. Don't add this to 3.5.x, as it's an
optimization but not needed to fix bug #7339 - MSDFS is non-functional in 3.5.x.

Jeremy.
2010-04-08 21:24:23 -07:00
Jeremy Allison
3587815595 Fix bug #7339 - MSDFS is non-functional in 3.5.x
In the refactoring around filename_convert, the split between the functions
resolve_dfspath() and resolve_dfspath_wcard() was lost, leaving us only with
resolve_dfspath_wcard().

Internally resolve_dfspath_wcard() calls dfs_redirect() only with a
"allow_wcards" flag of true, wheras the old resolve_dfspath() would call with a
value of false. The loss of this case causes dfs_redirect to always masquerade
DFS links as directories, even when they are being queried directly by a trans2
QPATHINFO call. We should only masquerade DFS links as directories when called
from a SMBsearch or trans2 findfirst/findnext - which was the intent of the
"allow_wcards" flag.

This patch adds back an allow_wcards bool parameter to
resolve_dfspath_wcard(). This bool is set from the state of the ucf_flags when
filename_convert() is called.

I will follow this up with a new smbclient-based torture test that will prevent
us from ever regressing our DFS support again.

Jeremy.
2010-04-08 20:32:36 -07:00
Günther Deschner
ffcaa73280 s3-winreg: add winreg_DeleteKeyEx stub.
Guenther
2010-04-09 00:27:58 +02:00
Günther Deschner
8d588e96d9 s3-lanman: use spoolss for api_RDosPrintJobDel().
Guenther
2010-04-08 16:24:33 +02:00
Günther Deschner
d5e2b43176 s3-lanman: use spoolss for api_WPrintQueueCtrl().
Guenther
2010-04-08 16:24:25 +02:00
Günther Deschner
84f3eeeca3 s3-registry: fix fill_in_printer_values() for datatype and printprocessor.
It is wise and good to enforce RAW and winprint, but we need to be consistent
with spoolss (and enforce it there).

Found by torture test.

Guenther
2010-04-08 16:21:40 +02:00
Volker Lendecke
3d5732fc13 s3: Remove the separate "child" argument from setup_domain_child() 2010-04-08 15:12:42 +02:00
Stefan Metzmacher
eb9b7d0363 s3:winbindd: make "smbcontrol winbindd validate-cache" reliable again
commit 73577205cf
(s3:winbindd: fix problems with SIGCHLD handling (bug #7317))
broke this.

metze
2010-04-08 12:48:32 +02:00
Volker Lendecke
ca74246b4b s3: Fix a typo 2010-04-08 10:49:57 +02:00
Jeremy Allison
3413cf7a6b Start to plumb smb2 into the oplock system. Calls dummy functions for now.
Jeremy.
2010-04-07 19:00:44 -07:00
Günther Deschner
d9138f4ccf s3-spoolss: Fix an issue in _spoolss_DeleteForm.
Found by torture test.

Guenther
2010-04-07 23:53:19 +02:00
Günther Deschner
65c5b786ca s3-spoolss: Fix some issues in _spoolss_AddForm.
Found by torture test.

Guenther
2010-04-07 23:53:18 +02:00
Günther Deschner
34ada1d540 s3-spoolss: Fix potential memleak in _spoolss_AddForm and _spoolss_SetForm.
Guenther
2010-04-07 23:53:18 +02:00
Volker Lendecke
7ccd68073d s3: Fix bug 7327 -- Build fails while building without kerberos
libsmb/clikrb5.c has a dummy implementation for the non-kerberos case
2010-04-07 22:31:09 +02:00
Jeremy Allison
556b42a351 On compound requests, MS-SMB2 says clients MAY use 0xFFFFFFFF for compound tid and 0xFFFFFFFFFFFFFFFF for compound sessionid values. Cope with this.
Jeremy.
2010-04-07 10:32:01 -07:00
Jeremy Allison
146c1618e4 Don't forget to initialize *p_creds_requested.
Jeremy.
2010-04-07 10:31:43 -07:00
Andreas Schneider
eebc66ce32 s3-spoolss: Added a winreg_getform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:53 +02:00
Andreas Schneider
c7fb84a58f s3-spoolss: Added a winreg_setform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:53 +02:00
Andreas Schneider
0d46ab0f3e s3-spoolss: Added a winreg_deleteform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:53 +02:00
Andreas Schneider
93575d6d70 s3-spoolss: Added a winreg_addform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:53 +02:00
Andreas Schneider
fbd3235610 s3-spoolss: Added a winreg_enumforms1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:53 +02:00
Andreas Schneider
20e96d9243 s3-spoolss: Fixed winreg_printer_openkey to be used in a more generic way.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:53 +02:00
Andreas Schneider
adfd4854fa s3-spoolss: Added a delete_printer_key function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:52 +02:00
Andreas Schneider
f0054d8361 s3-spoolss: Added a enum_printer_key function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:52 +02:00
Andreas Schneider
77d1b73a3e s3-spoolss: Added a delete_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:52 +02:00
Andreas Schneider
e498338f6f s3-spoolss: Added a enum_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:52 +02:00
Andreas Schneider
511dba5ae8 s3-spoolss: Added a get_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:52 +02:00
Andreas Schneider
bc23545909 s3-spoolss: Added a set_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:52 +02:00
Andreas Schneider
4f3893f814 s3-spoolss: Added a function to open a regkey using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-04-07 15:16:52 +02:00
Günther Deschner
95b9c48ef1 s3-rpcclient: allow to define server_unc in cmd_srvsvc_srv_query_info().
Guenther
2010-04-07 14:41:13 +02:00
Björn Jacke
3fdebc0646 s3: add comment about what the FSCTL_QUERY_ALLOCATED_RANGES currently does 2010-04-07 12:22:47 +02:00
Jeremy Allison
3d113a6ffb Ensure we total up the correct number of creds requested in a compound request. 2010-04-06 16:31:26 -07:00
Jeremy Allison
9c410118cb Parameterize "smb2 max read", "smb2 max write", "smb2 max trans".
Set to 64k by default.

Jeremy.
2010-04-06 15:43:35 -07:00
Christian Ambach
96ae3ee803 fix a segfault in the notify subsystem
When the notify_array cannot be loaded correctly,
do not keep the half-baked parsing results in the global variable.

This can lead to segfaults next time notify_load is entered and
the seqnum has not changed. This has been seen in a case
where mixed smbd versions were running in a CTDB cluster
(versions with and w/o commit c216d1e6 that changed the
notify_entry structure).
There will be missed notifications until all smbds are at the
same software level, but this should be acceptable and is better
than crashing and interrupting client operations.

This fix cleans up the notify_array, removes the unparseable data
from the TDB and returns a fresh notify_array that can be worked
with.

The NDR_PRINT_DEBUG had to be moved to only be called when the
parsing succeeded, it was seen to cause additional segfaults.

The status variable is intentionally left to NT_STATUS_OK to not
make callers abort and report errors to the clients and make them
disconnect.

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2010-04-06 14:09:06 +02:00
Andrew Tridgell
553324bc10 s4-waf: move to a universal method of recursing into subdirs
This works with both standalone lib builds and bundled builds
2010-04-06 20:27:25 +10:00
Andrew Tridgell
c2d17cf978 s4-waf: set default for bundled libraries 2010-04-06 20:27:12 +10:00
Andrew Tridgell
f9eae32f4b s4-waf: mark the wscript files as python so vim/emacs knows how to highlight them 2010-04-06 20:27:11 +10:00
Andrew Tridgell
a247ce8ef9 s3-waf: added options for static/shared module building
Pair-Programmed-With: Kai Blin <kai@samba.org>
2010-04-06 20:27:08 +10:00
Andrew Tridgell
ab343e037d s3-waf: build version.h 2010-04-06 20:27:08 +10:00
Andrew Tridgell
0b47bda816 s3-waf: charsets needs to be quoted as strings in config.h
Pair-Programmed-With: Kai Blin <kai@samba.org>
2010-04-06 20:27:08 +10:00
Andrew Tridgell
6b3a72dd45 s3-waf: fixed tests for charsets
Pair-Programmed-With: Kai
2010-04-06 20:27:08 +10:00
Kai Blin
ecafbd3ec8 s3-waf: check for default charsets 2010-04-06 20:27:07 +10:00
Andrew Tridgell
8f5551c4b3 s3-waf: use new variable expansion feature 2010-04-06 20:27:06 +10:00
Andrew Tridgell
b2f01b54d2 s3-waf: modulesdir is in the base set of options now 2010-04-06 20:27:06 +10:00