James Peach
a22bf28bca
r16483: Turn off some useless MIPSPro warnings be default.
2007-10-10 11:18:56 -05:00
James Peach
2131ddd7a1
r16482: Fix bugzilla 3801 by forcing MIPSPro warning 1035 to be an error.
2007-10-10 11:18:56 -05:00
Günther Deschner
5853525f11
r16480: (Ugly) workaround before the set_dc_type_flags & friends cleanup:
...
When trying to login using krb5 with a trusted domain account, we
need to make sure that our and the remote domain are AD.
Guenther
2007-10-10 11:18:56 -05:00
Günther Deschner
098a87f492
r16479: When dcip_to_name failed to get the name of the ip in saf_servername we
...
cannot put saf_name in the failed conn cache as it's uninitialized.
Store saf_servername (the ip) in that case.
Volker, please check.
Guenther
2007-10-10 11:18:56 -05:00
Gerald Carter
0fca41efde
r16478: small cleanup to make pam_winbind.so build and iniparser
...
include directory like other parts of the build files.
2007-10-10 11:18:56 -05:00
Günther Deschner
d6b52e8181
r16475: destroy talloc ctx when we weren't able to collect onlinestatus
...
messages.
Guenther
2007-10-10 11:18:56 -05:00
Günther Deschner
dfbe555c69
r16474: There is no point in figuring out lockout policies if we do not allow
...
offline logons at all.
Guenther
2007-10-10 11:18:55 -05:00
Günther Deschner
520777f794
r16473: There is no point in calling set_dc_type_and_flags() before each
...
pam_auth login (when using kerberos).
Guenther
2007-10-10 11:18:55 -05:00
Gerald Carter
ce7846d6f1
r16471: Bug reported by Vitaly Protsko <villy@sft.ru> in 3.0.23rc1.
...
Add missing automatic add of the Administrators SID in the absence
of winbindd and precense of Domain Admins SID in the user's token.
2007-10-10 11:18:55 -05:00
Gerald Carter
8421d1b080
r16470: remove ntlm_auth_proto.h and passwd_proto.h in 'make clean
2007-10-10 11:18:55 -05:00
Günther Deschner
840ac23ec0
r16458: Increase debuglevel of cli_rpc_pipe_close().
...
Guenther
2007-10-10 11:18:55 -05:00
Günther Deschner
49fb1a3ebc
r16453: Fix another memleak.
...
Guenther
2007-10-10 11:18:55 -05:00
Günther Deschner
479dec6845
r16452: Fix memleak in the CLDAP processing (found by valgrind).
...
Guenther
2007-10-10 11:18:54 -05:00
Jeremy Allison
d929323d6f
r16435: Add in the uid info that Jerry needs into the
...
share_mode struct. Allows us to know the unix
uid of the opener of the file/directory. Needed
for info level queries on open files.
Jeremy.
2007-10-10 11:18:54 -05:00
Jeremy Allison
490c7c8467
r16433: Fix Coverity #300 (triggered by a Klockwork bugfix
...
I think). If a alloc fails just return NT_STATUS_NO_MEMORY,
don't go to "done" label and deref pointers.
Jeremy.
2007-10-10 11:18:54 -05:00
Jeremy Allison
9017547ccc
r16429: Fix final 4 Klocwork bugs we're going to fix before
...
release - #785 , #786 , #787 , #788 .
Jeremy.
2007-10-10 11:18:53 -05:00
Volker Lendecke
adf2dcce09
r16427: Fix bug # 3848. Thanks to Wilco Baan Hofman for testing the release candidate!
...
Volker
2007-10-10 11:18:53 -05:00
Jeremy Allison
e71cc6647a
r16426: Klocwork #1544 , #1545 , #1546 , #1549 , #1550 , #1552 , #1553 , #1554
...
Jeremy.
2007-10-10 11:18:53 -05:00
Jeremy Allison
4fbeae1a3a
r16424: Fix possible null deref and a memory leak found by
...
examining Klockwork #1519 . get_printer_subkeys()
could return zero without initializing it's return
pointer arg. Fixed this. Added free of subkey pointer
return in registry/reg_printing.c (interesting that
neithe Coverity or Klocwork found this one).
Jeremy.
2007-10-10 11:18:52 -05:00
Jeremy Allison
e83c3e0a65
r16422: winbindd_demote_client isn't used and generates
...
a Klocwork issue (#1844 ). Remove it
Jeremy.
2007-10-10 11:18:52 -05:00
Jeremy Allison
f5dddf339e
r16420: Fix Klocwork #1674 . Null deref.
...
Jeremy.
2007-10-10 11:18:52 -05:00
Günther Deschner
4e1816855a
r16415: Also delete object files from iniparser.
...
Guenther
2007-10-10 11:18:52 -05:00
Volker Lendecke
601643a460
r16411: Fix compilation of vfs_afsacl, thanks to Greszler Szilard for trying
2007-10-10 11:18:52 -05:00
Volker Lendecke
d6547d12b1
r16409: Fix Klocwork ID's.
...
1177
In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251
Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.
smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460
Volker
Volker
2007-10-10 11:18:52 -05:00
Jeremy Allison
d357f8b335
r16397: Fix Klocwork #11767 and drasticly simplify the
...
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
2007-10-10 11:18:52 -05:00
Jeremy Allison
220627ab70
r16396: Klocwork #1170 . Null deref.
...
Jeremy.
2007-10-10 11:18:51 -05:00
Jeremy Allison
c9a4ce51ed
r16393: Klocwork #1164 . Null deref.
...
Jeremy.
2007-10-10 11:18:51 -05:00
Jeremy Allison
cab256d72a
r16392: Klockwork #1168 . Protect against null deref.
...
Jeremy.
2007-10-10 11:18:51 -05:00
Jeremy Allison
e99cedfb0c
r16390: Klocwork #604 - ensure if NULL pointer we assert
...
if len != 0.
Jeremy.
2007-10-10 11:18:51 -05:00
Jeremy Allison
ceea8e2100
r16388: Klocwork #320 . Null deref.
...
Jeremy.
2007-10-10 11:18:51 -05:00
Jeremy Allison
d47ec4dc25
r16386: Klockwork #lots. Ensure talloc_get_type_abort aborts
...
if handed a NULL pointer, not returns NULL.
Jeremy.
2007-10-10 11:18:51 -05:00
Jeremy Allison
7b68a2acfc
r16383: Klocwork #1086 . No null deref.
...
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
2e5a881478
r16381: Now samu can't be null don't check it on set. Klockwork
...
related fix.
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
05c50d99a4
r16378: Klocwork #1079 . Allow BUFFER5 to cope with a NULL
...
dependentfiles pointer.
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
72709a8465
r16377: Klocwork #1077 .
...
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
99605ce296
r16375: Klocwork #1670 .
...
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
080464b93d
r16373: Fix Klocwork #1071 .
...
Jeremy
2007-10-10 11:18:50 -05:00
Jeremy Allison
5057e90db3
r16371: Fix Klocwork #1048 .
...
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
6924d1cd44
r16369: Klocwork #1035 .
...
Jeremy.
2007-10-10 11:18:49 -05:00
Jeremy Allison
b581fee982
r16367: Missed one, Klocwork #915 .
...
Jeremy.
2007-10-10 11:18:49 -05:00
Jeremy Allison
fe05769a1a
r16365: Fix Klocwork #895 , #898 , #899 , #915 , #932 , #938 and a
...
few other problems Klocwork missed.
Jeremy.
2007-10-10 11:18:49 -05:00
Volker Lendecke
ce1d8423ef
r16363: Fix Klocwork ID 981 1652
...
Volker
2007-10-10 11:18:49 -05:00
Volker Lendecke
e35f901067
r16362: That's the best way to fix a Klocwork bug: Remove the (unused...;-) code
...
altogether. This was essentially a second implementation if string_to_sid.
Klocwork ID 1038
Volker
2007-10-10 11:18:49 -05:00
Volker Lendecke
8a5cebc19e
r16361: Fix Klocwork ID 1731 1770 1771 1775 1796
...
Volker
2007-10-10 11:18:49 -05:00
Volker Lendecke
3df0bf7d60
r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
...
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
2007-10-10 11:18:48 -05:00
Jeremy Allison
09c8973286
r16358: ALWAYS compile this stuff on a 64-bit box before
...
checking in. size_t != uint32 on a 64-bit machine.
Jeremy.
2007-10-10 11:18:48 -05:00
Jeremy Allison
6193f11708
r16356: Helping derrell out. Jeremy.
...
Only set the DFS capability flag if the share is a DFS root. Fixes bug 3814.
2007-10-10 11:18:48 -05:00
Günther Deschner
3203ce3b49
r16350: Fix the build.
...
GUenther
2007-10-10 11:17:37 -05:00
Günther Deschner
d8fd94648f
r16349: Another fix to make winbind more robust in large domains:
...
We may only feed rpc_useraliases with chunks of 1024 entries. This is
important as the token generation otherwise fails when a user is member
of more then 1024 groups.
Volker, please check.
Guenther
2007-10-10 11:17:37 -05:00
Günther Deschner
232566e1cb
r16346: Allow to exit a "net rpc shell" with 'quit' or 'exit'.
...
Guenther
2007-10-10 11:17:37 -05:00