1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

669 Commits

Author SHA1 Message Date
Andrew Tridgell
ec879eacc2 This removes the 3rd argument from init_unistr2(). There were 240
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.

The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.

I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing.
(This used to be commit b9eff31b1433c81fbff733e194914a40f25e3bda)
2003-01-17 04:58:45 +00:00
Tim Potter
5183aada24 Let's clean up client side ntlmssp!
Removed a dead function.
(This used to be commit a1c790b5ea8de120a1d8710ac190955aea28246f)
2003-01-17 04:05:28 +00:00
Gerald Carter
4242eda183 merging some rpcclient and net functionality from HEAD
(This used to be commit 7a4c87484237308cb3ad0d671687da7e0f6e733b)
2003-01-15 17:22:48 +00:00
Andrew Tridgell
eb6312af9f added cli_lsa_enum_account_rights() call. Note that this is in
principal similar to the existing cli_lsa_enum_privsaccount() call,
except that cli_lsa_enum_account_rights() doesn't require a call to
open_account first. There is also the minor matter that
cli_lsa_enum_account_rights() works whereas
cli_lsa_enum_privsaccount() doesn't!

this call can be used to find what privileges an account or group
has. This is a first step towards proper privileges support in Samba.
(This used to be commit 65bac11d716f873dcdbda528313c33634c26a072)
2003-01-15 07:40:40 +00:00
Tim Potter
3c23522863 Added comment about a SMB_ASSERT()
(This used to be commit 056bdfbce73bbd7ddaa198d18e596b94b2224d3d)
2003-01-14 05:25:08 +00:00
Richard Sharpe
5bbac9dd80 Make sure that those cleanups actually went in.
(This used to be commit 9a38e378115a1c36d0cd7c41f4c5767c23b4eb3f)
2003-01-13 20:30:28 +00:00
Richard Sharpe
16925589eb Now that I am running config.developer, I decided to get rif of some warnings:
1. reboot in parse_reg and cli_reg was shadowing a definition on FreeBSD
   4.3 from system includes.

2. Added a bit of const to places.

3. Made sure internal functions were declared where needed.
(This used to be commit fd847aa93690eb72f0437a8d22c03b222eb2a016)
2003-01-13 20:04:40 +00:00
Gerald Carter
071af8f007 [merge] make sure to update print queue cache during timeout_processing() to send notify events; CR 1491
(This used to be commit f8a915b14d63e4fdb99235053eeb896ef9492068)
2003-01-11 02:38:36 +00:00
Gerald Carter
47873e781d [merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491
(This used to be commit 142c5029c701e7a82074e301278846c02843f46f)
2003-01-11 02:29:23 +00:00
Andrew Bartlett
b327f5ba53 Merge from HEAD - idra's fix for the fact that the shutdown command takes two 1
byte boolean flags, not a 16 bit bitmask.

Andrew Bartlett
(This used to be commit a4f7777ca08c732ace2ba60bc0ecffbea1239fc3)
2003-01-04 07:50:04 +00:00
Andrew Bartlett
634c54310c Merge from HEAD - make Samba compile with -Wwrite-strings without additional
warnings.  (Adds a lot of const).

Andrew Bartlett
(This used to be commit 3a7458f9472432ef12c43008414925fd1ce8ea0c)
2003-01-03 08:28:12 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
2003-01-02 09:07:17 +00:00
Simo Sorce
60667264b7 the shutdown call does not have a 16 bit flags, but 2 byte representing booleans
this commit change the structure and code to reflect this

some test revelead I'm right.

some other revelead currently the abort shutdown does not work against my test machine even if it returns successfully ... need investigation
(This used to be commit c5892b656dedd0367adc33d9606311d1dde99a58)
2002-12-30 04:41:27 +00:00
Simo Sorce
e8c80081b5 fix rpcclient querygroup command (from 2.2 and head)
(This used to be commit ea2154b2692f76a3f0d597ddc154ecbbef72de60)
2002-12-08 12:03:42 +00:00
Simo Sorce
a543e6ea62 make querygroup in rpcclient working, same fix as per 2.2 tree
(This used to be commit 8877ff2482bfa880614a9f40eed448d60216419d)
2002-12-08 11:56:45 +00:00
Jeremy Allison
1c8e1e0448 Ensure callid is not used uninitialized.
Jeremy.
(This used to be commit ddd70995951c072a02fc3bddd7a94ccbf301f62c)
2002-12-02 23:51:53 +00:00
Gerald Carter
e6f956f9b4 fix cli_ds_getprimarydominfo(); merge from SAMBA_3_0
(This used to be commit 481a8a8aa9dff336929cb168302f3faa3f046aa8)
2002-11-27 02:23:25 +00:00
Gerald Carter
0c1a06dfad * finializnig RedHat package for alpha21 release
* fix cli_ds_getprimarydominfo() (bad memcpy() )
(This used to be commit e6184bbd8f87586e8cc98e4c599cf8e16f310bb9)
2002-11-27 02:22:53 +00:00
Tim Potter
b2201f2f39 Merge from appliance:
>Fix memory leak in cli_ds_getprimarydominfo()
(This used to be commit e643003dd4666d532604d86050d77f8b4212877e)
2002-11-19 01:14:00 +00:00
Tim Potter
1c5ffbd0ac Merge from appliance:
>Fix memory leak in cli_ds_getprimarydominfo()
(This used to be commit ca689916da200f2d772b007a913665a6b7df5bd7)
2002-11-19 01:12:44 +00:00
Tim Potter
e0d81b7728 A cool idea from mbp: create a big shared library of all Samba objects
which we can use to link against Samba unit test programs.  Now we can
compile and link unit tests without having to create 4MB executables
for each program

It's called libbigballofmud.so both to discourage casual usage and
also to reflect what the dependencies within Samba have become.
(This used to be commit fdce4be719d7a81f25a4bae05934a5590038ec47)
2002-11-15 00:20:55 +00:00
Jeremy Allison
2f194322d4 Removed global_myworkgroup, global_myname, global_myscope. Added liberal
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
(This used to be commit f755711df8f74f9b8e8c1a2b0d07d02a931eeb89)
2002-11-12 23:20:50 +00:00
Jeremy Allison
250c980119 Removed global_myworkgroup, global_myname, global_myscope. Added liberal
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
(This used to be commit 82b8f749a36b42e22186297482aad2abb04fab8a)
2002-11-12 23:15:52 +00:00
Jim McDonough
397873f0c4 Sync with HEAD to get enumprinterkey api.
(This used to be commit f6e21ba4c724f77586ef428f82126d209b0a9607)
2002-11-08 20:36:31 +00:00
Jeremy Allison
98f9e758f0 Merge Jim's new rpc client code to 3.0.
Jeremy.
(This used to be commit 121c456d4347bbefd9b2ce0141e3f53a21f37066)
2002-11-07 18:54:02 +00:00
Jim McDonough
e4a5ae5259 What is wrong with you, Jim? Check in the final version, not an interim one...
(This used to be commit 1fd6d34526e577b8a5463e3abcfb8fc3682e6473)
2002-11-07 15:43:04 +00:00
Jim McDonough
2b37e87bb9 Allow multiple fragment RPC's to be sent.
(This used to be commit d423e6424bc3c61281ad30cd1c66540b522b5d3e)
2002-11-07 14:40:25 +00:00
Jeremy Allison
47955b2f6c Merge of scalable printing code fix... Needs testing.
Also tidied up some of Richard's code (I don't think he uses the compiler
flags -g -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual like
I do :-) :-).
Jeremy.
(This used to be commit 10024ed06e9d91f24fdc78d59eef2f76bf395438)
2002-11-07 02:38:42 +00:00
Jeremy Allison
9304248788 Merge of scalable printing code fix... Needs testing.
Jeremy.
(This used to be commit d030df76439c72825d68410211e62090438cef54)
2002-11-07 02:15:35 +00:00
Tim Potter
904649b6f0 Client side functions for enumprinterkey.
(This used to be commit f56ce473b6964302ba51fc9796ee919738731065)
2002-11-06 23:38:39 +00:00
Tim Potter
84ef8d47a1 Display pipe name in rpc bind failure debug.
(This used to be commit 62ab0f8cbe7c517084383bdc9a8c97404ad27147)
2002-11-02 00:45:19 +00:00
Tim Potter
c49573e59f Display pipe name in rpc bind failure debug.
(This used to be commit 70838b33a61a10e9bd1622611a6be3b0cac08479)
2002-11-02 00:43:38 +00:00
Tim Potter
3a225c0785 Tidyup of some DCERPC pipe connection debugs. The new LSA_DS stuff
generates some errors we haven't seen before which are inappropriately
logged at level 0.
(This used to be commit bd64de3716ffa9c3ebec282aa5cc0f773d3d8096)
2002-11-01 00:38:26 +00:00
Tim Potter
5dd341d647 Tidyup of some DCERPC pipe connection debugs. The new LSA_DS stuff
generates some errors we haven't seen before which are inappropriately
logged at level 0.
(This used to be commit 40d5112048ab0943caef7149b7a0d9dee5256b87)
2002-11-01 00:37:45 +00:00
Tim Potter
346c9845a8 Fix a silly memset typo.
Change a int* to a uint32* in the cli_spoolss_enum_ports() function.
(This used to be commit 41a22b3a005876bccacd1f14d70547d2d71d1b1f)
2002-10-21 04:07:56 +00:00
Tim Potter
aed3a9f343 Fix a silly memset typo.
Change a int* to a uint32* in the cli_spoolss_enum_ports() function.
(This used to be commit 4663d79d3e9dcfef49f7cef1f6205efe58edbdc1)
2002-10-21 04:03:49 +00:00
Tim Potter
1188b37d6a Zero tallocated memory in decode_printer_info, decode_driver_info,
decode_port_info and decode_printerdriver functions.
(This used to be commit e28a719f04f8812ce01d78cf84b3a2e2935b674d)
2002-10-21 02:49:55 +00:00
Tim Potter
47cf2825f8 Zero tallocated memory in decode_printer_info, decode_driver_info,
decode_port_info and decode_printerdriver functions.
(This used to be commit bf2d9dd5ba2ecc7e0e1bd17049adee6dd80d807c)
2002-10-21 02:48:55 +00:00
Tim Potter
14a85b0008 Merge of SMB_ASSERT.
(This used to be commit 1094e1ffde09b0393b11d2cce148b6da893348c1)
2002-10-17 05:23:14 +00:00
Tim Potter
e7c011412b Do a SMB_ASSERT() in cli_nt_session_open() when the pipe index is out
of range instead of silently failing.
(This used to be commit b5111f47b5cf1820550e17663f983674b67bcaff)
2002-10-17 05:08:34 +00:00
Gerald Carter
bfa93735ab merge from APP_HEAD of winbindd's domain local group fix
(This used to be commit 09c6f6329d6ae9327b7ef06de0ea78d24d805456)
2002-10-08 18:32:42 +00:00
Gerald Carter
876afb5d0f merge from APP_HEAD
* s/driverlocation/comment
* detect native mode domain and enumerate local groups

Also

* Added sendfile stats from SAMBA_2_2
(This used to be commit 764b58e2c0b3179cffe157c0ab58761b156b8423)
2002-10-08 18:29:57 +00:00
Gerald Carter
055e6d1491 * merge native_mode flag in winbindd_domain struct from app-head
* add some files missing from a previous commit
(This used to be commit 29159c97371c75327e377f9d13406dad46095568)
2002-10-04 21:42:04 +00:00
Gerald Carter
d2eae2a299 merge native_mode flag in winbindd_domain struct from app-head
(This used to be commit dd948a302ad6bd4307ecdfb10510e12185150eae)
2002-10-04 21:39:09 +00:00
Gerald Carter
9c1b62c0fd merge of working dsrolegetprimdominfo() client code from APP_HEAD
(This used to be commit 028477e35208e76fedbc7c743426fd9be94b7cf0)
2002-10-04 19:33:41 +00:00
cvs2svn Import User
326a429d46 This commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.(This used to be commit 7950dfc795568798e8ede784b4e8b927be0add49) 2002-10-04 19:11:37 +00:00
Gerald Carter
d2ea6d5ae7 merge of working dsrolegetprimdominfo() client code from APP_HEAD
(This used to be commit f70caa25e4ee198151b915cf2bc0a26b2d0e243d)
2002-10-04 19:11:36 +00:00
Gerald Carter
36ef82a529 merge of new client side support the Win2k LSARPC UUID in rpcbind
from APP_HEAD
(This used to be commit 1cfd2ee433305e91e87804dd55d10e025d30a69e)
2002-10-04 04:10:23 +00:00
Gerald Carter
83e58265b5 merge of new client side support the Win2k LSARPC UUID in rpcbind
from APP_HEAD
(This used to be commit 38c9e4299845fd77cc8629945ce2d259489f7437)
2002-10-04 03:51:43 +00:00
Gerald Carter
ef6f8197a3 remove files not in HEAD
(This used to be commit 9d9f7bbf87bf9a0e003e6da482615fe040d00852)
2002-09-26 18:53:51 +00:00