sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Code
72,757 Commits 60 Branches 1,144 Tags 452 MiB
b83223476c
Commit Graph

4877 Commits

Author SHA1 Message Date
Stefan Metzmacher
9bbe047f8d s4:torture/rpc/autoidl: use dcerpc_binding_handle_raw_call() instead of dcerpc_request() 
metze
 2011-03-13 16:53:16 +01:00
Stefan Metzmacher
7888f0e7f7 s4:torture/rpc/object_uuid: use dcerpc_binding_handle_call() instead of dcerpc_ndr_request() 
metze
 2011-03-13 10:34:22 +01:00
Matthias Dieter Wallnöfer
a5aecdf361 s4:torture/rap/rap.c - remove unused variable "i" 
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Mar  2 18:38:58 CET 2011 on sn-devel-104
 2011-03-02 18:38:58 +01:00
Günther Deschner
bd675e0b15 s4-smbtorture: add netsessionenum rap torture test. 
Guenther
 2011-03-02 12:12:32 +01:00
Günther Deschner
c884e622fa s4-smbtorture: add smbcli_rap_netsessionenum(). 
Guenther
 2011-03-02 12:12:32 +01:00
Jelmer Vernooij
59a077d8f5 Fix some types 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 28 23:30:06 CET 2011 on sn-devel-104
 2011-02-28 23:30:06 +01:00
Jelmer Vernooij
136c160064 Use <tdb.h> to include tdb, so the system include file gets used when building against 
system tdb.
 2011-02-28 21:11:21 +01:00
Kamen Mazdrashki
375eddc15e s4/drs-test: Remove unused imports 2011-02-27 00:23:20 +02:00
Kamen Mazdrashki
62a6b75482 s4/drs-test: remove netReplicateCmd test from 'deleted object' test case 
DCs synchronization is moved to the test case setUp method
as there is no guarantee for the order of execution of tests
in a test case - thus netReplicateCmd may be executed after
ReplicateDeleteOjbect test
 2011-02-27 00:23:20 +02:00
Kamen Mazdrashki
281e306045 s4/drs-tests: Disable replication during 'deleted object' test 
This allows us to remove the patch that prevents the test failure.

Also pass 'forced' flag to samba-tool drs replicate command, otherwise
DsReplicaSync will fail with 'replication not permitted' error
 2011-02-27 00:23:19 +02:00
Kamen Mazdrashki
90d0d3e5f8 s4/drs-tests: Move enable/disable replication methods to DrsBase class so we can re-use them 2011-02-27 00:23:19 +02:00
Andrew Tridgell
5ec284d152 build: moved librpc/rpc/*.c into a rpccommon library 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb 24 02:42:37 CET 2011 on sn-devel-104
 2011-02-24 02:42:37 +01:00
Matthias Dieter Wallnöfer
85f4f73ed4 s4:torture/rpc/netlogon.c - fix two build warnings by casts 
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Feb 22 11:45:49 CET 2011 on sn-devel-104
 2011-02-22 11:45:49 +01:00
Andrew Tridgell
a12239b131 s4-waf: rename smbpasswd library to smbpasswdparser 
this removes a conflict with the s3 smbpasswd binary
 2011-02-22 02:51:10 +01:00
Günther Deschner
fb45c88904 s4-smbtorture: use torture_comment() instead of printf in raw.write test. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Feb 21 15:26:38 CET 2011 on sn-devel-104
 2011-02-21 15:26:38 +01:00
Günther Deschner
138533da3c s4-smbtorture: fix some indent in raw.write test. 
Guenther
 2011-02-21 14:42:22 +01:00
Günther Deschner
e1f4f0b605 s4-smbtorture: fix trailing whitespace in raw.write test. 
Guenther
 2011-02-21 14:42:22 +01:00
Christian Ambach
2ba57fd183 s4:smbtorture do not leave output directory around 
calling smbtorture with no or invalid arguments left the temporary
output directory around
this patches removes the dead-end exit from usage and makes the
logic go on until the final cleanup state is reached

output directory will still be left around when test times out
or testcases itself force an exit

also make sure that the directory itself is deleted, not just
the objects in it

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Feb 21 11:35:30 CET 2011 on sn-devel-104
 2011-02-21 11:35:30 +01:00
Kamen Mazdrashki
1273d504f2 s4/drs-tests:Blackbox test to verify DsReplicaSync handling 
DsReplicaSync is indirectly called using 'samba-tool drs options' command
to enable/disable replication and 'samba-tool drs replicate' command
to trigger inbound replication cycle

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sun Feb 20 23:03:03 CET 2011 on sn-devel-104
 2011-02-20 23:03:03 +01:00
Kamen Mazdrashki
adfb618ef5 s4/drs-tests: Allow _net_drs_replicate to force replication and return output from command execution 2011-02-20 23:13:11 +02:00
Kamen Mazdrashki
288e20cfb7 s4/drs-tests: Split samba-tool command line generation into separate method 
so we can use to exec samba-tool passing different commands
 2011-02-20 23:13:10 +02:00
Kamen Mazdrashki
75856d53cb s4/drs-tests: Inherit DrsReplSchemaTestCase from DrsBaseTestCase 
and remove duplicated functionality
 2011-02-20 23:13:09 +02:00
Kamen Mazdrashki
60bb40cd25 s4/drs-tests: Inherit DrsFsmoTestCase from DrsBaseTestCase 
and remove duplicated functionality
 2011-02-20 23:13:09 +02:00
Kamen Mazdrashki
fcd4aa84ed s4/drs-tests: Inherit DrsDeleteObjectTestCase from DrsBaseTestCase 
and remove duplicated functionality
 2011-02-20 23:13:08 +02:00
Kamen Mazdrashki
e21039110c s4/drs-tests: Add a base class to hold common functionality for all DRS python tests 2011-02-20 23:13:08 +02:00
Andrew Tridgell
ed71c1ef1f s4-auth: rename 'auth' subsystem to 'auth4' 
this prevents conflicts with the s3 auth modules. The auth modules in
samba3 may appear in production smb.conf files, so it is preferable to
rename the s4 modules for minimal disruption.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-18 15:09:46 +11:00
Günther Deschner
d4892f3876 s4-smbtorture: add more complex spoolss_EnumPrinterDataEx test. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Feb 17 16:46:28 CET 2011 on sn-devel-104
 2011-02-17 16:46:28 +01:00
Sumit Bose
92ea55e84e s4-smbtorture: Fix for RPC-LSA-FOREST-TRUST. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2011-02-16 11:44:06 +01:00
Sumit Bose
a357ac0222 s4-smbtorture: Two fixes for forest trust test against samba. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2011-02-16 11:44:05 +01:00
Volker Lendecke
fbcdef8268 s4: Fix a typo 2011-02-15 21:12:22 +01:00
Matthias Dieter Wallnöfer
20197c6687 s4:torture/rpc/samr.c - fix up the "test_GroupList" suite regarding QueryDisplayInfo 
This is needed to comply with the previous patch.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Feb 15 17:40:22 CET 2011 on sn-devel-104
 2011-02-15 17:40:22 +01:00
Andrew Tridgell
8dc92c8f71 ldb: use #include <ldb.h> for ldb 
thi ensures we are using the header corresponding to the version of
ldb we're linking against. Otherwise we could use the system ldb for
link and the in-tree one for include

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-10 06:51:07 +01:00
Andrew Bartlett
a2ce53c1f5 s4-auth Rework auth subsystem to remove struct auth_serversupplied_info 
This changes auth_serversupplied_info into the IDL-defined struct
auth_user_info_dc.  This then in turn contains a struct
auth_user_info, which is the only part of the structure that is
mainted into the struct session_info.

The idea here is to avoid keeping the incomplete results of the
authentication (such as session keys, lists of SID memberships etc) in
a namespace where it may be confused for the finalised results.

Andrew Barltett
 2011-02-09 01:11:06 +01:00
Günther Deschner
9e6d61fb85 s4-smbtorture: add torture test to check proper add and delete driver operations. 
Thanks to Bjoern Baumbach <bb@sernet.de> for pushing us to test and verify this.

Guenther
 2011-02-08 17:23:52 +01:00
Günther Deschner
7d107cda89 s4-smbtorture: also run the driver timestamp spoolss test against samba. 
Guenther
 2011-02-08 17:23:52 +01:00
Günther Deschner
34722c72f6 pam: share pam errors in a common location. 
Guenther
 2011-02-08 14:05:36 +01:00
Günther Deschner
be5edba117 libndr: share some uuid helpers. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb  8 09:52:56 CET 2011 on sn-devel-104
 2011-02-08 09:52:56 +01:00
Matthieu Patou
56b1cff70e s4 torture: add new rpc torture tests for backup key remote protocol 
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Feb  5 13:01:42 CET 2011 on sn-devel-104
 2011-02-05 13:01:42 +01:00
Stefan Metzmacher
eca7292aec s4:torture/rpc/netlogon: add invalid level tests for netr_LogonControl2 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Feb  2 12:43:32 CET 2011 on sn-devel-104
 2011-02-02 12:43:32 +01:00
Stefan Metzmacher
1f9caef362 s4:torture/rpc/netlogon: improve comments in test_LogonControl2() 
metze
 2011-02-02 11:58:26 +01:00
Stefan Metzmacher
89dd048bdf s4:torture/rpc/netlogon: test invalid netr_LogonControl() level 
metze
 2011-02-02 11:58:26 +01:00
Stefan Metzmacher
d3e4d90d41 s4:torture/rpc/netlogon: test invalid LogonSamLogon levels 
This proves that the invalid parameter/info class checks
need to be done before the credential chain checks.

metze
 2011-02-02 11:58:26 +01:00
Stefan Metzmacher
e9807916af s4:torture/rpc/netlogon: test validation levels 2 and 3 
metze
 2011-02-02 11:58:26 +01:00
Andrew Bartlett
7faa3be453 s4-python Ensure we add the Samba python path first. 
This exact form of the construction is important, and we match on it
in the installation scripts.

Andrew Bartlett
 2011-02-02 15:21:12 +11:00
Pavel Shilovsky
f453235ce0 smbtorture4 test for bug #7928 - Samba problems with kernel oplocks option set to "no" 2011-01-31 12:03:17 -08:00
Günther Deschner
1537f5dab1 s4-smbtorture: add samr_changepassworduser3 ndr torture tests. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 31 16:07:14 CET 2011 on sn-devel-104
 2011-01-31 16:07:14 +01:00
Günther Deschner
8f4eee9054 s4-smbtorture: make it more obvious this are w2k dumps in netlogon ndr test. 
Guenther
 2011-01-31 15:16:35 +01:00
Günther Deschner
7182da7f91 s4-smbtorture: add (disabled) ndr torture test to check for a w2k samlogon reply we can't currently parse. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 16:23:30 CET 2011 on sn-devel-104
 2011-01-28 16:23:30 +01:00
Günther Deschner
6957109e8d s4-smbtorture: add NDR tests for netr_LogonSamLogon. 
Guenther
 2011-01-28 15:37:10 +01:00
Andreas Schneider
dbb184ab7b s4-torture: Reorder the epmapper tests. 
It works like a stack!

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 15:28:05 CET 2011 on sn-devel-104
 2011-01-27 15:28:05 +01:00
Andreas Schneider
3e29bb0b92 s4-torture: Added a full epm_Map test. 2011-01-27 14:41:41 +01:00
Andreas Schneider
357fd2cecc s4-torture: Added a test_Insert for epmapper. 2011-01-27 14:41:41 +01:00
Andreas Schneider
43f766dd04 s4-torture: Use binding handle in epm_Delete test. 2011-01-27 14:41:41 +01:00
Andreas Schneider
fed2b6167a s4-torture: Comment out the test_InqObject. 2011-01-27 14:41:41 +01:00
Andreas Schneider
dd9feec3df s4-torture: Added a clean test_Map_simple. 2011-01-27 14:41:41 +01:00
Andreas Schneider
c3c650623a s4-torture: Added a clean test_Lookup_terminate_search. 2011-01-27 14:41:41 +01:00
Andreas Schneider
548c712082 s4-torture: Added a clean test_Lookup_simple. 2011-01-27 14:41:41 +01:00
Andreas Schneider
0ccb374c6a s4-torture: Added test_LookupHandleFree. 2011-01-27 14:41:40 +01:00
Andreas Schneider
9a771f17c8 s4-torture: Start with a clean epm_Insert_noreplace test. 2011-01-27 14:41:40 +01:00
Kamen Mazdrashki
6e2263749a s4-test/delete_object: Remove global ldb connections 
Make it more xUnit compliant

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Jan 25 21:30:19 CET 2011 on sn-devel-104
 2011-01-25 21:30:19 +01:00
Günther Deschner
1f3fb30ed9 s4-smbtorture: make sure there is always driverextra data in spoolss devmode size tests. 
Guenther
 2011-01-21 10:58:20 +01:00
Günther Deschner
aefbec5270 s4-smbtorture: add tests for the size member of spoolss devicemodes. 
Guenther
 2011-01-21 10:58:20 +01:00
Günther Deschner
7a7b61ef08 s4-smbtorture: prepare devicemode test for expected result tests. 
Guenther
 2011-01-21 10:58:20 +01:00
Günther Deschner
bb51c05014 s4-smbtorture: add some paranoia checks for 0 sized devmodes. 
Guenther
 2011-01-21 10:58:20 +01:00
Andrew Bartlett
fbe6d155bf s4-auth Remove special case for account_sid from auth_serversupplied_info 
This makes everything reference a server_info->sids list, which is now
a struct dom_sid *, not a struct dom_sid **.  This is in keeping with
the other sid lists in the security_token etc.

In the process, I also tidy up the talloc tree (move more structures
under their logical parents) and check for some possible overflows in
situations with a pathological number of sids.

Andrew Bartlett
 2011-01-20 23:44:05 +01:00
Stefan Metzmacher
c9e6bf047d lib/util: add tests for anonymous_shared_allocate/free() 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 06:25:03 CET 2011 on sn-devel-104
 2011-01-20 06:25:03 +01:00
Andrew Bartlett
489e3372d6 s4-torture Remove unused temp dirs from the RPC-PAC test. 
The code previously required the creation of a messaging context, but
this isn't done any more, so we don't need the tmp dir to put it in.

Andrew Bartlett
 2011-01-18 10:55:05 +01:00
Andrew Tridgell
87f3151047 s4-dsdb: pass parent request to dsdb_module_*() functions 
this preserves the request hierarchy for dsdb_module_*() calls inside
dsdb ldb modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-01-17 05:23:04 +01:00
Matthias Dieter Wallnöfer
3b78fcff5a s4:torture/nbench/nbench.c - initialise "n" 
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Jan 12 20:38:02 CET 2011 on sn-devel-104
 2011-01-12 20:38:02 +01:00
Matthias Dieter Wallnöfer
a26a48934d torture:drs/rpc/msds_intid.c - proof for the correct "intId" 
"drs_attr" is uninitialised in this loop
 2011-01-12 19:52:19 +01:00
Matthieu Patou
1c6077e71e torture: add ndr tests for backup key protocol 
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 12 10:25:00 CET 2011 on sn-devel-104
 2011-01-12 10:25:00 +01:00
Günther Deschner
0279422c83 s4-smbtorture: check driver_version equality as well. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan  4 11:22:09 CET 2011 on sn-devel-104
 2011-01-04 11:22:08 +01:00
Günther Deschner
64576106b1 s4-smbtorture: always setup full driver level 8 in test_add_driver_arg(). 
Guenther
 2011-01-04 10:33:56 +01:00
Günther Deschner
69174fea5b s4-smbtorture: in test_GetDriverInfo_winreg() always test level 6 for samba3 as 
well.

Guenther
 2011-01-04 10:33:56 +01:00
Günther Deschner
19a295dee8 s4-smbtorture: setup help and dependent files in spoolss driver unc path tests. 
Guenther
 2011-01-04 10:33:55 +01:00
Günther Deschner
8fc28818b9 s4-smbtorture: fix DriverDate and DriverVersion comparison checks against w2k3. 
Guenther
 2011-01-04 10:33:55 +01:00
Günther Deschner
9c46370e91 s4-smbtorture: add more tests for driver_dates. 
Guenther
 2011-01-04 10:33:52 +01:00
Jelmer Vernooij
b5474f2441 remove unnecessary use of pass. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Jan  3 08:21:12 CET 2011 on sn-devel-104
 2011-01-03 08:21:12 +01:00
Jelmer Vernooij
9fc2e6c352 Use TestCase.get_credentials() where possible. 2011-01-03 01:48:05 +01:00
Stefan Metzmacher
01a1a71b55 s4:selftest: specify the gentest_seeds.dat location 
metze
 2010-12-27 15:37:56 +01:00
Matthias Dieter Wallnöfer
78d12e5629 s4:torture/ndr/spoolss.c - add a "ULL" suffix for a 64 bit unsigned integer literal 
To quiet a warning on Solaris

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Dec 23 13:43:57 CET 2010 on sn-devel-104
 2010-12-23 13:43:57 +01:00
Günther Deschner
a204c45e59 s4-smbtorture: always skip addprinter{ex} level 1 tests for now. 
Guenther
 2010-12-22 13:33:18 +01:00
Günther Deschner
9626487a14 s4-smbtorture: fix expected driver date REG_SZ string. 
This resolves the "WARNING!: ../torture/rpc/spoolss.c:4688: str was 01/01/1601,
expected 01/01/1970: "DriverDate" - driver_date mismatch" warnings.

Guenther
 2010-12-22 13:33:17 +01:00
Günther Deschner
3931d4aa65 s4-smbtorture: check the returned driver date is equal to the one we passed in. 
Guenther
 2010-12-22 13:33:17 +01:00
Günther Deschner
340d2df123 s4-smbtorture: interesting, DriverDate and DriverVersion are different in w2k3 and w2k8r2. 
While in w2k8 they are REG_SZ date or numerical strings, they are 8 byte REG_BINARY blobs in w2k3.

Guenther
 2010-12-22 13:33:17 +01:00
Matthias Dieter Wallnöfer
912faf1b08 s4:dsdb/schema/schema_* - adaptions needed for removed "const" on OIDs 2010-12-21 15:10:37 +11:00
Günther Deschner
9dce43a809 s4-smbtorture: run the winreg tests also against an added driver. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Dec 20 14:31:43 CET 2010 on sn-devel-104
 2010-12-20 14:31:43 +01:00
Günther Deschner
4e9d67b7c0 s4-smbtorture: allow to call test_GetDriverInfo_winreg without printer handle. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Dec 17 17:35:21 CET 2010 on sn-devel-104
 2010-12-17 17:35:21 +01:00
Günther Deschner
92f1029e87 s4-smbtorture: check if returned driver paths match requested architecture. 
Guenther
 2010-12-17 16:50:19 +01:00
Günther Deschner
545d3a013c s4-smbtorture: pass down driverosversion to test_DriverInfo_winreg. 
Guenther
 2010-12-17 13:10:08 +01:00
Günther Deschner
4f4ac6462a s4-smbtorture: skip level 8 checks in test_GetDriverInfo_winreg for w2k3. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Dec 17 12:20:38 CET 2010 on sn-devel-104
 2010-12-17 12:20:38 +01:00
Günther Deschner
5083be506e s4-smbtorture: skipping level 8 driveradds against w2k3. 
Guenther
 2010-12-17 11:33:05 +01:00
Kamen Mazdrashki
3bc1cf94e3 s4-test/repl_schema: remove unused and commented out code 
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Dec 15 01:37:10 CET 2010 on sn-devel-104
 2010-12-15 01:37:10 +01:00
Kamen Mazdrashki
9c78bdfd47 s4-test/repl_schema: Make sure every object is with unique name 
This way, test writer don't have to be careful to choose
unique objects suffix
 2010-12-15 00:51:19 +01:00
Kamen Mazdrashki
efcc3c0d79 s4-test/repl_schema: use 'top' as default base class for our test classSchema objects 
Otherwise we will end up passing whole inheritance chain
every time we create some new fancy classSchema object
(as the 'cls-A' and 'cls-B' ones in test_classWithCustomAttribute test)
 2010-12-15 00:51:19 +01:00
Kamen Mazdrashki
1379075762 s4-test/repl_schema: New test to test a classSchema with custom attribute 
Create new Attribute and a Class,
that has value for newly created attribute.

This should check code path that searches for
AttributeID_id in Schema cacheThis test.

It also tests how we replicate a leaf classSchema that
inherits from a new classSchema with attribute added
- tests both dsdb_attribute_drsuapi_to_ldb() and
_dsdb_syntax_OID_obj_drsuapi_to_ldb() syntax handler
 2010-12-15 00:51:19 +01:00
Günther Deschner
0990f6342e s4-smbtorture: paranoia check for architectures in request and reply for enumdrivers test. 
Guenther
 2010-12-14 22:42:17 +01:00
Jelmer Vernooij
13bb9e7046 smbtorture: Default to listing all tests if no prefix was specified. 2010-12-11 18:48:05 +01:00
Jelmer Vernooij
1f5f4e912d smbtorture: Implement --list argument. 2010-12-11 18:48:05 +01:00
Jelmer Vernooij
35fbc7bbda s4-smbtorture: Make test names lowercase and dot-separated. 
This is consistent with the test names used by selftest, should
make the names less confusing and easier to integrate with other tools.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Dec 11 04:16:13 CET 2010 on sn-devel-104
 2010-12-11 04:16:13 +01:00