sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code
99,662 Commits 60 Branches 1,145 Tags 452 MiB
bc71251433
Commit Graph

808 Commits

Author SHA1 Message Date
Volker Lendecke
f6a75cf4d1 registry: Fix CID 240989 Buffer not null terminated 
This makes it clearer that we don't really have a string in .hdr

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
 2015-03-10 21:48:03 +01:00
Volker Lendecke
101b047ab0 registry: Fix CID 241075 Unchecked return value 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
 2015-03-10 21:48:03 +01:00
Volker Lendecke
a99a5a34a5 Fix the developer O3 build 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Feb 25 16:32:29 CET 2015 on sn-devel-104
 2015-02-25 16:32:29 +01:00
Stefan Metzmacher
c066506cb3 s4:lib/registry: remove unused allow_warnings=True 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-11-25 07:25:45 +01:00
Stefan Metzmacher
ea132fd7d1 s4:lib/registry: fix compiler warnings 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-11-25 07:25:45 +01:00
Stefan Metzmacher
dac1590379 s4:lib/registry: avoid some const warnings 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-11-25 07:25:45 +01:00
Andrew Bartlett
b8fc4d4ab5 Use correct size for test string, sizeof() was of the pointer 
Found by AddressSanitizer

Change-Id: Ifc9883d958f253df903775544010c0228a102f0f
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
 2014-09-08 07:26:34 +02:00
Stefan Metzmacher
835f8b7e2e s4:lib/registry: explicitly use allow_warnings=True 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-04-02 09:03:46 +02:00
Günther Deschner
e320d57ed6 docs: remove duplicate arguments listing in regdiff manpage. 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2013-11-19 09:52:39 +01:00
Volker Lendecke
55b0a16e9b registry: Fix Coverity ID 1034918 Wrong sizeof argument 
sizeof(data_val) is the size of the pointer. This might well be 8 bytes
where the string is only 4 bytes long

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
 2013-11-11 21:04:08 +01:00
Volker Lendecke
ba370ae630 registry: Fix Coverity ID 1034917 Wrong sizeof argument 
sizeof(data_val) is the size of the pointer. This might well be 8 bytes
where the string is only 4 bytes long

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
 2013-11-11 21:04:08 +01:00
Volker Lendecke
4e80a30daa registry: Fix Coverity ID 1034916 Wrong sizeof argument 
sizeof(data_val) is the size of the pointer. This might well be 8 bytes
where the string is only 4 bytes long

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
 2013-11-11 21:04:08 +01:00
Volker Lendecke
2055ce1dbe registry4: Fix CID 1034911 Dereference before null check 
curbegin is always != NULL here (curend + 1) and is dereferenced by
strchr.

Signed-off-by: Volker Lendecke <vl@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-08-19 11:15:20 +12:00
Volker Lendecke
f82daa054a registry4: Fix CID 1034911 Dereference before null check 
curbegin is always != NULL here (curend + 1) and is dereferenced by
strchr.

Signed-off-by: Volker Lendecke <vl@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2013-08-19 11:08:15 +12:00
Andreas Schneider
7a50f089e0 s4-libregistry: Improve NULL handling of name. 
Reviewed-by: David Disseldorp <ddiss@samba.org>
 2013-03-05 23:30:11 +01:00
Andreas Schneider
cab969d5ec s4-libregistry: Fix path check and improve while loops. 
Reviewed-by: David Disseldorp <ddiss@samba.org>
 2013-03-05 23:30:03 +01:00
Andreas Schneider
2aca90b9a0 s4-libregistry: Make sure we don't dereference a NULL pointer. 
Reviewed-by: David Disseldorp <ddiss@samba.org>
 2013-03-05 23:30:01 +01:00
Stefan Metzmacher
8ec4d9cb00 s4:pyregistry: make use of samba_tevent_context_init() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
 2013-02-28 12:07:31 +01:00
Andreas Schneider
f4d1e8c1e2 s4-registry: Don't leak file descriptor. 
Reviewed-by: Alexander Bokovoy <ab@samba.org>
 2013-02-22 16:36:14 +01:00
Andreas Schneider
66ee744ccb s4-registry: Don't leak memory on error. 
Reviewed-by: Alexander Bokovoy <ab@samba.org>
 2013-02-22 16:36:14 +01:00
Andreas Schneider
ae6947cc48 s4-regsitry: Check return value of ldb_msg_add_empty(). 
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
 2012-12-21 13:55:59 +01:00
Karolin Seeger
c86707973d docs: man regtree: Add missing meta data. 
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.

Karolin

Reviewed-by: Andreas Schneider <asn@samba.org>
 2012-11-29 13:42:09 +01:00
Karolin Seeger
53b9e4ba6b docs: man regshell: Add missing meta data. 
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.

Karolin

Reviewed-by: Andreas Schneider <asn@samba.org>
 2012-11-29 13:42:05 +01:00
Karolin Seeger
9678fca3c6 docs: man regpatch: Add missing meta data. 
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.

Karolin

Reviewed-by: Andreas Schneider <asn@samba.org>
 2012-11-29 13:42:00 +01:00
Karolin Seeger
1ad091296d docs: man regdiff: Add missing meta data. 
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.

Karolin

Reviewed-by: Andreas Schneider <asn@samba.org>
 2012-11-29 13:41:57 +01:00
Stefan Metzmacher
a370792cbc s4:libcli/pyerrors: s/PyErr_WERROR_IS_ERR_RAISE/PyErr_WERROR_NOT_OK_RAISE/ 
metze
 2012-08-06 15:50:16 +02:00
Michael Adam
bf650a1b59 s4:registry:regdiff: use existing talloc context for the event context 
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Jul 13 02:51:44 CEST 2012 on sn-devel-104
 2012-07-13 02:51:44 +02:00
Michael Adam
342ab97506 s4:registry:regdiff: add TALLOC_CTX * argument to open_backend() 2012-07-13 00:57:20 +02:00
Michael Adam
6ee16cefc9 s4:registry: add a TALLOC_CTX argument to reg_open_remote() 2012-07-13 00:57:19 +02:00
Michael Adam
acd3a6bb6c s4:registry:testsuite: fix use of non-existent word (existant) 2012-06-12 07:21:44 +02:00
Jelmer Vernooij
24ed8c5924 regshell: Fix a counter that can actually be non-zero. 
This was a regression caused by one of the unsigned patches.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Feb  8 16:00:22 CET 2012 on sn-devel-104
 2012-02-08 16:00:22 +01:00
David Disseldorp
ec094bf9ac WERROR type variable being incorrectly checked with a NT_STATUS_IS_X 
type macro.
 2012-01-23 12:18:01 -08:00
Jelmer Vernooij
a108eb4fdb pyregistry: Remove directory support. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Dec 29 19:59:57 CET 2011 on sn-devel-104
 2011-12-29 19:59:57 +01:00
Jelmer Vernooij
af1b7f5575 Remove the 'dir' registry backend. 
This backend was incomplete, and we already have plenty of other backends.
 2011-12-29 16:45:23 +01:00
Matthias Dieter Wallnöfer
1dbffa70ae s4:lib/registry - enhance registry tests in respect to default values 
Reviewed-by: Jelmer

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov  3 21:41:17 CET 2011 on sn-devel-104
 2011-11-03 21:41:17 +01:00
Matthias Dieter Wallnöfer
7e0bef604a s4:lib/registry/ldb.c - quit the deletion of a not-existing default value with WERR_BADFILE 
Reviewed-by: Jelmer
 2011-11-03 20:10:06 +01:00
Matthias Dieter Wallnöfer
6b5a296b4a s4:lib/registry/ldb.c - don't use search filters for base searches 
They are not necessary in this case.

Reviewed-by: Jelmer
 2011-11-03 20:10:06 +01:00
Matthias Dieter Wallnöfer
042372bc20 s4:lib/registry/regf.c - always generate debug messages on error cases 
We need to know what is going on.

Reviewed-by: Jelmer
 2011-11-03 20:10:06 +01:00
Jelmer Vernooij
88ecf1a9b8 Use public pytalloc header file. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Aug 14 17:18:46 CEST 2011 on sn-devel-104
 2011-08-14 17:18:46 +02:00
Jelmer Vernooij
f8ec7f6cb1 pytalloc: Use consistent prefix for functions, add ABI file. 2011-08-10 15:36:21 +02:00
Stefan Metzmacher
3b11ee1db1 s4:pyregistry: PyArg_ParseTuple("z#") requires an 'int' argument instead of 'size_t' 
If we pass variables by reference we don't get implicit type casting.

metze
 2011-08-08 16:45:27 +02:00
Andrew Bartlett
907cdb5de7 s4-modules Remove lp_ctx from init functions that no longer need it 
Now that we don't allow the smb.conf to change the modules dir, many
functions that simply load modules or initialise a subsytem that may
load modules no longer need an lp_ctx.

Andrew Bartlett
 2011-06-06 17:37:51 +10:00
Andrew Bartlett
30979f3ea1 build: Expand dcerpc-samba grouping library 
This is possible in common now because the generated RPC code does not
rely on a particular dcerpc layer.

Andrew Bartlett
 2011-05-18 16:12:07 +02:00
Matthias Dieter Wallnöfer
dcdfc27dbf s4:lib/registry/registry.h - align a copyright line in header comment 2011-03-30 08:46:04 +02:00
Jeremy Allison
0c5214e2eb Ensure convert_string_XXX is always called with a valid converted_size pointer. 
Preparation for cleaning up this API.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 29 21:01:49 CEST 2011 on sn-devel-104
 2011-03-29 21:01:49 +02:00
Andrew Tridgell
15e84a9a09 charcnv: removed the allow_badcharcnv and allow_bad_conv options to convert_string*() 
we shouldn't accept bad multi-byte strings, it just hides problems

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
 2011-03-24 01:47:26 +01:00
Jelmer Vernooij
01b0f45d52 lib/registry/tests: Fix prototypes. 2011-03-19 15:33:29 +01:00
Jelmer Vernooij
bd0eced7d5 source4/lib: Fix prototypes for all functions. 2011-03-19 03:20:05 +01:00
Andrew Tridgell
11a97d60d9 build: moved util_reg.c into a common subsystem 
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb 24 05:53:52 CET 2011 on sn-devel-104
 2011-02-24 05:53:52 +01:00
Andrew Tridgell
8dc92c8f71 ldb: use #include <ldb.h> for ldb 
thi ensures we are using the header corresponding to the version of
ldb we're linking against. Otherwise we could use the system ldb for
link and the in-tree one for include

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-10 06:51:07 +01:00