1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Commit Graph

24690 Commits

Author SHA1 Message Date
Volker Lendecke
be5dc4f3c8 Remove current_user references from nttrans.c
(This used to be commit 5f8a5e68ea)
2008-06-19 18:51:38 +02:00
Volker Lendecke
52664f62ba Remove current_user references from trans2.c
This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function.
(This used to be commit 5595cdf837)
2008-06-19 18:51:38 +02:00
Volker Lendecke
e901466061 Remove some current_user references from trans2.c
(This used to be commit 4c31cc0b62)
2008-06-19 18:51:38 +02:00
Volker Lendecke
f1cd0bdbcc Remove reference to current_user from reply.c
(This used to be commit e895e44cc7)
2008-06-19 18:51:38 +02:00
Volker Lendecke
40f5eab5eb Wrap the unix token info in a unix_user_token in auth_serversupplied_info
No functional change, this is a preparation for more current_user ref removal
(This used to be commit dcaedf345e)
2008-06-19 18:51:37 +02:00
Volker Lendecke
e40b6e296a Remove the "current_user" arg from fsp_belongs_conn
fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.
(This used to be commit 64e9372ab9)
2008-06-19 18:51:37 +02:00
Volker Lendecke
49ca8efa91 Remove the "current_user" arg from check_fsp
check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.
(This used to be commit 8d364c4c33)
2008-06-19 18:51:37 +02:00
Michael Adam
769646efc6 loadparm: use the return value of the special handlers in lp_load().
Up to now, the bool return value was silently ignored.

Michael
(This used to be commit c65d425fec)
2008-06-19 17:22:27 +02:00
Michael Adam
09d769057e loadparm: don't treat a missing include file as an error in handle_include().
Michael
(This used to be commit a8ef8870be)
2008-06-19 17:22:27 +02:00
Michael Adam
0f32b22031 testsuite: enable the testparm_s3 tests.
Michael
(This used to be commit 0f5c13e573)
2008-06-19 17:22:27 +02:00
Michael Adam
24de341973 testsuite: add a testparm_s3 test script.
This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
(This used to be commit eb28146d40)
2008-06-19 17:22:27 +02:00
Michael Adam
b0c3f1459d testsuite: update introductory comment to test_net_regsistry.sh
This is now used to test rpc and local access depending on
command line parameters.

Michael
(This used to be commit 73c17b6303)
2008-06-19 17:22:27 +02:00
Volker Lendecke
39479c9ee6 Remove current_user_info reference from vfs_recycle.c
(This used to be commit fdc03c0a5b)
2008-06-19 15:53:43 +02:00
Volker Lendecke
3283a5d0de Remove current_user_info reference from vfs_fake_perms.c
(This used to be commit a227181e8d)
2008-06-19 15:53:43 +02:00
Volker Lendecke
ff215c4f81 Remove current_user_info reference from vfs_expand_msdfs.c
(This used to be commit 05a66980a9)
2008-06-19 15:53:43 +02:00
Volker Lendecke
17885401b8 current_user is not used in vfs_aixacl2.c
(This used to be commit 407136abdf)
2008-06-19 15:53:43 +02:00
Volker Lendecke
156cd09899 RWX on a file does not imply DELETE access
Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.
(This used to be commit 51b5364c2a)
2008-06-19 15:27:41 +02:00
Volker Lendecke
066f6c856f Fix checks in can_delete_file_in_directory()
With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.
(This used to be commit daa9b05664)
2008-06-19 15:27:41 +02:00
Volker Lendecke
7df309c339 Remove some code
Did not measure it, but I think a single write is better than a read and a
conditional branch
(This used to be commit abe1bed665)
2008-06-19 12:03:31 +02:00
Volker Lendecke
809b992b17 Fix typo
(This used to be commit 2eef2c682c)
2008-06-19 12:02:12 +02:00
Volker Lendecke
bdc9391021 Fix the build on FreeBSD 4.6.2
(This used to be commit 4f50cb63e9)
2008-06-19 12:02:12 +02:00
Jeremy Allison
33aa758bf3 Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.
(This used to be commit 8b26afdcdd)
2008-06-18 12:56:36 -07:00
Derrell Lipman
6398f945e8 Remove prototype of unimplemented smbc_chown() function.
(This used to be commit 0e84e3bb80)
2008-06-18 11:00:46 -04:00
Volker Lendecke
2b7fca9e79 Revert "Fix a memleak in svcctl_init_keys()"
This reverts commit b1afb31f3c.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981)
(This used to be commit b1e8e5d173)
2008-06-18 16:31:35 +02:00
Michael Adam
1917b38873 Fix Bug #5548 (segfauls in handle_include with %m macro expansion).
In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
(This used to be commit c65b456c6a)
2008-06-18 14:50:53 +02:00
Michael Adam
aedce263a8 file_access: add a function header comment for can_access_file_acl().
Michael
(This used to be commit 7d5fb873bd)
2008-06-18 00:06:46 +02:00
Michael Adam
24e7f40687 smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()
This is not needed anymore since user_can_access_file_acl() ist used.

Michael
(This used to be commit 3c349f773a)
2008-06-18 00:02:28 +02:00
Michael Adam
b172eb1d47 file_access: remove unneeded stat buf parameter from can_access_file_acl().
This is a security descriptor level function only.

Michael
(This used to be commit 5931540fa1)
2008-06-17 23:58:49 +02:00
Michael Adam
92c983292e net sam: fix typo in comment
Michael
(This used to be commit b9f6904044)
2008-06-17 23:57:26 +02:00
Michael Adam
00168e4d5a net sam: fix typo in debug message.
Michael
(This used to be commit 6d7f64c348)
2008-06-17 23:56:42 +02:00
Michael Adam
ba3eee6cf8 testsuite: give admin rights to testuser only for the "net rpc registry" test.
Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
(This used to be commit 1734f9305a)
2008-06-17 23:54:15 +02:00
Michael Adam
aeec9c7f55 testsuite: don't give the testuser administrative rights globally.
It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
(This used to be commit 9fe99c69f3)
2008-06-17 23:51:23 +02:00
Volker Lendecke
c8dfed63a6 Fix a brown paper bag segfault in clitar
Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa39)
(This used to be commit b8e1d62b8e)
2008-06-17 21:14:47 +02:00
Günther Deschner
8fd045f918 rpcclient: add more generic internal dscracknames call.
Guenther
(This used to be commit 2351b0845c)
2008-06-17 20:01:51 +02:00
Günther Deschner
44e153e3c1 netapi: use NetUserEnum filter in example code.
Guenther
(This used to be commit ad10517768)
2008-06-17 20:00:11 +02:00
Günther Deschner
b330ea29c7 netapi: add NetUserEnum filter constants to public headers.
Guenther
(This used to be commit 32a66131eb)
2008-06-17 20:00:00 +02:00
Günther Deschner
d0b7bccf6d netapi: implement NetUserEnum filters.
Guenther
(This used to be commit 0bd69df770)
2008-06-17 19:59:50 +02:00
Günther Deschner
68064b8101 re-run make idl.
Guenther
(This used to be commit 383636aaca)
2008-06-17 19:59:38 +02:00
Günther Deschner
a040b8be7d netapi: add NetUserEnum filter constants to IDL.
Guenther
(This used to be commit 12669b12c2)
2008-06-17 19:59:22 +02:00
Günther Deschner
08cf0bb878 netapi: some IDL cosmetics.
Guenther
(This used to be commit 4fd6bc61d0)
2008-06-17 19:58:39 +02:00
Günther Deschner
ffba83d22d netapi: add NetRemoteTOD example code.
Guenther
(This used to be commit 2b82779a40)
2008-06-17 19:58:11 +02:00
Günther Deschner
a2290e5e00 netapi: implement NetRemoteTOD().
Guenther
(This used to be commit 76877680a8)
2008-06-17 19:58:01 +02:00
Günther Deschner
feca006232 netapi: make NetRemoteTOD() headers public.
Guenther
(This used to be commit 1262ab1843)
2008-06-17 19:57:06 +02:00
Günther Deschner
ebbeddfdcd netapi: add NetRemoteTOD() skeleton.
Guenther
(This used to be commit 78bc98cb55)
2008-06-17 19:56:44 +02:00
Günther Deschner
de7de69530 re-run make idl.
Guenther
(This used to be commit 782ab0f1c1)
2008-06-17 19:56:27 +02:00
Günther Deschner
db1db7da92 netapi: add NetRemoteTOD() to IDL.
Guenther
(This used to be commit 8dd1a5fabf)
2008-06-17 19:56:16 +02:00
Günther Deschner
fefcb70f87 net_vampire: add error and result_message to samsync_context.
Guenther
(This used to be commit e0b1172004)
2008-06-17 19:55:16 +02:00
Günther Deschner
49b269f50f net_vampire: add domain_name to samsync_context.
Guenther
(This used to be commit 7e7f07ec59)
2008-06-17 19:55:10 +02:00
Günther Deschner
0447e6a0a7 libads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.
Guenther
(This used to be commit cb7ace209c)
2008-06-17 19:54:09 +02:00
Günther Deschner
fd288b4110 clikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.
Guenther
(This used to be commit ec86852fc6)
2008-06-17 19:51:52 +02:00