1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
Commit Graph

1034 Commits

Author SHA1 Message Date
Stefan Metzmacher
f5b0bbf108 s3:client: avoid cli_errstr() where we already have an NTSTATUS
metze
2011-07-08 14:09:07 +02:00
Stefan Metzmacher
5cc279eb34 s3:clitar: avoid usage of cli_errstr()
metze
2011-07-08 14:09:07 +02:00
Björn Baumbach
80c65416c1 s3-client: Remove use of cli_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-07 19:16:28 +02:00
Stefan Metzmacher
2b0cc3c412 s3:libsmb: use clistr_pull_talloc() in cli_get_fs_volume_info()
metze
2011-07-06 17:18:13 +02:00
Volker Lendecke
7d96a4594b s3: Remove cli_errstr from cmd_posix_open
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 09:45:11 CEST 2011 on sn-devel-104
2011-07-06 09:45:11 +02:00
Volker Lendecke
c33a5a659c s3: Fix error logic in posix_open 2011-07-06 08:35:27 +02:00
Volker Lendecke
c1fdec7efc s3: Remove a few uses of cli_errstr 2011-07-06 08:35:27 +02:00
Volker Lendecke
26782fbbf3 s3: make cli_resolve_path return NTSTATUS
This looks larger than it is. No parameters needed changing.
2011-07-06 08:35:27 +02:00
Volker Lendecke
80838491e6 s3: Make cli_cm_open return NTSTATUS
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jul  3 23:57:53 CEST 2011 on sn-devel-104
2011-07-03 23:57:53 +02:00
Volker Lendecke
e2498b1110 s3: Read symlink information in smbclient "allinfo" 2011-07-03 11:31:29 +02:00
Volker Lendecke
c8d374a0f2 s3: Fix an error message in smbclient symlink 2011-06-24 21:24:17 +02:00
Volker Lendecke
daec41c846 s3: Use reparse point style symlinks 2011-06-24 21:24:17 +02:00
Volker Lendecke
d637cd2380 s3: Remove a call to cli_errstr 2011-06-24 21:24:17 +02:00
Andrew Bartlett
74eed8f3ed s3-param Remove special case for global_myname(), rename to lp_netbios_name()
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
3ccc760947 s3-param Remove special case for lp_workgroup()
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
5e26e94092 s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653 s3-talloc Change TALLOC_ARRAY() to talloc_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Jeremy Allison
1cee71713f Change sys_getcd() to take no arguments and always return malloc'ed memory (or NULL).
Part of the efforts to remove PATH_MAX on modern systems.
2011-06-01 02:54:51 +02:00
Volker Lendecke
edfa62f2a0 s3: Use cli_connect_nb in do_message_op
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 10:11:54 CEST 2011 on sn-devel-104
2011-05-29 10:11:54 +02:00
Björn Baumbach
26f7c0771b s3-client/clitar.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:55:15 +02:00
Günther Deschner
675573d54b s3-includes: finally only include client.h when libsmb is used.
Guenther
2011-05-06 16:37:22 +02:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h
Guenther
2011-05-06 16:37:18 +02:00
Jeremy Allison
9eee6e2fd2 More const fixes... getting near the end now.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 00:57:00 CEST 2011 on sn-devel-104
2011-05-06 00:57:00 +02:00
Jeremy Allison
f85e095dd2 More simple const fixups. 2011-05-05 23:56:08 +02:00
Jeremy Allison
8380835fc6 Fix warning messages caused by addition of null check in fstrcpy macro. 2011-05-04 12:12:15 -07:00
Jeremy Allison
df023b8657 Tidy up some missing checks for NULL in strlcpy. 2011-05-04 12:12:15 -07:00
Jeremy Allison
6f7c4a0539 Convert safe_strXX to strlXXX. Clean up off-by-ones. 2011-05-04 12:12:15 -07:00
Jeremy Allison
0c464df22b Change safe_strcpy_base to strlcpy_base. Note the size doesn't change here as the original macro auto-added the -1. 2011-05-04 12:12:14 -07:00
Andrew Bartlett
724915f721 s3-client Add TALLOC_CTX argument to attrib_string().
This ensures the caller knows where the memory was allocated.

Andrew Bartlett
2011-04-29 16:38:14 +10:00
Andrew Bartlett
0520da2bbe s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH
This means we use just one constant for this file attribute.

Andrew Bartlett
2011-04-29 16:38:13 +10:00
Andrew Bartlett
0eca33bbf6 s3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR
This means we use just one constant for this file attribute.

Andrew Bartlett
2011-04-29 16:38:13 +10:00
Andrew Bartlett
0a3c84b554 s3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM
This means we use just one constant for this file attribute.

Andrew Bartlett
2011-04-29 16:38:13 +10:00
Andrew Bartlett
317e19aeb3 s3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN
This means we use just one constant for this file attribute.

Andrew Bartlett
2011-04-29 16:38:12 +10:00
Andrew Bartlett
7f66ebde2e s3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY
This means we use just one constant for this file attribute.

Andrew Bartlett
2011-04-29 16:38:12 +10:00
Volker Lendecke
0226428eb9 s3: Use cli_writeall instead of cli_write
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-26 12:22:55 -07:00
Volker Lendecke
25b43d317f s3: Use cli_ntcreate to when listing snapshots
This works for directories as well

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 14:37:02 CEST 2011 on sn-devel-104
2011-03-30 14:37:02 +02:00
Günther Deschner
2473c2fb1b s3-libsmb: put namequery headers to nmblib.h
We might find a better name for it and merge other namequery related things as
well here...

Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
0e771263ee s3-includes: only include system/filesys.h when needed.
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
49fcf653b1 s3-includes: only include system/passwd.h when needed.
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
99f4a64543 s3-trans2: only include trans2.h where needed.
Guenther
2011-03-30 01:13:06 +02:00
Volker Lendecke
7c868e6174 s3: Fix Coverity ID 83: RESOURCE_LEAK 2011-03-27 22:22:10 +02:00
Volker Lendecke
b47b4c9e3d s3: Remove two calls to cli_errstr
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 13:17:47 CEST 2011 on sn-devel-104
2011-03-27 13:17:47 +02:00
Günther Deschner
7a91282c9f s3-libsmb: only include rap client when needed.
Guenther
2011-03-15 21:16:35 +01:00
Volker Lendecke
dee53e04ba s3: Print all flags in "smbclient allinfo" 2011-03-02 18:39:21 +01:00
Andreas Schneider
bf18403c81 s3-rpc_client: Move client pipe functions to own header. 2011-02-28 18:15:04 +01:00
Volker Lendecke
5b26cfe143 s3: Eliminate sys_select from do_smb_resolve() -- untested 2011-02-28 16:40:20 +01:00
Volker Lendecke
b28a2e519a s3: Eliminate sys_select from do_smb_browse() -- untested 2011-02-28 16:40:19 +01:00
Volker Lendecke
e6f8208358 s3: Eliminiate sys_select_intr from client.c 2011-02-28 16:40:19 +01:00
Björn Baumbach
07ccc2905d s3-smbclient: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 25 11:41:53 CET 2011 on sn-devel-104
2011-01-25 11:41:53 +01:00
Björn Baumbach
09c612f377 s3-smbclient: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-01-25 10:45:22 +01:00
Volker Lendecke
d3abc90401 s3: Avoid a few calls to cli_errstr
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 08:47:25 CET 2011 on sn-devel-104
2011-01-17 08:47:25 +01:00
Günther Deschner
fccfd29283 s3-smbclient: prefer dcerpc_srvsvc_X functions.
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-13 14:11:29 +01:00
Volker Lendecke
28d997a890 s3: AllowDebugChange is gone 2010-12-28 17:18:14 +01:00
Volker Lendecke
bfc4fe4012 s3: Remove unused "retry" from cli_start_connection
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Dec 20 17:58:33 CET 2010 on sn-devel-104
2010-12-20 17:58:33 +01:00
Volker Lendecke
e0e4dc1c22 s3: Add shadow copy info to smbclient allinfo
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Nov 30 12:23:50 CET 2010 on sn-devel-104
2010-11-30 12:23:50 +01:00
Volker Lendecke
ddd33f0351 s3: Make cli_set_ea_path return NTSTATUS 2010-11-11 16:16:24 +00:00
Andrew Bartlett
ed111d11eb s3-debug Move 'load_case_tables()' before lp_set_cmdline() and popt calls
The problem here is that we cannot run lp_set_cmdline() (directly or
indirectly via the popt helpers) until load_case_tables() has been run.

However, load_case_tables does not have auto-initialisation, so we
must init it once, and once only.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
cf4de8ec2c s3-debug Remove 'AllowDebugChange' and use lp_set_cmdline() instead
By removing this global variable, the API between the two different
debug systems is made more similar.  Both s3 and s4 now have
lp_set_cmdline() which ensures that the smb.conf cannot overwrite
these the user-specified log level.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Andrew Bartlett
9da4ace1d9 s3-debug Impove setup_logging() to specify logging to stderr
This change improves the setup_logging() API so that callers which
wish to set up logging to stderr can simply ask for it, rather than
directly modify the dbf global variable.

Andrew Bartlett
2010-11-02 04:36:04 +00:00
Jeremy Allison
14ff2e8de9 Fix bug #7700 - Improvement of return code of smbclient
Based on an initial patch from H Hasegawa <hasegawa.hiroyuki@fujixerox.co.jp>.
Convert cli_list and associated functions to take calls that return NTSTATUS.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 29 19:40:16 UTC 2010 on sn-devel-104
2010-10-29 19:40:16 +00:00
Volker Lendecke
40cc1a3d2e s3: Add "setea" to smbclient 2010-10-24 20:46:28 +00:00
Volker Lendecke
86cb0ad242 s3: Add "geteas" to smbclient 2010-10-24 20:46:28 +00:00
Volker Lendecke
c095809c04 s3: Convert cli_qfileinfo_basic to cli_qfileinfo 2010-10-24 11:39:30 +02:00
Volker Lendecke
03333fc68c s3: Rename cli_fileinfo() to cli_fileinfo_basic() 2010-10-24 11:39:29 +02:00
Andrew Bartlett
f768b32e37 libcli/security Provide a common, top level libcli/security/security.h
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.

This includes (along with other security headers) dom_sid.h and
security_token.h

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-12 05:54:10 +00:00
Günther Deschner
0ff7e0c998 samba: share readline wrappers among all buildsystems.
Guenther
2010-10-01 22:30:22 +02:00
Günther Deschner
405b7d843f s3-readline: move cmd_history to smbclient, the only user.
Guenther
2010-10-01 22:30:22 +02:00
Günther Deschner
b38d0542e1 samba: share select wrappers.
Guenther
2010-10-01 22:30:22 +02:00
Björn Jacke
10eefd85c9 s3: fix order of arguments in nsec_time_diff call 2010-09-17 13:49:11 +02:00
Björn Jacke
aada719694 s3: use nsec_time_diff instead of TspecDiff 2010-09-16 21:38:20 +02:00
Björn Jacke
5728b0fb5f s3: use monotonic clock for time deltas in smbtar 2010-08-31 10:26:09 +02:00
Björn Jacke
fc67675028 s3: use monotonic clock for time deltas in smbclient 2010-08-31 10:26:04 +02:00
Jeremy Allison
af081ec4a1 Fix bug 7627 - smbclient ignores "-I" when used with "-L", fails name resolution.
Still needs some more work to fix missing netbios name issues, but fixes
underlying issue of IP address being ignored.

Jeremy.
2010-08-20 15:57:08 -07:00
Jeremy Allison
34230608df Fix bug 7563 - Creation of symlink using smbclient is buggy.
Fix semantics of symlink. "oldpath" should be an untouched blob,
"newpath" should fit the share path semantics.

Jeremy.
2010-08-18 15:51:43 -07:00
Volker Lendecke
734f581906 s3: Replace some cli_errstr calls by nt_errstr 2010-08-13 16:03:04 +02:00
Andreas Schneider
ce2a086119 s3-popt: Only include popt-common.h when needed. 2010-08-05 12:08:31 +02:00
Volker Lendecke
867626abca s3: Convert cli_list() to return NTSTATUS
If needed, the callback functions can count themselves
2010-08-04 20:32:50 +02:00
Volker Lendecke
fcdda8f443 s3: Remove "cli" from "struct finfo" 2010-07-30 17:01:33 +02:00
Volker Lendecke
dace013898 s3: Remove a typedef (struct file_info) 2010-07-27 21:05:35 +02:00
Volker Lendecke
2ad4b4f63e s3: Convert cli_qpathinfo_streams to cli_qpathinfo_send 2010-07-26 23:01:38 +02:00
Volker Lendecke
f62bde93ce s3: Convert cli_qpathinfo2 to cli_qpathinfo_send 2010-07-26 23:01:37 +02:00
Volker Lendecke
9a2d08bd3c s3: Use error status instead of cli_errstr 2010-07-26 23:01:37 +02:00
Jeremy Allison
8ce15b3a71 Fix bug - 7551 smbclient does not return proper exit code.
Catch error in cli_push.

Jeremy.
2010-07-15 16:06:11 -07:00
Andreas Schneider
ee01fe8c5b s3-client: Make sure we only write to an opened file.
Found by clang-analyzer.
2010-06-29 11:12:12 +02:00
Günther Deschner
7f6bb48bdf s3-secdesc: remove "typedef struct security_descriptor SEC_DESC".
Guenther
2010-05-18 12:30:12 +02:00
Jeremy Allison
f3b8e31f83 Split out the client unix capabilities to those the server offered, and those the client asked for.
This fixes a bug when using encrypted transport and DFS links. Found
by my basic DFS torture test, which I'll check in next. Testing *rocks* :-).

Jeremy.
2010-04-13 18:41:14 -07:00
Jeremy Allison
f1fe808978 Add an "attributes" string to allinfo.
Jeremy.
2010-02-22 14:36:40 -08:00
Volker Lendecke
2beaa19029 s3: Slightly simplify the logic of completion_remote_filter 2010-02-20 18:59:30 +01:00
Volker Lendecke
1f451d122e s3: Remove a "typedef struct" 2010-02-20 18:59:30 +01:00
Volker Lendecke
f27857e655 s3: Fix a typo 2010-02-20 18:59:30 +01:00
Volker Lendecke
8930a9c520 s3: Convert cli_qpathinfo_basic to use cli_trans() 2010-02-20 18:59:30 +01:00
Volker Lendecke
6e510b49c0 s3: Make cli_get_fs_volume_info() use cli_trans() 2010-02-07 12:29:25 +01:00
Volker Lendecke
24d4433bd7 s3: Move "yesno" to the only place where it is used: client.c 2010-01-21 12:58:11 +01:00
Volker Lendecke
33601b8632 s3: Pass fake_dir_create_times down to file_exist_stat, none of the callers look at the mtime 2009-11-29 11:22:04 +01:00
Volker Lendecke
5ba42b0a5b s3: "tar_parseargs" only looks at the mtime 2009-11-29 11:22:02 +01:00
Volker Lendecke
e1f53e5d49 s3: "dotareof" only looks at the file type 2009-11-29 11:22:02 +01:00
Volker Lendecke
932ab0c299 s3: client "newer" does not look at the create timestamp 2009-11-29 11:22:02 +01:00
Volker Lendecke
44ce5603dd s3: Pass the "fake dir create times" parameter to sys_*stat
Step 0 to restore it as a per-share paramter
2009-11-29 11:22:01 +01:00
Günther Deschner
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
Guenther
2009-11-26 20:03:17 +01:00
Volker Lendecke
a1a81ef785 Revert "s3: Make the implicit reference to Protocol in mask_match() explicit"
This reverts commit e23d8a3d1f.
2009-11-23 16:35:00 +01:00