1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-19 10:03:58 +03:00

2410 Commits

Author SHA1 Message Date
Andrew Tridgell
c3a798cb7a r3954: bring Samba3 into line with the Samba4 password change code
(This used to be commit 04a6573f894800b9d939d9b4be48790437352804)
2007-10-10 10:53:26 -05:00
Jeremy Allison
f3cb4f31a2 r3951: Fix for bugid #2081 reported by John Janosik <jpjanosi@us.ibm.com> - ensure
SE_DESC_DACL_PROTECTED is set if "map acl inherit = no".
Jeremy.
(This used to be commit 934c41b474c8959310389378bfa7d3332bd5ec79)
2007-10-10 10:53:26 -05:00
Jeremy Allison
482f14871d r3946: Fix for bugid #2085 reported by Jason Mader <jason@ncac.gwu.edu>. Use consistent
enum type for Protocol extern.
Jeremy.
(This used to be commit 65dfae7ea45d4c9452b2a08efa09b01d870142f3)
2007-10-10 10:53:26 -05:00
Jeremy Allison
314ec086f3 r3944: Fix the problem we get on Linux where sendfile fails, but we've already sent the
header using send(). As our implementation of sendfile can't return EINTR (it
restarts in that case) use an errno of EINTR to signal the linux sendfile fail
after header case. When that happens send the rest of the data and then turn
off sendfile. Sendfile should be safe to enable on all systems now (even though
it may not help in all performance cases).
Jeremy.
(This used to be commit 78236382f7ffe08d7924907be49493779521837f)
2007-10-10 10:53:26 -05:00
Jeremy Allison
97bb32d61f r3936: Ensure LARGE_READX response must fit within reply buffer.
Jeremy.
(This used to be commit 5541001cf98aa9afb8f98ebeb91561348d3f5d74)
2007-10-10 10:53:25 -05:00
Jeremy Allison
44b5067e32 r3934: Correctly check for the top length bit in LARGE_READX.
Jeremy.
(This used to be commit f9effa2af90245c0fe090d730c86a2a60d8570dc)
2007-10-10 10:53:25 -05:00
Jeremy Allison
9038a56f82 r3895: Fix for bug #2045. May also fix other timestamp bugs with Excel
(Volker please test). Setting a last write timestamp from Windows
overrides any subsequent write timestamp changes and must be immediately
seen by and findfirst/findnexts. This is a racy solution, but should
work most of the time. This may also fix #1061, not sure.
Jeremy.
(This used to be commit 47bab92c0b062f3fefbb4fd4a09852e1c829a7f9)
2007-10-10 10:53:24 -05:00
Jeremy Allison
5a83636948 r3889: Only set mtime from pending_modtime if it's not already zero...
Jeremy.
(This used to be commit 984c3506351ba97f74813d678424858508c4197a)
2007-10-10 10:53:23 -05:00
Jeremy Allison
a68172ce7c r3877: Final (I hope :-) fix for #2050 from Lars Müller for select maxfd's.
Jeremy.
(This used to be commit 65fc39fc388244923d1e36076b5a4116aa434be5)
2007-10-10 10:53:23 -05:00
Jeremy Allison
2f167e909e r3859: Ensure if num_acls is set to 0xFFFF this field is ignored.
Use def_acl everywhere instead of dir_acl.
Jeremy.
(This used to be commit d28611c960f87830aa8449725951984aa155b089)
2007-10-10 10:53:21 -05:00
Volker Lendecke
ea9f97886b r3853: Fix an uninitialized variable warning. Jeremy, there are some of these in
charcnv.c.

Volker
(This used to be commit 650d52648dbf67f71d7619ffb8bf32d93a15ae9c)
2007-10-10 10:53:21 -05:00
Volker Lendecke
54024f5826 r3848: Fix for bug 2057. Only partially applied the patch, the second part seems not
necessary.

I'm using gcc 3.4.1, this does not detect the possibly uninitialized
variable. Does anybody know how to get 3.4.1 to warn me?

Volker
(This used to be commit 8b6f8f93a0f30be0184e6044a499c1ef8f7b247e)
2007-10-10 10:53:20 -05:00
Volker Lendecke
0c639097cf r3824: Fix crash in api_RNetShareEnum. ServicePtrs[] may contain invalid
entries. Happened after rev3708 removed non-existing cups printers.

Volker
(This used to be commit 60998d9d2f6272e383304da2b1d568a4b65f8787)
2007-10-10 10:53:19 -05:00
Jeremy Allison
00f6baa15a r3823: Fix bug reported by Tom Dickson <tdickson@inostor.com> with
follow symlinks = no reporting an incorrect error when it should
be access denied.
Jeremy.
(This used to be commit 5a103f4abff0503740822c8ed75d9102ee51e8f0)
2007-10-10 10:53:19 -05:00
Jeremy Allison
d12a7fdee2 r3817: Fix from Lars Müller <lmuelle@suse.de> for bug #2050, calculate
max_fd for select correctly.
Jeremy.
(This used to be commit eb0b1f757d814e01980cd9c5fc4918791ce1e54d)
2007-10-10 10:53:19 -05:00
Jeremy Allison
7eaba1f528 r3816: Added fn to remove an ACL from a file. Now need client code to test this.
How do the share mask/modes fit into this code... Need to think about this.
Jeremy.
(This used to be commit 1aa1c2f489f5b92c3696e7b9123061d91babc34e)
2007-10-10 10:53:19 -05:00
Jeremy Allison
672b22ae43 r3814: At least use a proper constant name (aRONLY :-) not a number.
That way we can at least remember why we did this :-).
Jeremy.
(This used to be commit d84f5f8cc10f89d5fbd6cfb694bccfbd1c3d8a3f)
2007-10-10 10:53:18 -05:00
Volker Lendecke
99dd85abe9 r3811: Believe it or not, but this patch seems to be necessary. If someone sets a
folder icon in the start menu and saves the profile on a samba server, after
logging in again this setting is gone. Why is this? The folder for which the
icon is set must have the read only flag set. If it is not set, the
desktop.ini file (the file containing the icon reference) inside that folder
is ignored.

lp_profile_acls is a hack for such a situation, so overload this parameter
with another profile-related hack.

Volker
(This used to be commit b8d888000eb7456c7620e9a783d6f1b3ba4c8985)
2007-10-10 10:53:18 -05:00
Jeremy Allison
6192b3121f r3794: Added set posix acl functionality into the UNIX extensions code.
One part missing - delete file acl (to be added asap). No client
code yet, also needs testing with valgrind.
Jeremy.
(This used to be commit 6101ec2247c182fde6ea3e7e1f64a92b353ec4e8)
2007-10-10 10:53:17 -05:00
Jeremy Allison
1b31f46f22 r3714: Getfacl now seems to work on files and directories. Next do setfacl
and port to Samba4.
Jeremy.
(This used to be commit 4d52bf7c8b3147dd4f0d3081fbf9a1f5ebd246a1)
2007-10-10 10:53:16 -05:00
Jeremy Allison
f995b164b9 r3713: Implementation of get posix acls in UNIX extensions. Passes valgrind.
Need to add printout functions in client and set posix acl in server.
SteveF - take a look at this for the cifsfs client !
Once this is working and tested the next step is to write this up for
the UNIX extensions spec. documents.
Jeremy.
(This used to be commit 1bd3f133442a472b4718b94a636f2fec89a2e0dc)
2007-10-10 10:53:16 -05:00
Gerald Carter
e51451d4ba r3708: BUG 1838: patch from Gavrie Philipson <gavrie@disksites.com> to remove stale printers when reloading after a sighup
(This used to be commit bcb9105c5488a97944d2dfee8681d662e9c9b818)
2007-10-10 10:53:15 -05:00
Volker Lendecke
f9e87b9ba6 r3705: Nobody has commented, so I'll take this as an ack...
abartlet, I'd like to ask you to take a severe look at this!

We have solved the problem to find the global groups a user is in twice: Once
in auth_util.c and another time for the corresponding samr call. The attached
patch unifies these and sends them through the passdb backend (new function
pdb_enum_group_memberships). Thus it gives pdb_ldap.c the chance to further
optimize the corresponding call if the samba and posix accounts are unified by
issuing a specialized ldap query.

The parameter to activate this ldapsam behaviour is

ldapsam:trusted = yes

Volker
(This used to be commit b94838aff1a009f8d8c2c3efd48756a5b8f3f989)
2007-10-10 10:53:15 -05:00
Jeremy Allison
ecd1b0fffd r3693: Correctly detect errno for no acl/ea support.
Jeremy
(This used to be commit 089a76f611187e2ba4c3363b657905d04576109e)
2007-10-10 10:53:14 -05:00
Gerald Carter
a4fab4d51a r3682: fix seg fault in lanman printing code caused by uninitialized variable
(This used to be commit c52e663c4a32b975796383834b2c04796daf8f29)
2007-10-10 10:53:13 -05:00
Jeremy Allison
4a69011a63 r3674: Stefan Esser <s.esser@e-matters.de> pointed out that the max data
value is only valid on the initial trans/trans2/nttrans request,
so if there are secondary requests we can't read it from them. Read
it from the initial request and pass as a parameter for those functions
that need it.
Jeremy.
(This used to be commit e007845e67e0604321fb36b216a98e4fca1c98e1)
2007-10-10 10:53:13 -05:00
Günther Deschner
c0cad75f09 r3673: Do not fail on setting file attributes with acl support enabled.
Rolling back r3496 (close #2015).

Guenther
(This used to be commit e88ac807847bd016f9c921f01f788708b1564b5c)
2007-10-10 10:53:13 -05:00
Jeremy Allison
e87470fa3f r3670: Warning fixes from Rob Foehl <rwf@loonybin.net>.
Jeremy.
(This used to be commit 54da75ca4cc27dfb0012fd17047702ec2f39cae9)
2007-10-10 10:53:12 -05:00
Jeremy Allison
17c8907d9c r3666: Generalise fix for trans and nttrans multi-fragment requests.
Jeremy
(This used to be commit 10b2489e3b2345a8532098523ebcebb73665a76f)
2007-10-10 10:53:12 -05:00
Jeremy Allison
70696e4c1c r3663: Fix too tight checking of incoming secondary trans2 requests.
Found by Stefan Esser <s.esser@e-matters.de>.
Jeremy.
(This used to be commit 44132c39ecbf055b897b1aa7bfca4eb1731badbf)
2007-10-10 10:53:12 -05:00
Jeremy Allison
c0406ae1b0 r3642: Extend vfs to add seekdir/telldir/rewinddir. Yes I know I have to
fix the modules too... First step in fixing out large directories
problem.
Jeremy.
(This used to be commit 344e9dd33a936b429fefb67cd748ac009a1bab10)
2007-10-10 10:53:11 -05:00
Volker Lendecke
55fe875a44 r3563: During a typical logon a modern workstation makes a lot of anonymous session
setups on its way to open a pipe. This gets rid of many round-trips to the
LDAP server during logon by setting up the server_info_guest once and not
asking the LDAP server and nss every time. Make sure that the ldap connection
is reopened in the child. (I did not look at the sql backends.)

Volker
(This used to be commit 3298f6105e6a88c9390cac02245c8f2eee1e5046)
2007-10-10 10:53:09 -05:00
Volker Lendecke
baf1ae1b0e r3559: If called interactively, on shutdown dump the talloc contexts left. Idea
stolen from samba4 ... ;-)

Volker
(This used to be commit b111bb46afc247e034a11e953b9d243cde69cc07)
2007-10-10 10:53:09 -05:00
Günther Deschner
193e82b056 r3496: Fix calling of get_acl_group_bits().
Guenther
(This used to be commit 3acc74eef5dae16d7e2792206640904265c42494)
2007-10-10 10:53:08 -05:00
Jeremy Allison
e62d9c3b87 r3296: Fix to ensure entries are stored in correct order. Bug #1498. Patch from
SATOH Fumiyasu <fumiya@samba.gr.jp>.
Jeremy.
(This used to be commit 7e35900bc6894d69f83c99ac6eb260d7cc35683a)
2007-10-10 10:53:04 -05:00
Jeremy Allison
2d32a93725 r3225: Fix correct use of resume name. Cope with the resume
name not existing. Found using Samba4 RAW-SEARCH.
Jeremy.
(This used to be commit 74dd2b33ff1ecba752682937c792628e081f17f5)
2007-10-10 10:53:03 -05:00
Jeremy Allison
7eec693863 r3121: Bug #1956. Ensure errno is saved and restored consistently on a normal_close.
Jeremy.
(This used to be commit f08f437c736e44913b3eeb16d6e32da8975442a7)
2007-10-10 10:53:01 -05:00
Jeremy Allison
677c218f3f r3117: Fix from Tom Lackemann <cessnatomny@yahoo.com> for bug #1954.
Memory leak in posix acl code.
Jeremy.
(This used to be commit c97aab7ee6bf1f385b445b4b0eb0e1df7e9a56f5)
2007-10-10 10:53:01 -05:00
Gerald Carter
293136c04b r3067: patch based on volker's initial work in trunk that fixes the queu update problem when using the background daemon
(This used to be commit de7af09e727e744aa27af85ef7c0f73ed5c1550a)
2007-10-10 10:53:00 -05:00
Jeremy Allison
8c1c918c94 r3050: Steal from Samba4 :-). Make us pass most of the new lock tests (except for
the cancel lock which I have to add).
Jeremy.
(This used to be commit cf7f89999e0c6becd4617c812400d1e71b9c0a30)
2007-10-10 10:52:59 -05:00
Gerald Carter
c53e6401eb r3049: fixing some calls in the printing code to stanard_sub_basic(); fix standard_sub_snum() to use the current user's gid; add some (snum == -1) checks to standard_sub_advanced()
(This used to be commit 8c3fd1908d201e9891878ff4c3259ed9690dff97)
2007-10-10 10:52:59 -05:00
Jeremy Allison
2efbc238d4 r3002: Fix for bug #1886 - prevent delete on close being set
for readonly files (and return the correct error code).
We now pass the Samba4 test suite on this.
Jeremy.
(This used to be commit 6ae417f12cc6f8d2ad00bea27ce0a20242f76325)
2007-10-10 10:52:59 -05:00
Tim Potter
8f49721fef r2899: Change some #if DEBUG_PASSWORD's to #ifdef DEBUG_PASSWORD.
Bugzilla #1903.
(This used to be commit 1327d83d902b6a39096d387d734e73d85ed53f85)
2007-10-10 10:52:56 -05:00
Günther Deschner
96876f696e r2772: Check correct string length when verifying password-policies. Do not
allow e.g. two umlauts and one ascii char to comply with account-policy
"min password length" of 5.

Thanks to Uwe Morgenroth from CC Compunet and Volker.

TODO: we do check the length against AP_MIN_PASSWORD_LEN *and*
lp_min_passwd_length() - both can have differing values.
(This used to be commit d03683772942e8c32507be210b8fd35bfba2c048)
2007-10-10 10:52:52 -05:00
Gerald Carter
31441aaa13 r2768: BUG 1519: save the hostname used in the open_printer_ex() for later reuse when filling in the spolss replies (also gets rid of get_called_name()
(This used to be commit 57db8ca91f52329c7f8985c04463b6b69015b0c4)
2007-10-10 10:52:52 -05:00
Jeremy Allison
39efdab4c1 r2708: Don't look for bzero, we don't use it.
Samba4 torture tester treates maxentries = 0 as maxentries ==1.
Jeremy.
(This used to be commit 38f3d3e263f59f94f243907447b5a82f67d3e3f7)
2007-10-10 10:52:49 -05:00
Jeremy Allison
8df096a75e r2700: Fix bug where we could incorrectly set sparse attribute. Don't use
st_blksize, it isn't what you think....
Jeremy.
--his line, and those below, will be ignored--

M    source/smbd/dosmode.c
(This used to be commit 0a40c1a50f0e4b1b7efc9a53d22ceac14841bccf)
2007-10-10 10:52:49 -05:00
Jim McDonough
2d5bf9ec40 r2697: Fix for bugzilla #1732, patch by Satoh Fumiyasu, fumiya@samba.gr.jp
Limit share names returned by RAP based on windows character width, not unix
character width.
(This used to be commit 5d57058d912a42d55879352e904f0bcaa6531075)
2007-10-10 10:52:49 -05:00
Jeremy Allison
eb9a09954b r2651: Added 'stat' command to smbclient to exercise the UNIX_FILE_BASIC
info level. Outputs data on the file in the same format the the
stat command in Linux. Should be useful to people wanting to learn
how to parse the UNIX extension output.
Yes I will add the docs later :-).
Jeremy.
(This used to be commit b25cc596417d29815814c3968ac2627bf59ffc0b)
2007-10-10 10:52:48 -05:00
Jeremy Allison
761dfdabfa r2637: Fix the roundup problem (returning 1mb roundup) for non-Windows
clients. This upsets the smb client in the Linux kernel (and Linus :-).
Jeremy.
(This used to be commit dad699ce0b36d23b80fe70b74d5e98df568a0495)
2007-10-10 10:52:48 -05:00