1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-09 09:57:48 +03:00

1896 Commits

Author SHA1 Message Date
Jeremy Allison
f1d8c4da23 r22675: Simo's patch for 0 size allocation. Still need
to examine parse_misc.c fix.
Jeremy.
(This used to be commit 80d981265cd3bc9d73c5da3c514ec736e2dfa73a)
2007-10-10 12:19:54 -05:00
Jeremy Allison
879081236d r22593: Finish doing the same for raw TALLOC.
Jeremy.
(This used to be commit aef3c262b724d1283187e732833519c4e6fb088c)
2007-10-10 12:19:50 -05:00
Jeremy Allison
79de0ad946 r22588: Make all uses of TALLOC_MEMDUP consistent.
Jeremy.
(This used to be commit 8ad13718af0ba1fcb10a6f1631b1ed3cb8d11175)
2007-10-10 12:19:48 -05:00
Jeremy Allison
1e362c0e7f r22587: Ensure TALLOC_ZERO_ARRAY is consistent.
Jeremy.
(This used to be commit c3df5d08dd6a983f9d53dc6628a50e571d322e8d)
2007-10-10 12:19:47 -05:00
Jeremy Allison
6b605a9cd7 r22586: Add a modified version of Simo's patch.
Jeremy.
(This used to be commit 18f47f999d28af56e205cd20d10c72ff6f0a3846)
2007-10-10 12:19:47 -05:00
Jeremy Allison
08a730e2ef r22574: Fix reply when we have no dfs shares.
Jeremy.
(This used to be commit f95bf093f9303131618b1de8f9b783ba19644bb3)
2007-10-10 12:19:45 -05:00
Jeremy Allison
71aa8a1ec2 r22573: Fix old bug mixing free() and talloc_free()
when the add_sid_to_array_XX code was moved
from malloc to talloc. Found running valgrind
and rpcclient. Needs merging for 3.0.25 final.
Jeremy.
(This used to be commit 8af56dbd00045049ea3c5022822bbaeeecbd9661)
2007-10-10 12:19:45 -05:00
Volker Lendecke
e26dee48f0 r22561: Fix a memleak in lanman.c: Nobody would free the session_list.
Volker
(This used to be commit 5d428400f77399b7fc30fb2a0fb10f0c74b96458)
2007-10-10 12:19:45 -05:00
Jeremy Allison
12ba88574b r22542: Move over to using the _strict varients of the talloc
calls. No functional changes. Looks bigger than it is :-).
Jeremy.
(This used to be commit f6fa3080fee1b20df9f1968500840a88cf0ee592)
2007-10-10 12:19:44 -05:00
Alexander Bokovoy
f4affb4382 r22505: Fix build
(This used to be commit cc38ffb9a45b008ab7bbc3299610bd0dfec13aa9)
2007-10-10 12:19:40 -05:00
Jim McDonough
70806db06a r22504: Fix bug Jerry found during his tutorial. Sorry :-(
Allows authorized users (e.g. BUILTIN\Administrators members) to
set attributes on an account, particularly "user cannot change
password".

add become_root() around updating attributes, after checking that
access has been granted.
(This used to be commit b1ab360519a1f67f50446ca8599e5b7aa58e7db3)
2007-10-10 12:19:40 -05:00
Volker Lendecke
d1103534ba r22126: Fix a bogus uninitialized variable warning
(This used to be commit 3be234effacd370dbdae11f6fcfddfe37d0623b3)
2007-10-10 12:19:15 -05:00
Gerald Carter
a1e72969d5 r22104: BUG 4439: Fix the object picket on x64 WIndopws XP/2003.
Enable the DsRoleGetPrimaryDomainInfo() server code.
Tested by Win2000/XP/2003/Vista (x86) and WinXP (x64)
(This used to be commit eab9ca7e7d8d7dc3e705720f8bc5dff5c8ec5f5f)
2007-10-10 12:19:12 -05:00
Jeremy Allison
cab91684e5 r22064: Fix the DFS code to work better with Vista clients. Allow
"host msdfs = true" to be set in the [global] section
and allow Vista to see shares with "msdfs root = yes"
and "msdfs root = no" off the same server. Down
to an error message really :-).
Jeremy.
(This used to be commit 1a0f69bb21fd03a18514dfc93c84568708144e28)
2007-10-10 12:19:08 -05:00
Jeremy Allison
7f8d89bc54 r22062: Fix the parsing of info level 3. Flags is not a flags
field, but an offset. Fixed 64-bit display of ACLs on
printers.
Jeremy.
(This used to be commit 0c8949ff5d742dbe59f2af0f57a289f238e3592c)
2007-10-10 12:19:07 -05:00
Jelmer Vernooij
0389cad7c4 r22055: Port the endpoint mapper (and functions it requires) to Samba 3.
(This used to be commit ad981261877e6a2dce0c4f4e71fd9127aa31538a)
2007-10-10 12:19:06 -05:00
Stefan Metzmacher
bc2b6436d0 r22009: change TDB_DATA from char * to unsigned char *
and fix all compiler warnings in the users

metze
(This used to be commit 3a28443079c141a6ce8182c65b56ca210e34f37f)
2007-10-10 12:19:00 -05:00
Stefan Metzmacher
56ba447668 r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.

also fix all the callers to prevent compiler warnings

metze
(This used to be commit fa322f0cc9c26a9537ba3f0a7d4e4a25941317e7)
2007-10-10 12:18:59 -05:00
Jeremy Allison
24cdd7c733 r21800: Check-in the DFS rewrite. I am still testing this but it
works from smbclient and Windows, and I am promising to
support and fix both client and server code moving forward.
Still need to test the RPC admin support but I haven't
changed that code.
Jeremy.
(This used to be commit 7a7862c01d07796ef206b255c676ad7dc2cc42fc)
2007-10-10 12:18:34 -05:00
Volker Lendecke
0d91334fe7 r21784: Replace smb_register_idle_event() with event_add_timed(). This fixes winbind
who did not run the idle events to drop ldap connections.

Volker
(This used to be commit af3308ce5a21220ff4c510de356dbaa6cf9ff997)
2007-10-10 12:18:33 -05:00
Gerald Carter
742a853875 r21635: Don't free talloc()'d memory. I wish people would check the callers
when changing how memory is allocated.
(This used to be commit 78bf4042dd22bf063846c58729d5b64be3fce8a8)
2007-10-10 12:18:19 -05:00
Jeremy Allison
8c5846acf2 r21569: Fix bug reported by Martin Zielinski <mz@seh.de>
where return value was incorrectly initialized.
Jeremy.
(This used to be commit 8d45f1f3b524031a34cfba21b677be8a09fc192c)
2007-10-10 12:18:14 -05:00
Volker Lendecke
2838d7499c r21563: Fix a memleak: We only need dispinfo structs for "our" and for the builtin
domain. Without this patch we leaked a DISPINFO for the (NULL) domain per
samr_connect*() call.

Volker
(This used to be commit 4423880ff47a94074c625a4f4f81c3b516faa644)
2007-10-10 12:18:14 -05:00
Volker Lendecke
f4a008424f r21551: Ok, this is more subtle. More tomorrow :-)
(This used to be commit f63189907efe857ef51ff91470ddb8d21b9a41fa)
2007-10-10 12:18:12 -05:00
Volker Lendecke
ab6a1df7a6 r21550: make disp_info_list static to get_samr_dispinfo_by_sid(), add a comment :-)
(This used to be commit fad2ee8aa3e99c31a0632a80b4a64dedb6e01495)
2007-10-10 12:18:12 -05:00
Volker Lendecke
eccb9b7962 r21549: Only create DISP_INFO structs for domain handles, the others don't need
them. It just does not make sense to do a querydispinfo on an alias handle...

This fixes a memleak: Every samr_connect*() call leaked a DISP_INFO for the
(NULL) sid.

More cleanup pending: Essentially, we only need the DISP_INFO cache for the
get_global_sam_sid() domain. BUILTIN is fixed and small enough, and there are
no other domains around where enumerations could happen.

This also removes the explicit builtin_domain flags. I don't think this is
worth it. If this makes a significant difference, then we have a *VERY* tuned
RPC layer...

Jeremy, please check this. If it's ok, we might want to merge it across.

Volker
(This used to be commit 0aceda68a825788895759e79de55b080ad3f971d)
2007-10-10 12:18:12 -05:00
Gerald Carter
2b52e35770 r21507: Fix some "cannot access LDAP when no root" bugs.
The two culprits were

* pdb_get_account_policy()
* pdb_get_group_sid()
(This used to be commit 6a69caf6907fad01b13aa4358ce5c62506f98495)
2007-10-10 12:18:09 -05:00
Jelmer Vernooij
1052cadbae r21462: Fix EnumValue (?)
(This used to be commit e73a418b5b0100936efb4c1133da3cfe3fcb61cd)
2007-10-10 12:18:06 -05:00
Jelmer Vernooij
4003edf0df r21385: Regenerate IDL after pidl changes, sync winreg.idl from samba4.
(This used to be commit b84370513fbf790e599c33f177fb271a2a992b72)
2007-10-10 12:18:00 -05:00
Volker Lendecke
c96fc96de9 r21265: Fix some valgrind errors -- not in 3_0
(This used to be commit b419a3407532efcd50f54c77927b3b3bb566845f)
2007-10-10 12:17:52 -05:00
Jeremy Allison
7a5fa7f12e r21191: Add in the POSIX open/mkdir/unlink calls.
Move more error code returns to NTSTATUS.
Client test code to follow... See if this
passes the build-farm before I add it into
3.0.25.
Jeremy.
(This used to be commit 83dbbdff345fa9e427c9579183f4380004bf3dd7)
2007-10-10 12:17:47 -05:00
Jeremy Allison
3ad849db21 r21164: Fix from Martin Zielinski <mz@seh.de> for EnumprinterdataEX
on Vista.
Jeremy.
(This used to be commit b16707a8615e1d00839d31e7a3061fb111336691)
2007-10-10 12:17:45 -05:00
Jeremy Allison
d4135a3bdb r21129: Fix from Martin Zielinski <mz@seh.de> - ensure
the hand marshalled container size is a multiple
of 4 bytes for RPC alignment.
Jeremy.
(This used to be commit 0e9ad2b29f1c05dc3f5d5e9659fe0557fa077d2e)
2007-10-10 12:17:41 -05:00
Volker Lendecke
69d8c5ae5f r21115: notify_internal.c needs to remove the table entry if a process has crashed. So
it needs the specific error message.

Make messages.c return NTSTATUS and specificially NT_STATUS_INVALID_HANDLE if
sending to a non-existent process.

Volker
(This used to be commit 3f620d181da0c356c8ffbdb5b380ccab3645a972)
2007-10-10 12:17:39 -05:00
Jeremy Allison
5eb536601a r21100: Add the RPC hack fix to adddriver as well as adddriverex.
Thanks to Martin Zielinski <mz@seh.de>.
Jeremy.
(This used to be commit d18a3f8b72f0f4cf0aa5b599f36ce3f4125adac3)
2007-10-10 12:17:37 -05:00
Jeremy Allison
0150bd394b r21099: Protect ourselves from null pointer deref. This isn't
the correct fix for the Vista bug, but it needed as
protection against invalid RPC. Thanks to Martin Zielinski <mz@seh.de>
for pointing this out.
Jeremy.
(This used to be commit fbab8e4ba93325f68353ee345a257a5445d78e67)
2007-10-10 12:17:37 -05:00
Volker Lendecke
caf8c6a76b r21064: The core of this patch is
void message_register(int msg_type,
                      void (*fn)(int msg_type, struct process_id pid,
-                                void *buf, size_t len))
+                                void *buf, size_t len,
+                                void *private_data),
+                     void *private_data)
 {
        struct dispatch_fns *dfn;

So this adds a (so far unused) private pointer that is passed from
message_register to the message handler. A prerequisite to implement a tiny
samba4-API compatible wrapper around our messaging system. That itself is
necessary for the Samba4 notify system.

Yes, I know, I could import the whole Samba4 messaging system, but I want to
do it step by step and I think getting notify in is more important in this
step.

Volker
(This used to be commit c8ae60ed65dcce9660ee39c75488f2838cf9a28b)
2007-10-10 12:17:32 -05:00
Jeremy Allison
6beb519280 r21047: Hand marshalling hack from Martin Zielinski <mz@seh.de>
to allow Vista to upload printer drivers (it wants level 8
which we don't support yet). Downgrade in the same way
that Windows servers do.
Jeremy.
(This used to be commit 01c659692c3e054904f1af815cf243b8a1dde109)
2007-10-10 12:17:29 -05:00
Volker Lendecke
71730ae5eb r20876: Fix bug 4346 -- Thanks to YAMASAKI Hiroyuki
(This used to be commit a7a66eb4eb2e518007b791457694c39dfff90705)
2007-10-10 12:17:17 -05:00
Jelmer Vernooij
d6b3fce078 r20875: Pass DCE/RPC server call arguments as a struct rather than as separate arguments.
This makes it a bit more similar to the Samba4 code.
(This used to be commit 0596badb410a58e7a715e2b17bc0bef0489a2448)
2007-10-10 12:17:16 -05:00
Jeremy Allison
83eb0d1d6d r20844: Somewhat radical change - this may break the build (I will
watch carefully - so I'm doing it in one transaction so I can
roll back).

Change check_name(), reduce_name() and dptr_create() to
return NTSTATUS. This helps a lot in error path processing
and especially in reduce_name() allows us to ditch the flaky
and error-prone saving of errno and return errors directly.

Jeremy.
(This used to be commit 6133a694aa429d638320e39ffe1c49d172583ccf)
2007-10-10 12:17:12 -05:00
Jelmer Vernooij
62e11c4f17 r20832: Remove extra pointers previously added to unique [out] pointers. Instead,
add [ref] pointers where necessary (top-level [ref] pointers,
by spec, don't appear on the wire).

This brings us closer to the DCE/RPC standard again.
(This used to be commit 580f2a7197b1bc9db14a643fdd112b40ef37aaef)
2007-10-10 12:17:11 -05:00
Volker Lendecke
b906886e9e r20824: Send access to the trusted domain passwords through the pdb backend, so that
in the next step we can store them in LDAP to be replicated across DCs.

Thanks to Michael Adam <ma@sernet.de>

Volker
(This used to be commit 3c879745cfc39be6128b63a88ecdbfa3d9ce6c2d)
2007-10-10 12:17:10 -05:00
Jeremy Allison
db0ad252a0 r20718: Sync up the filename path parsing changes from SAMBA_3_0_24.
The only difference between the two trees now w.r.t file
serving are the changes to smbd/open.c in this branch I need
to review.
Jeremy.
(This used to be commit f4474edf6a0c71001dbd01429ef70bafad6abd74)
2007-10-10 12:17:04 -05:00
Volker Lendecke
18bf0b29b4 r20546: Fix some IBM checker errors
(This used to be commit 8f67efd582655e03fea746eee499f3cab6cbdb4d)
2007-10-10 12:16:56 -05:00
Herb Lewis
e59e787b48 r20269: merge -r20264:20267 from SAMBA_3_0_24
more no previous prototype warnings
(This used to be commit 41be182f78762372ae13759ede5d2bd40a71d7f5)
2007-10-10 12:16:38 -05:00
Volker Lendecke
2494868ffb r20020: Arglll... eventlogadm links against reg_db but not the rest of the registry
stuff. Revert the last change.

This needs better fixing.

Volker
(This used to be commit ad1e00430bf5c4130023d30e9c8266ecdc640d2b)
2007-10-10 12:16:21 -05:00
Volker Lendecke
61bd0c8e45 r20019: Replace one set of tricky code by calls to another set of tricky code:
Initializing the reg_db now uses reg_createkey and reg_setvalue.

Volker
(This used to be commit cab5ccbbe484795f13531726d68b978073262e33)
2007-10-10 12:16:21 -05:00
Volker Lendecke
b676097927 r20017: Make srvsvc_NetShareAdd & friends take care of registry shares
(This used to be commit fc29a283cc9c2458375aa4fe2ecef82e6a3847df)
2007-10-10 12:16:21 -05:00
Volker Lendecke
fe34827ffd r20015: We have to zero out handle on key_close, otherwise the NT4 regedit will re-use the handle
(This used to be commit 0afd696f88ed04f562ef64201ac2e58cef372a90)
2007-10-10 12:16:20 -05:00