1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00

71627 Commits

Author SHA1 Message Date
David Disseldorp
9c342c44a4 s3: add two missing vfs disconnect calls
The fix for bug 7976 added a vfs connect call to create_conn_struct.
This change adds two further disconnect calls that were missed by the
original change.

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Mar  4 16:33:53 CET 2011 on sn-devel-104
2011-03-04 16:33:53 +01:00
David Disseldorp
2b635949a2 s3-printing: fix cups pcap reload with no printers
cups_async_callback() is called to receive new printcap data from a
child process which requests the information from cupsd.
Newly received printcap information is stored in a temporary printcap
cache (tmp_pcap_cache). Once the child process closes the printcap IPC
file descriptor, the system printcap cache is replaced with the newly
populated tmp_pcap_cache, however this only occurs if tmp_pcap_cache is
non null (has at least one printer).

If the printcap cache is empty, which is the case when cups is not
exporting any printers, the printcap cache is not replaced resulting in
stale data.

https://bugzilla.samba.org/show_bug.cgi?id=7915
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04 15:46:23 +01:00
David Disseldorp
624e33f869 s3-printing: remove unneeded local_pcap_copy global
The cups local_pcap_copy global served as a temporary buffer during
asynchronous cups printcap cache updates, as well as indicating when
the printcap cache had not yet been filled and printcap cache update
should block.

As smbd printcap reads are now triggered by the parent smbd following
printcap cache update, the variable and blocking mechanism are no longer
needed.

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04 15:46:20 +01:00
David Disseldorp
61bf4699f0 s3-printing: follow force user/group for driver IO
Configuring force user/group settings for the print$ share currently has
unexpected results, this is explained by how the driver upload/add
process takes place. Consider the following example:

[print$]
        path = /print-drv
        write list = $DRIVER_UPLOAD_USER
        force group = ntadmin

- the client connects to the [print$] share and uploads all driver
  files to the /print-drv/W32X86 directory.

- This is permitted, as /print-drv/W32X86 is owned by group ntadmin, and
  the "force group = ntadmin" takes effect for the [print$] session.

- Once all files are uploaded, the client connects to the [ipc$]
  share and issues an AddPrinterDriverEx spoolss request.

- In handling this request move_driver_to_download_area() is called,
  which attempts to create the directory /print-drv/W32X86/3

- The create directory fails, as it is done as the user connected to
  the [ipc$] share which does not have permission to write to the driver
  directory. The [print$] "force group = ntadmin" has no effect.

This is a regression from previous behaviour prior to the commit:
783ab04 Convert move_driver_to_download_area to use create_conn_struct.

https://bugzilla.samba.org/show_bug.cgi?id=7921
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-03-04 15:46:14 +01:00
Matthias Dieter Wallnöfer
b0c6899973 ldb:ldb tools - remove a superflous "return" (usage internally calls "exit")
Reviewed by: Tridge

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar  4 09:39:22 CET 2011 on sn-devel-104
2011-03-04 09:39:22 +01:00
Matthias Dieter Wallnöfer
b50ebc3228 ldb:ldb tools - return LDB_ERR_INVALID_DN_SYNTAX on wrong DN parameters
Not all LDB databases have further DN checks.

Reviewed by: Tridge
2011-03-04 08:51:57 +01:00
Matthias Dieter Wallnöfer
1b93173813 ldb:ldb tools - ldbtest - convert other result values to LDB codes as well
I've forgotten this in my first patchset.

Reviewed by: Tridge
2011-03-04 08:51:45 +01:00
Matthias Dieter Wallnöfer
1343c0723f s4:LDAP server - remove validation checks of input DNs
We should rather try to let the LDB modules perform these checks
otherwise different backends behaviour differently.

Reviewed by: Tridge
2011-03-04 08:51:38 +01:00
Matthias Dieter Wallnöfer
5896b72993 s4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid
ERR_INVALID_DN_SYNTAX fits better than ERR_OPERATION_ERROR in this case. This
one gets triggered if we perform "add" requests without the LDAP server.

Reviewed by: Tridge
2011-03-04 08:51:29 +01:00
Andrew Tridgell
3560db3da3 debug: fixed a valgrind error
Thanks to Volker for spotting this one!

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Mar  4 03:09:52 CET 2011 on sn-devel-104
2011-03-04 03:09:52 +01:00
Günther Deschner
e63f0dfba1 s3-waf: add wildcard commands from main wscript.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar  4 02:11:11 CET 2011 on sn-devel-104
2011-03-04 02:11:10 +01:00
Günther Deschner
ef87f970b3 s3-nterr: use strcasecmp in nt_status_string_to_code().
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
dc35442fb1 s4-nterr: move auth_nt_status_squash to nt_status_squash and move to nterr.c
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
9f4b3b103f s4-nterr: some minor cosmetic edits to further match s3 nterr.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
d367777352 s3-nterr: within nt_errstr() compare codes using NT_STATUS_V().
This is to avoid future very special NT_STATUS_EQUAL semantics within s4.

Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
199809b3cc nterr: make sure both nt_err_desc structs are the same.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
45710a05c5 nterr: make sure both nt_errs structs are the same.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
648a9fbc03 s4-nterr: add _N macro handling as in s3-nterr.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
c1089c130b s3-nterr: make nt_err_desc static const.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
cb8c0e1776 nterr: remove space indents (use tabs instead), following coding standards.
Guenther
2011-03-04 01:18:41 +01:00
Günther Deschner
2f46942e08 nterr: remove trailing whitespace.
Guenther
2011-03-04 01:18:41 +01:00
Günther Deschner
6b3d68fffd s3-waf: add check for SEEKDIR_RETURNS_VOID.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar  4 01:13:54 CET 2011 on sn-devel-104
2011-03-04 01:13:54 +01:00
Günther Deschner
0fb246ba73 s3-waf: add check for HAVE_FUNCTION_ATTRIBUTE_DESTRUCTOR.
Guenther
2011-03-04 00:28:28 +01:00
Günther Deschner
9167d70e77 libreplace: move "struct timespec" checks into libreplace (where timespec is already used).
Bjoern, Metze, please check.

Guenther
2011-03-04 00:28:27 +01:00
Stefan Metzmacher
a5d54579ea socket_wrapper: use swrap_sendmsg_before()/after() in swrap_writev()
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Mar  3 23:43:39 CET 2011 on sn-devel-104
2011-03-03 23:43:39 +01:00
Stefan Metzmacher
e831376f91 socket_wrapper: use swrap_sendmsg_before()/after() in swrap_sendmsg()
This also adds the same logic for broadcast as in swrap_sendto()
for SOCK_DGRAM.

metze
2011-03-03 22:57:26 +01:00
Stefan Metzmacher
4a736f0fbe socket_wrapper: use swrap_sendmsg_before()/after() in swrap_send()
metze
2011-03-03 22:57:26 +01:00
Stefan Metzmacher
a2db6b4dba socket_wrapper: use swrap_sendmsg_before()/after() in swrap_sendto()
metze
2011-03-03 22:57:26 +01:00
Stefan Metzmacher
8c6d7d7b27 socket_wrapper: add swrap_sendmsg_before/after helper functions
Currently have almost the same logic in swrap_send(), swrap_sendto(),
swrap_writev() and swrap_sendmsg(), this helper functions
let combine all the logic in 2 places.

metze
2011-03-03 22:57:26 +01:00
Stefan Metzmacher
c9ae810209 socket_wrapper: replace recvmsg() correctly
metze
2011-03-03 22:57:26 +01:00
Stefan Metzmacher
ec028b555b socket_wrapper: readv() should only work on connected sockets
metze
2011-03-03 22:57:26 +01:00
Stefan Metzmacher
7bdc3db9ea socket_wrapper: move swrap_ioctl() above the send*/recv* functions
metze
2011-03-03 22:57:26 +01:00
Stefan Metzmacher
0ad8d459c6 socket_wrapper: fix compiler warnings
metze
2011-03-03 22:57:25 +01:00
Stefan Metzmacher
e3c0d66110 socket_wrapper: don't allow connect() to the broadcast address
This will simplify other code later.

metze
2011-03-03 22:57:25 +01:00
Volker Lendecke
7b139a49dc s3: Use dom_sid_string_buf in sid_to_fstring
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar  3 22:56:57 CET 2011 on sn-devel-104
2011-03-03 22:56:56 +01:00
Volker Lendecke
70517477f8 Add dom_sid_string_buf
This prints into a fixed buffer with the same overflow semantics as snprintf
has: Return required string length, regardless of whether it fit or not.
2011-03-03 22:08:49 +01:00
Volker Lendecke
f8a13c7dbc s3: Use dom_sid_string in _lsa_lookup_sids_internal 2011-03-03 22:08:49 +01:00
Volker Lendecke
ae28029f67 s3: Remove an obsolete comment 2011-03-03 22:08:49 +01:00
Volker Lendecke
01da00abfd s3: Fix some nonempty blank lines 2011-03-03 22:08:49 +01:00
Günther Deschner
875d9b8098 lib/util: LIBCRYPTO is in common already, so add it to samba-util-common.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar  3 18:08:30 CET 2011 on sn-devel-104
2011-03-03 18:08:30 +01:00
Günther Deschner
ba7727487e s3-includes: remove global include of system/readline.h.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar  2 23:06:17 CET 2011 on sn-devel-104
2011-03-02 23:06:17 +01:00
Günther Deschner
a460fe8151 s3-proto: fix some inline comments.
Guenther
2011-03-02 22:17:52 +01:00
Günther Deschner
93db9489fd s3-libds: use already existing ../libds/common/flag_mapping.h header.
Guenther
2011-03-02 22:17:17 +01:00
Volker Lendecke
4afda9ebf4 s3: Pass the aio_force operation through vfs_gpfs
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar  2 19:24:27 CET 2011 on sn-devel-104
2011-03-02 19:24:27 +01:00
Volker Lendecke
6405e341b9 s3: Ask GPFS for the IS_OFFLINE operation 2011-03-02 18:39:21 +01:00
Volker Lendecke
73ce3e156e s3: Announce HSM in the gpfs module 2011-03-02 18:39:21 +01:00
Volker Lendecke
cf7dac6fbc s3: Pass smb_filename through the set_offline vfs op 2011-03-02 18:39:21 +01:00
Volker Lendecke
c9d1e16c2c s3: Pass smb_filename through the is_offline vfs op 2011-03-02 18:39:21 +01:00
Volker Lendecke
48f6b4d6fc s3: Fix operation names in vfs_full_audit.c 2011-03-02 18:39:21 +01:00
Volker Lendecke
dee53e04ba s3: Print all flags in "smbclient allinfo" 2011-03-02 18:39:21 +01:00