1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

156 Commits

Author SHA1 Message Date
Jeremy Allison
0100bb0eb6 r7157: Ensure we abort a directory listing if we see the same
name twice between packets.
Jeremy.
(This used to be commit f9063b383ed2c53841ac27691b6a593b80c20b12)
2007-10-10 10:57:04 -05:00
Jeremy Allison
57fa7e1547 r7151: Fix for bug #2698. If a unicode to unix charset conversion fails (due to buggy iconv?) we can
be left with a filename that doesn't exist on the remote machine. If we then do a findnext
with this file the server gets confused and restarts from the beginning of the directory,
causing directory listing loops. Fix this by keeping a copy of the "raw" filename data and
length and using this as the argument to findnext. This won't fix the incorrect iconv
conversion into the finfo struct but at least it ensures that directory listings always
terminate. Tested against NTFS and FAT directories.
Jeremy.
(This used to be commit 848940d5a91b310e58d0631ead293418ea4186f0)
2007-10-10 10:57:03 -05:00
Jeremy Allison
45d03e327a r6994: Fix for bugid #2729 - it turns out resume keys are *mandatory* for
a search when listing a W2K and above server from a FATxx filesystem
only. Thanks to Steve Langasek <vorlon@debian.org> for giving me the
essential info that allowed me to reproduce and thus fix this.
Jeremy.
(This used to be commit 8227675d3dbcd4f8bb2a24ea7e3e05c428b7c929)
2007-10-10 10:56:59 -05:00
Herb Lewis
978ca84860 r6225: get rid of warnings from my compiler about nested externs
(This used to be commit efea76ac71412f8622cd233912309e91b9ea52da)
2007-10-10 10:56:30 -05:00
Jeremy Allison
7478d77b31 r5991: Fixup last entry offset correctly for level 260.
Should fix bug found by Derrell.Lipman@UnwiredUniverse.com.
Jeremy.
(This used to be commit 5ded615679e346d1ea155cde3413396d3e3c3a6b)
2007-10-10 10:56:14 -05:00
Jeremy Allison
656140bf4b r5975: Re-arrange code and comments to make more sense.
Jeremy.
(This used to be commit 08616ad80d96d1b7b558eec036bafb4bf3663942)
2007-10-10 10:56:14 -05:00
Jeremy Allison
47f58beb28 r5973: Fix up overwrite of last 2 bytes on clilist (could cause coredump).
Jeremy.
(This used to be commit b0de2d761f6697ca1f4859ba098af6162ab42027)
2007-10-10 10:56:14 -05:00
Jeremy Allison
f8f090ad24 r5970: Fix old bug where ff_searchcount was being compared -1 ! This caused a
filename to be processed twice.
Jeremy.
(This used to be commit 2ed7e30cbb3e194a08d5d9b46993652666193bec)
2007-10-10 10:56:13 -05:00
Jeremy Allison
b360f556a5 r5967: Fix typo bug where flags overwrote info level.
Jeremy.
(This used to be commit 214a2cbe5aed9f0540b03350b60d0eec1c61bad8)
2007-10-10 10:56:13 -05:00
Jeremy Allison
4a62d418d9 r5723: Add missing part of fix for #2271. After analysing the actions of a XP
client against a Samba server. It never uses the "continue" flag, but always
does "new search, continue from this file" instead. Change our client code
to do the same (it appears that's all they test in W2K etc.).
Jeremy.
(This used to be commit 710bceee325005b8ca8e8ed04acc50bafa92b6e6)
2007-10-10 10:55:57 -05:00
Jeremy Allison
9d23e37a6f r5702: Fix bug #2271. Correctly pull out and use resume names in a
directory listing (we were incorrectly understanding what was
returned in the "last name" entry).
Jeremy.
(This used to be commit 4f2da9ecf1e5cee4749839ea1b35a942d27de09e)
2007-10-10 10:55:55 -05:00
Gerald Carter
96572957fc r5577: get recurse; dir working across single level dfs referrals
(This used to be commit d4443807bc7a5a8615c69517365a92709db7ce29)
2007-10-10 10:55:48 -05:00
Gerald Carter
1b0f75ddfb r5520: fix last remaining dfs issues with smbclient.
* all the unix extension commands should work
* send the correct TRANS2_FINDFIRST format to 2k to
  get a listing from a msdfs root share (tested against
  smbd as well).
* mkdir, rmdir, etc... all seem ok.

I'm sure bugs will pop up so keep testing.

Last thing I plan on doing is to clean up the horrible
mess with connection management in smbclient and global
variables (so i can move the cli_cm_xx() routines to a
separate file).
(This used to be commit 53d6a5f9d16aef4afc60b4b37b296b256da00dfd)
2007-10-10 10:55:44 -05:00
Jeremy Allison
acf9d61421 r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
(This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10 10:53:32 -05:00
Jim McDonough
24df38dbc6 Janitor for tpot...bugzilla #1098, msleep already exists on aix
(This used to be commit 4319df7fdc2d878c509381923cc1db4d731620ba)
2004-02-23 02:54:03 +00:00
Jeremy Allison
231124ced9 Fixes to check for wraps which could cause coredumps.
Jeremy.
(This used to be commit ad06edd1bb58cc5e2c38a364b1af96a933b770af)
2003-10-29 21:28:00 +00:00
Jeremy Allison
2443f7ffa2 Correct fix (removed the earlier band-aid) for what I thought was a signing
bug with w2k. Turns out that when we're doing a trans/trans2/nttrans call
the MID and send_sequence_number and reply_sequence_number must remain constant.
This was something we got very wrong in earlier versions of Samba. I can now
get a directory listing from WINNT\SYSTEM32 with the older earlier parameters
for clilist.c
This still needs to be fixed for the server side of Samba, client appears to
be working happily now (I'm doing a signed smbtar download of an entire W2K3
image to test this :-).
Jeremy.
(This used to be commit 2093a3130d4087d0659b497eebd580e7a66e5aa3)
2003-08-02 00:29:45 +00:00
Jeremy Allison
9c49c46948 Fix bug we discovered in W2K client signing on secondary trans2 packets.
Use W2K parameters. tpot please re-test smbclient with your problem
directory.
Jeremy.
(This used to be commit 677d3a3c4ca0b67148e5e56fa876773a067679bd)
2003-07-30 19:00:52 +00:00
Jeremy Allison
5ab2b1e921 Eliminate valgrind error when client gets bad sig on list. Some reformatting.
Jeremy.
(This used to be commit b8f6b836468b3a0ae75977dc65cae8400f74734c)
2003-07-30 18:57:37 +00:00
Andrew Bartlett
d5ee9b2f48 Jeremy merged across my string parinoia fixes, but forgot to enable them! :-)
This patch catches up on the rest of the work - as much string checking
as is possible is done at compile time, and the rest at runtime.

Lots of code converted to pstrcpy() etc, and other code reworked to correctly
call sizeof().

Andrew Bartlett
(This used to be commit c5b604e2ee67d74241ae2fa07ae904647d35a2be)
2003-03-18 11:22:52 +00:00
Jeremy Allison
dbe2858b86 Change size parameters from signed to unsigned to fix up warnings.
Jeremy.
(This used to be commit 33b11d5eb53bdeb9d279d221fd5c01579253e1c7)
2003-03-13 00:51:05 +00:00
Gerald Carter
99cdb46208 *lots of small merges form HEAD
*sync up configure.in
*don't build torture tools in make all
*make sure to remove torture tools as part of make clean
(This used to be commit 0fb724b3216eeeb97e61ff12755ca3a31bcad6ef)
2003-01-15 18:57:41 +00:00
Gerald Carter
4242eda183 merging some rpcclient and net functionality from HEAD
(This used to be commit 7a4c87484237308cb3ad0d671687da7e0f6e733b)
2003-01-15 17:22:48 +00:00
Jeremy Allison
3fc4d88d99 Fix client reporting of 64 bit files.
Jeremy.
(This used to be commit 8dcbfa4e770d74d4ce6faaf1a0597d07d0a5cc81)
2002-12-10 23:44:33 +00:00
Herb Lewis
e217ba0a70 use the new IVAL_TO_SMB_OFF_T for file_info size member
dir now shows correct size on large files
(This used to be commit 172dccf55e972d4cc40b7e34ce433d49e738fba0)
2002-12-03 20:02:18 +00:00
Gerald Carter
a834a73e34 sync'ing up for 3.0alpha20 release
(This used to be commit 65e7b5273bb58802bf0c389b77f7fcae0a1f6139)
2002-09-25 15:19:00 +00:00
Andrew Tridgell
e90b652848 updated the 3.0 branch from the head branch - ready for alpha18
(This used to be commit 03ac082dcb375b6f3ca3d810a6a6367542bc23ce)
2002-07-15 10:35:28 +00:00
Tim Potter
cd68afe312 Removed version number from file header.
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
(This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
2002-01-30 06:08:46 +00:00
Jeremy Allison
d6823366b8 Same fix as went into 2.2 (I'm waiting for jerry to finish some code).
Jeremy.
(This used to be commit 01ff6ce4963e1daff019f2b936cef218e1c93f67)
2002-01-11 19:10:25 +00:00
Simo Sorce
bcbd75f7ad move to SAFE_FREE()
(This used to be commit 48fc6a6cd52e01b287030fbbf0aa08a6814c5e11)
2001-09-17 03:33:37 +00:00
Andrew Tridgell
d53d5beeb2 use cli_is_error() instead of looking in smb_rcls, otherwise NT status
codes don't work correctly
(This used to be commit 55d5828e608671f070a9e96938be0d16d50aeb26)
2001-09-05 11:32:59 +00:00
Andrew Tridgell
a350db7c7c fixed shortname length in trans2 list
(This used to be commit ae669720d8f434a23397deaea3371998ab6f1f54)
2001-08-24 04:53:39 +00:00
Andrew Tridgell
8d9cdf0d74 a fix for directory listing with the dave/thursby client
(This used to be commit 5a3fd3317e0fedd72450660f031b5ba42a11b875)
2001-08-22 02:47:38 +00:00
Andrew Tridgell
11ce0f4d2d a bunch of fixes from the sflight to seattle
in particular:
 - fixed NT status code for a bunch of ops
 - fixed handling of protocol levels in ms_fnmatch
(This used to be commit 3eba9606f71f90bfd9820af26f8676277ed22390)
2001-08-20 05:15:26 +00:00
Tim Potter
4da562d4dc Fixed crash bug when attempting to list contents of non-existent
directory.
(This used to be commit a7863f0f033b31838a53960e9f616d9a82081ecf)
2001-08-12 23:53:26 +00:00
Simo Sorce
2e783a4707 this is a big global fix for the ptr = Realloc(ptr, size) bug.
many possible mem leaks, and segfaults fixed.

someone should port this fix to 2.2 also.
(This used to be commit fa8e55b8b465114ce209344965c1ca0333b84db9)
2001-08-12 17:30:01 +00:00
Tim Potter
2ccfea3de7 A rewrite of the error handling in the libsmb client code. I've separated
out the error handling into a bunch of separate functions rather than all
being handled in one big function.

Fetch error codes from the last received packet:

    void cli_dos_error(struct cli_state *cli, uint8 *eclass, uint32 *num);
    uint32 cli_nt_error(struct cli_state *);

Convert errors to UNIX errno values:

    int cli_errno_from_dos(uint8 eclass, uint32 num);
    int cli_errno_from_nt(uint32 status);
    int cli_errno(struct cli_state *cli);

Detect different kinds of errors:

    BOOL cli_is_dos_error(struct cli_state *cli);
    BOOL cli_is_nt_error(struct cli_state *cli);
    BOOL cli_is_error(struct cli_state *cli);

This also means we now support CAP_STATUS32 as we can decode and understand
NT errors instead of just DOS errors.  Yay!

Ported a whole bunch of files in libsmb to use this new API instead of the
just the DOS error.
(This used to be commit 6dbdb0d813f3c7ab20b38baa1223b0b479aadec9)
2001-08-10 06:00:33 +00:00
Andrew Tridgell
74e9921628 fixed some unicode and LANMAN2 bugs in trans2 find first
(This used to be commit dc99b9ddf847c210c72921ba1dedcdc34fd32aab)
2001-07-07 21:23:32 +00:00
Andrew Tridgell
87fbb7092b The big character set handling changeover!
This commit gets rid of all our old codepage handling and replaces it with
iconv. All internal strings in Samba are now in "unix" charset, which may
be multi-byte. See internals.doc and my posting to samba-technical for
a more complete explanation.
(This used to be commit debb471267960e56005a741817ebd227ecfc512a)
2001-07-04 07:15:53 +00:00
Andrew Tridgell
871a429404 added STR_ASCII support to clistr_pull()
(This used to be commit 797293811ef0a79eecc460c471135c89090f8c06)
2001-03-16 03:25:13 +00:00
Andrew Tridgell
9ea70bd003 simpler clistr interface which handles individual packets having
unicode bit set differently to capabilities
(This used to be commit 34a0821e087810381996f5ff6cf3b4d7b9bb53a0)
2001-03-14 12:42:43 +00:00
Andrew Tridgell
45c2ee3ff2 to use the same macros in the client and server rename the CLISTR_
macros to STR_
(This used to be commit 95c9e4e0ba8f37f565aaf136f41eb76489441ff7)
2001-03-10 11:35:25 +00:00
Andrew Tridgell
0d54de536c made some LANMAN1 wildcard progress
it now handles -M LANMAN1 -f '.x' -m '?x' nicely
(This used to be commit e7ccb9be6da9b1426eb136b4a0a1171232471768)
2001-02-26 06:53:42 +00:00
Andrew Tridgell
f9405ab8f9 add cli_list_new() for forced new protocol listing
(This used to be commit a5407366b77f2bec2c21e1f36dd007813d33f75e)
2001-02-26 05:10:44 +00:00
Andrew Tridgell
96e791eb11 use cli_list_old() when negotiating the older protocols
(This used to be commit 735f29319b8d81df203c8ddbcea5349b11f2195d)
2001-02-25 23:46:28 +00:00
Andrew Tridgell
a8ab984078 the unicode conversion of our client code is complete enough to be
enabled by default

you can disable it by setting the environment variable CLI_FORCE_ASCII
(This used to be commit 4d59c08c5e6f54c0d6ced7650750cb987e77b6c9)
2001-02-21 03:40:20 +00:00
Andrew Tridgell
f76015333a yipee! client unicode now works well with nt
(This used to be commit 5b2ef8a1b914265c6072c968d2dad7d26c2aeffc)
2001-02-20 23:52:27 +00:00
Andrew Tridgell
c7c3db2f16 converted cli_list()
(This used to be commit bdce09b77807c80281c1e169b7c4813c9238fbe3)
2001-02-20 12:22:30 +00:00
Andrew Tridgell
c565c98723 pipe opening now works with unicode
(This used to be commit ba3ce3404e1cd2e9da3ba1708f6fc8a12c085ef2)
2001-02-20 10:11:40 +00:00
Richard Sharpe
dca808cbc4 Needed a callback arg on cli_list ...
(This used to be commit d45e667a74fc2fcbf69c4819d480269c03dbfae4)
2001-01-05 13:11:29 +00:00