1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

675 Commits

Author SHA1 Message Date
Andrew Bartlett
f0cd6b35e5 - Fix the kerberos downgrade problem:
- When connecting to the NETOGON pipe, we make a call to auth2, in order
   to verify our identity.  This call was being made with negotiation flags
   of 0x1ff.  This caused our account to be downgraded.  If we instead make
   the call with flags > 1ff (such as 0x701ff), then this does not occour.

 - This is *not* related to the use of kerberos for the CIFS-level connection

My theory is that Win2k has a test to see if we are sending *exactly* what
NT4 sent - setting any other flags seems to cause us to remain intact.

Also ensure that we only have 'setup schannel' code in a few places, not
scattered around cmd_netlogon too.

Andrew Bartlett
(This used to be commit e10f0529fe)
2003-08-19 20:39:32 +00:00
Gerald Carter
5ba60c5608 working on fix for BUG #294. Not done yet, but this at least clears
up some of the false positives in "rpcclient -c getdriver".
Also make sure that we ask for version2 and 3 drivers on x86.
(This used to be commit 5be5151568)
2003-08-19 16:56:53 +00:00
Herb Lewis
aa39cc37da get rid of more compiler warnings
(This used to be commit 398bd14fc6)
2003-08-15 04:42:05 +00:00
Andrew Bartlett
172766eea7 Change Samba to always use extended security for it's guest logins, (ie,
NTLMSSP with "" username, NULL password), and add --machine-pass (-P) to
all of Samba's clients.

When connecting to an Active Directory DC, you must initiate the CIFS level
session setup with Kerberos, not a guest login.  If you don't, your machine
account is demoted to NT4.

Andrew Bartlett
(This used to be commit 3547cb3def)
2003-08-14 01:08:00 +00:00
Jeremy Allison
8d94de787e Patch from waider@waider.ie to print out Port Type.
Jeremy.
(This used to be commit 8516baf58d)
2003-08-07 00:55:35 +00:00
Simo Sorce
04bf12b176 port latest changes from SAMBA_3_0 tree
(This used to be commit 3101c236b8)
2003-08-02 20:06:57 +00:00
Jeremy Allison
29ca70cd34 Add a command line option (-S on|off|required) to enable signing on client
connections. Overrides smb.conf parameter if set.
Jeremy.
(This used to be commit 879309671d)
2003-07-30 23:49:29 +00:00
Gerald Carter
c856d9274b add a few more tidy ups. Now onto winbindd
(This used to be commit f8abdd23e1)
2003-07-30 17:37:46 +00:00
Gerald Carter
de1a998622 add support for DsEnumerateDomainTrusted for enumerating all the
trusted domains in a forest.
(This used to be commit c691c7f7d9)
2003-07-30 17:29:00 +00:00
Andrew Bartlett
c9305f1c64 Schannel, once setup, may be used on *ANY* TCP/IP connection until the
connection that set it up has been shut down.

(Also, pipes still connected, and reconnections to the same pipe (eg SAMR)
may continue to use that session key until their TCP/IP connection is shut
down)

Allow further testing by printing out the session key, and allowing it's input
into rpcclient.

Next step is automatic storage in a TDB.

Andrew Bartlett
(This used to be commit fa4d7be161)
2003-07-25 01:26:19 +00:00
Gerald Carter
3a5dc7c2ec convert snprintf() calls using pstrings & fstrings
to pstr_sprintf() and fstr_sprintf() to try to standardize.
lots of snprintf() calls were using len-1; some were using
len.  At least this helps to be consistent.
(This used to be commit 9f835b85dd)
2003-07-23 12:33:59 +00:00
Tim Potter
274f1f8806 Replace the eight (!) copies of dummy become/unbecome root with a single one.
(This used to be commit 8b818ce381)
2003-07-22 00:20:53 +00:00
Gerald Carter
4a090ba06a trying to get HEAD building again. If you want the code
prior to this merge, checkout HEAD_PRE_3_0_0_BETA_3_MERGE
(This used to be commit adb98e7b7c)
2003-07-16 05:34:56 +00:00
Andrew Bartlett
456f51bcbe Jeremy requested that I get my NTLMSSP patch into CVS. He didn't request
the schannel code, but I've included that anyway. :-)

This patch revives the client-side NTLMSSP support for RPC named pipes
in Samba, and cleans up the client and server schannel code.  The use of the
new code is enabled by the 'sign', 'seal' and 'schannel' commands in
rpcclient.

The aim was to prove that our separate NTLMSSP client library actually
implements NTLMSSP signing and sealing as per Microsoft's NTLMv1 implementation,
in the hope that knowing this will assist us in correctly implementing
NTLMSSP signing for SMB packets.  (Still not yet functional)

This patch replaces the NTLMSSP implementation in rpc_client/cli_pipe.c with
calls to libsmb/ntlmssp.c.  In the process, we have gained the ability to
use the more secure NT password, and the ability to sign-only, instead of
having to seal the pipe connection.  (Previously we were limited to sealing,
and could only use the LM-password derived key).

Our new client-side NTLMSSP code also needed alteration to cope with our
comparatively simple server-side implementation.  A future step is to replace
it with calls to the same NTLMSSP library.

Also included in this patch is the schannel 'sign only' patch I submitted to
the team earlier.  While not enabled (and not functional, at this stage) the
work in this patch makes the code paths *much* easier to follow.  I have also
included similar hooks in rpccleint to allow the use of schannel on *any* pipe.

rpcclient now defaults to not using schannel (or any other extra per-pipe
authenticiation) for any connection.  The 'schannel' command enables schannel
for all pipes until disabled.

This code is also much more secure than the previous code, as changes to our
cli_pipe routines ensure that the authentication footer cannot be removed
by an attacker, and more error states are correctly handled.

(The same needs to be done to our server)

Andrew Bartlett
(This used to be commit 5472ddc9ea)
2003-07-14 08:46:32 +00:00
Gerald Carter
816724fb39 more compile fixes for become/unbecome_root()
(This used to be commit f005f1cf12)
2003-07-09 03:32:07 +00:00
Jeremy Allison
ce0709666c More conversions I missed. Thanks metze.
Jeremy.
(This used to be commit 4f78d747e6)
2003-07-04 18:52:31 +00:00
Jeremy Allison
ce72beb2b5 Removed strupper/strlower macros that automatically map to strupper_m/strlower_m.
I really want people to think about when they're using multibyte strings.
Jeremy.
(This used to be commit ff222716a0)
2003-07-03 19:11:31 +00:00
Gerald Carter
f36c96d59c * s/get_dc_name/rpc_dc_name/g (revert a previous change)
* move back to qsort() for sorting IP address in get_dc_list()

* remove dc_name_cache in cm_get_dc_name() since it slowed
  things down more than it helped.  I've made a note of where
  to add in the negative connection cache in the ads code.
  Will come back to that.

* fix rpcclient to use PRINTER_ALL_ACCESS for set printer (instead
  of MAX_ALLOWED)

* only enumerate domain local groups in our domain

* simplify ldap search for seqnum in winbindd's rpc backend
(This used to be commit f8cab8635b)
2003-06-23 19:05:23 +00:00
Jelmer Vernooij
0914e541f5 Reverse previous patch from Stefan and me after comments by Andrew Bartlett
(This used to be commit d817eaf0ec)
2003-05-10 11:49:51 +00:00
Jelmer Vernooij
7ed8b615b9 Reverse previous patch from Stefan and me after comments by Andrew Bartlett.
(This used to be commit d31509fe88)
2003-05-10 11:47:29 +00:00
Jelmer Vernooij
ec40d70b3b Patch from metze and me that adds dummy smb_register_*() functions
(This used to be commit 367a5cad1e)
2003-05-10 10:56:20 +00:00
Jelmer Vernooij
c507ebe567 Patch from metze and me that adds dummy smb_register_*() functions so
that is now possible to, for example, load a module which contains
an auth method into a binary without the auth/ subsystem built in.
(This used to be commit 74d9ecfe2d)
2003-05-10 10:53:48 +00:00
Volker Lendecke
d1da999e0a This puts real netlogon connection caching to winbind. This becomes
important once we start doing schannel, as there would be a lot more
roundtrips for the second PIPE open and bind. With this patch logging
in to a member server is a matter of two (three if you count the
ack...) packets between us and the DC.

Volker
(This used to be commit 5b3cb7725a)
2003-05-08 08:02:52 +00:00
Tim Potter
9784320676 Merge:
> Perform lp_load() before popt to fix -W option.
(This used to be commit f8db590b07)
2003-04-28 07:05:50 +00:00
Tim Potter
d31cb1b468 Perform lp_load() before popt to fix -W option.
(This used to be commit d20f4bf5d8)
2003-04-28 07:03:08 +00:00
Tim Potter
507cdd1996 Merge:
>Patch from waider to set exit code of last executed command specified
>as an argument to -c.
(This used to be commit b1ad692688)
2003-04-28 05:54:37 +00:00
Tim Potter
ee007fc7b8 Merge from HEAD:
>Return NT_STATUS_UNSUCCESSFUL if the sourcedata and echodata rpcs
>return unexpected data.
>
>Closes bug #2.
(This used to be commit 2e5f75beaf)
2003-04-28 03:36:01 +00:00
Tim Potter
39fbda7f03 Return NT_STATUS_UNSUCCESSFUL if the sourcedata and echodata rpcs
return unexpected data.

Closes bug #2.
(This used to be commit 0c3314ab97)
2003-04-28 03:33:56 +00:00
Andrew Bartlett
2a3a9f0bf4 Merge the 'safe' parts of my StrnCpy patch - many of the users really wanted
a pstrcpy/fstrcpy or at most a safe_strcpy().

These have the advantage of being compiler-verifiable.

Get these out of the way, along with a rewrite of 'get_short_archi' in the
spoolss client and server.  (This pushes around const string pointers, rather
than copied strings).

Andrew Bartlett
(This used to be commit 32fb801ddc)
2003-04-23 13:27:35 +00:00
Tim Potter
1fe7ec8b4b Patch from waider to set exit code of last executed command specified
as an argument to -c.
(This used to be commit 048aeefcdc)
2003-04-23 07:10:28 +00:00
Andrew Bartlett
f071020f5e Merge from HEAD - save the type of channel used to contact the DC.
This allows us to join as a BDC, without appearing on the network as one
until we have the database replicated, and the admin changes the configuration.

This also change the SID retreval order from secrets.tdb, so we no longer
require a 'net rpc getsid' - the sid fetch during the domain join is sufficient.
Also minor fixes to 'net'.

Andrew Bartlett
(This used to be commit 876e00fd11)
2003-04-21 14:09:03 +00:00
Andrew Bartlett
2cb0b91ed1 Store the type of 'sec channel' that we establish to the DC. If we are a
workstation, we have to use the workstation type, if we have a BDC account,
we must use the BDC type - even if we are pretending to be a workstation
at the moment.

Also actually store and retreive the last change time, so we can do
periodic password changes again (for RPC at least).

And finally, a couple of minor fixes to 'net'.

Andrew Bartlett
(This used to be commit 6e6b7b79ed)
2003-04-16 10:20:14 +00:00
Tim Potter
c182b78639 Merge: remove unused variable.
(This used to be commit 6a1d99d318)
2003-04-14 05:26:30 +00:00
Tim Potter
69605f6fa9 Removed unused variable.
(This used to be commit 117cc35dd0)
2003-04-14 05:22:17 +00:00
Tim Potter
c967d21ca7 Merge Jelmer's popt updates from HEAD.
Also merged a bunch of other random changes as this file has
been drifting off due to lack of janitors.
(This used to be commit 38337ec5ef)
2003-04-14 03:31:19 +00:00
Tim Potter
3b865c7398 Merge of rpcecho pipe for testing large dcerpc requests and responses.
Only compiled in when --enable-developer argument passed to configure.
(This used to be commit 017da9393b)
2003-04-14 02:08:03 +00:00
Tim Potter
cb621ec3a6 Merge of samr lookup domain rpc client call from HEAD.
(This used to be commit 5b1807dddf)
2003-04-14 01:17:05 +00:00
cvs2svn Import User
a47d06a2c2 This commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.(This used to be commit 381649916e) 2003-04-13 13:50:46 +00:00
Tim Potter
065561932c A new RPC pipe! The \pipe\echo named pipe is for testing large RPC
requests and responses and is only compiled in when --enable-developer
is passed to configure.  It includes server and client side code for
generating and responding to functions on this pipe.  The functions are:

 - AddOne: add one to the uint32 argument and return ig
 - EchoData: echo back a variable sized char array to the caller
 - SourceData: request a variable sized char array
 - SinkData: send a variable sized char array and throw it away

There's a win32 implementation of the client and server in the
junkcode CVS repository in the rpcecho-win32 subdirectory.
(This used to be commit 4ccd34ef83)
2003-04-11 04:09:14 +00:00
Volker Lendecke
7238bf5f40 This is the netlogon schannel client code. Try a
rpcclient -S pdc -U% -c "samlogon user password"

and it should work with the schannel. Needs testing against platforms
different from NT4SP6.

Volker
(This used to be commit eaef0d8aef)
2003-04-09 15:54:17 +00:00
Volker Lendecke
803e23f403 This is the netlogon schannel client code. Try a
rpcclient -S pdc -U% -c "samlogon user password"

and it should work with the schannel. Needs testing platforms
different from NT4SP6.

Volker
(This used to be commit ecd0ee4d24)
2003-04-09 15:47:06 +00:00
Tim Potter
0bcc0c343f SAMR lookupdomain rpc client patches from amber palekar <amber@nu3.net>
(This used to be commit 67bc6bccc2)
2003-04-04 00:52:42 +00:00
Tim Potter
676e2707e8 This file deleted in HEAD.
(This used to be commit 6174560e50)
2003-04-02 06:00:41 +00:00
Jelmer Vernooij
41a09c3c53 Revoke some of the popt patch from metze I applied earlier today. It added
some double options and broke some parameters.
(This used to be commit d5f9b0275c)
2003-03-24 14:15:14 +00:00
Jelmer Vernooij
11e9de855c Patch from metze to generalise POPT_COMMON_SAMBA, with some minor changes
(This used to be commit 2ddfed298d)
2003-03-24 11:25:34 +00:00
Tim Potter
417bf608f4 Merge of waider's rpcclient return type patch.
(This used to be commit fb91bfa7a2)
2003-03-18 06:30:30 +00:00
Tim Potter
e6d438c2db Merge of enumdomusers rpcclient command.
(This used to be commit 8cabdd635d)
2003-03-18 06:11:17 +00:00
Tim Potter
1eae003fef Applied waider's patch to return DOS error codes for pipes that
support it.
(This used to be commit ac3df9a805)
2003-03-17 05:55:41 +00:00
Martin Pool
4724780212 Patch from Ronan Waide:
> when doing "enumdomusers", rpcclient prints each one preceded by the
> word "group" instead of "user"
(This used to be commit 0e9a2f41df)
2003-03-11 03:41:21 +00:00
Martin Pool
2e3f9c35d5 Patch from Ronan Waide:
> when doing "enumdomusers", rpcclient prints each one preceded by the
> word "group" instead of "user"
(This used to be commit 17567dd1d5)
2003-03-11 00:14:55 +00:00
Andrew Bartlett
80087e6cfe safe_strcpy() -> fstrcpy() fix, and a cleanup to how rpcclient calls the
IP address resolving code.
(This used to be commit 1f605fe77c)
2003-03-07 09:25:48 +00:00
Tim Potter
4c8091ef9c Use PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinter
command.  From Ronan Waide <waider@waider.ie>.
(This used to be commit 992b5eb4e0)
2003-03-05 05:14:19 +00:00
Tim Potter
130d49aa6b Merge: const fixes.
Merge: add popt_common_version to command line options table.

Merge: mbp's rewrite of do_cmd()
(This used to be commit 20f153cee3)
2003-02-25 23:53:38 +00:00
Tim Potter
1788f806e7 Merge: const fixes.
(This used to be commit a20aba0999)
2003-02-25 23:51:56 +00:00
Tim Potter
991f6cc3c1 More const fixes and flow on fixes from yesterday's const-fest.
(This used to be commit 018733eedd)
2003-02-25 23:34:57 +00:00
Tim Potter
3a2f56cb63 Fixed up some const related compiler warnings.
(This used to be commit 923425e497)
2003-02-25 06:24:13 +00:00
Tim Potter
696895d5b1 Added enumdomusers command.
(This used to be commit 30353da3e9)
2003-02-21 04:28:32 +00:00
Tim Potter
4834c61ebc Fix for only specifying one command with -c
(This used to be commit 7418351427)
2003-02-21 04:25:04 +00:00
Jelmer Vernooij
896e133c3c Remove obsolete files
(This used to be commit 1a68ead433)
2003-02-20 19:13:37 +00:00
Jelmer Vernooij
9d913a62ad Remove obsolete files
(This used to be commit f035cba2cf)
2003-02-20 19:10:19 +00:00
Tim Potter
39cf300869 Merge typo fix.
(This used to be commit 7406fabe7c)
2003-02-19 22:54:21 +00:00
Tim Potter
7024ab8dca Merge NTSTATUS vs WERROR return for cli_srvsvc_net_srv_get_info()
(This used to be commit 7edaf93796)
2003-02-19 22:52:50 +00:00
Jelmer Vernooij
5eb7b6113b Add -V option (to print out version) to utilities where possible
(pdbedit already has a -V option..)
(This used to be commit 5de622968d)
2003-02-18 18:43:59 +00:00
Martin Pool
188c5195ed Check return code of string_to_sid. (Merge from HEAD)
(This used to be commit 5d09aea6f7)
2003-02-18 07:05:02 +00:00
Martin Pool
7741d66b18 Doxygen janitor. No other changes.
(This used to be commit 735c99dadb)
2003-02-18 01:55:50 +00:00
Martin Pool
05e3070b23 cmd_lsa_lookup_sids: Check return code from string_to_sid; skip SIDs
which are not valid.
(This used to be commit bfb6104521)
2003-02-18 01:35:19 +00:00
Volker Lendecke
0cf080f719 Dummy commit, I can't get through to samba-cvs@samba.org. It can't really
remember under what mail address I have to post.

My last commit to this file made it compile again, my fingers were a bit
too fast to really type this message.

Sorry for this confusion,

Volker
(This used to be commit 3b905f5a16)
2003-02-17 21:12:21 +00:00
Volker Lendecke
bf89801bd2 cmd_srvsvc.c
(This used to be commit fcfbb3c430)
2003-02-17 21:04:09 +00:00
Martin Pool
f203f1643c Typo: /mized/mixed/
(This used to be commit ada36d2fe3)
2003-02-17 06:54:43 +00:00
Martin Pool
645d68a45a Don't pstrcpy into an fstring. (Harmless in this case since it comes
from an environment variable.)
(This used to be commit 9f9077346b)
2003-02-17 06:28:58 +00:00
Martin Pool
541ed81a63 Start reworking rpcclient to use popt rather than next_token to parse
command lines.  This makes the code much simpler and also stops
trivial syntax errors from causing a crash.

Also fix support for semicolon-separated commands in -c, which is
promised by the manual but apparently never working due to an
off-by-one error.
(This used to be commit d85a25e733)
2003-02-17 05:42:36 +00:00
Andrew Bartlett
497470214d merge desired_access for open_printer_ex from HEAD, allowing cupsaddsmb to
work again!

Andrew Bartlett
(This used to be commit 94976a4128)
2003-02-12 11:23:24 +00:00
Andrew Bartlett
749d90dfc7 Match Samba 2.2 by chosing the correct desired access, and getting cupsaddsmb
back working again.

Andrew Bartlett
(This used to be commit 512e65a6a6)
2003-02-12 11:17:35 +00:00
Andrew Tridgell
6c66e42d2c added the 'lsaenumacctwithright' command to rpcclient. This allows you
to lookup what SIDs have a particular privilege (that is how
privileges are stored).
(This used to be commit 3ddb5fb0dd)
2003-02-10 11:31:23 +00:00
Jeremy Allison
f8601187ca Merge tpot's changes to request the correct sizes for user dispinfo
from HEAD. I had to do this for him as he was *so* tired, the poor
chap, plus he has this bad leg, plus the dog ate his homework etc. etc.
Jeremy.
(This used to be commit 1e752b48a1)
2003-01-29 20:15:35 +00:00
Jeremy Allison
ef49ed3e06 Remove NULL buffer checks before rpcstr_pull() as they're now done
inside this function. Merge from HEAD (tpot).
Jeremy.
(This used to be commit e20cb9ca55)
2003-01-29 06:53:07 +00:00
Tim Potter
7634efbfec Use new interface for cli_samr_query_dispinfo().
(This used to be commit d3962da61a)
2003-01-29 06:24:13 +00:00
Tim Potter
e536c2e9d3 Remove NULL buffer checks before rpcstr_pull() as they're now done
inside this function.
(This used to be commit cdc7c599c7)
2003-01-29 02:57:03 +00:00
Jeremy Allison
438b5c92d4 Merge tridge's client priv code from HEAD.
Jeremy
(This used to be commit 49739be1e2)
2003-01-29 02:24:12 +00:00
Andrew Tridgell
79b26867c0 added LsaRemoveAccountRights
this now gives us complete remove privileges control in the client
libs, so we are in good shape for starting on the server side.
(This used to be commit bf99440398)
2003-01-28 21:31:45 +00:00
Jeremy Allison
734c6d8a51 Merging tridge's privillage client changes from HEAD.
Jeremy.
(This used to be commit 30a33920b4)
2003-01-28 21:09:56 +00:00
Andrew Tridgell
5f9112ac1b cleaned up the lsa_enum_acct_rights function and added a
lsa_add_acct_rights function.

This allows us to add privileges remotely to accounts using rpcclient.
(This used to be commit 2e5e659e09)
2003-01-28 12:52:51 +00:00
Jim McDonough
e47fbbd37f revert accidentally committed changes
(This used to be commit 5d43346761)
2003-01-21 14:05:37 +00:00
Jim McDonough
19938c0d2c Properly display popt errors. Also fix debug to be -d for consistency with other progs.
(This used to be commit 97133f7168)
2003-01-21 13:58:16 +00:00
Andrew Tridgell
96c795cea7 reverted this patch till I sort out the craziness with UNIHDR
(This used to be commit e3d00fa47d)
2003-01-17 06:15:18 +00:00
Andrew Tridgell
ec879eacc2 This removes the 3rd argument from init_unistr2(). There were 240
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.

The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.

I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing.
(This used to be commit b9eff31b14)
2003-01-17 04:58:45 +00:00
Andrew Tridgell
70bf249cfb allow a couple of LSA functions to take a username instead of a SID,
They still accept a SID, it just can be tedious to have to type SIDs
instead of names all the time.
(This used to be commit 665cc9b1ac)
2003-01-16 04:14:59 +00:00
Gerald Carter
99cdb46208 *lots of small merges form HEAD
*sync up configure.in
*don't build torture tools in make all
*make sure to remove torture tools as part of make clean
(This used to be commit 0fb724b321)
2003-01-15 18:57:41 +00:00
Gerald Carter
4242eda183 merging some rpcclient and net functionality from HEAD
(This used to be commit 7a4c874842)
2003-01-15 17:22:48 +00:00
Gerald Carter
9eeab10e54 [merge]
* removed unused variable from rpcclient code
* added container option to net command (patch from SuSE)
* Makefile patch for examples/VFS from SuSE
(This used to be commit 25a9681ddd)
2003-01-15 16:10:57 +00:00
Gerald Carter
43e4cae106 * removed unused variable from rpcclient code
* added container option to net command (patch from SuSE)
* Makefile patch for examples/VFS from SuSE
(This used to be commit 4a6d8280ea)
2003-01-15 16:07:14 +00:00
Andrew Tridgell
eb6312af9f added cli_lsa_enum_account_rights() call. Note that this is in
principal similar to the existing cli_lsa_enum_privsaccount() call,
except that cli_lsa_enum_account_rights() doesn't require a call to
open_account first. There is also the minor matter that
cli_lsa_enum_account_rights() works whereas
cli_lsa_enum_privsaccount() doesn't!

this call can be used to find what privileges an account or group
has. This is a first step towards proper privileges support in Samba.
(This used to be commit 65bac11d71)
2003-01-15 07:40:40 +00:00
Andrew Bartlett
27b7e51a3c Merge from HEAD:
- fstring/pstring mixups
 - the detection code that found them (disabled)
 - a bit of whitespace
 - a static

Andrew Bartlett
(This used to be commit 9b70fa868e)
2003-01-14 08:53:59 +00:00
Andrew Bartlett
ad20186707 A couple more fstring/pstring issues - and move from sizeof(fstring) to
sizeof(var) in slprintf statements, so as to ensure we don't get mixups there.

Also remove fstrcpy() into a variable that is about to be printed into anyway.

Andrew Bartlett
(This used to be commit 9b76123732)
2003-01-11 12:18:57 +00:00
Tim Potter
4315edcdca Display an error message when the server cannot be resolved when running at
debug level 0.
(This used to be commit 451286febd)
2003-01-08 02:54:42 +00:00
Andrew Bartlett
b327f5ba53 Merge from HEAD - idra's fix for the fact that the shutdown command takes two 1
byte boolean flags, not a 16 bit bitmask.

Andrew Bartlett
(This used to be commit a4f7777ca0)
2003-01-04 07:50:04 +00:00
Andrew Bartlett
634c54310c Merge from HEAD - make Samba compile with -Wwrite-strings without additional
warnings.  (Adds a lot of const).

Andrew Bartlett
(This used to be commit 3a7458f947)
2003-01-03 08:28:12 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0ea)
2003-01-02 09:07:17 +00:00
Simo Sorce
60667264b7 the shutdown call does not have a 16 bit flags, but 2 byte representing booleans
this commit change the structure and code to reflect this

some test revelead I'm right.

some other revelead currently the abort shutdown does not work against my test machine even if it returns successfully ... need investigation
(This used to be commit c5892b656d)
2002-12-30 04:41:27 +00:00
Jeremy Allison
98ac4503ac Finish adding strings to all talloc_init() calls.
Jeremy.
(This used to be commit aa8439a49e)
2002-12-23 23:54:10 +00:00