1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Commit Graph

2788 Commits

Author SHA1 Message Date
Luke Leighton
1c330d5682 - todd sabin spotted bugs in samr enum dom users / groups / aliases code:
last count (probably an ENUM / resume handle) should always be returned
  even if there are no items being returned.

- got fed up of seven intendation levels in cmd_samr.c, maximum recommended
  in *any* code is three!  made some sub-fns instead.
0001-01-01 00:00:00 +00:00
Luke Leighton
073c8652c1 pass_check.c could receive encrypted password: printing it out as a %s
results in garbage.  with no password length argument doing dump_data(
100, password, strlen(password)) is the next best alternative.
0001-01-01 00:00:00 +00:00
Luke Leighton
e0b5a866ce oops, accidentally committed clear-text password reading last week. 0001-01-01 00:00:00 +00:00
Luke Leighton
188d9a75ed Bejamin Kuit. #define MYSQL and MYSQL_ROW to void iff <mysql.h> not found. 0001-01-01 00:00:00 +00:00
Luke Leighton
167b0b20e3 spelling mistake, #ifdef'd out for non-developers (oops!) 0001-01-01 00:00:00 +00:00
Luke Leighton
4e89fbb7d9 oops, put -DDEBUG_PASSWORD in wrong place. 0001-01-01 00:00:00 +00:00
Luke Leighton
eb63fbdb68 Benjamin Kuit's mods. 0001-01-01 00:00:00 +00:00
Luke Leighton
d59a2e669a Benjamin Kuit's latest mysql mods. issue with "make proto" needs to be
resolved.
0001-01-01 00:00:00 +00:00
Luke Leighton
511ef8a58c added <mysql.h> autoconf test. 0001-01-01 00:00:00 +00:00
Luke Leighton
fdf61e1dab Benjamin Kuit's MYSQL SAM Database implementation.
Copyright (C) Benjamin Kuit <bj@mcs.uts.edu.au> 1999.
0001-01-01 00:00:00 +00:00
Luke Leighton
8b859797aa improving syntax / useability of rpcclient "shutdown" command:
rpcclient [-m messsage] [-t timeout] [-r or --reboot].
0001-01-01 00:00:00 +00:00
Gerald Carter
644cda5d80 referred reader to NT Domain FAQ for more info (copy of update to 2.0) 0001-01-01 00:00:00 +00:00
Matthew Chapman
cb5428308d Return either STATUS_BUFFER_OVERFLOW or ERRDOS/ERRmoredata depending on
whether the client supports 32-bit error codes.
0001-01-01 00:00:00 +00:00
Matthew Chapman
d1cc33bcb6 Added "lookupdomain" rpcclient command. Not particularly useful currently
(you can do "lookupdomain MYDOMAIN" and "lookupdomain BUILTIN" and the
results won't be too surprising), but it will come in useful testing the
new password database code I'm working on.
0001-01-01 00:00:00 +00:00
Matthew Chapman
7d03e6e219 Win9x user level security.
* Added SAMR_LOOKUP_DOMAIN (-> SamrLookupDomainInSamServer)

* Added real SAMR_ENUM_DOM_GROUPS (corresponding to
SamrEnumerateGroupsInDomain). The existing one is just an alias for
SamrQueryDisplayInformation (see below).

* Added three extra info levels to SAMR_QUERY_DISPINFO. Info level 3 is
what was previously SAMR_ENUM_DOM_GROUPS; info levels 4 and 5 are
simple user/group list requests used by Win9x and I suspect (haven't
checked) the "low speed connection" User Manager.

* Added another two aliases for SAMR_QUERY_DISPINFO, opcodes 0x30 and
0x33. Usually the first is with info level 3 and the second 4 but there is
some overlap so indeed these should be implemented as just aliases.

* Return ERRDOS/ERRmoredata on extra data instead of
STATUS_BUFFER_OVERFLOW for Win95's benefit. On a named pipe this results
in an SMBreadX as usual.

Still need to fix SAMR_QUERY_DOMAIN_INFO which has a hard-coded number of
users and groups - which Win95 proceeds to truncate at.
0001-01-01 00:00:00 +00:00
Luke Leighton
ec1b7000fd added jeremy's new c++-like code for parsing of security descriptors. 0001-01-01 00:00:00 +00:00
Luke Leighton
e164b5080c samr_lookup_names "none found" error needed corrections with empty lists. 0001-01-01 00:00:00 +00:00
Luke Leighton
2d5fc5c7cf last unix group not being listed. spotted by jacques sansdrap. 0001-01-01 00:00:00 +00:00
Luke Leighton
66e2787ab7 problem been there for months: reg_r_info not aligning after string buffer. 0001-01-01 00:00:00 +00:00
Michael Warfield
329ceaee49 Got to the bottom of another weird one...
Piping the output of smbmount back to autofs/automount was causing the
automount process to hang.  Reason was that automount was depending
on the pipe to close to continue on, rather than detecting the child
signal.  This occured with debug enabled and the daemon process was not
closing the stdout process.  Disabling debuging avoids the problem.
Debugging is turned off in the cvs repository and a warning placed over
the debugging option.
0001-01-01 00:00:00 +00:00
Luke Leighton
59f081069a rpcclient shutdown command 0001-01-01 00:00:00 +00:00
Luke Leighton
ba5919bcae bitmap to strings 0001-01-01 00:00:00 +00:00
Matthew Chapman
ce24191939 Always null-terminate strings.
Also some string length and sizeof(pointer) corrections.
0001-01-01 00:00:00 +00:00
Matthew Chapman
b314430b21 Always null-terminate strings. 0001-01-01 00:00:00 +00:00
Michael Warfield
ad8389804c Added caching of user password if it was entered via getpass. We were already
caching the password if it came from the command line or from the environment.
This completes the set and deals with the bloody nusance when reconnecting
a connection after we have gone daemon...  Grrr...

Added code to clean up the mount point following a catastrophic failure
during reconnect.  The smbmount daemon was exiting but leaving the mount
point in an unusable state.  If smbmount must exit following a reconnect
failure, we "unmount" the mount point and clean up mnttab.  Currently,
the unmount works, fixing some really ugly I/O errors and failure when
trying to remount.  The cleanup on mnttab still has problems.  This
is better than what it was and doesn't break anything that wasn't broken
before, so I'm committing this in even with the mnttab problem.  Will
commit the fix to that when I figure out what is busted there...

	-mhw-
0001-01-01 00:00:00 +00:00
John Terpstra
1041d53ec2 Folding into Samba-2.1.X tree documents added to 2.0.3. 0001-01-01 00:00:00 +00:00
Michael Warfield
4b4a706213 Fixed a glibc glitch in smbumount.c and reenabled some debugging
in smbmount.c
0001-01-01 00:00:00 +00:00
Luke Leighton
dad5baef19 const cast issues. [p.s - tidy work, matt!] 0001-01-01 00:00:00 +00:00
Luke Leighton
98ecb88704 const issues with byte mod / byte read macros. 0001-01-01 00:00:00 +00:00
Matthew Chapman
9ea91d89d2 Cut and paste error. 0001-01-01 00:00:00 +00:00
Matthew Chapman
a1d39af1ce UNICODE cleanup (see lib/util_unistr.c).
No more ugly static library buffers and all functions take a destination
string length (especially unistrcpy was rather dangerous; we were only
saved by the fact that datagrams are limited in size).
0001-01-01 00:00:00 +00:00
Luke Leighton
6a437cfb33 UNICODE issues. 0001-01-01 00:00:00 +00:00
Luke Leighton
73db80f341 the UNICODE issue... 0001-01-01 00:00:00 +00:00
Luke Leighton
b5396d3c6d enum dom users buffer was 0x80 not 0x8000. must fix "enumeration" code
as you need to make multiple enum dom users calls.
0001-01-01 00:00:00 +00:00
Luke Leighton
c1d65e9060 refinement of random ipc$ SMBtrans torture test. send requests, and
don't wait for responses :-)
0001-01-01 00:00:00 +00:00
Luke Leighton
d77de86858 uninitialised pointer being freed if lookupnames failed. oops. 0001-01-01 00:00:00 +00:00
Luke Leighton
c5109ff782 use jeremy's versions of the UNICODE routines. 0001-01-01 00:00:00 +00:00
Luke Leighton
3072044134 Having Well-known Domain Groups ("Domain Admins/Guests/Users") returned
under SID_NAME_ENUM 0x5 instead of 0x2 (Well-known group instead of
Domain Group) was making it impossible to view these groups from USRMGR.EXE.
0001-01-01 00:00:00 +00:00
Luke Leighton
56469578a1 groups and aliases being "manually" added which do not necessarily have
representation in the underlying database: removed this code.

for example, with the nt->unix mapping system (don't know about the ldap
one) if you want "Domain Admins" to appear you _must_ put it in the
domaingroup.map file.

the previous code was adding builtin aliases and well-known groups even
if they weren't in the domain maps.  bad idea.
0001-01-01 00:00:00 +00:00
Luke Leighton
fcaa121441 when multiple independent large rpc calls come in on the same pipe,
prev_pdu_file_offset was not being re-initialised to zero.
0001-01-01 00:00:00 +00:00
Luke Leighton
ac72fe1ab3 removal of the use of unistrn2 function: replace it with unistr2_to_str
which is more appropriate.
0001-01-01 00:00:00 +00:00
Luke Leighton
ddd3501982 pwdb_smb_to_sam was not returning NULL for nt name so that
pwdb_sam_map_names() was using a "blank" static string instead of
a NULL pointer for nt names.  NULL means over-ride, so the nt name
got left as "blank".

this causes nt clients to terminate with extreme prejudice.
0001-01-01 00:00:00 +00:00
Matthew Chapman
30a085bf80 Fix for NT BSOD problem. There's no reason to have two "NT usernames" running
around anyway.

The real problem is, once again, the brokenness of pwdb_sam_map_names et al.
This time it is deciding to return blank NT usernames, which NT's redirector
objects to.

I'm currently working on improving the pwdb/mapping code, should be ready in a
couple of weeks.
0001-01-01 00:00:00 +00:00
Luke Leighton
9084b7e33d UNICODE byte ordering issue: typecast to uint16* replaced with SSVAL() 0001-01-01 00:00:00 +00:00
Luke Leighton
9ab81caa06 reload_services needs to be called prior to init_files but after
get_myname.
0001-01-01 00:00:00 +00:00
Luke Leighton
d455c9d2c9 iteration of sam passwd entries was an order n-cubed algorithm due
to resolution of unix name to nt name being unnecessarily _inside_
another loop.
0001-01-01 00:00:00 +00:00
Luke Leighton
ed128c38a8 initialise my name (used in %h) prior to loading smb.conf files. 0001-01-01 00:00:00 +00:00
Luke Leighton
62118e15fe %s not $s 0001-01-01 00:00:00 +00:00
Luke Leighton
5b9a7278da corrections to get data stream for 2nd and subsequent pdus copied from
right place (forgot to subtract 0x18 header bytes)
0001-01-01 00:00:00 +00:00
Luke Leighton
f7dfa55a2e cache unix groups so that two-level getgrent calls don't occur. 0001-01-01 00:00:00 +00:00