1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Commit Graph

141 Commits

Author SHA1 Message Date
Andrew Tridgell
fae84f98e3 libutil: moved the networking defines to util_net.h
These were causing thousands of warnings on solaris8
2010-03-26 17:36:02 +11:00
Kamen Mazdrashki
aa572a4334 s4/drs: Pretty print for drsuapi_SecBufferType
It is a type and mask combined in one DRS field so
we have to make a custom ndr_print implementation for this type
2010-03-24 17:34:44 +02:00
Kamen Mazdrashki
fbaf3b3799 s4/drs: pretty print for drsuapi_DsAddEntry_AttrErrListItem_V1 2010-03-24 17:34:38 +02:00
Andrew Tridgell
55c45110e6 charset: fixed a problem with the global use of the iconv_convenience structure
We had a crash bug where a cached copy of a iconv convenience pointer
was used after being freed when loadparm asked for iconv to
reload. This could happen if a python module used a iconv based
function before loadparm was completed.

The fix is to ensure that any use of this pointer remains valid, by
reusing the pointer itself when it has already been initialised, but
filling in the child elements with the updated values.
2010-03-18 14:18:41 +11:00
Günther Deschner
0e779b573b spoolss: rollback GetPrinterData[Ex] IDL.
Guenther
2010-03-05 15:17:59 +01:00
Günther Deschner
0528515be4 spoolss: rollback SetPrinterData{Ex} IDL.
Guenther
2010-03-05 15:17:58 +01:00
Andrew Bartlett
a7036a9e47 librpc/ndr Remove unused macros
Since the change to the way we pull these OIDs from the wire, these
macros are unused.

Andrew Bartlett
2010-02-20 17:59:13 +11:00
Stefan Metzmacher
76aa37f653 librpc/ndr: don't overwrite the content in ndr_push_relative_ptr2_end()
metze
2010-02-19 08:12:42 +01:00
Günther Deschner
0a8011aa98 spoolss: use ndr_push_spoolss_PrinterInfo2 hand-marshalled version (moves devmode relative pointer down to sd).
Guenther
2010-02-18 15:47:59 +01:00
Günther Deschner
2881742493 spoolss: add spoolss_security_descriptor.
Guenther
2010-02-18 15:47:59 +01:00
Stefan Metzmacher
2059a165ee ndr_spoolss_buf: use LIBNDR_FLAG_NO_NDR_SIZE in NDR_SPOOLSS_SIZE_*
metze
2010-02-18 15:47:57 +01:00
Stefan Metzmacher
a4c3aeb793 spoolss: use subcontext in NDR_SPOOLSS_PUSH_ENUM_OUT macro.
metze
2010-02-18 15:47:56 +01:00
Stefan Metzmacher
8310f02414 libndr: fix ndr_size_* calculation with relative reverse buffers
metze
2010-02-18 15:47:52 +01:00
Stefan Metzmacher
4a76d29374 libndr: for now align reverse relative pointers to 2 bytes by default.
This is just a hack and we should let the callers use FLAG_ALIGN2
explicit in future.

metze
2010-02-18 13:44:04 +01:00
Stefan Metzmacher
31c7780c16 libndr: implement LIBNDR_RELATIVE_REVERSE handling
This is based on Guenther's initial code.

metze
2010-02-18 13:44:03 +01:00
Günther Deschner
05347754ee libndr: store a subcontext buffer size in ndr_push_subcontext_start.
Guenther
2010-02-18 13:44:03 +01:00
Stefan Metzmacher
b5f9c44da5 libndr: give an error when ndr_push_relative_ptr2_start()/_end() is used with the RELATIVE_REVERSE flag
metze
2010-02-18 13:44:03 +01:00
Günther Deschner
a2c34296fa libndr: add LIBNDR_FLAG_NO_RELATIVE_REVERSE so that relative reverse processing
can be disabled for single structure elements.

Guenther
2010-02-18 13:44:02 +01:00
Günther Deschner
ee13a51b05 libndr: add LIBNDR_FLAG_RELATIVE_REVERSE flag.
Guenther
2010-02-18 13:44:02 +01:00
Günther Deschner
c9fa97b017 libndr: change subcontext buffer allocation to allocate on subcontext_start.
Guenther
2010-02-18 13:44:01 +01:00
Stefan Metzmacher
98e143cd31 librpc/ndr: make ndr_push_relative_ptr2() static
metze
2010-02-18 13:44:01 +01:00
Stefan Metzmacher
e03591111a librpc/ndr_krb5pac: use ndr_push_relative_ptr2_start()/_end()
metze
2010-02-18 13:44:01 +01:00
Stefan Metzmacher
b423bd2115 librpc/ndr_drsblobs: use ndr_push_relative_ptr2_start()/_end()
metze
2010-02-18 13:44:00 +01:00
Günther Deschner
bfd6edb3e9 spoolss: fix relative pointers in ndr_push_spoolss_DriverInfo101.
Guenther
2010-02-18 13:44:00 +01:00
Günther Deschner
bc20d3446a libndr: add ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.
Guenther
2010-02-18 13:43:59 +01:00
Günther Deschner
7e328e1e1c spoolss: regenerate hand-marshalled ndr_pull_spoolss_DriverInfo101 after ndr64 changes.
Guenther
2010-02-12 11:34:56 +01:00
Günther Deschner
95846bfee6 spoolss: make sure hand-marshalled spoolss_DriverInfo101 handles relative_highest_offset.
Guenther
2010-02-12 11:34:48 +01:00
Günther Deschner
8f07339b6d spoolss: regenerate hand-marshalled ndr_push_spoolss_DriverInfo101 after ndr64 changes.
Guenther
2010-02-12 11:34:39 +01:00
Kamen Mazdrashki
20db3211ae s4/drsblobs: Custom ndr_print_ implementation for drsuapi_MSPrefixMap_Entry
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-02-01 15:23:30 +01:00
Andrew Tridgell
a106fefcfb librpc: fixed the GUID_compare() function
When comparing two unsigned values you can't just subtract
them.

Imagine you are comparing: "uint32_t u1" and "uint32_t u2". If you use
"u1 - u2" and u2 is zero, then the signed integer result will depend
on the top bit of u1.

This error occurs in a few places in Samba. For DRS replication it
resulted in corrupt uptodateness vectors.
2009-12-21 23:41:07 +11:00
Brian Lu
a3b7e84a65 librpc/ndr: avoid comparison_fn_t to fix the openchange build on solaris
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-12-14 11:08:45 +01:00
Stefan Metzmacher
05effef1aa librpc/ndr: add missing prototypes for relative_short functions
metze
2009-12-14 10:58:31 +01:00
Günther Deschner
e316624ddb spoolss: fix spoolss_PrinterData size calculation.
Currently we were crashing in EnumPrinterDataEx when an e.g. an empty (NULL)
string for a separator file was returned.

Guenther
2009-12-14 10:39:34 +01:00
Matthieu Patou
f0054da041 librpc/ndr: add support for relative_short pointers
relative_short is like relative but instead of having the offset coded on 4 bytes
it's coded on 2 bytes. Such things happen in GET_DFS_REFERAL messages.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2009-12-12 10:21:22 +01:00
Günther Deschner
835e7d6c98 spoolss: remove unused spoolss_StringArray2.
Guenther
2009-12-10 17:48:50 +01:00
Andrew Tridgell
3ce800dcbe libndr: added a GUID_to_ndr_blob() helper function
This can be used in many places that deal with GUIDs
2009-12-10 17:51:28 +11:00
Andrew Tridgell
effff54426 librpc: split out a separate GUID_from_ndr_blob() function
This will simplify many of the places that deal with NDR formatted
GUIDs
2009-12-10 17:51:26 +11:00
Günther Deschner
08823166a1 spoolss: rework spoolss_GetPrinterDataEx and spoolss_SetPrinterDataEx.
Guenther
2009-12-07 14:42:12 +01:00
Günther Deschner
f32ccc321a spoolss: hand-marshall the spoolss_StringArray2 struct for spoolss_EnumPrinterKey.
This call is just driving me nuts :-)

Guenther
2009-12-03 01:04:02 +01:00
Günther Deschner
292af4fc04 spoolss: add spoolss_StringArray2.
The difference to spoolss_StringArray is that in spoolss_StringArray2 the string
array is put into a subcontext of _ndr_size.

Guenther
2009-12-02 14:37:02 +01:00
Günther Deschner
b852a3494a drsuapi: fix build warning of NDR size calculation of drsuapi_DsReplicaObjectIdentifier3Binary.
The generated size actually does not include the size of the binary itself.

Guenther
2009-12-01 00:36:50 +01:00
Stefan Metzmacher
4b6c03a108 librpc/ndr: remember the highest offset we parsed with relative pointer buffers
ndr_*_pull_blob_all() will now work if relative pointers are used.

metze
2009-11-20 13:48:35 +01:00
Andrew Bartlett
fd5174e88c lib/util Split data_blob_hex_string() into upper and lower
Rather than have a repeat of the bugs we found at the plugfest where
hexidecimal strings must be in upper or lower case in particular
places, ensure that each caller chooses which case they want.

This reverts most of the callers back to upper case, as things were
before tridge's patch.  The critical call in the extended DN code is
of course handled in lower case.

Andrew Bartlett
2009-11-12 16:34:01 +11:00
Volker Lendecke
dd0e16b1d5 uuid.c: Remove some dead code 2009-11-01 23:50:04 +01:00
Stefan (metze) Metzmacher
25f96a4058 Add in Metze's new code to ndr encode the user.DOSATTRIB
blobs. Next I'll change the create timestamp and dos attribute
code to use this.
2009-10-28 15:42:47 -07:00
Kamen Mazdrashki
7e8fb4ad06 s4/drs(NDR): Print implementation for drsuapi_DsReplicaOID
Custom ndr_print functions is implemented so that transmited
partia-binary-oid to be printed both in hex and
partial-oid formats
2009-10-16 12:54:13 +03:00
Kamen Mazdrashki
4bfd132b08 s4/drs(NDR): Remove push/pull code for drsuapi_DsReplicaOID struct
New structure definition is automarshaled so custom marshaling
code is not used anymore
2009-10-16 12:54:13 +03:00
Andrew Tridgell
2bf8a7485c pidl: get the alignment right for uint1632 enums (NDR64)
The default enum in NDR63 is 32 bits, not 16 bits. We need a uint1632
type to get the alignment right.
2009-10-07 09:56:22 +11:00
Günther Deschner
76feeb1b97 libndr: add int3264 ndr prototype.
Guenther
2009-10-05 15:10:35 +02:00
Andrew Tridgell
f21fb4b395 pidl: added int3264 as a base type
This is the type used for a variable that is 32 bits for NDR32 and 64
bits for NDR64
2009-10-03 18:17:23 +10:00