sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-31 17:18:04 +03:00
Code
116,020 Commits 60 Branches 1,144 Tags 452 MiB
c93430fe8f
Commit Graph

1216 Commits

Author SHA1 Message Date
Aurélien Aptel
45a45c8eda implement argument parsing, split client_proto.h 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
eebd378b6c client.c: remove trailing whitespace 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
342d38eb4b clitar.c: start of argument parsing 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
b9b5bc433d clitar.c: add doc, remove _t suffix in enum name 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
a896f046fe clitar.c: add cmd_setmode(), remove typedef 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
1d142c6237 clitar.c: expand context structure and implement cmd_block() 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
2945596011 clitar.c: fresh new compilable file. 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:25 +01:00
Garming Sam
f548585051 param: rename lp function and variable from "cli_maxprotocol" to "client_max_protocol" 
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-02-07 16:19:15 -08:00
Gregor Beck
f959dd44a0 client: use cli_qpathinfo3 for allinfo 
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2013-10-30 15:23:51 -07:00
Gregor Beck
7e35a4dc73 client: remove a write only variable 
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2013-10-30 15:23:51 -07:00
Jeremy Allison
75f353b857 s3: libsmb - 10150 - Not all OEM servers support the ALTNAME info level. 
Sigh. Some OEM servers return NT_STATUS_NOT_IMPLEMENTED not
NT_STATUS_NOT_SUPPORTED.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
 2013-09-18 08:58:30 -07:00
Jeremy Allison
17a9a0f37b s3: libsmb : Bug 10150 - Not all OEM servers support the ALTNAME info level. 
Just ignore and print error message and an altname of "" if the
server returns NT_STATUS_NOT_SUPPORTED.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 17 23:40:08 CEST 2013 on sn-devel-104
 2013-09-17 23:40:08 +02:00
Michael Adam
db1d0349c4 client: add missing newlines to error messages for invalid iosize parameter. 
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Aug 21 21:49:45 CEST 2013 on sn-devel-104
 2013-08-21 21:49:44 +02:00
Jeremy Allison
d9c88a56dc Add new "timeout" command and -t option to smbclient to set the per-operation timeout. 
This is needed as once SMB3 encryption is selected the server
response time can be very slow when requesting large numbers
(256) of large encrypted packets (1MB) from a Windows 2012
virtual machine. This allows clients to tune their allowable
wait time.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
 2013-08-21 17:28:55 +02:00
Jeremy Allison
25521c9085 Remove restrictions on setting iosize inside smbclient for SMB2 connections. 
Also remove the SMB1 restriction to minimum iosize of 16384 (0x4000):
Now values >= 0 and <= 0xFFFF00 can be set for SMB1, 0 meaning server
defined behaviour. 0 is the new default for iosize, both for SMB1 and SMB2.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
 2013-08-21 17:28:54 +02:00
Stefan Metzmacher
2394f8788d s3:client: fix compiler warning 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2013-08-15 09:07:06 +02:00
Stefan Metzmacher
9b4692f2d0 s3:client: use the default io size 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2013-08-15 09:07:06 +02:00
Stefan Metzmacher
861ee9319f s3:client: avoid interpret_protocol() 
lp_set_cmdline("client max protocol",...) and
lp_cli_maxprotocol() are the more generic solution.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2013-08-15 09:07:05 +02:00
Günther Deschner
9813fe2b04 s3-rpc_cli: pass down ndr_interface_table to cli_rpc_pipe_open_noauth(). 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2013-08-05 10:30:00 +02:00
David Disseldorp
398ee49bda s3/smbclient: fix incorrect command tab completions 
smbclient commands can offer tab-completion for local and remote paths.
This behaviour is specified for the first two arguments using the
compl_args entry in the commands struct.
This change fixes a number of incorrectly specified compl_args values.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Jun 24 19:32:54 CEST 2013 on sn-devel-104
 2013-06-24 19:32:53 +02:00
Andreas Schneider
90cbfc96d1 Make sure to set umask() before calling mkstemp(). 
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Mar  6 01:16:34 CET 2013 on sn-devel-104
 2013-03-06 01:16:34 +01:00
David Disseldorp
64eba0a842 BUG 9633: Recursive mget should continue on EPERM. 
Regression introduced by 14ff2e8de9.
When downloading files recursively, smbclient halts if it encounters
a folder to which it does not have permission to traverse.

Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Feb  7 15:50:36 CET 2013 on sn-devel-104
 2013-02-07 15:50:36 +01:00
Scott Lovenberg
bd18d996e2 Clean up client timeout definitions [rev. 2] 
The definitions for default client timeout values have been moved to client.h.  When initializing a client struct we use this value instead of the old hardcoded value.  The timeout value remains 20 seconds.

Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com>
Reviewed by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Dec  6 03:25:58 CET 2012 on sn-devel-104
 2012-12-06 03:25:58 +01:00
Andreas Schneider
85b1b840cb smbclient: Use new samba_getpass() function. 
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
 2012-12-03 14:35:08 +01:00
Andreas Schneider
50d47fc081 s3fs-client: Burn commandline password of client utils. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov  8 21:24:21 CET 2012 on sn-devel-104
 2012-11-08 21:24:21 +01:00
Andrew Bartlett
c4f143f9d7 client: Fix talloc_stackframe() free order assertion in developer mode 
Reported-by: Ricky Nance <ricky.nance@weaubleau.k12.mo.us>
 2012-09-25 14:43:01 +10:00
Christian Ambach
cf7f68503d s3:client use more access bits for snapshot display 
otherwise Windows server will reject the request for shadow copy enumeration
with access denied
 2012-09-10 17:58:19 +02:00
Salvador I. Gonzalez
4e4c3062bc Fix smbclient/tarmode panic on connecting to Windows 2000 clients. 
'Freed frame ../source3/libsmb/clilist.c:934, expected ../source3/client/clitar.c:821'
  Cause: (strequal(finfo->name,"..") || strequal(finfo->name,"."))
    evaluates to true, do_tar returns without freeing ctx

Signed-off-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Aug 13 23:12:50 CEST 2012 on sn-devel-104
 2012-08-13 23:12:50 +02:00
Jeremy Allison
b70f23c2b5 Correctly check for errors in strlower_m() returns. 2012-08-09 12:08:18 -07:00
Andrew Bartlett
cf9bd1d9ed s3-param: Make lp_name_resolve_order() return a list 
This allows this parameter, one of the few with differing declarations
between the loadparm systems, to be brought into common.

Andrew Bartlett

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
 2012-07-19 08:02:32 +02:00
Rusty Russell
fe72740e82 loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *. 
They use talloc_tos() internally: hoist that up to the callers, some
of whom don't want to us talloc_tos().

A simple patch, but hits a lot of files.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2012-07-18 15:07:23 +09:30
Rusty Russell
dcec7c1f71 source3/client/client.c: fix stackframe leak. 
do_message_op() doesn't free its stackframe in various paths.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2012-07-18 04:59:31 +09:30
Luk Claes
d8c0646a5d s3:libsmb: get rid of cli_state_protocol 
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2012-05-28 14:49:45 +02:00
Luk Claes
4f6f4ea93c s3:libsmb: get rid of cli_state_remote_name 
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2012-05-28 14:49:45 +02:00
Jeremy Allison
0fefe24d6f Fix bug #8922. 
Looking at the do_list status returns was historically
ignored, allowing tar to continue after NT_STATUS_ACCESS_DENIED.
Return to this state.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 11 14:55:53 CEST 2012 on sn-devel-104
 2012-05-11 14:55:53 +02:00
Volker Lendecke
a8e9242a10 s3: Fix smbclient notify against Windows 
We need READ_DATA

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Apr 16 21:27:54 CEST 2012 on sn-devel-104
 2012-04-16 21:27:54 +02:00
Andrew Bartlett
6aa12fcb30 build: Remove SMB_OFF_T, replace with off_t 
Now that we always require a 64 bit off_t, we no longer need SMB_OFF_T.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Apr  6 01:47:43 CEST 2012 on sn-devel-104
 2012-04-06 01:47:43 +02:00
Andrew Bartlett
f6e0532024 build: Remove SMB_STRUCT_DIR define 2012-04-05 02:39:09 +02:00
Andrew Bartlett
3e8a6e5760 build: Remove sys_closedir wrapper 2012-04-05 02:39:09 +02:00
Andrew Bartlett
fe526bb32b build: Remove sys_opendir wrapper 2012-04-05 02:39:09 +02:00
Andrew Bartlett
d166b79852 build: Remove sys_open wrapper 2012-04-05 02:39:08 +02:00
Andrew Bartlett
9cc056e567 build: Remove sys_creat wrapper 2012-04-05 02:39:08 +02:00
Andrew Bartlett
43e9be8894 build: Remove sys_lseek wrapper 2012-04-05 02:39:08 +02:00
Jelmer Vernooij
c0288e0612 lib/util: Remove obsolete sys_getpid() and sys_fork(). 
The performance of these is minimal (these days) and they can return
invalid results when used as part of applications that do not use
sys_fork().

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 21:55:41 CET 2012 on sn-devel-104
 2012-03-24 21:55:40 +01:00
Christian Ambach
80cb6e84de s3:client correct a wording 2012-03-22 18:41:22 +01:00
Volker Lendecke
42cb8ff71c s3: Add "notify" cmd to smbclient 
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Mar 22 13:51:50 CET 2012 on sn-devel-104
 2012-03-22 13:51:48 +01:00
Christopher R. Hertel (crh)
b5b204184a Rename obscure defined constants. 
Replaced the undescriptive SMB_PORT1 and SMB_PORT2 defined constants
with the slightly more descriptive names NBT_SMB_PORT and TCP_SMB_PORT.
Also replaced several hard-coded references to the well-known port
numbers (139 and 445, respectively) as appropriate.

Small changes to clarify some comments regarding the two transport
types.

Signed-off-by: Simo Sorce <idra@samba.org>

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Feb 16 08:29:41 CET 2012 on sn-devel-104
 2012-02-16 08:29:41 +01:00
Stefan Metzmacher
6b8a4c96e8 s3:client: ignore SMBecho errors (the server may not support it) (bug #8139) 
metze
 2012-01-31 21:53:25 +01:00
Stefan Metzmacher
27c686dd70 Revert "Fix bug #8139 - smbclient fails if server does not support Echo request." 
This reverts commit 1fdc96ecaf.

This is wrong in master as the error codes are different compared to
3.5.x. The correct way to handle this is to call cli_state_is_connected().

metze
 2012-01-31 21:53:25 +01:00
Jeremy Allison
1fdc96ecaf Fix bug #8139 - smbclient fails if server does not support Echo request. 
Based on work by Matthias Scheler <tron@NetBSD.org>

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jan 31 00:47:19 CET 2012 on sn-devel-104
 2012-01-31 00:47:19 +01:00
Volker Lendecke
e9d66999c6 Introduce dump_data_file 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 25 11:57:18 CET 2012 on sn-devel-104
 2012-01-25 11:57:18 +01:00
Masafumi Nakayama
909056a2da s3-cli: fix bug 563, >8GB tar on BE machines 
Borrows on existing patches proposed by Craig Barratt and Brad Ellis.

Signed-off-by: David Disseldorp <ddiss@suse.de>

Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Tue Jan  3 18:31:28 CET 2012 on sn-devel-104
 2012-01-03 18:31:28 +01:00
Jeremy Allison
c8a1082f2b Move the callers that need to use the new cli_open() back to calling 
it from cli_openx().
 2011-12-03 21:36:47 -08:00
Jeremy Allison
4e709dc42f Rename cli_open -> cli_openx. Prelude to replacing generic cli_open() 
with a call that uses NTCreateX in preference to OpenAndX.
 2011-12-03 21:13:08 -08:00
Jeremy Allison
3e0d923096 Ensure we map our own Samba return of ERRSRV, ERRunknownsmb 
on an unknown SMB request to NT_STATUS_NOT_IMPLEMENTED.
 2011-12-02 20:41:02 +01:00
Jeremy Allison
010566215b Convert smbclient to using NtCreateX by preference, fall back to openX on 
'not implemented' or similar error.
 2011-12-02 20:41:02 +01:00
Jeremy Allison
30d4484bf9 Add the "backup" toggle command to smbclient. In order for this to be 
really useful we need to change to using NTCreateX opens by default in
cli_open() and fall back to old OpenX calls instead of doing it the
other way around.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Dec  2 00:23:13 CET 2011 on sn-devel-104
 2011-12-02 00:23:13 +01:00
Stefan Metzmacher
694b7d6f77 s3:client: make use of cli_tree_connect() 
metze
 2011-11-24 19:02:33 +01:00
Stefan Metzmacher
ff66e521e0 s3:client: s/Undefined/SMB_SIGNING_DEFAULT/ 
metze
 2011-11-03 16:55:12 +01:00
Bram
d883cc664c Bug 7551: Return error of cli_push when 'put - /some/file' is used 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 29 23:47:02 CEST 2011 on sn-devel-104
 2011-09-29 23:47:02 +02:00
Stefan Metzmacher
58482494fd s3:clitar: remove unused/not existing extern variables 
metze
 2011-09-13 13:16:07 +02:00
Stefan Metzmacher
3e227d8544 s3:libsmb: pass CLI_FULL_CONNECTION_* flags via cli_connect_nb() 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep  8 10:21:50 CEST 2011 on sn-devel-104
 2011-09-08 10:21:50 +02:00
Stefan Metzmacher
5e59a36beb s3:client: make use of cli_state_protocol() 
metze
 2011-08-02 04:54:29 +02:00
Michael Adam
bff217cf4a s3:smbspool: use lp_load_client() 2011-07-28 11:17:27 +02:00
Michael Adam
0c55a7606f s3:smbclient: use lp_load_client() 2011-07-28 11:17:27 +02:00
Björn Baumbach
78f267df69 s3-client/client.c: replace cli_query_secdesc_old() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-23 09:30:38 +02:00
Björn Baumbach
768646c9a2 s3-libsmb: rename cli_query_secdesc() to cli_query_secdesc_old() 
Will introduce new cli_query_secdesc() function

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-23 09:18:56 +02:00
Björn Baumbach
bffc521a8a s3-client/clitar.c: replace cli_read_old() with cli_read() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-23 09:18:26 +02:00
Stefan Metzmacher
9a3e15df7e s3:client: make use of cli_state_remote_name() 
metze
 2011-07-22 17:06:09 +02:00
Michael Adam
2b4bb9b7a1 s3:smbclient: print nt status code when smb echo fails 2011-07-22 15:42:17 +02:00
Michael Adam
d67a91b955 s3:smbclient: add a "tdis" command to view and change the tree id (tid). 
This low level command can be used to switch between tree connects in one
session.
 2011-07-22 15:42:17 +02:00
Michael Adam
7327bde81a s3:smbclient: add a "tdis" command to do a tree disconnect (close a connection to a share) 2011-07-22 15:42:17 +02:00
Michael Adam
88d0e44df3 s3:smbclient: add a "tcon" command to do a tree connect (connect to a share) 2011-07-22 15:42:16 +02:00
Michael Adam
281c6d02bd s3:smbclient: add "logoff" command to close the session 2011-07-22 15:42:16 +02:00
Stefan Metzmacher
25447a528a s3:libsmb: move cli->vuid to cli->smb1.uid and hide it behind cli_state_[g|s]et_uid() 
metze
 2011-07-21 22:08:52 +02:00
Björn Baumbach
9b168e128a s3-libsmb: replace cli_read() with cli_read_old() 
Will introduce new cli_read() function.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-20 22:09:25 +02:00
Jeremy Allison
ee34c25c8a First part of fix for bug 8310 - toupper_ascii() is broken on big-endian systems 
Remove
int toupper_ascii(int c);
int tolower_ascii(int c);
int isupper_ascii(int c);
int islower_ascii(int c);

and replace with their _m equivalents, as they are identical.
 2011-07-19 13:19:29 -07:00
Stefan Metzmacher
6ec26f0c1a s3:client: simplify readline_callback() to only use cli_echo() 
cli_echo() already swallows NBT keepalive messages,
so there's no need to filter them in the 'smbclient' layer.

metze
 2011-07-11 18:18:27 +02:00
Stefan Metzmacher
fccc607a5d s3:client: use an inbuf on the stack in readline_callback() 
metze
 2011-07-08 14:09:11 +02:00
Stefan Metzmacher
f0e6e5c37d s3:libsmb: remove unused enum smb_read_errors infrastructure 
metze
 2011-07-08 14:09:08 +02:00
Stefan Metzmacher
2b8e148084 s3:client: close the socket if receive_smb_raw() fails 
metze
 2011-07-08 14:09:08 +02:00
Stefan Metzmacher
0ecd15abe6 s3:client: use cli_nt_error() in order to avoid cli_errstr() 
metze
 2011-07-08 14:09:08 +02:00
Stefan Metzmacher
f5b0bbf108 s3:client: avoid cli_errstr() where we already have an NTSTATUS 
metze
 2011-07-08 14:09:07 +02:00
Stefan Metzmacher
5cc279eb34 s3:clitar: avoid usage of cli_errstr() 
metze
 2011-07-08 14:09:07 +02:00
Björn Baumbach
80c65416c1 s3-client: Remove use of cli_errstr() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-07 19:16:28 +02:00
Stefan Metzmacher
2b0cc3c412 s3:libsmb: use clistr_pull_talloc() in cli_get_fs_volume_info() 
metze
 2011-07-06 17:18:13 +02:00
Volker Lendecke
7d96a4594b s3: Remove cli_errstr from cmd_posix_open 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 09:45:11 CEST 2011 on sn-devel-104
 2011-07-06 09:45:11 +02:00
Volker Lendecke
c33a5a659c s3: Fix error logic in posix_open 2011-07-06 08:35:27 +02:00
Volker Lendecke
c1fdec7efc s3: Remove a few uses of cli_errstr 2011-07-06 08:35:27 +02:00
Volker Lendecke
26782fbbf3 s3: make cli_resolve_path return NTSTATUS 
This looks larger than it is. No parameters needed changing.
 2011-07-06 08:35:27 +02:00
Volker Lendecke
80838491e6 s3: Make cli_cm_open return NTSTATUS 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jul  3 23:57:53 CEST 2011 on sn-devel-104
 2011-07-03 23:57:53 +02:00
Volker Lendecke
e2498b1110 s3: Read symlink information in smbclient "allinfo" 2011-07-03 11:31:29 +02:00
Volker Lendecke
c8d374a0f2 s3: Fix an error message in smbclient symlink 2011-06-24 21:24:17 +02:00
Volker Lendecke
daec41c846 s3: Use reparse point style symlinks 2011-06-24 21:24:17 +02:00
Volker Lendecke
d637cd2380 s3: Remove a call to cli_errstr 2011-06-24 21:24:17 +02:00
Andrew Bartlett
74eed8f3ed s3-param Remove special case for global_myname(), rename to lp_netbios_name() 
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
 2011-06-09 12:40:09 +02:00
Andrew Bartlett
3ccc760947 s3-param Remove special case for lp_workgroup() 
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
 2011-06-09 12:40:09 +02:00
Andrew Bartlett
5e26e94092 s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array() 
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_ARRAY isn't standard talloc.
 2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653 s3-talloc Change TALLOC_ARRAY() to talloc_array() 
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
 2011-06-09 12:40:08 +02:00
Jeremy Allison
1cee71713f Change sys_getcd() to take no arguments and always return malloc'ed memory (or NULL). 
Part of the efforts to remove PATH_MAX on modern systems.
 2011-06-01 02:54:51 +02:00
Volker Lendecke
edfa62f2a0 s3: Use cli_connect_nb in do_message_op 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 10:11:54 CEST 2011 on sn-devel-104
 2011-05-29 10:11:54 +02:00
Björn Baumbach
26f7c0771b s3-client/clitar.c: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-05-18 10:55:15 +02:00
Günther Deschner
675573d54b s3-includes: finally only include client.h when libsmb is used. 
Guenther
 2011-05-06 16:37:22 +02:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h 
Guenther
 2011-05-06 16:37:18 +02:00
Jeremy Allison
9eee6e2fd2 More const fixes... getting near the end now. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 00:57:00 CEST 2011 on sn-devel-104
 2011-05-06 00:57:00 +02:00
Jeremy Allison
f85e095dd2 More simple const fixups. 2011-05-05 23:56:08 +02:00
Jeremy Allison
8380835fc6 Fix warning messages caused by addition of null check in fstrcpy macro. 2011-05-04 12:12:15 -07:00
Jeremy Allison
df023b8657 Tidy up some missing checks for NULL in strlcpy. 2011-05-04 12:12:15 -07:00
Jeremy Allison
6f7c4a0539 Convert safe_strXX to strlXXX. Clean up off-by-ones. 2011-05-04 12:12:15 -07:00
Jeremy Allison
0c464df22b Change safe_strcpy_base to strlcpy_base. Note the size doesn't change here as the original macro auto-added the -1. 2011-05-04 12:12:14 -07:00
Andrew Bartlett
724915f721 s3-client Add TALLOC_CTX argument to attrib_string(). 
This ensures the caller knows where the memory was allocated.

Andrew Bartlett
 2011-04-29 16:38:14 +10:00
Andrew Bartlett
0520da2bbe s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
0eca33bbf6 s3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
0a3c84b554 s3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
317e19aeb3 s3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:12 +10:00
Andrew Bartlett
7f66ebde2e s3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:12 +10:00
Volker Lendecke
0226428eb9 s3: Use cli_writeall instead of cli_write 
Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-26 12:22:55 -07:00
Volker Lendecke
25b43d317f s3: Use cli_ntcreate to when listing snapshots 
This works for directories as well

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 14:37:02 CEST 2011 on sn-devel-104
 2011-03-30 14:37:02 +02:00
Günther Deschner
2473c2fb1b s3-libsmb: put namequery headers to nmblib.h 
We might find a better name for it and merge other namequery related things as
well here...

Guenther
 2011-03-30 01:13:09 +02:00
Günther Deschner
0e771263ee s3-includes: only include system/filesys.h when needed. 
Guenther
 2011-03-30 01:13:07 +02:00
Günther Deschner
49fcf653b1 s3-includes: only include system/passwd.h when needed. 
Guenther
 2011-03-30 01:13:07 +02:00
Günther Deschner
99f4a64543 s3-trans2: only include trans2.h where needed. 
Guenther
 2011-03-30 01:13:06 +02:00
Volker Lendecke
7c868e6174 s3: Fix Coverity ID 83: RESOURCE_LEAK 2011-03-27 22:22:10 +02:00
Volker Lendecke
b47b4c9e3d s3: Remove two calls to cli_errstr 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 13:17:47 CEST 2011 on sn-devel-104
 2011-03-27 13:17:47 +02:00
Günther Deschner
7a91282c9f s3-libsmb: only include rap client when needed. 
Guenther
 2011-03-15 21:16:35 +01:00
Volker Lendecke
dee53e04ba s3: Print all flags in "smbclient allinfo" 2011-03-02 18:39:21 +01:00
Andreas Schneider
bf18403c81 s3-rpc_client: Move client pipe functions to own header. 2011-02-28 18:15:04 +01:00
Volker Lendecke
5b26cfe143 s3: Eliminate sys_select from do_smb_resolve() -- untested 2011-02-28 16:40:20 +01:00
Volker Lendecke
b28a2e519a s3: Eliminate sys_select from do_smb_browse() -- untested 2011-02-28 16:40:19 +01:00
Volker Lendecke
e6f8208358 s3: Eliminiate sys_select_intr from client.c 2011-02-28 16:40:19 +01:00
Björn Baumbach
07ccc2905d s3-smbclient: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 25 11:41:53 CET 2011 on sn-devel-104
 2011-01-25 11:41:53 +01:00
Björn Baumbach
09c612f377 s3-smbclient: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-01-25 10:45:22 +01:00
Volker Lendecke
d3abc90401 s3: Avoid a few calls to cli_errstr 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 08:47:25 CET 2011 on sn-devel-104
 2011-01-17 08:47:25 +01:00
Günther Deschner
fccfd29283 s3-smbclient: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:11:29 +01:00
Volker Lendecke
28d997a890 s3: AllowDebugChange is gone 2010-12-28 17:18:14 +01:00
Volker Lendecke
bfc4fe4012 s3: Remove unused "retry" from cli_start_connection 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Dec 20 17:58:33 CET 2010 on sn-devel-104
 2010-12-20 17:58:33 +01:00
Volker Lendecke
e0e4dc1c22 s3: Add shadow copy info to smbclient allinfo 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Nov 30 12:23:50 CET 2010 on sn-devel-104
 2010-11-30 12:23:50 +01:00
Volker Lendecke
ddd33f0351 s3: Make cli_set_ea_path return NTSTATUS 2010-11-11 16:16:24 +00:00
Andrew Bartlett
ed111d11eb s3-debug Move 'load_case_tables()' before lp_set_cmdline() and popt calls 
The problem here is that we cannot run lp_set_cmdline() (directly or
indirectly via the popt helpers) until load_case_tables() has been run.

However, load_case_tables does not have auto-initialisation, so we
must init it once, and once only.

Andrew Bartlett
 2010-11-02 04:36:04 +00:00
Andrew Bartlett
cf4de8ec2c s3-debug Remove 'AllowDebugChange' and use lp_set_cmdline() instead 
By removing this global variable, the API between the two different
debug systems is made more similar.  Both s3 and s4 now have
lp_set_cmdline() which ensures that the smb.conf cannot overwrite
these the user-specified log level.

Andrew Bartlett
 2010-11-02 04:36:04 +00:00
Andrew Bartlett
9da4ace1d9 s3-debug Impove setup_logging() to specify logging to stderr 
This change improves the setup_logging() API so that callers which
wish to set up logging to stderr can simply ask for it, rather than
directly modify the dbf global variable.

Andrew Bartlett
 2010-11-02 04:36:04 +00:00
Jeremy Allison
14ff2e8de9 Fix bug #7700 - Improvement of return code of smbclient 
Based on an initial patch from H Hasegawa <hasegawa.hiroyuki@fujixerox.co.jp>.
Convert cli_list and associated functions to take calls that return NTSTATUS.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 29 19:40:16 UTC 2010 on sn-devel-104
 2010-10-29 19:40:16 +00:00
Volker Lendecke
40cc1a3d2e s3: Add "setea" to smbclient 2010-10-24 20:46:28 +00:00
Volker Lendecke
86cb0ad242 s3: Add "geteas" to smbclient 2010-10-24 20:46:28 +00:00
Volker Lendecke
c095809c04 s3: Convert cli_qfileinfo_basic to cli_qfileinfo 2010-10-24 11:39:30 +02:00
Volker Lendecke
03333fc68c s3: Rename cli_fileinfo() to cli_fileinfo_basic() 2010-10-24 11:39:29 +02:00
Andrew Bartlett
f768b32e37 libcli/security Provide a common, top level libcli/security/security.h 
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.

This includes (along with other security headers) dom_sid.h and
security_token.h

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
 2010-10-12 05:54:10 +00:00
Günther Deschner
0ff7e0c998 samba: share readline wrappers among all buildsystems. 
Guenther
 2010-10-01 22:30:22 +02:00
Günther Deschner
405b7d843f s3-readline: move cmd_history to smbclient, the only user. 
Guenther
 2010-10-01 22:30:22 +02:00
Günther Deschner
b38d0542e1 samba: share select wrappers. 
Guenther
 2010-10-01 22:30:22 +02:00
Björn Jacke
10eefd85c9 s3: fix order of arguments in nsec_time_diff call 2010-09-17 13:49:11 +02:00
Björn Jacke
aada719694 s3: use nsec_time_diff instead of TspecDiff 2010-09-16 21:38:20 +02:00
Björn Jacke
5728b0fb5f s3: use monotonic clock for time deltas in smbtar 2010-08-31 10:26:09 +02:00
Björn Jacke
fc67675028 s3: use monotonic clock for time deltas in smbclient 2010-08-31 10:26:04 +02:00
Jeremy Allison
af081ec4a1 Fix bug 7627 - smbclient ignores "-I" when used with "-L", fails name resolution. 
Still needs some more work to fix missing netbios name issues, but fixes
underlying issue of IP address being ignored.

Jeremy.
 2010-08-20 15:57:08 -07:00
Jeremy Allison
34230608df Fix bug 7563 - Creation of symlink using smbclient is buggy. 
Fix semantics of symlink. "oldpath" should be an untouched blob,
"newpath" should fit the share path semantics.

Jeremy.
 2010-08-18 15:51:43 -07:00
Volker Lendecke
734f581906 s3: Replace some cli_errstr calls by nt_errstr 2010-08-13 16:03:04 +02:00
Andreas Schneider
ce2a086119 s3-popt: Only include popt-common.h when needed. 2010-08-05 12:08:31 +02:00
Volker Lendecke
867626abca s3: Convert cli_list() to return NTSTATUS 
If needed, the callback functions can count themselves
 2010-08-04 20:32:50 +02:00
Volker Lendecke
fcdda8f443 s3: Remove "cli" from "struct finfo" 2010-07-30 17:01:33 +02:00
Volker Lendecke
dace013898 s3: Remove a typedef (struct file_info) 2010-07-27 21:05:35 +02:00
Volker Lendecke
2ad4b4f63e s3: Convert cli_qpathinfo_streams to cli_qpathinfo_send 2010-07-26 23:01:38 +02:00
Volker Lendecke
f62bde93ce s3: Convert cli_qpathinfo2 to cli_qpathinfo_send 2010-07-26 23:01:37 +02:00
Volker Lendecke
9a2d08bd3c s3: Use error status instead of cli_errstr 2010-07-26 23:01:37 +02:00
Jeremy Allison
8ce15b3a71 Fix bug - 7551 smbclient does not return proper exit code. 
Catch error in cli_push.

Jeremy.
 2010-07-15 16:06:11 -07:00
Andreas Schneider
ee01fe8c5b s3-client: Make sure we only write to an opened file. 
Found by clang-analyzer.
 2010-06-29 11:12:12 +02:00
Günther Deschner
7f6bb48bdf s3-secdesc: remove "typedef struct security_descriptor SEC_DESC". 
Guenther
 2010-05-18 12:30:12 +02:00
Jeremy Allison
f3b8e31f83 Split out the client unix capabilities to those the server offered, and those the client asked for. 
This fixes a bug when using encrypted transport and DFS links. Found
by my basic DFS torture test, which I'll check in next. Testing *rocks* :-).

Jeremy.
 2010-04-13 18:41:14 -07:00
Jeremy Allison
f1fe808978 Add an "attributes" string to allinfo. 
Jeremy.
 2010-02-22 14:36:40 -08:00
Volker Lendecke
2beaa19029 s3: Slightly simplify the logic of completion_remote_filter 2010-02-20 18:59:30 +01:00
Volker Lendecke
1f451d122e s3: Remove a "typedef struct" 2010-02-20 18:59:30 +01:00
Volker Lendecke
f27857e655 s3: Fix a typo 2010-02-20 18:59:30 +01:00
Volker Lendecke
8930a9c520 s3: Convert cli_qpathinfo_basic to use cli_trans() 2010-02-20 18:59:30 +01:00
Volker Lendecke
6e510b49c0 s3: Make cli_get_fs_volume_info() use cli_trans() 2010-02-07 12:29:25 +01:00
Volker Lendecke
24d4433bd7 s3: Move "yesno" to the only place where it is used: client.c 2010-01-21 12:58:11 +01:00
Volker Lendecke
33601b8632 s3: Pass fake_dir_create_times down to file_exist_stat, none of the callers look at the mtime 2009-11-29 11:22:04 +01:00
Volker Lendecke
5ba42b0a5b s3: "tar_parseargs" only looks at the mtime 2009-11-29 11:22:02 +01:00
Volker Lendecke
e1f53e5d49 s3: "dotareof" only looks at the file type 2009-11-29 11:22:02 +01:00
Volker Lendecke
932ab0c299 s3: client "newer" does not look at the create timestamp 2009-11-29 11:22:02 +01:00
Volker Lendecke
44ce5603dd s3: Pass the "fake dir create times" parameter to sys_*stat 
Step 0 to restore it as a per-share paramter
 2009-11-29 11:22:01 +01:00
Günther Deschner
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba. 
Guenther
 2009-11-26 20:03:17 +01:00
Volker Lendecke
a1a81ef785 Revert "s3: Make the implicit reference to Protocol in mask_match() explicit" 
This reverts commit e23d8a3d1f.
 2009-11-23 16:35:00 +01:00
Volker Lendecke
d6e55d8ec0 Revert "s3: Make the implicit reference to Protocol in mask_match_list() explicit" 
This reverts commit 1e22899d26.
 2009-11-23 16:35:00 +01:00
Volker Lendecke
0f8e2a6ebb Revert "s3: Move the global variable Protocol to struct smbd_server_connection" 
This reverts commit c85a4c9ba4.
 2009-11-23 16:34:59 +01:00
Volker Lendecke
c85a4c9ba4 s3: Move the global variable Protocol to struct smbd_server_connection 2009-11-21 20:49:17 +01:00
Volker Lendecke
1e22899d26 s3: Make the implicit reference to Protocol in mask_match_list() explicit 2009-11-21 20:49:17 +01:00
Volker Lendecke
e23d8a3d1f s3: Make the implicit reference to Protocol in mask_match() explicit 2009-11-21 20:49:16 +01:00
Volker Lendecke
f668e4104f s3: Convert cli_set_unix_extensions_capabilities_send to async 2009-11-14 11:03:28 +01:00
Volker Lendecke
f9ad5cd133 s3: Convert cli_unix_extensions_version to async 2009-11-13 09:30:30 +01:00
Jeremy Allison
5363d6e62c Ensure all callers to the rpc_client/cli_pipe functions correctly 
initialize return variables.
Jeremy.
 2009-11-12 13:56:33 -08:00
Volker Lendecke
2b75933960 s3: Convert libsmb/cli_message to the async API 2009-11-10 23:48:22 +01:00
Jeremy Allison
e67de63ba6 Make cli_posix_lock/unlock asynchronous. 
Jeremy.
 2009-07-13 18:43:10 -07:00
Jeremy Allison
661f0ba73b Fix coverity #729. Resource leak in error path. 
Jeremy.
 2009-06-19 17:26:53 -07:00
Jeremy Allison
ba4d51c521 Fix bug #2356 - smbclient -t <term code> no longer works. 
Removed code and docs.
Jeremy.
 2009-06-03 09:44:49 -07:00
Jelmer Vernooij
8d033ec0d1 Move mount.cifs/umount.cifs to the top level and remove the outdated copy 
in Samba 4.
 2009-06-02 23:24:33 +02:00
Jeremy Allison
9df85a9374 Make cli_posix_chown()/cli_posix_chmod() async. 
Jeremy.
 2009-05-28 16:15:09 -07:00
Jeremy Allison
656e86d5fa Make cli_posix_stat() async. 
Jeremy.
 2009-05-28 13:32:00 -07:00
Jeremy Allison
d74e42e0ec Make getfacl async. 
Jeremy.
 2009-05-28 13:05:50 -07:00
Jeremy Allison
bd11948107 Add a smbclient "readlink" command and add docs for it. 
Jeremy.
 2009-05-27 22:02:20 -07:00
Jeremy Allison
f55c7614bd Add aync POSIX hardlink and symlink and torture test for them. 
Missing call cli_readlink() is next.
Jeremy.
 2009-05-27 17:28:23 -07:00