3 Commits

Author	SHA1	Message	Date
Douglas Bagnall	b46af17050	util:tsort.h: add a macro for safely comparing numbers ... In many places we use `return a - b;` in a comparison function. This can be problematic if the comparison is used in a sort, as `a - b` is not guaranteed to do what we expect. For example: * if a and b are 2s-complement ints, a is INT_MIN and b is INT_MAX, then a - b = 1, which is wrong. * if a and b are 64 bit pointers, a - b could wrap around many times in a cmp function returning 32 bit ints. (We do this often). The issue is not just that a sort could go haywire. Due to a bug in glibc, this could result in out-of-bounds access: https://www.openwall.com/lists/oss-security/2024/01/30/7 (We have replicated this bug in ldb_qsort). BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625 Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 5ab93f48c5)	2024-06-10 13:24:16 +00:00
Andrew Tridgell	282cc79454	s4-ldb: use TYPESAFE_QSORT() in the rest of the ldb code	2010-02-14 18:44:20 +11:00
Andrew Tridgell	63844609da	util: added TYPESAFE_QSORT() macro ... This makes it much harder to get the type of a qsort comparison function wrong.	2010-02-13 22:36:11 +11:00