Jeremy Allison
017e0c8d95
Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1.
2011-05-04 12:12:13 -07:00
Andrew Bartlett
2742ec0e34
Remove strlower_m() and strupper_m() from source4 and common code.
...
This function is problematic because a string may expand in size when
changed into upper or lower case. This will then push characters off
the end of the string in the s3 implementation, or panic in the former
s4 implementation.
Andrew Bartlett
2011-05-03 07:37:07 +02:00
Matthias Dieter Wallnöfer
0c8cf666fc
s4:client/client.c - fix Solaris warning by a type cast
2010-12-06 11:28:58 +01:00
Günther Deschner
0ff7e0c998
samba: share readline wrappers among all buildsystems.
...
Guenther
2010-10-01 22:30:22 +02:00
Matthias Dieter Wallnöfer
07af8f2514
s4:client/client.c - fix wrong return codes in "do_connect"
...
Detected by the Solaris cc compiler.
2010-09-10 22:45:50 +02:00
Andrew Tridgell
6b266b85cf
s4-loadparm: 2nd half of lp_ to lpcfg_ conversion
...
this converts all callers that use the Samba4 loadparm lp_ calling
convention to use the lpcfg_ prefix.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-16 18:24:27 +10:00
Matthias Dieter Wallnöfer
76f804af10
s4:client/client.c - we don't need "&ctx" for talloc calls
...
Simply use "ctx".
2010-05-28 10:39:54 +02:00
Matthias Dieter Wallnöfer
3318459fdc
s4:client/client.c - fix "asprintf"s
...
Fix the result values or change them into "talloc_asprintf"s where possible
see bug #6404
2010-05-28 10:04:45 +02:00
Jelmer Vernooij
f9ca9e46ad
Finish removal of iconv_convenience in public API's.
2010-05-18 11:45:30 +02:00
Stefan Metzmacher
dea7c4f999
s4:client: make use of dcerpc_binding_handle stubs
...
metze
2010-03-12 15:25:50 +01:00
Matt Kraai
d8071e7ed7
Change uint_t to unsigned int in source4
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-02-02 07:18:18 +01:00
Andrew Tridgell
090fbdce7d
s4: ran minimal_includes.pl on source4/client
2009-10-20 16:04:59 +11:00
Matthias Dieter Wallnöfer
44df2488e3
s4: fix various warnings (not "const" related ones)
2009-10-02 15:33:48 +02:00
Sam Liddicott
9d824dc115
s4:client
...
Put was assuming that the remote name was always absolute, and not relative to
the current remote directory.
Signed-off-by: Sam Liddicott <sam@liddicott.com>
2009-08-21 16:54:49 +02:00
Slava Semushin
ef45b31886
source4/client/client.c: Possible memory leaks
...
Patch for bug #6446
cppcheck found 2 possible memory leaks:
[./source4/client/client.c:3305]: (error) Memory leak: base_directory
[./source4/client/client.c:3305]: (error) Memory leak: desthost
Patch in attach.
2009-06-18 13:49:26 +10:00
Stefan Metzmacher
07e01f8405
s4:smbclient: correct initialize smbclient_context
...
Found by valgrind.
metze
2009-01-07 06:36:23 +01:00
Stefan Metzmacher
183c379fe5
s4:lib/tevent: rename structs
...
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"
for s in $list; do
o=`echo $s | cut -d ':' -f1`
n=`echo $s | cut -d ':' -f2`
r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
for f in $files; do
cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
mv $f.tmp $f
done
done
metze
2008-12-29 20:46:40 +01:00
Jelmer Vernooij
ff36c52d8c
Remove another use of global_loadparm.
...
Eventually, we should move some of these parameters into a separate
struct (perhaps into smb_transport_options?), to avoid the long lists of
parameters.
2008-11-02 16:07:28 +01:00
Jelmer Vernooij
3ebc574be4
Fix the build.
2008-11-02 02:30:21 +01:00
Jelmer Vernooij
57a60f0920
Move lp_*() calls a bit higher up the calls tack.
2008-11-01 22:13:47 +01:00
Jelmer Vernooij
af2940459d
Fix prototype for attrib_string().
2008-11-01 16:00:41 +01:00
Günther Deschner
7204deac82
s4-srvsvc: merge srvsvc_NetShareEnumAll from s3 idl.
...
Guenther
2008-10-31 02:44:34 +01:00
Jelmer Vernooij
0218669d62
Remove include/local.h and move defines to more appropriate places.
2008-10-24 17:53:38 +02:00
Jelmer Vernooij
8b06312f7e
Eliminate another instance of global_loadparm.
2008-10-24 13:13:27 +02:00
Jelmer Vernooij
09065795d6
Remove unused constants from local.h.
2008-10-23 18:13:25 +02:00
Jelmer Vernooij
218f482fbf
Use common strlist implementation in Samba 3 and Samba 4.
2008-10-12 00:56:56 +02:00
Jelmer Vernooij
9565999755
Fix include paths to new location of libutil.
2008-10-11 21:31:42 +02:00
Jelmer Vernooij
235b729309
Cope with API changes.
2008-09-30 03:07:08 +02:00
Simo Sorce
2daf2897d5
Use a custom init function for samba4 that sets a samba4
...
specific debug function.
By default do not debug, this is the most appropriate action for a library
as we cannot assume what stderr is use for in the main app.
The main app is responsible to set ev_debug_stderr if they so desire.
(This used to be commit e566a2f308
)
2008-06-14 13:00:53 -04:00
Andrew Tridgell
0abc2e2020
use a newer fsinfo level in smbclient, to support larger disks
...
(This used to be commit 1acc8077fb
)
2008-05-15 20:45:30 +10:00
Andrew Bartlett
9b65a7c38f
Remove unused KANJI and terminal code options.
...
Someone can re-add this with tests and an actual implementation.
Andrew Bartlett
(This used to be commit 62136febe7
)
2008-04-24 11:49:41 +01:00
Simo Sorce
4e83011f72
Remove more event_context_init() uses from function calls within deep down the code.
...
Make sure we pass around the event_context where we need it instead.
All test but a few python ones fail. Jelmer promised to fix them.
(This used to be commit 3045d39162
)
2008-04-21 18:12:33 -04:00
Jelmer Vernooij
1efbd5fbf6
Remove event context tracking from the credentials struct.
...
(This used to be commit 4d7fc946b2
)
2008-04-17 01:03:18 +02:00
Jelmer Vernooij
afe3e8172d
Install public header files again and include required prototypes.
...
(This used to be commit 47ffbbf674
)
2008-04-02 04:53:27 +02:00
Jelmer Vernooij
dcc282590b
r26654: libcli/smb_composite: Rather than specifying each of the gazillion options for SMB individually, just specify the smbcli_options struct.
...
(This used to be commit 8a97886e24
)
2008-01-03 12:33:36 -06:00
Jelmer Vernooij
425732f688
r26651: libsmb: Allow specifying signing policy from higher up.
...
The number of arguments is getting a bit excessive now, so it
probably makes sense to pass in the smbcli_options struct rather than
all members individually and add a convenience function for obtaining a
smbcli_options struct from a loadparm context.
(This used to be commit 9f64213463
)
2008-01-03 12:33:36 -06:00
Jelmer Vernooij
771b347f9b
r26644: Janitorial: Pass resolve_context explicitly to various SMB functions, should help fix the build for OpenChange.
...
(This used to be commit 385ffe4f4c
)
2008-01-02 12:48:03 -06:00
Kai Blin
59b7d8dd2a
r26458: Janitorial: also free() var on continue.
...
Spotted by metze.
(This used to be commit adbf61dca5
)
2007-12-21 05:50:26 +01:00
Kai Blin
43ac3d9b44
r26453: Janitorial: Don't use a static char[] in smb_readline_replacement.
...
Fix up callers to free the memory returned, as that is needed if we use the
original readline function as well.
(This used to be commit c81ead1c38
)
2007-12-21 05:50:18 +01:00
Jelmer Vernooij
4b0199a549
r26409: Pass smb ports along.
...
(This used to be commit 2833f320de
)
2007-12-21 05:49:42 +01:00
Jelmer Vernooij
5f4842cf65
r26376: Add context for libcli_resolve.
...
(This used to be commit 459e1466a4
)
2007-12-21 05:49:12 +01:00
Jelmer Vernooij
2e1f142ab0
r26360: Add some const.
...
(This used to be commit 3616ced29e
)
2007-12-21 05:49:03 +01:00
Jelmer Vernooij
b65dba2245
r26355: Eliminate global_loadparm in more places.
...
(This used to be commit 5d589a0d94
)
2007-12-21 05:49:01 +01:00
Jelmer Vernooij
4c4323009f
r26327: Explicit loadparm_context for RPC client functions.
...
(This used to be commit eeb2251d22
)
2007-12-21 05:48:41 +01:00
Jelmer Vernooij
da0f222f43
r26271: Remove some more uses of global_loadparm.
...
(This used to be commit e9875fcd56
)
2007-12-21 05:47:53 +01:00
Jelmer Vernooij
2f8dc4f48f
r26266: Remove more global_loadparm uses.
...
(This used to be commit 99113075c4
)
2007-12-21 05:47:42 +01:00
Jelmer Vernooij
7e298580e0
r26234: More global_loadparm fixes.
...
(This used to be commit 84892d030d
)
2007-12-21 05:47:12 +01:00
Jelmer Vernooij
2fa338cdc9
r26226: Avoid more uses of global_loadparm.
...
(This used to be commit 6cbce47a3e
)
2007-12-21 05:47:02 +01:00
Jelmer Vernooij
734aaefd34
r25550: Convert to standard bool type.
...
(This used to be commit 3ed7aba8e2
)
2007-10-10 15:07:53 -05:00
Jelmer Vernooij
37d53832a4
r25398: Parse loadparm context to all lp_*() functions.
...
(This used to be commit 3fcc960839
)
2007-10-10 15:07:25 -05:00