1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-07 20:23:50 +03:00
Commit Graph

187 Commits

Author SHA1 Message Date
Volker Lendecke
c73d0815a3 r19448: Convert delete_share_security to struct share_params plus some cleanups 2007-10-10 12:15:36 -05:00
Volker Lendecke
99e54a213a r19224: Add setting the rng_fault_state to the already converted pipes.
Convert the low-hanging fruit of the LSA server. This provides a sample how
the server calls can be converted one by one, see the "proxy_lsa_call"
function.

Volker
2007-10-10 12:15:23 -05:00
Jelmer Vernooij
f0508ecb44 r18823: Fix some errors in the srsvc handling code and start running the RPC-SRVSVC
test against samba3.
2007-10-10 12:01:03 -05:00
Stefan Metzmacher
8736262342 r18804: resume_hnd isn't a ref pointer and can be NULL
metze
2007-10-10 12:00:59 -05:00
Jelmer Vernooij
ef10672399 r18802: Use the pidl-generated code for the srvsvc interface, both client and server code.
This has had some basic testing. I'll do more during the next couple of days and hopefully also
make RPC-SRVSVC from Samba4 pass against it.
2007-10-10 12:00:59 -05:00
Jelmer Vernooij
b41c52b9db r18745: Use the Samba4 data structures for security descriptors and security descriptor
buffers.

Make security access masks simply a uint32 rather than a structure
with a uint32 in it.
2007-10-10 12:00:54 -05:00
Simo Sorce
f09f8b2d82 r18413: Based on the new torture test I added in samba4 it turns out
the flags determines what kind of share is this.
I suppose 0x80000000 means something like (legacy) as it will
fail for any share name longer then 13 chars (same size accepted
for old RAP calls that come from pre NT OSs.

Jerry,
let me know if you want me to commit this to 3_0_23

Simo.
2007-10-10 11:51:22 -05:00
Jeremy Allison
ac06fc42cb r17872: Fix possible null deref found by the Stanford checker.
Jeremy.
2007-10-10 11:38:56 -05:00
Jeremy Allison
fcd798ca0c r17346: Add optimisation vl needs for the cluster code where
we don't get the chainlock when getting the byte range
lock record read-only.
Jeremy.
2007-10-10 11:38:27 -05:00
Jeremy Allison
4ace291278 r17293: After the results from the cluster tests in Germany,
fix the messaging code to call the efficient calls :

save_re_uid()
set_effective_uid(0);

messaging_op

restore_re_uid();

instead of using heavyweight become_root()/unbecome_root()
pairs around all messaging code. Fixup the messaging
code to ensure sec_init() is called (only once) so that non-root
processes still work when sending messages.

This is a lighter weight solution to become_root()/unbecome_root()
(which swaps all the supplemental groups) and should be more
efficient. I will migrate all server code over to using this
(a similar technique should be used in the passdb backend
where needed).

Jeremy.
2007-10-10 11:38:24 -05:00
Volker Lendecke
f97f6cedff r17177: Get rid of a global variable by adding a private data pointer to
share_mode_forall().

Volker
2007-10-10 11:38:17 -05:00
Volker Lendecke
220dd43330 r17097: Move share_access_check from rpc_server/srv_srvsvc_nt.c to lib/sharesec.c 2007-10-10 11:38:11 -05:00
Volker Lendecke
0a138888ad r17096: Simplify share_access_check a bit: It takes the sharename instead of the snum,
and the decision which token to use (conn or vuser) does not really belong
here, it is better done in the two places where this is called.

Volker
2007-10-10 11:38:11 -05:00
Volker Lendecke
c5e393d5ed r17039: Eliminate snum from enumshares and getshareinfo. Get rid of some pstrings.
Volker
2007-10-10 11:19:21 -05:00
Volker Lendecke
6e98f8d6c6 r17033: Restructure init_srv_share_info_ctr so that there's only one loop, not a dozen
or so. Next step will be to eliminate the explicit snum reference.

Volker
2007-10-10 11:19:21 -05:00
Volker Lendecke
c89471e157 r17032: I thought I had already merged this from trunk:
> r16959 | vlendec | 2006-07-11 23:10:44 +0200 (Di, 11 Jul 2006) | 1 line
>
> get_share_security does not need snum, activate RPC-SAMBA3-SRVSVC

Volker
2007-10-10 11:19:21 -05:00
Jeremy Allison
9dafb7f48c r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
2007-10-10 11:19:14 -05:00
Volker Lendecke
21aaede518 r16301: Fix a memleak 2007-10-10 11:17:32 -05:00
Gerald Carter
17e63ac4ed r13316: Let the carnage begin....
Sync with trunk as off r13315
2007-10-10 11:06:23 -05:00
Jeremy Allison
23f16cbc2e r13293: Rather a big patch I'm afraid, but this should fix bug #3347
by saving the UNIX token used to set a delete on close flag,
and using it when doing the delete. libsmbsharemodes.so still
needs updating to cope with this change.
Samba4 torture tests to follow.
Jeremy.
2007-10-10 11:06:21 -05:00
Gerald Carter
e6afdf1df5 r13086: hooking max connections into 'add share' as well (although the WinXP UI doesn't give you a way to set the value on add 2007-10-10 11:06:13 -05:00
Gerald Carter
af68748baa r13085: hook the max connections spin box in the share properties MMC plugin
dialog to the 'max connections' smb.conf parameter.  Also added the max
uses int from the SHARE_INFO_2 structure to the 'modify share command'
2007-10-10 11:06:13 -05:00
Gerald Carter
e43775fb31 r13082: revert an accidentally commited patch (still in progress) 2007-10-10 11:06:12 -05:00
Gerald Carter
c908dbc4b2 r13081: correct fix for the segv in nmbd caused by a double free on namerec. 2007-10-10 11:06:12 -05:00
Gerald Carter
c08bc30698 r12916: use rpcstr_pull() instead of unistr_to_ascii() when validating share names 2007-10-10 11:06:07 -05:00
Gerald Carter
e461143639 r12224: adding more characters to the invalid share name string 2007-10-10 11:05:50 -05:00
Gerald Carter
174fe494f9 r12177: last of outstanding patches in my queue to deal with MMC.
Validate the share name and fail when trying to creating
a share with bad characters.
2007-10-10 11:05:48 -05:00
Jeremy Allison
68d03a7a74 r11936: Fix bug in returning remote time found by Thomas Bork <tombork@web.de>.
get_time_zone() was overwriting static buffer returned by
gmtime(). Lars - this is a mandatory fix for the next patch...
Jeremy.
2007-10-10 11:05:37 -05:00
Jeremy Allison
414303bc02 r11511: A classic "friday night check-in" :-). This moves much
of the Samba4 timezone handling code back into Samba3.
Gets rid of "kludge-gmt" and removes the effectiveness
of the parameter "time offset" (I can add this back
in very easily if needed) - it's no longer being
looked at. I'm hoping this will fix the problems people
have been having with DST transitions. I'll start comprehensive
testing tomorrow, but for now all modifications are done.
Splits time get/set functions into srv_XXX and cli_XXX
as they need to look at different timezone offsets.
Get rid of much of the "efficiency" cruft that was
added to Samba back in the day when the C library
timezone handling functions were slow.
Jeremy.
2007-10-10 11:05:19 -05:00
Gerald Carter
b4e78520cc r11054: patch from Brian Moran; fix error code return in _srv_net_name_validate() 2007-10-10 11:04:59 -05:00
Gerald Carter
939c3cb5d7 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
2007-10-10 11:04:48 -05:00
James Peach
623d2e6931 r9780: Clean up a bunch of compiler warnings. 2007-10-10 11:03:26 -05:00
Tim Potter
ae6b4df7fe r8573: Fix set but not used warning in srvsvc server-side code.
Another bugzilla (#2891) from Jason Mader.
2007-10-10 11:00:11 -05:00
Jeremy Allison
c7fe18761e r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the torture
tests on this as it's very late NY time (just wanted to get this work
into the tree). I'll test this over the weekend....
Jerry - in looking at the difference between the two trees there
seem to be some printing/ntprinting.c and registry changes we might
want to examine to try keep in sync.
Jeremy.
2007-10-10 10:58:18 -05:00
Günther Deschner
1f17b4f45e r8019: Better give a hint that we are failing share-manipulation due to missing
scripts.

Guenther
2007-10-10 10:58:08 -05:00
Günther Deschner
2e5cb531ab r7606: add WERR_NET_NAME_NOT_FOUND. This is what windows returns when
trying to manipulate non-existing shares.

Guenther
2007-10-10 10:57:15 -05:00
Gerald Carter
81ffb0dbbb r6942: * merging the registry changes back to the 3.0 tree
* removing the testprns tool
2007-10-10 10:56:57 -05:00
Volker Lendecke
3493d9f383 r6263: Get rid of generate_wellknown_sids, they are const static and initializable
statically.

Volker
2007-10-10 10:56:33 -05:00
Herb Lewis
efea76ac71 r6225: get rid of warnings from my compiler about nested externs 2007-10-10 10:56:30 -05:00
Gerald Carter
167f7d3caa r6037: little cleanup of unused vars and unnecessary codepaths 2007-10-10 10:56:17 -05:00
Simo Sorce
5a4274371c r6034: Check only once 2007-10-10 10:56:16 -05:00
Simo Sorce
d3557ed4b7 r6016: Give access only to root and Domain Users 2007-10-10 10:56:16 -05:00
Jeremy Allison
51beba71d4 r6009: Add privillage check for SE_DISK_OP (is this the right privilage?)
before allowing users to shut down any sessions.
Simo - please check security before allowing state changes. Please
review this change.
Jeremy.
2007-10-10 10:56:15 -05:00
Simo Sorce
5d3d025db7 r6004: Let's make server manager able to kill a user session.
This will send a shutdown command to the right process by pid read from the sessions list.
2007-10-10 10:56:15 -05:00
Gerald Carter
6409de1a1e r4856: after testing a simple add printer script, i realized that you still have to be root to send the message to all smbds that the config file has been updated 2007-10-10 10:54:00 -05:00
Gerald Carter
9af83a7d70 r4852: merge simo changes to srv_srvsvc_nt.c from trunk
that allows the add/change share command to create the directory
passed in as an arguement and not require that it pre-exist.

Also finish testing of SeDiskOperatorPrivilege via srvmgr.exe
2007-10-10 10:53:59 -05:00
Gerald Carter
8ab8113d2e r4825: Printing changes
----------------

* bracket the add/delete/set printer scripts with checks for se_print_op
* slight change to the add/set printer script semantics.  smbd no longer
  relies on output from the script (on stdout) to re-read smb.conf
* remove SIGHUP from set/add/delete printin script code and now just
  use MSG_SMB_CONF_UPDATED

* bracket the add/delete/set share scripts with checks for se_print_op
  (this includes setting share ACLs)
2007-10-10 10:53:56 -05:00
Jeremy Allison
620f2e608f r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
2007-10-10 10:53:32 -05:00
Jeremy Allison
9d367ac636 r3929: Dead code elimination fix for bug #2075 from jason@ncac.gwu.edu.
Jeremy.
2007-10-10 10:53:25 -05:00
Jeremy Allison
5e8237e306 r1115: Fix for #1427. Catch bad path errors at the right point. Ensure all
our pathname parsing is consistent.
Jeremy.
2007-10-10 10:51:56 -05:00