sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code
64,932 Commits 60 Branches 1,144 Tags 452 MiB
d17abc69f6
Commit Graph

1307 Commits

Author SHA1 Message Date
Stefan Metzmacher
dc09b12681 s3:rpc_client: don't mix layers and keep a reference to cli_state in the caller 
We should not rely on the backend to have a reference to the cli_state.
This will make it possible for the backend to set its cli_state reference
to NULL, when the transport is dead.

metze
 2010-03-29 18:11:16 +02:00
Stefan Metzmacher
5f8fc63515 s3:rpc_transport_np: add comment about bad usage in a destructor 
metze
 2010-03-29 18:11:15 +02:00
Stefan Metzmacher
b862351da8 s3:rpc_transport_np: use cli_state_is_connected() helper 
metze
 2010-03-29 18:11:15 +02:00
Stefan Metzmacher
7d977da925 s3:ntlmssp: pass names and use_ntlmv2 to ntlmssp_client_start() and store them 
Inspired by the NTLMSSP merge work by Andrew Bartlett.

metze

Signed-off-by: Günther Deschner <gd@samba.org>
 2010-03-24 17:34:55 +01:00
Günther Deschner
7643afa70e s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change. 
Guenther
 2010-03-05 15:18:00 +01:00
Stefan Metzmacher
911287285c s3:rpc_transport_np: handle trans rdata like the output of a normal read 
Inspired by bug #7159.

metze
 2010-02-24 11:55:36 +01:00
Stefan Metzmacher
1e9df26ef9 s3:cli_netlogon: keep the the correct negotiate_flags on the cli->dc structure 
This should fix the rpccli_netlogon_set_trust_password() against DC's
without netr_ServerPasswordSet2 support.

This fixes bug #7160.

metze
 2010-02-23 16:19:58 +01:00
Jeremy Allison
0055e33dbe Second part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns. 
If server returns zero on a NP read. Report pipe broken.
Prevents client from looping if it thinks there should be
more data.

Jeremy.
 2010-02-19 14:26:22 -08:00
Jeremy Allison
ad77ae1d58 First part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns. 
Ensure that subreq is *always* talloc_free'd in the _done
function, as it has an event timeout attached. If the
read requests look longer than the cli->timeout, then
the timeout fn is called with already freed data.

Jeremy.
 2010-02-19 14:26:12 -08:00
Jeremy Allison
7b4387f765 Fix bug #7146 - Samba miss-parses authenticated RPC packets. 
Parts of the Samba RPC client and server code misinterpret authenticated
packets.

DCE authenticated packets actually look like this :

+--------------------------+
|header                    |
| ... frag_len (packet len)|
| ... auth_len             |
+--------------------------+
|                          |
| Data payload             |
...                     ....
|                          |
+--------------------------+
|                          |
| auth_pad_len bytes       |
+--------------------------+
|                          |
| Auth footer              |
| auth_pad_len value       |
+--------------------------+
|                          |
| Auth payload             |
| (auth_len bytes long)    |
+--------------------------+

That's right. The pad bytes come *before* the footer specifying how many pad
bytes there are. In order to read this you must seek to the end of the packet
and subtract the auth_len (in the packet header) and the auth footer length (a
known value).

The client and server code gets this right (mostly) in 3.0.x -> 3.4.x so long
as the pad alignment is on an 8 byte boundary (there are some special cases in
the code for this).

Tridge discovered there are some (DRS replication) cases where on 64-bit
machines where the pad alignment is on a 16-byte boundary. This breaks the
existing S3 hand-optimized rpc code.

This patch removes all the special cases in client and server code, and allows
the pad alignment for generated packets to be specified by changing a constant
in include/local.h (this doesn't affect received packets, the new code always
handles them correctly whatever pad alignment is used).

This patch also works correctly with rpcclient using sign+seal from
the 3.4.x and 3.3.x builds (testing with 3.0.x and 3.2.x to follow)
so even as a server it should still work with older libsmbclient and
winbindd code.

Jeremy
 2010-02-17 15:27:59 -08:00
Volker Lendecke
81a848be6d s3: Remove some unused variables 2010-01-10 22:43:02 +01:00
Bo Yang
36493bf2f6 s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response. 
Signed-off-by: Bo Yang <boyang@samba.org>
 2010-01-06 19:19:35 +08:00
Andrew Bartlett
802e9328ed s3:ntlmssp: only include ntlmssp.h where actually needed 
Andrew Bartlett
 2009-12-22 21:07:53 +01:00
Andrew Bartlett
5b37cd23bf s3:ntlmssp: remove the typedef NTLMSSP_STATE 
Andrew Bartlett
 2009-12-22 21:07:53 +01:00
Günther Deschner
f20effc437 s3-spoolss: fix enumprinter key client and server. 
Guenther
 2009-12-10 17:48:50 +01:00
Günther Deschner
5f60855ba2 samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey. 
This should finally resolve the endian issues we were seeing on sparc and is
much cleaner for spoolss clients and servers.

Guenther
 2009-12-02 14:56:17 +01:00
Günther Deschner
04f8c229de s3-kerberos: only use krb5 headers where required. 
This seems to be the only way to deal with mixed heimdal/MIT setups during
merged build.

Guenther
 2009-11-27 16:36:00 +01:00
Günther Deschner
5d706a2fd4 s3-rpc: running minimal_includes.pl on rpc_client and rpc_server. 
Guenther
 2009-11-26 20:17:07 +01:00
Günther Deschner
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba. 
Guenther
 2009-11-26 20:03:17 +01:00
Günther Deschner
846aa18648 s3-spoolss: fixes for _spoolss_EnumPrinterKey client and server. 
Thanks Metze for review!

Guenther
 2009-11-24 15:49:35 +01:00
Günther Deschner
d464151f3b s3-spoolss: fix spoolss_EnumPrinterKey client and server code. 
Guenther
 2009-11-23 11:44:43 +01:00
Volker Lendecke
f4cf1c56a2 s3: Add min_setup, min_param and min_data to cli_trans_recv 
Every caller that expects to receive something needs to check if enough was
sent. Make this check mandatory for everyone.

Yes, this makes the parameter list for cli_trans a bit silly, but that's just
the way it is: A silly protocol request :-)

While there, convert some _done functions to tevent_req_simple_finish_ntstatus.
 2009-11-14 12:20:12 +01:00
Volker Lendecke
92a16b91e8 fix bogus "out of memory" winbind msg 
Signed-off-by: Michael Adam <obnox@samba.org>
 2009-11-13 11:36:06 +01:00
Jeremy Allison
0363713031 Remove erroneous 'presult = NULL' changes. Now presult only gets set 
if NTSTATUS == OK.
Jeremy.
 2009-11-12 13:59:25 -08:00
Jeremy Allison
496d147dc4 Revert "Ensure every return path initializes presult as NULL." 
Vl is correct, this is the wrong way to fix this.

This reverts commit 83c2c177a5.
 2009-11-12 13:57:13 -08:00
Jeremy Allison
5363d6e62c Ensure all callers to the rpc_client/cli_pipe functions correctly 
initialize return variables.
Jeremy.
 2009-11-12 13:56:33 -08:00
Jeremy Allison
83c2c177a5 Ensure every return path initializes presult as NULL. 
Ensures no crashes in calling code that forgets to
init return as null.
Jeremy.
 2009-11-12 11:49:54 -08:00
Günther Deschner
d241b9ae4c s3-rpc_client: make sure cli_rpc_pipe_open_schannel() does not always return NT_STATUS_OK. 
Guenther
 2009-11-10 13:10:12 +01:00
Volker Lendecke
bb283af16f Revert "s3: Do not directly reference the ndr_table_* in rpcclient" 
This reverts commit 70c698fd54.
 2009-11-08 19:43:47 +01:00
Volker Lendecke
e181b88978 Revert "s3: Do not reference ndr_table_<pipe> in the cli_ routines directly" 
This reverts commit daa964013b.
 2009-11-08 19:43:47 +01:00
Volker Lendecke
daa964013b s3: Do not reference ndr_table_<pipe> in the cli_ routines directly 2009-11-08 13:12:13 +01:00
Volker Lendecke
70c698fd54 s3: Do not directly reference the ndr_table_* in rpcclient 2009-11-08 00:28:36 +01:00
Volker Lendecke
5cdee7ae05 s3: Do the printing for DEBUGLEVEL>=10 centrally 
12 insertions(+), 10651 deletions(-)

I think that says it all :-)
 2009-11-07 11:07:37 +01:00
Volker Lendecke
cd16e38e32 s3: Register the ndr_interfaces dynamically 2009-11-07 09:14:16 +01:00
Volker Lendecke
268df12ab6 s3: Get rid of a NULL terminator 2009-11-07 09:14:16 +01:00
Volker Lendecke
a32c425f91 s3: Get rid of explicit pipe names 2009-11-07 09:14:16 +01:00
Volker Lendecke
2aa0af9867 s3: get_pipe_name_from_iface -> get_pipe_name_from_syntax 2009-11-07 09:14:15 +01:00
Günther Deschner
60bf0eb607 s3-kerberos: modify cli_krb5_get_ticket to take a new impersonate_princ_s arg. 
Guenther
 2009-11-06 13:31:17 +01:00
Volker Lendecke
b067a5e4e8 s3: Remove debug_ctx() 
smbd just crashed on me: In a debug message I called a routine preparing a
string that itself used debug_ctx. The outer routine also used it after the
inner routine had returned. It was still referencing the talloc context
that the outer debug_ctx() had given us, which the inner DEBUG had already
freed.
 2009-11-03 11:30:00 +01:00
Günther Deschner
64e8aa1b14 s3-netlogon: fix updating trust accout passwords with downlevel domains. 
When choosing the netlogon password set function, make sure to look at the
*negotiated* flags in the cli->dc state, not the ones we start the negotiation
with.

Guenther
 2009-10-16 18:03:32 +02:00
Günther Deschner
ebe0e64ba9 s3: use enum netr_SchannelType all over the place. 
Guenther
 2009-10-13 10:21:46 +02:00
Günther Deschner
4a1b50afd5 s3-netlogon: pass down account name to remote password set functions. 
Guenther
 2009-10-13 00:07:45 +02:00
Matthias Dieter Wallnöfer
607ceff234 s3/s4 - Adapt the IDL changes on various locations 2009-10-08 09:50:19 +02:00
Günther Deschner
0c2fc9eedf s3-netlogon: setup NETLOGON credential chain in rpccli_netlogon_set_trust_password() only when needed. 
Guenther
 2009-10-06 16:50:23 +02:00
Volker Lendecke
872f9c4f91 Revert "s3: Attempt to fix machine password change" 
This reverts commit 20a8ea91e1.

Ooops, this should not have been committed.
 2009-10-05 22:14:06 +02:00
Volker Lendecke
20a8ea91e1 s3: Attempt to fix machine password change 2009-10-05 22:12:20 +02:00
Volker Lendecke
84de81b478 s3: Remove a scary error message -- talloc_move can not fail :-) 
Signed-off-by: Günther Deschner <gd@samba.org>
 2009-10-05 12:14:08 +02:00
Günther Deschner
c6a7ecf28b s3-registry: move rpccli_winreg_Connect to the only file it belongs. 
Guenther
 2009-10-01 11:40:31 +02:00
Stefan Metzmacher
68b8149d1f s3:rpc_client: don't randomly fragment rpc pdu's in developer mode 
This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.

metze
 2009-09-25 05:20:16 +02:00
Günther Deschner
a4b5c792c5 s3-rpc_client: fix non initialized structure in rpccli_lsa_lookup_sids_noalloc. 
Guenther
 2009-09-18 21:32:45 +02:00
Günther Deschner
503d035814 spnego: share spnego_parse. 
Guenther
 2009-09-17 01:12:20 +02:00
Stefan Metzmacher
033ced60ac libcli/auth: rewrite schannel sign/seal code to be more generic 
This prepares support for HMAC-SHA256/AES.

metze
 2009-09-16 12:29:06 +02:00
Günther Deschner
37bc806453 s3-dcerpc: remove more obsolete or duplicate headers. 
Guenther
 2009-09-16 08:55:51 +02:00
Günther Deschner
c5c04fcf90 s3-schannel: add dump_NL_AUTH_SIGNATURE. 
Guenther
 2009-09-16 07:54:02 +02:00
Günther Deschner
799f8d7e13 schannel: fully share schannel sign/seal between s3 and 4. 
Guenther
 2009-09-16 01:55:06 +02:00
Günther Deschner
f8014d30e7 s3-schannel: fix blob length when pulling off a NL_AUTH_SIGNATURE in 
cli_pipe_verify_schannel().

Guenther
 2009-09-16 00:11:23 +02:00
Günther Deschner
c2d7c7a9dd s3-dcerpc: fix remaining old auth level constants. 
Guenther
 2009-09-15 18:30:44 +02:00
Günther Deschner
fdf3bd6203 s3-dcerpc: remove unsed auth type defines as seen on the wire. 
Guenther
 2009-09-15 17:50:00 +02:00
Günther Deschner
d3af0346c8 s3-dcerpc: use dcerpc_AuthLevel and remove duplicate set of flags. 
Guenther
 2009-09-15 17:49:34 +02:00
Günther Deschner
2f9adf04e4 s3-rpc_client: add rpccli_lsa_lookup_sids3 wrapper. 
Guenther
 2009-09-14 06:49:58 +02:00
Günther Deschner
ff968712ba s3-rpc_client: add rpccli_lsa_lookup_names4 wrapper. 
Guenther
 2009-09-14 06:49:58 +02:00
Günther Deschner
bea8e5fa60 s3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_schannel(). 
Guenther
 2009-09-11 09:59:04 +02:00
Günther Deschner
032e01e7c1 s3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_spnego_ntlmssp and cli_rpc_pipe_open_ntlmssp. 
Guenther
 2009-09-11 09:59:04 +02:00
Günther Deschner
87f61a144b s3-rpc_client: add cli_rpc_pipe_open_noauth_transport. 
Guenther
 2009-09-11 09:59:03 +02:00
Günther Deschner
d258fb4d0d s3-schannel: use NL_AUTH_SIGNATURE for schannel sign & seal (client & server). 
Guenther
 2009-09-11 03:00:35 +02:00
Günther Deschner
393a1f594d s3-rpc_client: add enum dcerpc_transport_t to rpc_cli_transport struct. 
Guenther
 2009-09-11 00:26:24 +02:00
Günther Deschner
de0bf36493 s3-rpc_client: use NL_AUTH_MESSAGE in create_schannel_auth_rpc_bind_req(). 
Guenther
 2009-09-08 17:07:02 +02:00
Günther Deschner
5b2b5abf4f s3-schannel: Fix Bug #6697. Interdomain trusts with Windows 2008 R2 DCs. 
The Schannel verifier (aka NL_AUTH_SIGNATURE) structure (32 byte) sent from a
W2k8r2 DC is passed in a buffer with the size of a NL_AUTH_SHA2_SIGNATURE (56
byte). We should just ignore the remaining 12 zeroed bytes and proceed.

Guenther
 2009-09-08 12:34:10 +02:00
Stefan Metzmacher
dcdefc17b9 s3:rpc_client: add dispatch_send/recv() to struct rpc_pipe_client 
metze
 2009-07-31 12:49:45 +02:00
Jeremy Allison
5d05d22999 Added prefer_ipv4 bool parameter to resolve_name(). 
W2K3 DC's can have IPv6 addresses but won't serve
krb5/ldap or cldap on those addresses. Make sure when
we're asking for DC's we prefer IPv4.
If you have an IPv6-only network this prioritizing code
will be a no-op. And if you have a mixed network then you
need to prioritize IPv4 due to W2K3 DC's.
Jeremy.
 2009-07-28 11:51:58 -07:00
Volker Lendecke
3532882d02 Lift the event loop in rpc_api_pipe_req() one level into cli_do_rpc_ndr 2009-07-27 16:15:54 +02:00
Volker Lendecke
58fbf7420c Remove "typedef struct ndr_syntax_id RPC_IFACE;" 2009-07-05 23:50:12 +02:00
Günther Deschner
1225d57abe s3-spoolss: add rpccli_spoolss_getprinterdriver convenience wrapper. 
Guenther
 2009-07-03 22:05:46 +02:00
Günther Deschner
7450f3ad99 s3-netlogon: remove remaining netlogon init functions. 
Guenther
 2009-06-25 16:46:31 +02:00
Günther Deschner
313a2bfa52 s3-netlogon: remove init_netr_SamInfo functions. 
Guenther
 2009-06-25 12:19:17 +02:00
Volker Lendecke
f140bf2e65 Fix broken pipe handling 
Metze is right: If we have *any* error at the socket level, we just can
not continue.

Also, apply some defensive programming: With this async stuff someone else
might already have closed the socket.
 2009-05-18 07:13:04 +02:00
Volker Lendecke
795b896ab0 Fix a type-punned warning 2009-05-18 07:13:04 +02:00
Bo Yang
aa70e44cd0 s3: tevent_req_poll() loops forever when pipe is broken 
Signed-off-by: Bo Yang <boyang@samba.org>
 2009-05-19 01:13:36 +08:00
Jeremy Allison
f3af298e5b Cause cli_close to return an NTSTATUS. 
Jeremy.
 2009-04-30 16:57:42 -07:00
Bo Yang
f8cc0e88fb s3: fix crash in winbindd 2009-04-29 09:50:41 +08:00
Volker Lendecke
6af92c0228 Do not panic unnecessarily 2009-04-28 05:31:48 +02:00
Günther Deschner
8d3e61e5ce s3-netlogon: Start fixing rpccli_netlogon_setup_creds after auth merge. 
Guenther
 2009-04-24 09:52:00 +02:00
Volker Lendecke
8bc88aae5d Move serverinfo_to_SamInfo3() to rpc_server/ 
Normally I hate moving around stuff, but this function is only called from the
RPC server side and it pulls in passdb when trying to link in our rpc client
routines. That seems unnecessary to me.
 2009-04-22 12:33:46 +02:00
Andrew Bartlett
53765c81f7 Remove use of talloc_reference in cli_rpc_pipe_open_schannel_with_key() 2009-04-20 16:50:49 +02:00
Andrew Bartlett
baf7274fed Make Samba3 use the new common libcli/auth code 
This is particuarly in the netlogon client (but not server at this
stage)
 2009-04-14 16:23:44 +10:00
Andrew Bartlett
f28f113d8e Rework Samba3 to use new libcli/auth code (partial) 
This commit is mostly to cope with the removal of SamOemHash (replaced
by arcfour_crypt()) and other collisions (such as changed function
arguments compared to Samba3).

We still provide creds_hash3 until Samba3 uses the credentials code in
netlogon server

Andrew Bartlett
 2009-04-14 16:23:35 +10:00
Volker Lendecke
a3f24d91c5 Convert rpc_transport_smbd_init to tevent_req 2009-04-08 22:17:04 +02:00
Volker Lendecke
8a2112c942 Convert rpc_cli_smbd_conn_init to tevent_req 2009-04-08 22:17:04 +02:00
Volker Lendecke
bfacecc17b Convert get_anon_ipc to tevent_req 2009-04-08 22:17:04 +02:00
Volker Lendecke
f3d33cd81d Convert rpc_transport_np_init to tevent_req 2009-04-08 22:17:03 +02:00
Volker Lendecke
1c4027678e Correct sync wrappers in cli_pipe.c 2009-04-06 21:32:08 +02:00
Volker Lendecke
097db28c5d Convert cli_write_andx to tevent_req 2009-04-06 21:32:07 +02:00
Volker Lendecke
c23ccff13a Convert cli_read_andx to tevent_req 2009-04-06 21:32:07 +02:00
Volker Lendecke
ca7cd350a6 Convert cli_ntcreate to tevent_req 2009-04-06 21:32:07 +02:00
Volker Lendecke
807328ce6d Convert cli_tcon_andx to tevent_req 2009-04-06 21:32:07 +02:00
Volker Lendecke
03becb5066 Convert cli_negprot to tevent_req 2009-04-06 21:32:06 +02:00
Volker Lendecke
95c792b6af Convert cli_session_setup_guest to tevent_req 2009-04-06 21:32:06 +02:00
Volker Lendecke
7ef78bd7b5 Convert cli_trans to tevent_req 2009-04-06 21:32:06 +02:00
Volker Lendecke
0421fa90ce Keep the forked-smbd stdout reader around longer 2009-04-05 13:52:46 +02:00
Volker Lendecke
6d760a4a9f Ensure 0-termination for the forked-smbd debug output 2009-04-05 13:52:46 +02:00
Volker Lendecke
ac4c319ed7 Pass the current debuglevel down to the forked smbd 2009-04-05 13:52:46 +02:00
Volker Lendecke
5f753e22f1 Convert rpc_pipe_bind to tevent_req 2009-03-24 13:23:41 +01:00
Volker Lendecke
fa62836839 Convert rpc_cli_transport->trans to tevent_req 2009-03-24 13:23:41 +01:00
Volker Lendecke
8e0d9d002a Convert rpc_cli_transport->write to tevent_req 2009-03-24 13:23:41 +01:00
Volker Lendecke
22badee4bf Convert rpc_cli_transport->read to tevent_req 2009-03-24 13:23:40 +01:00
Volker Lendecke
1724f2ff31 Convert rpc_api_pipe_req to tevent_req 2009-03-24 13:23:40 +01:00
Volker Lendecke
f88990ec7e Convert rpc_api_pipe to tevent_req 2009-03-24 13:23:40 +01:00
Volker Lendecke
545ed5b52e Convert cli_api_pipe to tevent_req 2009-03-24 13:23:40 +01:00
Volker Lendecke
7a429fb369 Convert get_complete_frag to tevent_req 2009-03-24 13:23:40 +01:00
Volker Lendecke
7573bb758e Convert rpc_write to tevent_req 2009-03-24 13:23:40 +01:00
Volker Lendecke
1dd0883458 Convert rpc_read to tevent_req 2009-03-24 13:23:40 +01:00
Günther Deschner
531af136f9 s3: remove POLICY_HND. 
Guenther
 2009-03-18 23:22:29 +01:00
Günther Deschner
9fdeb7f7b3 s3-spoolss: remove custom syntax_spoolss and use the syntax defined in IDL. 
Guenther
 2009-03-18 14:18:42 +01:00
Günther Deschner
9d024d1715 s3-spoolss: remove old rpccli_spoolss_enumprinterdataex. 
Guenther
 2009-03-18 01:30:41 +01:00
Günther Deschner
ab85fc78bd s3-spoolss: add rpccli_spoolss_enumprinterdataex convenience wrapper. 
Guenther
 2009-03-18 01:30:18 +01:00
Günther Deschner
846b93f54f s3-spoolss: remove old rpccli_spoolss_enumprinterkey wrapper. 
Guenther
 2009-03-17 12:18:50 +01:00
Günther Deschner
86c25b3533 s3-spoolss: add rpccli_spoolss_enumprinterkey convenience wrapper. 
Guenther
 2009-03-17 12:18:28 +01:00
Günther Deschner
57077f43a7 s3-spoolss: remove rpccli_spoolss_enumprinterdata. 
Guenther
 2009-03-17 12:07:50 +01:00
Günther Deschner
4234969df7 s3-spoolss: remove old rpccli_spoolss_setprinterdata wrapper. 
Guenther
 2009-03-17 11:57:17 +01:00
Günther Deschner
d77cc43784 s3-spoolss: remove old rpccli_spoolss_getprinterdata. 
Guenther
 2009-03-17 11:49:23 +01:00
Günther Deschner
08d170abc1 s3-spoolss: add rpccli_spoolss_getprinterdata convenience wrapper. 
Guenther
 2009-03-17 11:49:08 +01:00
Günther Deschner
6df9e1f7aa s3-spoolss: add push_spoolss_PrinterData(). 
Guenther
 2009-03-17 10:53:43 +01:00
Günther Deschner
9a8f19672d s3-spoolss: add pull_spoolss_PrinterData(). 
Guenther
 2009-03-17 10:53:24 +01:00
Jeremy Allison
f48a345e4a Remove pwd_cache.c, it was doing nothing. Make user_name, domain, and 
password talloc'ed strings within the cli_struct.
Jeremy.
 2009-03-13 17:49:24 -07:00
Günther Deschner
16438e3a93 s3-spoolss: remove old enumprinters wrapper. 
Guenther
 2009-03-13 09:25:24 +01:00
Günther Deschner
9397ae5114 s3-spoolss: add rpccli_spoolss_enumprinters convenience wrapper. 
Guenther
 2009-03-13 09:25:23 +01:00
Günther Deschner
6928c5ce47 s3-spoolss: remove old rpccli_spoolss_enumprinterdrivers wrapper. 
Guenther
 2009-03-13 09:25:22 +01:00
Günther Deschner
5f46554228 s3-spoolss: add rpccli_spoolss_enumprinterdrivers convenience wrapper. 
Guenther
 2009-03-13 09:25:22 +01:00
Günther Deschner
3bd1aabcfe s3-spoolss: remove old rpccli_spoolss_enumjobs wrapper. 
Guenther
 2009-03-13 09:25:21 +01:00
Günther Deschner
80284124ba s3-spoolss: add rpccli_spoolss_enumjobs convenience wrapper. 
Guenther
 2009-03-13 09:25:20 +01:00
Günther Deschner
33a441b0c2 s3-spoolss: add rpccli_spoolss_enummonitors convenience wrapper. 
Guenther
 2009-03-07 00:55:39 +01:00
Günther Deschner
c7e19c2627 s3-spoolss: add rpccli_spoolss_enumports convenience wrapper. 
Guenther
 2009-03-07 00:55:37 +01:00
Günther Deschner
631f277d1c s3-spoolss: remove old spoolss_EnumPorts. 
Guenther
 2009-03-07 00:55:36 +01:00
Günther Deschner
2d24d3a380 s3-spoolss: add rpccli_spoolss_enumprintprocessordatatypes convenience wrapper. 
Guenther
 2009-03-07 00:55:00 +01:00
Günther Deschner
b73411d650 s3-spoolss: add rpccli_spoolss_enumprintprocessors convenience wrapper. 
Guenther
 2009-03-07 00:43:13 +01:00
Günther Deschner
9bdca59fc5 s3-spoolss: remove old rpccli_spoolss_enumforms. 
Guenther
 2009-03-06 14:30:26 +01:00
Günther Deschner
c14a589a46 s3-spoolss: add convencience wrapper around rpccli_spoolss_EnumForms. 
Guenther
 2009-03-06 14:30:02 +01:00
Simo Sorce
67d41d0fc7 Make struct tevent_req opaque 
Move struct tevent_req in tevent_internal, and ad getters and setters
for private data and the callback function.
This patch also renames 'private_state' into 'data'. What is held in this
pointer is in fact data and not a state like enum tevent_req_state.
Calling it 'state' is confusing.

The functions addedd are:
tevent_req_set_callback() - sets req->async.fn and req->async.private_data
tevent_req_set_print_fn() - sets req->private_print
tevent_req_callback_data() - gets req->async.private_data
tevent_req_data() - gets rea->data

This way it is much simpler to keep API/ABI compatibility in the future.
 2009-03-02 11:02:09 -05:00
Günther Deschner
f343ed7319 s3-spoolss: remove old rpccli_spoolss_getjob. 
Guenther
 2009-02-26 22:02:19 +01:00
Günther Deschner
0445c554d1 s3-spoolss: add rpccli_spoolss_getjob convenience wrapper. 
Guenther
 2009-02-26 22:02:18 +01:00
Günther Deschner
b6457c78d6 s3-spoolss: remove unused decode_printer_info_7. 
Guenther
 2009-02-25 15:10:46 +01:00
Volker Lendecke
be4913fbe6 Convert rpc_sock_write to use tevent_req base async_send 2009-02-25 13:04:18 +01:00
Volker Lendecke
d1c7bbd893 Convert rpc_sock_read to use tevent_req base async_read 2009-02-25 13:04:18 +01:00
Günther Deschner
59e90d3715 s3-spoolss: remove rpccli_spoolss_getprinter. 
Guenther
 2009-02-25 11:16:30 +01:00
Günther Deschner
c03f207276 s3-spoolss: remove rpccli_spoolss_setprinter. 
Guenther
 2009-02-25 11:16:29 +01:00
Günther Deschner
c7ba20b465 s3-spoolss: remove rpccli_spoolss_addprinterex. 
Guenther
 2009-02-25 11:16:29 +01:00
Günther Deschner
6366084c4a s3-spoolss: add rpccli_spoolss_getprinter convenience wrapper. 
Guenther
 2009-02-25 11:16:28 +01:00
Günther Deschner
9d165fa5c6 s3-spoolss: add rpccli_spoolss_addprinterex convenience wrapper. 
Guenther
 2009-02-25 10:32:09 +01:00
Günther Deschner
b2e038ef8b s3-spoolss: remove rpccli_spoolss_addprinterdriver. 
Guenther
 2009-02-24 23:57:52 +01:00
Günther Deschner
5ffa03dcd8 s3-spoolss: remove old rpccli_spoolss_getprinterdriver wrapper. 
Guenther
 2009-02-24 22:40:51 +01:00