1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Commit Graph

91 Commits

Author SHA1 Message Date
Gerald Carter
0ce53f8ba5 r14403: * modifies create_local_nt_token() to create a BUILTIN\Administrators
group IFF sid_to_gid(S-1-5-32-544) fails and 'winbind nested groups = yes'

* Add a SID domain to the group mapping enumeration passdb call
  to fix the checks for local and builtin groups.  The SID can be
  NULL if you want the old semantics for internal maintenance.
  I only updated the tdb group mapping code.

* remove any group mapping from the tdb that have a
  gid of -1 for better consistency with pdb_ldap.c.
  The fixes the problem with calling add_group_map() in
  the tdb code for unmapped groups which might have had
  a record present.

* Ensure that we distinguish between groups in the
  BUILTIN and local machine domains via getgrnam()
  Other wise BUILTIN\Administrators & SERVER\Administrators
  would resolve to the same gid.

* Doesn't strip the global_sam_name() from groups in the
  local machine's domain (this is required to work with
  'winbind default domain' code)

Still todo.

* Fix fallback Administrators membership for root and domain Admins
  if nested groups = no or winbindd is not running

* issues with "su - user -c 'groups'" command

* There are a few outstanding issues with BUILTIN\Users that
  Windows apparently tends to assume.  I worked around this
  presently with a manual group mapping but I do not think
  this is a good solution.  So I'll probably add some similar
  as I did for Administrators.
(This used to be commit 612979476a)
2007-10-10 11:15:28 -05:00
Tim Potter
3444017ed3 r13648: Duh.
(This used to be commit 48cd81074e)
2007-10-10 11:10:21 -05:00
Volker Lendecke
301d51e13a r13494: Merge the stuff I've done in head the last days.
Volker
(This used to be commit bb40e544de)
2007-10-10 11:10:06 -05:00
Gerald Carter
0af1500fc0 r13316: Let the carnage begin....
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed)
2007-10-10 11:06:23 -05:00
Lars Müller
c42be9fd38 r12986: Use d_fprintf(stderr, ...) for any error message in net.
All 'usage' messages are still printed to stdout.

Fix some compiler warnings for system() calls where we didn't used the
return code.  Add appropriate error messages and return with the error
code we got from system() or NT_STATUS_UNSUCCESSFUL.
(This used to be commit f650e3bdaf)
2007-10-10 11:06:09 -05:00
Volker Lendecke
db6eea0fb4 r12185: Cosmetic cleanup
(This used to be commit d1e8f9afff)
2007-10-10 11:05:48 -05:00
Volker Lendecke
4d03fc55df r12182: Cosmetic cleanup
(This used to be commit 81c358b511)
2007-10-10 11:05:48 -05:00
Volker Lendecke
ab51c18cc9 r12129: Fix uninitialized variables.
Volker
(This used to be commit 8a7d6eb2c0)
2007-10-10 11:05:46 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a78)
2007-10-10 11:05:02 -05:00
Gerald Carter
f24d88cf9d r7139: trying to reduce the number of diffs between trunk and 3.0; changing version to 3.0.20pre1
(This used to be commit 9727d05241)
2007-10-10 10:57:02 -05:00
Gerald Carter
5d5d596206 r6706: * fix bug that prevented smbclient from creating directories
on non-dfs paths
* add patch from James Peach to remove use of uninitialized
  variables
(This used to be commit c71f20f1ae)
2007-10-10 10:56:52 -05:00
Volker Lendecke
e84ead0cfd r6080: Port some of the non-critical changes from HEAD to 3_0. The main one is the
change in pdb_enum_alias_memberships to match samr.idl a bit closer.

Volker
(This used to be commit 3a67865169)
2007-10-10 10:56:20 -05:00
John Terpstra
eeefe8cf5e r5918: Fix typo.
(This used to be commit 0d38d5f610)
2007-10-10 10:56:08 -05:00
Günther Deschner
da4ae764b2 r5234: Do not use the "Local Unix Group"-default description for all kinds of
group-mappings.

Guenther
(This used to be commit 2556e6570e)
2007-10-10 10:55:34 -05:00
Günther Deschner
2da4456df9 r4285: Allow -v or -l for displaying verbose groupmap-listing as well as
"verbose".

Guenther
(This used to be commit 0760d07b4c)
2007-10-10 10:53:41 -05:00
Volker Lendecke
154d5f913b r3566: Completely replace the queryuseraliases call. The previous implementation does
not exactly match what you would expect.

XP workstations during login actually do this, so we should better become a
bit more correct. The LDAP query issued is not really fully optimal, but it is
a lot faster and more correct than what was there before. The change in
passdb.h makes it possible that queryuseraliases is done with a single ldap
query.

Volker
(This used to be commit 2508d4ed1e)
2007-10-10 10:53:09 -05:00
Tim Potter
b4cf9e9505 r2835: Since we always have -I. and -I$(srcdir) in CFLAGS, we can get rid of
'..' from all #include preprocessor commands.   This fixes bugzilla #1880
where OpenVMS gets confused about the '.' characters.
(This used to be commit 7f161702fa)
2007-10-10 10:52:55 -05:00
Günther Deschner
23f1b04b90 r1720: Show correct help for net groupmap commands.
Guenther
(This used to be commit 3677c6a8f6)
2007-10-10 10:52:19 -05:00
Gerald Carter
7af3777ab3 r116: volker's patch for local group and group nesting
(This used to be commit b393469d95)
2007-10-10 10:51:10 -05:00
Volker Lendecke
d9819ec090 Implement 'net groupmap set' and 'net groupmap cleanup'.
I was rather annoyed by the net groupmap syntax, I could never get it
right.

net groupmap set "domain admins" domadm

creates a mapping,

net groupmap set "domain admins" -C "Comment" -N "newntname"

should also do what you expect. I'd like to have some feedback on the usability
of this.

net groupmap cleanup

solves a problem I've had two times now: Our SID changed, and a user's primary
group was mapped to a SID that is not ours. net groupmap cleanup removes all
mappings that are not from our domain sid.

Volker
(This used to be commit eb4d4faff8)
2004-02-26 11:29:56 +00:00
Volker Lendecke
f570f879bb Fix success message for net groupmap modify
Volker
(This used to be commit 19b30334a7)
2004-02-16 14:04:56 +00:00
Gerald Carter
88c95aa735 fix some warnings found by the Sun C compiler
(This used to be commit e1fac713e2)
2003-09-22 17:53:59 +00:00
Jeremy Allison
2c21d31c92 Fix from gregory@networksentry.co.za, don't clobber the comment if it
exists.
Jeremy.
(This used to be commit c8bfde5be9)
2003-09-15 21:27:36 +00:00
Tim Potter
5cf58a1b98 Fix error message when calling namedtogid() fails adding a group map
entry.  Bug #431.
(This used to be commit bc8a181477)
2003-09-11 01:57:08 +00:00
Volker Lendecke
db5355cb3a Don't ask, it's too embarrassing :-)
Actually let the user explicitly specify a rid...

Volker
(This used to be commit 3aed9c8a4a)
2003-08-15 01:55:06 +00:00
Volker Lendecke
923cb1b731 When doing 'net groupmap add', default to algorithmic mapping for the rid.
Volker
(This used to be commit 7ce94d39ad)
2003-08-06 09:24:11 +00:00
Volker Lendecke
c9d6c786a1 Fix memleak
(This used to be commit 517bb4d0df)
2003-07-15 17:27:39 +00:00
Andrew Bartlett
4830a87845 (fixing bug in my last commit)
This isn't C++ - start your code *after* all the variables are declared...

Andrew Bartlett
(This used to be commit b7760faedc)
2003-06-21 23:35:12 +00:00
Andrew Bartlett
668a9af94e This removes the StrCaseCmp() stuff from 'net idmap' and 'net
groupmap'.  The correct way to implement this stuff is via a function
table, as exampled in all the other parts of 'net'.

This also moves the idmap code into a new file.  Volker, is this your
code?  You might want to put your name on it.

Andrew Bartlett
(This used to be commit 477f2d9e39)
2003-06-21 08:35:30 +00:00
Simo Sorce
75a5c0b307 Ok, this patch removes the privilege stuff we had in, unused, for some time.
The code was nice, but put in the wrong place (group mapping) and not
supported by most of the code, thus useless.

We will put back most of the code when our infrastructure will be changed
so that privileges actually really make sense to be set.

This is a first patch of a set to enhance all our mapping code cleaness and
stability towards a sane next beta for 3.0 code base

Simo.
(This used to be commit e341e7c49f)
2003-06-18 15:24:10 +00:00
Jeremy Allison
5ffd33df94 Patch from "Alex Deiter" <tiamat@komi.mts.ru> to fix incorrect error check.
Jeremy.
(This used to be commit 43ca4b8a84)
2003-05-15 17:23:35 +00:00
Gerald Carter
f4187018ea fix and if () that should be an 'else if()'
(This used to be commit 82f024723c)
2003-04-25 02:26:23 +00:00
Gerald Carter
9530bbe2ad groupmap delet should take a name or a SID
(This used to be commit d9277bd064)
2003-04-24 16:47:32 +00:00
Gerald Carter
cfe53bd066 allow the unix group in a mapping to be changed; doesn't work with LDAP right now but should be ok with tdb's
(This used to be commit fdacad185c)
2003-04-23 00:34:31 +00:00
Gerald Carter
651ff45e8d don't reset the group type unless specified
(This used to be commit 541f40a144)
2003-04-22 18:03:55 +00:00
Gerald Carter
9465f4b2c4 default new groups to domain groups
(This used to be commit 665d21b865)
2003-04-22 05:57:49 +00:00
Gerald Carter
cbdb436e21 support referencing group by sid in all operations; allow group name to be changed
(This used to be commit b6ccdb8f7b)
2003-04-22 05:14:21 +00:00
Gerald Carter
3996f116c7 removing some ifdef'd out code
(This used to be commit 43942398af)
2003-04-22 02:52:15 +00:00
Jeremy Allison
530dc71732 Fixup a few typos for Jerry.
Jeremy.
(This used to be commit 1e5fe87d75)
2003-04-21 23:23:24 +00:00
Gerald Carter
79d3731d98 * fix segfault when no vfs objects defined
* add "sid=..." to 'net groupmap add'
(This used to be commit e5f6676639)
2003-04-21 19:43:25 +00:00
Gerald Carter
a1fb9f2176 Merging smbgroupedit into 'net groupmap'. Not entirely done.
Need to check on where the privilege code is sitting
and update the docs.

Examples:

root# bin/net help groupmap
net groupmap add
  Create a new group mapping
net groupmap modify
  Update a group mapping
net groupmap delete
  Remove a group mapping
net groupmap list
  List current group map

# bin/net groupmap add
Usage: net groupmap add rid=<int> name=<string> type=<domain|local|builtin> [comment=<string>]

# bin/net groupmap delete
Usage: net groupmap delete name=<string|SID>

# bin/net groupmap modify
Usage: net groupmap modify name=<string|SID> [comment=<string>] [type=<domain|local>
(This used to be commit f2fd0ab41f)
2003-04-19 05:53:55 +00:00