1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-29 15:42:04 +03:00
Commit Graph

128 Commits

Author SHA1 Message Date
994694f7f2 r6149: Fixes bugs #2498 and 2484.
1. using smbc_getxattr() et al, one may now request all access control
   entities in the ACL without getting all other NT attributes.
2. added the ability to exclude specified attributes from the result set
   provided by smbc_getxattr() et al, when requesting all attributes,
   all NT attributes, or all DOS attributes.
3. eliminated all compiler warnings, including when --enable-developer
   compiler flags are in use.  removed -Wcast-qual flag from list, as that
   is specifically to force warnings in the case of casting away qualifiers.

Note: In the process of eliminating compiler warnings, a few nasties were
      discovered.  In the file libads/sasl.c, PRIVATE kerberos interfaces
      are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED
      kerberos interfaces are being used.  Someone who knows kerberos
      should look at these and determine if there is an alternate method
      of accomplishing the task.
2007-10-10 10:56:24 -05:00
4e0ac63c36 r6014: rather large change set....
pulling back all recent rpc changes from trunk into
3.0.  I've tested a compile and so don't think I've missed
any files.  But if so, just mail me and I'll clean backup
in a couple of hours.

Changes include \winreg, \eventlog, \svcctl, and
general parse_misc.c updates.

I am planning on bracketing the event code with an
#ifdef ENABLE_EVENTLOG until I finish merging Marcin's
changes (very soon).
2007-10-10 10:56:15 -05:00
9e77da9320 r5961: final round of compiler warning fixes based on feedback from Jason Mader 2007-10-10 10:56:13 -05:00
f3f315b14d r5956: more compile warngin fixes from the Mr. Mader 2007-10-10 10:56:11 -05:00
45a2a7bedb r5954: Fix some compiler warnings and add missing exclude-block in "net rpc
share migrate" (found by Lars Mueller <lmuelle@suse.de>).

Guenther
2007-10-10 10:56:11 -05:00
7dfafa712d r5953: more compiler cleanups; moved SID_LIST from smb.h to privileges.c to cleanup the name space 2007-10-10 10:56:11 -05:00
17239d609f r5158: BUG 2263: patch from Timur Bakeyev <timur@com.bat.ru> to guard base64_encode_data_blob() against empty blobs 2007-10-10 10:55:30 -05:00
9d131e9419 r5066: A couple of small fixes from James Peach @ SGI.
Jeremy.
2007-10-10 10:55:13 -05:00
ccdff4a998 r4746: add server support for lsa_enum_acct_rights(); last checkin for the night 2007-10-10 10:53:54 -05:00
c3f9c81a8f r4334: Fix for bugid #2186 - from Buck Huppmann <buckh@pobox.com>
to prevent uninitialized creds being freed.
Jeremy.
2007-10-10 10:53:44 -05:00
620f2e608f r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
2007-10-10 10:53:32 -05:00
ca9516520f r2605: Fix stupid typo in back-port of Samba4 fix.
Jeremy.
2007-10-10 10:52:47 -05:00
0465e2d23d r2578: Pick up optimisation from Samba4 - thanks tridge !
- I recently found out that charaters below 0x3F are guaranteed not to
  occur as secondary bytes in any multi-byte character set. This
  allows for a very simple optimisation in strchr_m() and
  strrchr_m(). It might be a good idea to pick this up for Samba3.
Jeremy.
2007-10-10 10:52:47 -05:00
d434d8e2b4 r2361: Fix the appalling toktocliplist() fn. Bug found by Luis Benvenutto.
Jeremy.
2007-10-10 10:52:40 -05:00
615aa6e914 r2175: Fix for #1546 from fumiya@samba.gr.jp. Preserve errno in MB strupper_m/strlower_m.
Jeremy.
2007-10-10 10:52:34 -05:00
3f0707132a r2111: Fix memleak with valid names.
Jeremy.
2007-10-10 10:52:31 -05:00
98feb3318f r2070: Let's try to overload srnlen and strndup for AIX where they are natly broken. 2007-10-10 10:52:29 -05:00
430cf63b91 r1570: merging changes from 3.0.5 2007-10-10 10:52:15 -05:00
b0739b073a r1087: BUG 1221: revert old change that used single and double quotes as delimters in next_token(), and change print_parameter() to print out parm values surrounded by double quotes (instead of single quotes) 2007-10-10 10:51:54 -05:00
578a508509 r570: Remove lots of globals to handle case issues - move them
to connection struct entries (as they should have been from
the start). Jerry, once you've cut over to 3.0.4 release
branch I'll add this to 3.0 also.
- Jerry cut over :-).
Jeremy.
2007-10-10 10:51:30 -05:00
b393469d95 r116: volker's patch for local group and group nesting 2007-10-10 10:51:10 -05:00
0693b9e79f r104: Fix ntlm_auth by adding the new strhex_to_data_blob() call.
Andrew Bartlett
2007-10-10 10:51:09 -05:00
b4ea493599 Modified fix for bugid #784. Based on a patch from moriyama@miraclelinux.com (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.
-
a893a324f3 Given how core this code is, I figure it should have it's own testsuite.
Big thanks to tpot and mbp for showing how easy it can be to write a simple
unit test, and for providing the STF.

This also changes the strstr_m() code to use strstr_w() (avoiding
duplication) and fixes it so that it passes the STF.

(We now always restart before doing the unicode run, until sombody can
show me why the testsuite is wrong).

Andrew Bartlett
-
44d304f84c JRA's recent strstr_m work really badly broke our string_sub code.
For example:

strstr_m("%v foo bar", "%v") would fail...

only strstr_m("foo %v", "%v") could work.

I wonder what else this broke...

Fix is to move to using strncmp() inside the strstr_m function.

Tested on ASCII only.

Andrew Bartlett
-
94a272b9a8 Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
-
ac1d03c05b Missed SAFE_FREE (typo).
Jeremy.
-
cdbeb7d2eb Added Andrew Bartlett's patch to use an allocated buffer for count_chars.
Jeremy.
-
49142c6352 Fix final valgrind errors with #830. Catch mb conversion error that may not
terminate correctly.
Jeremy.
-
6d22f0d8c3 Fix decoding of base64. We got the length wrong when the result was not
an exact multiple of 3.

I also wrote a torture test and it survived some minutes of random stuff
coded/decoded up to 16 MB data. But that would be a bit too embarassing to
commit... :-)

Volker
-
fac9e6d712 Fix for bug #922. Fast path not called for strlower_m() and strupper_m().
From ab@samba.org (Alexander Bokovoy).
Jeremy.
-
8d54f5fe0c Fix bug 916 - do not perform a + -> space substitution for squid URL encoded
strings, only form input in SWAT.

Andrew Bartlett
-
5bf91c79d6 Ensure that items in a list of strings containing whitespace
are written out surrounded by single quotes.  This means that
both double and single quotes are now used to surround
strings in smb.conf.  This is a slight change from the previous
behavior but needed or else things like

    printer admin = +ntadmin, 'VALE\Domain, Admin'

get written to smb.conf by SWAT.
-
2eef3c7bc1 Added useful information to debug lines.
Patch by metze.


rafal
-
8b06364b53 Useful debug message. Patch by metze.
rafal
-
d165a49d86 Squelch some warnings with more casty-foo. -
23443e3aa0 Fix more 64-bit printf warnings. -
f23acb4ca5 Fix for MacOS/X which uses STUPID BROKEN UNICODE COMPOSE CHARACTERS !
(rant off :-). Inspired by work from Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>.
Also add MacOSX/Darwin configure fixes.
Jerry - can we put this in 3.0 release ? :-).
Jeremy.
-
f23c9d36b0 Fix from Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>. Revered
condition meant fast-path in strchr_m was not being used. Doh !
Jeremy.
-
c5ed59b37b Fix stupid typo bug causing CPU spin. Spotted by Markus Ungermann <ungermann@elzet80.de>
Jeremy.
-
f35e9a8b90 More tuning from cachegrind. Change most trim_string() calls to trim_char(0,
as that's what they do. Fix string_replace() to fast-path ascii.
Jeremy.
-
62d5611df0 fix bug 397: use a variant of alloc_sub_basic() for string lists. -
a9709700ee Hand optimisatinos for strrchr_m using the properties we know about MB
character sets and how we use this call.
Jeremy.
-
b3176f2ec2 Fastpath strchr_m for ASCII.
Jeremy.
-
ef140d15ea Used cachegrind to track down some bottlenecks.
Removed calls to clobber_region when not compiling with developer as
they were hiding speed problems.
Added fast path to convert_string() when dealing with ascii -> ascii,
ucs2-le to ascii and ascii to ucs2-le with values <= 0x7F. This
gives a speedup of 22% on my nbench tests.
Next I will do this on convert_string_allocate.
Jeremy.
-
e0c1460c6b Fix up overlapping memcpy -> memmove found by valgrind.
Jeremy.
-
66dd20c7ea fix bug 289; make sure to reset the offset into a string when reallocating space -
398bd14fc6 get rid of more compiler warnings -
61bea183a2 get rid of const as these things really are not const -
6c9056029b Use push_ucs2_allocate(), rather than convert_string_allocate() directly.
Remove strdup_upper/strdup_lower from their old file, now that they have
been moved to charcnv.c

Note that string_replace assumes that s is a pstring.  (doco change only)

Andrew Bartlett
-