1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-28 11:42:03 +03:00
Commit Graph

347 Commits

Author SHA1 Message Date
994694f7f2 r6149: Fixes bugs #2498 and 2484.
1. using smbc_getxattr() et al, one may now request all access control
   entities in the ACL without getting all other NT attributes.
2. added the ability to exclude specified attributes from the result set
   provided by smbc_getxattr() et al, when requesting all attributes,
   all NT attributes, or all DOS attributes.
3. eliminated all compiler warnings, including when --enable-developer
   compiler flags are in use.  removed -Wcast-qual flag from list, as that
   is specifically to force warnings in the case of casting away qualifiers.

Note: In the process of eliminating compiler warnings, a few nasties were
      discovered.  In the file libads/sasl.c, PRIVATE kerberos interfaces
      are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED
      kerberos interfaces are being used.  Someone who knows kerberos
      should look at these and determine if there is an alternate method
      of accomplishing the task.
2007-10-10 10:56:24 -05:00
5b19ede88e r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers". The
whole of samba comiles warning-free with the default compiler flags.

Temporarily defined -Wall to locate other potential problems.  Found an
unused static function (#ifdefed out rather than deleted, in case it's
needed for something in progress).

There are also a number of uses of undeclared functions, mostly krb5_*.
Files with these problems need to have appropriate header files included,
but they are not fixed in this update.

oplock_linux.c.c has undefined functions capget() and capset(), which need
to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>,
but that could potentially have other side effects, so that remains uncorrected
as well.

The flag -Wall should be added permanently to CFLAGS, and all warnings then
generated should be eliminated.
2007-10-10 10:56:24 -05:00
f3f315b14d r5956: more compile warngin fixes from the Mr. Mader 2007-10-10 10:56:11 -05:00
19a639ac46 r5952: BUG 2469: patch from Jason Mader to cleanup compiler warning when not using krb5 2007-10-10 10:56:11 -05:00
cc6c769c3c r5948: more compile cleanups from Jason Mader 2007-10-10 10:56:10 -05:00
1ace2ca1be r5762: Modified version of patch from Michael Brown <mbrown@fensystems.co.uk> to case
insentively search for a principal match on logon verification in the system
keytab. UNTESTED (although it compiles). Please test.
Jeremy.
2007-10-10 10:56:00 -05:00
c687e73f24 r5759: Patch from Doug VanLeuven <roamdad@sonic.net> to add more case/realm/name
permutations to the kerberos keytab.
Jeremy.
2007-10-10 10:55:59 -05:00
75a223f118 r5336: BUG 2329: fix to re-enable winbindd to locate DC's when 'disable netbios = yes' 2007-10-10 10:55:38 -05:00
9019a84361 r5207: patches from Jay Fenlason @ RedHat (scooped from their Fedora packages) 2007-10-10 10:55:33 -05:00
5557e1409a r4882: Fix for #2255. Debug should have been 10 not 0.
Jeremy.
2007-10-10 10:55:07 -05:00
4b351f2fcc r4736: small set of merges from rtunk to minimize the diffs 2007-10-10 10:53:52 -05:00
0f0281c234 r4665: Fix inspired by posting from Joe Meadows <jameadows@webopolis.com>.
Make all LDAP timeouts consistent.
Jeremy.
2007-10-10 10:53:50 -05:00
5c22cb082c r4346: Fix cut-and-paste error - bugid #2189. Fixed by Buck Huppmann <buckh@pobox.com>
Jeremy.
2007-10-10 10:53:45 -05:00
c3f9c81a8f r4334: Fix for bugid #2186 - from Buck Huppmann <buckh@pobox.com>
to prevent uninitialized creds being freed.
Jeremy.
2007-10-10 10:53:44 -05:00
4f1927acfa r4273: Same fix for r4272 in SAMBA_3_0 branch. 2007-10-10 10:53:41 -05:00
620f2e608f r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
2007-10-10 10:53:32 -05:00
ebaf21e3e2 r4023: Code tidyup to fix bug #2098.
Jeremy.
2007-10-10 10:53:28 -05:00
fc454c8ef6 r3841: Time out in ads search queries. Even AD servers can hang.
Volker
2007-10-10 10:53:20 -05:00
53acf222a8 r3796: Patch from Jay Fenlason <fenlason@redhat.com>. Don't free static buffers.
Jeremy.
2007-10-10 10:53:18 -05:00
b815247747 r3764: Ensure on failure that *res is always NULL.
Check for malloc fail. Fixes for bug #2036.
Jeremy.
2007-10-10 10:53:17 -05:00
3906c1623f r3711: Fix KRB5_SETPW-defines, no change in behaviour.
A value of '2' is due to an expired internet draft, while 0xff80 comes
from RFC3244. See Bugzilla #1661 for details.

Thanks to Luke Mewburn <lukem@NetBSD.org> for his research.

Guenther
2007-10-10 10:53:16 -05:00
2ae717cd2c r3569: Fix for bug #1651, added extra servicePrincipalNames for kerberos interop.
Modified the redhat patch some...
Jeremy.
2007-10-10 10:53:10 -05:00
82651c1b17 r3502: Tidy up debugging in kerberos_keytab code.
Jeremy.
2007-10-10 10:53:08 -05:00
c7eab285d9 r3495: Fix the build (recent kerberos-changes).
Guenther
2007-10-10 10:53:07 -05:00
b356a8fdc5 r3492: Fixes from testing kerberos salted principal fix.
Jeremy.
2007-10-10 10:53:07 -05:00
ff4cb6b5e8 r3451: Finish off kerberos salting patch. Needs testing !
Jeremy.
2007-10-10 10:53:07 -05:00
05619cfdbf r3439: Finally fix build for platforms without kerberos.
Guenther
2007-10-10 10:53:07 -05:00
00598877df r3436: Fix build with recent heimdal-versions (0.6.3) as pointed out by Luke
Mewburn <lukem@NetBSD.org> and close Bugzilla #1661.

Leaving the old define for KRB5_KPASSWD_VERS_SETPW (added by Antti
Andreimann) as fallback when the library does not provide one.

Guenther
2007-10-10 10:53:06 -05:00
82acf83040 r3381: More merging of the #1717 patch. Fixup some erroneous assumptions about
memcpy's into fqdn names. I think the original intent was to create
MYNAME.fqdn.tail.part.
Will need testing to see I haven't broken keytab support.
Jeremy.
2007-10-10 10:53:05 -05:00
30b8807cf6 r3379: More merging of kerberos keytab and salting fixes from Nalin Dahyabhai <nalin@redhat.com>
(bugid #1717).
Jeremy.
2007-10-10 10:53:05 -05:00
7565019286 r3377: Merge in first part of modified patch from Nalin Dahyabhai <nalin@redhat.com>
for bug #1717.The rest of the code needed to call this patch has not yet been
checked in (that's my next task). This has not yet been tested - I'll do this
once the rest of the patch is integrated.
Jeremy.
2007-10-10 10:53:05 -05:00
0f3f7b035b r3273: Ensure we're consistent in the use of strchr_m for '@'.
Jeremy.
2007-10-10 10:53:03 -05:00
8836621694 r2832: Readd WKGUID-binding to match the correct default-locations of new
User-, Group- and Machine-Accounts in Active Directory (this got lost
during the last trunk-merge).

This way we match e.g. default containers moved by redircmp.exe and
redirusr.exe in Windows 2003 and don't blindly default to cn=Users or
cn=Computers.

Further wkguids can be examied via "net ads search wellknownobjects=*".
This should still keep a samba3-client joining a samba4 dc. Fixes
Bugzilla #1343.

Guenther
2007-10-10 10:52:54 -05:00
50a5a3dbd0 r2569: Patch from Rob Foehl <rwf@loonybin.net>:
- fix typo in libads/ldap_printer.c:39, ads_find_printer_on_server()
  (originally libads-typo.patch)
- fix leak in printing/nt_printing.c, is_printer_published()
  (originally is_printer_published-leak.patch)
- fix double print_backend_init() calls, now only called from main()
- restructuring in printing/nt_printing.c
  - replaced (un)publish_it() with ads-specific functions
  - moved common code to nt_printer_publish()
  - improved error handling in several places
- added check_published_printers() in printing/nt_printing.c, to verify
  that each published printer is actually in the directory at startup
- changed calling semantics of mod_a_printer, dump_a_printer, and
  update_driver_init to be more consistent with the rest of the api and
  reduce some copying
2007-10-10 10:52:46 -05:00
2bf08aaa37 r2091: only use sAMAccountName and not userPrincipalName since the breaks winbindd (lookup_name() only works with the sAMAccountName) -- *please* test this change. My tests all pass but there is probably something I missed 2007-10-10 10:52:31 -05:00
86a61c86a4 r1967: Fix a couple of krb5-DEBUG-messages.
Guenther
2007-10-10 10:52:25 -05:00
7e44193be1 r1789: compiler warnings from SuSE 2007-10-10 10:52:20 -05:00
959da6e176 r1381: fixing behavior found by gd@sernet.de; we must use the userPrincipalName value (host/hostname@REALM) and not the servicePrincipalName (host/fqdn@REALM) in the SASL binds 2007-10-10 10:52:09 -05:00
de80e8b169 r1378: Better debugging so I don't get confused what principal we mean.
Jeremy.
2007-10-10 10:52:08 -05:00
4bdf914cba r1373: Fix from Guenther Deschner <gd@sernet.de> to ensure last error return is not invalid.
Jeremy.
2007-10-10 10:52:08 -05:00
b7267121af r1330: Fix the build for systems without ldap headers 2007-10-10 10:52:07 -05:00
e5b3094c4c r1317: Patch from Joe Meadows "Joe Meadows" <jameadows@webopolis.com> to
add a timeout to the ldap open calls. New parameter, ldap timeout
added.
Jeremy.
2007-10-10 10:52:06 -05:00
e8786506b8 r1285: Put variable definitions into a block before the statements...
Volker
2007-10-10 10:52:04 -05:00
b491e76625 r1282: gcc 3.2 on SuSE 8.2 does not like #ifdefs inside a macro argument (DEBUG).
Volker
2007-10-10 10:52:04 -05:00
b462b8fa2f r1247: Final fix to make this compile on Heimdal.
Jeremy.
2007-10-10 10:52:02 -05:00
d4abeefe3e r1245: I think the parameter for "password" and "data" was reversed.
CHECK THIS !
Jeremy.
2007-10-10 10:52:02 -05:00
92a5dc1880 r1244: More Heimdal compile fixes.
Jeremy.
2007-10-10 10:52:02 -05:00
940f893d48 r1243: Fix so this compiles with Heimdal (in Heimdal krb5_kt_cursor is a struct not a pointer).
Jeremy.
2007-10-10 10:52:02 -05:00
dd07278b89 r1236: Heimdal fixes from Guenther Deschner <gd@sernet.de>, more to come before
it compiles with Heimdal.
Jeremy.
2007-10-10 10:52:01 -05:00
5a1d8c3c9b r1223: Fix valgrind error with realm manipulation.... Damn macros :-(.
Jeremy.
2007-10-10 10:52:01 -05:00