Günther Deschner
b22167fb60
Move inline comment about MSV1_0 flags to IDL.
...
Guenther
2008-03-27 13:06:43 +01:00
Michael Adam
2ae19b5fb8
libwbclient: fix Coverity ID 536 remove duplicate error path (dead code).
...
I leave the more explicit error path in the "if (cmd == 0)" block.
Michael
2008-03-27 11:51:31 +01:00
Michael Adam
451fc9ae05
libreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c
...
This is not a proper bug but the code is clearer now
and we are tracking failure of open separate from that of close.
Michael
2008-03-27 11:46:39 +01:00
Günther Deschner
e16ca32b8e
Re-run make idl.
...
Guenther
2008-03-27 11:04:56 +01:00
Günther Deschner
8474ef334f
Use netr_LogonControlCode in netr_LogonControl2().
...
Guenther
2008-03-27 11:04:56 +01:00
Michael Adam
6dab6cf064
posix_acls: clarify loop condition code, removing unneeded counter variable.
...
Coverity ID 545 falsely classified this as a NULL dereferencing bug.
By putting the loop of walking the list of aces more naturely not using
additional counters, it becomes much more obvious that it is not entered
when dir_ace == NULL.
The same modifications are done for the file_ace loop.
Michael
2008-03-27 10:09:24 +01:00
Günther Deschner
ffe77dc8b0
Fix typo.
...
Guenther
2008-03-27 00:48:08 +01:00
Michael Adam
cd17cc745a
net_conf: fix non-testmode import function.
...
Michael
2008-03-27 00:32:09 +01:00
Michael Adam
ee46f0eca6
libsmbconf: text - pass the cache instead of all private data to pm_process.
...
Michael
2008-03-27 00:32:09 +01:00
Michael Adam
03efb72b46
libsmbconf: text - change the cache to be talloced
...
instead of having it directly as a member in the private data struct.
This makes it easier to flush and initialize the cache.
Michael
2008-03-27 00:32:09 +01:00
Michael Adam
8cb2881249
libsmbconf: in text backend, put flushing of the cache into a helper function.
...
And use it also in the close operation.
Michael
2008-03-27 00:32:09 +01:00
Gerald W. Carter
4ddf58dbdc
Fix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....
...
Make sure that IPv4 addresses are not enclised in []'s.
2008-03-26 16:58:27 -05:00
Günther Deschner
2586dc34e0
Fix winbind NETLOGON cred chain on a samba dc for w2k8 trusts.
...
Guenther
2008-03-26 21:11:53 +01:00
Günther Deschner
9024aecdbf
Re-run make idl.
...
Guenther
2008-03-26 19:27:18 +01:00
Günther Deschner
5d0aa3bbf8
Fix IDL for netr_NETLOGON_INFO_2.
...
W2k8 generated NT_STATUS_ARRAY_BOUNDS_EXCEEDED errors while validating trusts.
Guenther
2008-03-26 19:25:54 +01:00
Günther Deschner
42971b71ac
Fix _netr_LogonControl2(). Return talloced dcname.
...
Guenther
2008-03-26 19:18:08 +01:00
Günther Deschner
4abe30fdae
Add ntsvcs_getdevregprop command to rpcclient.
...
Guenther
2008-03-26 16:46:58 +01:00
Michael Adam
9ef9d4c4e7
net_conf: reformat - re-indent one function call.
...
Michael
2008-03-26 14:55:06 +01:00
Michael Adam
1c6b9a0ac3
net_conf: add casts to avoid compiler warnings.
...
Michael
2008-03-26 14:55:06 +01:00
Michael Adam
5171df66eb
net_conf: rename "ctx" to "mem_ctx" for clarity.
...
There are also smbconf contexts arount...
Michael
2008-03-26 14:55:06 +01:00
Michael Adam
ab4fd03705
net_conf: use talloc_stackframe() instead of talloc_init().
...
Michael
2008-03-26 14:55:06 +01:00
Michael Adam
e41c6650f8
net_conf: fix import function by using the new text backend of smbconf.
...
Originally, lp_load() was used to import files to registry.
This had several bugs. Most notably, options explicitly set to
default values were silently dropped, and all parametric options
were ignored.
This new implementation reads config from the text backend and
stuffs everything verbatim in to the registry backend.
Michael
2008-03-26 14:55:06 +01:00
Michael Adam
4ea5084385
libsmbconf: add a text backend to libsmbconf based on the params.c parser.
...
This is a simple implementation of text backend for libsmbconf.
It is read only. It uses the parser from params.c. It loads the
given config file and holds the parsed lists of strings in memory.
Config is only re-read if the time stamp of the config file has changed.
Brilliant performance on large files is not to be expected since the
string lists are not hashed. This might be added in the future.
Michael
2008-03-26 14:55:05 +01:00
Michael Adam
31b31171bd
loadparm: add userdata parameter to do_section() and do_parameter().
...
The userdata is currently unused. It can be used in the future for
passing a context like in samba4 code.
Michael
2008-03-26 14:55:05 +01:00
Karolin Seeger
2b18b4d02a
WHATSNEW: Start to add changes since 3.2.0pre2.
...
Karolin
2008-03-26 14:03:28 +01:00
Günther Deschner
0c7af8bc13
Strip whitespace in ntsvcs rpc server.
...
Guenther
2008-03-26 12:17:17 +01:00
Günther Deschner
f67632f9b2
Re-run make idl.
...
Guenther
2008-03-26 12:17:17 +01:00
Günther Deschner
b1b6e93aa1
Fill in IDL for PNP_GetDeviceRegProp.
...
Guenther
2008-03-26 12:17:16 +01:00
Günther Deschner
2201a8118c
Comment out some svcctl headers which are now defined in IDL.
...
Guenther
2008-03-26 12:17:16 +01:00
Günther Deschner
0d8181dab7
Re-run make idl.
...
Guenther
2008-03-26 12:17:16 +01:00
Günther Deschner
eeb7c7d9d0
Add svcctl_MgrAccessMask and svcctl_ServiceAccessMask.
...
Guenther
2008-03-26 12:17:16 +01:00
Michael Adam
6d72fc4373
smbconf: reformat - fix intentation.
...
This time this won't make me stumble, since there is no
magic in indented function headers here - no automatic
prototype generation... :-)
Michael
2008-03-26 11:15:04 +01:00
Michael Adam
cdde2e4eac
util_tdb: remove trivial and unused tdb_wipe().
...
It has been replaced by tdb_wipe_all().
Michael
2008-03-26 11:15:03 +01:00
Michael Adam
3d2fdcd50f
use tdb_wipe_all() instead of tdb_wipe() - it is faster...
...
Michael
2008-03-26 10:50:35 +01:00
Michael Adam
1c51bec531
util_tdb: make the _byblob fetch/store functions public again.
...
Users of these are currently being written...
Michael
2008-03-26 10:50:35 +01:00
Günther Deschner
79f7a519f8
Fix wbcAuthenticateUserEx().
...
Guenther
2008-03-26 01:30:02 +01:00
Günther Deschner
0ad00a452f
Add debug statement in auth_winbind to display wbcAuthenticateUserEx error code.
...
Guenther
2008-03-26 01:29:56 +01:00
Volker Lendecke
aa4377561b
Fix a valgrind error
...
In winbind, we're using the info3 struct to send it to the winbind client after
netsamlogon_cache_store. Without this info3->base.account_name.string was
prematurely freed.
2008-03-25 23:36:13 +01:00
Volker Lendecke
559cd9e5a7
Fix a segfault
...
When we get a NT_STATUS_WRONG_PASSWORD for example, my_info3 is not initialized
at all. So first check that we have NT_STATUS_IS_OK(status) before we
dereference my_info3.
2008-03-25 23:36:06 +01:00
Volker Lendecke
38683a7301
Fix typo
2008-03-25 21:35:41 +01:00
Günther Deschner
492c26a936
Re-run make idl (after pidl change for adding header info to cli_ functions).
...
Guenther
2008-03-25 17:55:28 +01:00
Michael Adam
abf02a5a14
util_tdb: add my (C) for the tdb validation code
...
Michael
2008-03-25 15:55:34 +01:00
Michael Adam
d4be4e30cd
util_tdb: add a wrapper tdb_wipe() for traverse with tdb_traverse_delete_fn().
...
Replace all callers of traverse with this tdb_traverse_delete_fn() and
don't export tdb_traverse_delete_fn() anymore.
Michael
2008-03-25 15:55:34 +01:00
Michael Adam
48149a954c
util_tdb: add the tdb_pack_append() prototype to util_tdb.h
...
This function is currently not used but seems useful.
Michael
2008-03-25 15:55:34 +01:00
Michael Adam
b42cf3fc69
util_tdb: make the _byblob functions static - not currently used elsewhere.
...
Michael
2008-03-25 15:55:34 +01:00
Michael Adam
4b9231d33e
util_tdb: group prototypes in util_tdb.h thematically
...
Michael
2008-03-25 15:55:34 +01:00
Michael Adam
edf4dbed27
build: don't autogenerate prototypes for util_tdb and dbwrap anymore.
...
Stick to hand-written headers (that are there anyways).
Add some missing prototypes to util_tdb.h and dbwrap.h.
I did not bother to add a header for each single dbwrap backend
open function but put the prototypes for the open functions into
the central dbwrap.h.
Michael
2008-03-25 15:55:34 +01:00
Karolin Seeger
c967b62dd3
Fix usage message for 'net idmap dump'.
...
Karolin
2008-03-25 12:00:42 +01:00
Günther Deschner
b217dd674e
Fix _winreg_QueryValue().
...
Guenther
2008-03-25 10:56:56 +01:00
Günther Deschner
1570e1c597
Re-run make idl.
...
Guenther
2008-03-25 10:54:27 +01:00