sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-06-24 15:17:06 +03:00
Code
66,053 Commits 62 Branches 1,161 Tags
Commit Graph

906 Commits

Author SHA1 Message Date
Simo Sorce
d6a73ad85b s3-spoolss: Removed the Phantom DeviceMode. 
This was a hack that required a special client from HP.
The client code has never been released and was discontinued,
so this code was just dead weight.

Signed-off-by: Günther Deschner <gd@samba.org>
 2010-05-18 15:52:28 +02:00
Günther Deschner
8951c8301a s3-secdesc: remove "typedef struct security_acl SEC_ACL". 
Guenther
 2010-05-18 12:30:12 +02:00
Günther Deschner
8bc9c343c4 s3-secdesc: remove "typedef struct sec_desc_buf SEC_DESC_BUF". 
Guenther
 2010-05-18 12:30:11 +02:00
Jelmer Vernooij
b8268cf7b0 s3: Remove use of iconv_convenience. 2010-05-18 11:45:31 +02:00
Günther Deschner
fe31b67d5e s3-registry: only include registry headers when really needed. 
Guenther
 2010-05-18 01:15:38 +02:00
Günther Deschner
049416c285 s3-spoolss: make several notify functions static. 
Guenther
 2010-05-06 13:41:51 +02:00
Günther Deschner
c6ebab846d s3: only include gen_ndr headers where needed. 
This shrinks include/includes.h.gch by the size of 7 MB and reduces build time
as follows:

ccache build w/o patch
real    4m21.529s
ccache build with patch
real    3m6.402s

pch build w/o patch
real    4m26.318s
pch build with patch
real    3m6.932s

Guenther
 2010-05-06 00:22:59 +02:00
Andreas Schneider
6683b0d4b6 s3-lib: Create a sec_desc_merge and sec_desc_merge_buf function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-05-04 19:37:39 +02:00
Günther Deschner
1691eb73da s3-spoolss: add support for SetJobInfo level 1 (for jobfile rename). 
Guenther
 2010-04-28 00:10:40 +02:00
Günther Deschner
698b7780c9 s3-spoolss: make switch in _spoolss_AddPrinterDriver() a bit more clear. 
Guenther
 2010-04-23 11:41:25 +02:00
Günther Deschner
a14938377e s3-spoolss: make sure AddPrinterDriver calls into AddPrinterDriverEx. 
Not vice versa. Also disable some info levels in AddPrinterDriver according to
MS-RPRN 3.1.4.4.1.

Found by torture test.

Guenther
 2010-04-23 03:04:47 +02:00
Günther Deschner
413ffe9adb s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths. 
Found by torture test.

Guenther
 2010-04-23 02:34:43 +02:00
Günther Deschner
63b111bd32 s3: add iconv_convenience handle to pull/push sz helpers. 
Guenther
 2010-04-09 18:33:45 +02:00
Günther Deschner
65c5b786ca s3-spoolss: Fix some issues in _spoolss_AddForm. 
Found by torture test.

Guenther
 2010-04-07 23:53:18 +02:00
Günther Deschner
34ada1d540 s3-spoolss: Fix potential memleak in _spoolss_AddForm and _spoolss_SetForm. 
Guenther
 2010-04-07 23:53:18 +02:00
Günther Deschner
dcec932279 s3-spoolss: return info for the correct printjob in _spoolss_GetJob(). 
Guenther
 2010-03-26 14:36:47 +01:00
Günther Deschner
c9cc26ef62 s3-spoolss: Fix _spoolss_EnumPrinterData. 
Guenther
 2010-03-15 14:41:58 +01:00
Günther Deschner
5e48aa7ebb s3-spoolss: wrap _spoolss_EnumPrinterData() around _spoolss_EnumPrinterDataEx(). 
This removes some dependencies to registry code.

Guenther
 2010-03-13 01:12:22 +01:00
Jeremy Allison
59545276f2 Try and fix bug #7233 - print fails with jobs >4GB from Win7 clients. 
Remove an arbitrarty 4G B limit that *doesn't need to be there* !
Jeremy.
 2010-03-10 17:46:09 -08:00
Günther Deschner
5532654985 s3-spoolss: fix _spoolss_EnumPrinterDataEx after idl 
Guenther
 2010-03-05 15:18:01 +01:00
Günther Deschner
fbb6d00eed s3-spoolss: fix _spoolss_GetPrinterDataEx after IDL change. 
Guenther
 2010-03-05 15:18:00 +01:00
Günther Deschner
9a93483279 s3-spoolss: fix _spoolss_SetPrinterData{Ex} after IDL change. 
Guenther
 2010-03-05 15:17:59 +01:00
Günther Deschner
3ca8d28bb7 spoolss: fix build and version in spoolss_PrinterInfo0 (aka PRINTER_INFO_STRESS). 
Guenther
 2010-02-26 17:39:21 +01:00
Günther Deschner
10c8b0fb73 s3-spoolss: Save entire devicemode. 
found by RPC-SPOOLSS-PRINTER torture test.

Guenther
 2010-02-25 14:35:41 +01:00
Stefan Metzmacher
a2cd203982 s3:spoolss: construct the devmode the same way for level 2 and 8 
metze
 2010-02-23 16:41:26 +01:00
Günther Deschner
13533e12fd s3-spoolss: add support for _spoolss_SetPrinter level 8. 
Guenther
 2010-02-19 00:42:25 +01:00
Günther Deschner
b3c2b2260a s3-spoolss: Fix _spoolss_EnumPrinters servername handling. 
Guenther
 2010-02-18 12:40:36 +01:00
Günther Deschner
43e3d8f51d s3-spoolss: fix return code of spoolss_DeletePrinter. 
When the printer has been removed by the "deleteprinter command", we need to
check if it is still there and then fail, not fail if we successfully removed
it (found by RPC-SPOOLSS-PRINTER).

Guenther
 2010-02-18 02:19:59 +01:00
Günther Deschner
8ce66fba03 s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer! 
Guenther
 2010-02-18 02:19:50 +01:00
Günther Deschner
2d2db2a822 s3-spoolss: more AddPrinter{Ex} checks. 
Windows will allow to add a non-shared printer that is returned by EnumPrinters.
Samba has no notion of non-shared local printers yet, so just make sure to
behave like we do elsewhere: a printer autoloaded by samba or added to samba is
shared.

Guenther
 2010-02-18 02:19:42 +01:00
Günther Deschner
5cff7e1692 s3-spoolss: add some printer info validation for AddPrinter calls. 
Guenther
 2010-02-18 02:19:33 +01:00
Günther Deschner
ddbda92f87 spoolss: disable GetPrinterDriver level 101 (as called by XP). 
We still dont get the marshalling right, disable and XP will just fall back to
level 6.

Guenther
 2010-02-15 11:17:29 +01:00
Günther Deschner
a16e974593 spoolss: allow to set server architecture via parametric option. 
This allows to set "spoolss:architecture = 'Windows x64'" for debugging purpose.

Guenther
 2010-02-11 13:29:59 +01:00
Günther Deschner
25001bbd1b s3-spoolss: implement spoolss_EnumJobs level 3. 
Level 3 has been added with NT 4.0 and Windows 7 (at least 64bit version) makes
use of it in order to display queued jobs. Windows 7 will *not* fall back to
level 2 if we just return WERR_UNKNOWN_LEVEL, instead there will be no printjobs
displayed at all.

Guenther
 2010-02-11 13:27:46 +01:00
Jeremy Allison
a056eb85ff Missed one check on the memcpy for bug #7063. 
Jeremy.
 2010-02-09 14:56:12 -08:00
Jeremy Allison
539bbf8653 Second part of fix for bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core dumps. 
Ensure we have no naked memcpy calls. This isn't a crash bug (it's
already checked in the data_blob_talloc_zero() above, but I want to
get into the pattern of having all memcpy's covered by safety checks.

Jeremy.
 2010-02-09 14:48:15 -08:00
Jeremy Allison
110a6f29f0 Fix bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core dumps. 
Reported and found by Martin Hochreiter <linuxbox@wavenet.at>.
Ensure we copy the right amount of registry data into the outgoing
buffer.

Jeremy.
 2010-02-02 16:32:51 -08:00
Günther Deschner
f720f7512e s3-spoolss: stricter name checks when opening back-channel notify connection. 
Make sure to always check if the name the client passed in
spoolss_RemoteFindFirstPrinterChangeNotifyEx is not one of our names.

Guenther
 2010-01-19 14:14:30 +01:00
Günther Deschner
f20effc437 s3-spoolss: fix enumprinter key client and server. 
Guenther
 2009-12-10 17:48:50 +01:00
Günther Deschner
e14fb8f913 s3-spoolss: use SPOOLSS_ARCHITECTURE_ALL in driver enum server code. 
Guenther
 2009-12-08 16:20:51 +01:00
Günther Deschner
7770d1492b s3-spoolss: cleanup _spoolss_EnumPrinterDrivers(). 
Guenther
 2009-12-08 11:51:02 +01:00
Günther Deschner
0efbd932b6 s3-spoolss: remove unused architecture from fill_printer_driver_info1(). 
Guenther
 2009-12-08 11:50:54 +01:00
Günther Deschner
af08962c94 s3-spoolss: remove ridiculous amount of duplicate driver code. 
Guenther
 2009-12-08 11:50:47 +01:00
Günther Deschner
1c9eba40ae s3-spoolss: fully support level 8 drivers. 
Guenther
 2009-12-08 11:50:40 +01:00
Günther Deschner
35c50dcce3 s3-spoolss: use driver level info8 everywhere in spoolss server internally. 
Guenther
 2009-12-08 11:05:21 +01:00
Günther Deschner
ef9d6580ef s3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx. 
Guenther
 2009-12-07 14:42:13 +01:00
Günther Deschner
167dca0cbf s3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx. 
Guenther
 2009-12-07 14:42:13 +01:00
Günther Deschner
778124ea32 s3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx. 
Guenther
 2009-12-07 14:42:12 +01:00
Günther Deschner
459a968fb4 s3-spoolss: handle SEC_FLAG_MAXIMUM_ALLOWED in spoolss_OpenPrinterEx. 
In case someone (smbtorture4) requests SEC_FLAG_MAXIMUM_ALLOWED, translate it
to a request of PRINTER_ACCESS_ADMINISTER.

Guenther
 2009-12-03 23:49:03 +01:00
Günther Deschner
5f60855ba2 samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey. 
This should finally resolve the endian issues we were seeing on sparc and is
much cleaner for spoolss clients and servers.

Guenther
 2009-12-02 14:56:17 +01:00