1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-25 19:17:10 +03:00

91 Commits

Author SHA1 Message Date
Günther Deschner
3aab0c701c s3-build: only include rpc_misc.h where needed.
Guenther
2010-08-26 00:26:01 +02:00
Jeremy Allison
15d3541c67 Eliminate any chance of a class of "uninitialized auto variable" errors.
Jeremy.
2010-08-13 10:49:18 -07:00
Jeremy Allison
84fd910c34 Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code.
In the file rpc_server.c, function _winreg_QueryValue()

uint8_t *outbuf

Should be :

uint8_t *outbuf = NULL;

As it is later freed by

      if (free_buf) SAFE_FREE(outbuf);

in some cases, this frees the unintialized outbuf, which causes a coredump.
2010-08-12 15:16:42 -07:00
Andreas Schneider
31a4240b8d s3-winreg: Use struct pipes_struct. 2010-07-28 10:39:24 +02:00
Simo Sorce
f4c6c7e7b8 Move the remnants of rpc_parse code under registry/
The registry code is the only last user of this code.
Move everything under registry/ and hope someone will get rid od
it completely from there in the future.

Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:18 +02:00
Günther Deschner
786198e523 s3-registry: remove unused reg_util_marshalling code.
Guenther
2010-07-02 10:50:21 +02:00
Günther Deschner
b381fba089 s3-registry: avoid using registry_value union.
Just pull and push data as is.

Guenther
2010-07-02 10:50:21 +02:00
Günther Deschner
2a4bd64973 s3-winreg: implement _winreg_QueryMultipleValues().
Guenther
2010-06-30 21:46:08 +02:00
Günther Deschner
de0d9e0bff s3-winreg: implement _winreg_QueryMultipleValues2().
Guenther
2010-06-30 21:46:08 +02:00
Günther Deschner
b6a2cea74d s3-security: use shared "Standard access rights.".
Guenther
2010-06-03 11:00:26 +02:00
Michael Adam
e829b42978 s3:registry: extract registry_pull/push_value prototypes into own header
reg_util_marshalling.h and use them only where needed.
2010-05-25 10:35:27 +02:00
Michael Adam
5a92d88f38 s3:registry: extract reg_perfcount prototypes into header of their own.
And use them only when necessary.
2010-05-25 10:35:26 +02:00
Günther Deschner
fe31b67d5e s3-registry: only include registry headers when really needed.
Guenther
2010-05-18 01:15:38 +02:00
Andreas Schneider
4567bf9df5 s3-winreg_nt: Fixed QueryValue with data=NULL to get the length. 2010-04-16 15:17:59 +02:00
Günther Deschner
ffcaa73280 s3-winreg: add winreg_DeleteKeyEx stub.
Guenther
2010-04-09 00:27:58 +02:00
Günther Deschner
e46d3d9475 s3-winreg: change notify call has no meaning when called remotely.
Just return not supported to make smbtorture happy.

Guenther
2010-03-16 15:29:14 +01:00
Günther Deschner
24a7f8f2db s3-winreg: make QueryValue pass RPC-WINREG test again.
Guenther
2010-03-11 20:48:24 +01:00
Günther Deschner
96a38e387e s3-winreg: fix some function names in debug statements.
Guenther
2010-03-11 20:23:47 +01:00
Günther Deschner
cddc542ba5 s3-winreg: Fix _winreg_QueryValue crash bugs and implement windows behavior.
Found by RPC-WINREG smbtorture test.

Guenther
2010-03-11 12:48:43 +01:00
Günther Deschner
c5ba525748 s3-winreg: add some debug statements to _winreg_QueryValue().
Guenther
2010-03-10 16:12:22 +01:00
Günther Deschner
1bc83b984d s3-winreg: fill in some inline comments.
Guenther
2009-12-07 14:41:15 +01:00
Günther Deschner
5d46530053 s3-winreg: remove trailing whitespace.
Guenther
2009-12-07 14:41:15 +01:00
Günther Deschner
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
Guenther
2009-11-26 20:03:17 +01:00
Günther Deschner
531af136f9 s3: remove POLICY_HND.
Guenther
2009-03-18 23:22:29 +01:00
Volker Lendecke
84292022bf Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn 2009-01-08 22:29:54 +01:00
Volker Lendecke
907f126d3e Get rid of pipes_struct->pipe_user, we have server_info now --- YESSS! 2008-11-24 11:39:03 +01:00
Günther Deschner
42a8de780b s3: fix s3 winreg server after idl changes.
Guenther
2008-10-15 21:45:05 +02:00
Jelmer Vernooij
5d408ccf83 Rename reboot -> do_reboot since the first is a reserved name on FreeBSD. 2008-10-15 16:25:06 +02:00
Jelmer Vernooij
881b36f4cf Share initshutdown.idl. 2008-10-15 16:13:02 +02:00
Zach Loafman
863a6aa07e Fix warnings on FreeBSD-based platforms
Fix two shadowed declaration warnings on FreeBSD-based platform:
'reboot' is a 4.0BSD syscall in unistd.h and 'tcp_seq' is a typedef in
netinet/tcp.h.
(This used to be commit 14d2a4da1da38d6f69c63505d35990322f253e5d)
2008-07-22 15:00:48 +02:00
Volker Lendecke
c404c8950d Fix a crash in _winreg_QueryValue
Coverity ID 474, value_length and type are both unique, not ref pointers and
can thus be NULL.

Karolin, please merge this to -stable.

Thanks,

Volker
(cherry picked from commit 999533c0ccced59141d8baff5bc248d63e2a966f)
(This used to be commit 7e07ec68f15908a998f83d615a1b4d1349935a54)
2008-06-13 15:33:51 +02:00
Michael Adam
cc2f5fd1b5 srv_winreg: add a debug message to _winreg_CreateKey().
Michael
(This used to be commit 971f6749ed23523f6eafe5136f6d4c920c20aec4)
2008-03-28 16:19:35 +01:00
Günther Deschner
055224640b Fix _winreg_QueryValue().
Guenther
(This used to be commit b217dd674e22b6a7cc492f1a84a37ddc4ddca663)
2008-03-25 10:56:56 +01:00
Marc VanHeyningen
e06aa46b9f Coverity fixes
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-17 20:52:25 +01:00
Volker Lendecke
932c287a40 Fix Coverity ID 565
This would crash safely
(This used to be commit 0f14357c86aee9a76ffbb45ea6419f4cc4106d62)
2008-03-05 18:45:34 +01:00
Michael Adam
d31806dffe Fix a comment. REGISTRY_KEY has vanished from srv_winreg_nt.c
(It is reg_api time)

Michael
(This used to be commit d94998e46ba0faac3fa625e8292d452ad52b8e55)
2008-02-18 17:48:19 +01:00
Michael Adam
355faf2e3d Move the implementation of _winreg_RestoreKey to reg_api.c
This removes the internals of reg_api from srv_winreg_nt.c entirely,
only reg_api is used there, now. This enlarges the dependencies of
reg_api somewhat now since it adds regfio. But this can be separated
out later. The current goal is to achieve a complete use of reg_api.

Michael
(This used to be commit 2222acbac955cd6d5bd48d1ce5cf4b4c7c067093)
2008-02-15 16:23:10 +01:00
Michael Adam
c720a0e228 Move implementation of _winreg_SaveKey() from srv_winreg_nt.c to reg_api.c
This gives a new function reg_savekey() and hides a piece of
the backend code from srv_winreg_nt.c. One step towards using
reg_api throughout samba code.

Michael
(This used to be commit bf6340d00dd631fdc909c20632250977a3a112c4)
2008-02-15 16:23:10 +01:00
Michael Adam
32a8e74078 Add a reg_getversion() function to reg_api and use it in srv_winreg_nt.c.
Michael
(This used to be commit 903223b160eef6ba6ff19a8bfef19e5fe7008631)
2008-01-17 16:25:11 +01:00
Michael Adam
7bfdcbcfdc Use reg_[gs]etkeysecurity() instead of regkey_[gs]et_secdes().
Rationale: Use reg_api instead of backend functions.

Michael
(This used to be commit f986a708be15dd9b9fc28b9862f64f2d0f94accc)
2008-01-17 16:25:11 +01:00
Volker Lendecke
99b86e4a26 Some C++ fixes
(This used to be commit 5c392c4c6e277a24d0d477902dc7856b2b46ee53)
2007-12-21 09:58:21 +01:00
Volker Lendecke
addf598cde Some C++ warnings
(This used to be commit 5ab82d4f574f2a2e2761e9e414c66a70aeffb05d)
2007-12-21 09:58:20 +01:00
Jeremy Allison
9c8bd95acf Fixed obvious typo.
Jeremy.
(This used to be commit 9755c5311416f17bac0a848d027cafb3fd487618)
2007-11-27 23:00:11 -08:00
Jeremy Allison
3a452a15b7 Remove pstring from everything in rpc_server except
srv_spoolss_nt.c and srv_srvsvc_nt.c.
They're next :-).
Jeremy.
(This used to be commit 55b4f9d003b036af69085f7b64e0df08c5ba440d)
2007-11-27 11:22:58 -08:00
Jeremy Allison
68be9a8200 More pstring removal. This one was tricky. I had to add
one horror (pstring_clean_name()) which will have to
remain until I've removed all pstrings from the client code.
Jeremy.
(This used to be commit 1ea3ac80146b83c2522b69e7747c823366a2b47d)
2007-11-15 14:19:52 -08:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-18 17:40:25 -07:00
Volker Lendecke
0ebab65706 r25534: Apply some const
Why? It moves these structs from the data into the text segment, so they
will never been copy-on-write copied. Not much, but as in German you say
"Kleinvieh macht auch Mist...."
(This used to be commit 0141e64ad4972232de867137064d0dae62da22ee)
2007-10-10 12:31:12 -05:00
Andrew Tridgell
153cfb9c83 r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10 12:28:27 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10 12:28:20 -05:00
Gerald Carter
255b807802 r23633: Fix a couple of crash bugs pointed out by Volker caused by an old
change from a pstring to a char* and still trying use pstrcpy().
(This used to be commit 21dc46a2bad6fee720f0f591e1051aa7675c77c8)
2007-10-10 12:23:39 -05:00