1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
Commit Graph

1180 Commits

Author SHA1 Message Date
Volker Lendecke
d4c5d5ffb3 r22613: Fix an uninitialized variable warning 2007-10-10 12:19:50 -05:00
Jeremy Allison
8968808c3b r22589: Make TALLOC_ARRAY consistent across all uses.
Jeremy.
2007-10-10 12:19:49 -05:00
Volker Lendecke
1c0ceb5fe2 r22125: Fix a warning 2007-10-10 12:19:14 -05:00
Jeremy Allison
f3ffb3f984 r22096: become_root_uid_only() is unneeded - it's only used in
messages.c. Refactor to use become_root() instead and
make it local to messages.c
Jeremy.
2007-10-10 12:19:11 -05:00
Gerald Carter
fc1aeee52d r22066: Ensure that winbind can resolve SIDs in the S-1-22-{1,2}
domain to a uid.gid using the idmap_passdb backend.
2007-10-10 12:19:09 -05:00
Stefan Metzmacher
3a28443079 r22009: change TDB_DATA from char * to unsigned char *
and fix all compiler warnings in the users

metze
2007-10-10 12:19:00 -05:00
Stefan Metzmacher
fa322f0cc9 r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.

also fix all the callers to prevent compiler warnings

metze
2007-10-10 12:18:59 -05:00
Stefan Metzmacher
5a5579d842 r21983: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

metze
2007-10-10 12:18:56 -05:00
Stefan Metzmacher
9ebaa4c573 r21982: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

metze
2007-10-10 12:18:55 -05:00
Stefan Metzmacher
2d2f809968 r21981: as we use tdb_trans_store(), we should also use tdb_trans_delete()
metze
2007-10-10 12:18:55 -05:00
Jeremy Allison
8ff76a9cb8 r21954: Someone misused a '!' instead of a '~' for a binary NOT
command. Jerry, Simo, please check.
Jeremy.
2007-10-10 12:18:52 -05:00
James Peach
86a70adb6a r21881: Make sure we are very specific when testing whether a backand can handle a
particular SID. Make sure that the passdb backend will accept the same set
range of local SIDs that the idmap system sends it.

Simo, Jerry - this is a 3_0_25 candidate. Can you please review?
2007-10-10 12:18:43 -05:00
Volker Lendecke
d0d16cc55a r21853: Fix a valgrind error 2007-10-10 12:18:38 -05:00
Volker Lendecke
fd0ee6722d r21831: Back out r21823 for a while, this is going into a bzr tree first.
Volker
2007-10-10 12:18:37 -05:00
Volker Lendecke
f94e5af72e r21823: Let secrets_store_machine_password() also store the account name. Not used
yet, the next step will be a secrets_fetch_machine_account() function that
also pulls the account name to be used in the appropriate places.

Volker
2007-10-10 12:18:36 -05:00
Volker Lendecke
4efc7b4598 r21819: Wrap all steps in secrets_store_machine_password into one single
transaction. Succeed all or store nothing.

Volker
2007-10-10 12:18:36 -05:00
Volker Lendecke
f88eab91c4 r21818: Remove some unused code 2007-10-10 12:18:36 -05:00
Volker Lendecke
af3308ce5a r21784: Replace smb_register_idle_event() with event_add_timed(). This fixes winbind
who did not run the idle events to drop ldap connections.

Volker
2007-10-10 12:18:33 -05:00
Volker Lendecke
a2dc1f62fd r21782: Fix a memleak 2007-10-10 12:18:33 -05:00
James Peach
7246b31696 r21738: Remove unused file. 2007-10-10 12:18:27 -05:00
Jeremy Allison
df07a662e3 r21609: Fix memory leaks in error code paths (and one in winbindd_group.c).
Patch from Zack Kirsch <zack.kirsch@isilon.com>.
Jeremy.
2007-10-10 12:18:16 -05:00
Jeremy Allison
cbe725f1b0 r21608: Fix a couple of memleaks in error code paths before
Coverity finds them :-)
Jeremy.
2007-10-10 12:18:16 -05:00
Simo Sorce
5b4838f62a r21606: Implement escaping function for ldap RDN values
Fix escaping of DN components and filters around the code
Add some notes to commandline help messages about how to pass DNs

revert jra's "concistency" commit to nsswitch/winbindd_ads.c, as it was
incorrect.
The 2 functions use DNs in different ways.

- lookup_usergroups_member() uses the DN in a search filter,
and must use the filter escaping function to escape it
Escaping filters that include escaped DNs ("\," becomes "\5c,") is the
correct way to do it (tested against W2k3).

- lookup_usergroups_memberof() instead uses the DN ultimately as a base dn.
Both functions do NOT need any DN escaping function as DNs can't be reliably
escaped when in a string form, intead each single RDN value must be escaped
separately.

DNs coming from other ldap calls (like ads_get_dn()), do not need escaping as
they come already escaped on the wire and passed as is by the ldap libraries

DN filtering has been tested.
For example now it is possible to do something like:
'net ads add user joe#5' as now the '#' character is correctly escaped when
building the DN, previously such a call failed with Invalid DN Syntax.

Simo.
2007-10-10 12:18:16 -05:00
Gerald Carter
6a69caf690 r21507: Fix some "cannot access LDAP when no root" bugs.
The two culprits were

* pdb_get_account_policy()
* pdb_get_group_sid()
2007-10-10 12:18:09 -05:00
Volker Lendecke
a5a1c8c785 r20998: Fix debug message 2007-10-10 12:17:25 -05:00
Gerald Carter
2a7311db27 r20985: leave room for terminating NULL when printing password hashes via 'pdbedit -L -w' 2007-10-10 12:17:22 -05:00
Volker Lendecke
b48ea4d777 r20851: To read account policies from LDAP we need root.
Volker
2007-10-10 12:17:13 -05:00
Volker Lendecke
3c879745cf r20824: Send access to the trusted domain passwords through the pdb backend, so that
in the next step we can store them in LDAP to be replicated across DCs.

Thanks to Michael Adam <ma@sernet.de>

Volker
2007-10-10 12:17:10 -05:00
Volker Lendecke
d78c18a9fa r20707: Clean up pdb_interface.c a bit -- patch from Michael Adam <ma@sernet.de> 2007-10-10 12:17:04 -05:00
Volker Lendecke
f1f5d035db r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> for the hint. 2007-10-10 12:17:01 -05:00
Volker Lendecke
7e444e1612 r20614: Dummy-checkin to trigger the build 2007-10-10 12:16:58 -05:00
Andrew Bartlett
e43aa4e03d r20402: Fix spelling: samba bug #4292 debian #402392 2007-10-10 12:16:46 -05:00
Simo Sorce
7167e7b26a r20243: Make lookup_name resolve both the mapped and the real unix group name 2007-10-10 12:16:35 -05:00
Volker Lendecke
902d81becb r20212: Attempt to fix the Solaris build 2007-10-10 12:16:32 -05:00
Simo Sorce
4a81ee9608 r20169: Support for fallback to legacy mapping code was not completely tested.
Add necessary fixes.
2007-10-10 12:16:28 -05:00
Simo Sorce
50cd8bffee r20116: Start merging in the work done to create the new idmap subsystem.
Simo.
2007-10-10 12:16:25 -05:00
Jeremy Allison
0ffca7559e r20090: Fix a class of bugs found by James Peach. Ensure
we never mix malloc and talloc'ed contexts in the
add_XX_to_array() and add_XX_to_array_unique()
calls. Ensure that these calls always return
False on out of memory, True otherwise and always
check them. Ensure that the relevent parts of
the conn struct and the nt_user_tokens are
TALLOC_DESTROYED not SAFE_FREE'd.
James - this should fix your crash bug in both
branches.
Jeremy.
2007-10-10 12:16:24 -05:00
Volker Lendecke
eba404e668 r19945: Fix a segfault -- lookup_rids needs to init the names even on failure 2007-10-10 12:16:14 -05:00
Volker Lendecke
714971b34a r19943: Fix bug 4267 -- Thanks to David! 2007-10-10 12:16:12 -05:00
Gerald Carter
5b3ac400a7 r19579: BUG 4075: patch from Dmitry Butskoy <dmitry@butskoy.name>.
Allow smbd to use winbindd to lookup uids/gids outside the
idmap range if 'winbind trusted domains only = yes'
2007-10-10 12:15:42 -05:00
Gerald Carter
a6366b40b3 r19419: BUG 4109: Patch from Timur Bakeyev. Fix bug causing smbd to turn off
winbindd and fail to disable the _NO_WINBIND environment.
2007-10-10 12:15:34 -05:00
Volker Lendecke
6c4d68d849 r19083: Fix objectclass 2007-10-10 12:15:09 -05:00
Jim McDonough
21abbeaee9 r19058: Implement "user cannot change password", and complete "user must change
password at next logon" code.  The "password last set time" of zero now
means "user must change password", because that's how windows seems to
use it.  The "can change" and "must change" times are now calculated
based on the "last set" time and policies.

We use the "can change" field now to indicate that a user cannot change
a password by putting MAX_TIME_T in it (so long as "last set" time isn't
zero).  Based on this, we set the password-can-change bit in the
faked secdesc.
2007-10-10 12:15:06 -05:00
Jim McDonough
fd5761c9e5 r18722: Fix up password change times. The can change and must change times are
calculated based on the last change time, policies, and acb flags.

Next step will be to not bother storing them.  Right now I'm just trying to
get them reported correctly.
2007-10-10 12:00:52 -05:00
Günther Deschner
7db6ce295a r18703: Fix the annoying effect that happens when nscd is running:
We usually do not get the results from user/group script modifications
immediately. A lot of users do add nscd restart/refresh commands into
their scripts to workaround that while we could flush the nscd caches
directly using libnscd.

Guenther
2007-10-10 12:00:49 -05:00
Gerald Carter
4cea9bfca1 r18684: pdb_get_group_sid() has to use the Get_Pwnam_alloc() call
to ensure it finds the Unix user.
2007-10-10 12:00:47 -05:00
Jelmer Vernooij
5de76767e8 r18654: Rename "struct uuid" => "struct GUID" for consistency. 2007-10-10 11:52:19 -05:00
Volker Lendecke
d72ba9ed12 r18527: Janitor for Jeremy ;-) 2007-10-10 11:51:46 -05:00
Jeremy Allison
f787b9d156 r18483: Ensure all pdb_XXX calls are wrapped in become_root()/unbecome_root()
pairs. Should fix bug #4097.
Jeremy.
2007-10-10 11:51:44 -05:00
Volker Lendecke
fa8b2e2a58 r18313: Nobody said "no" (yet.... gd?), so commit it:
Remove the account_policy_migrated() thingy, and make cache_account_policy_set
use gencache. Account policies are now handled like groups and users are with
respect to "passdb backend".

Volker
2007-10-10 11:51:19 -05:00