1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

35953 Commits

Author SHA1 Message Date
Andrew Bartlett
d73db405f7 s3-safe_string: Add checked_strlcpy()
This is strlcpy, just with an extra check of the parameters with
sizeof(), use only where that works.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 23 03:39:35 CET 2011 on sn-devel-104
2011-03-23 03:39:35 +01:00
Andrew Bartlett
1d22c3919d s3-safe_str: Futher simplify the macros by removing indirection
Now that we don't need to pass in the function name and string,
another level of indirection can be safely removed, and the operation
of these macros made much clearer.

Andrew Bartlett
2011-03-23 12:49:39 +11:00
Andrew Bartlett
1923b78209 s3-lib Remove the clobber_region() code.
This code wrote to the full buffer in fstrcpy(), pstrcpy() and other
fixed-length string manipulation functions.

The hope of this code was to find out at run time if we were mixing up
pstring and fstring etc, and to record where this came from.  It has a
runtime performance impact (particularly if compiled with
--enable-developer).

It is being removed because of the complexity it adds, and the
distinct lack of bugs that this complexity has been credited in
finding.

The macro-based compile-time checking of string sizes remains.

Andrew Bartlett
2011-03-23 12:49:39 +11:00
Andrew Tridgell
7aef9c3fe0 s3-config: say which config file we failed to open
saves having to strace it to work that out
2011-03-23 12:19:29 +11:00
Andrew Tridgell
6e8b6358ec fault: fixed smb_panic() prototypes
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar 23 01:51:44 CET 2011 on sn-devel-104
2011-03-23 01:51:44 +01:00
Andrew Tridgell
580997ede0 fault: get fault.c ready for use by s4
this moves the s3 specific dumpcore code into source3/lib/dumpcore.c,
and uses a function pointer to setup which smb_panic call to use
2011-03-23 11:03:57 +11:00
Andrew Tridgell
058c3bb923 fault: moved s3 fault.c to top level 2011-03-23 11:03:57 +11:00
Michael Adam
f50a25cc8d s3:idmap: make sure that the id mapping system is initialized for first access 2011-03-22 22:49:58 +01:00
Michael Adam
0109604f53 s3:loadparm: set the default "idmap config * : backend" in initialize_globals(). 2011-03-22 22:49:58 +01:00
Michael Adam
ac8836e77f s3:loadparm: deprecate "idmap uid/gid/backend" and have them set "idmap config * : range/backend" 2011-03-22 22:49:57 +01:00
Michael Adam
474f6a0f75 s3:loadparm: remove unused parameter "idmap read only".
This has not been released yet and is now useless since we
use the "idmap config * : read only = ..." syntax.
2011-03-22 22:49:57 +01:00
Michael Adam
ae5d35b09e s3:idmap: remove (now) unneeded function parse_idmap_module() 2011-03-22 22:49:57 +01:00
Michael Adam
efc1d38b32 s3:idmap: simply call idmap_init_named_domain for "*" in idmap_init_default_domain
The default domain "*" is now treated exactly the same as other explicitly
configured domains.
2011-03-22 22:49:57 +01:00
Michael Adam
ca8c493bfd s3:idmap: remove passdb argument from idmap_init_domain() 2011-03-22 22:49:57 +01:00
Michael Adam
82853a613b s3:idmap: remove the params argument from the init function 2011-03-22 22:49:56 +01:00
Michael Adam
98854207fe s3:idmap: remove special treatment of domain "*" from idmap_ldap_init.
The default config via domain "*" is now treated just as the explicit
domain configs.
2011-03-22 22:49:56 +01:00
Michael Adam
7511f080b4 s3:idmap: remove use of params from idmap_ldap_init - it is not used any more 2011-03-22 22:49:56 +01:00
Michael Adam
0a3627d249 s3:idmap: remove the special treatment of the default domain "*" from idmap_init_domain 2011-03-22 22:49:56 +01:00
Andrew Tridgell
c8297073db s3-fault: removed the cont_fn from fault_setup()
cont_fn() was supposed to be a way to continue after a seg fault. It
could never be called however, as smb_panic() from fault_report()
could never return, as dump_core() never returns at the end of
smb_panic()

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 22 05:07:58 CET 2011 on sn-devel-104
2011-03-22 05:07:58 +01:00
Stefan Metzmacher
f0ec69b535 s3:smbd: access checks should not depend on share mode flags
metze
2011-03-21 22:35:19 +01:00
Volker Lendecke
16155812e0 s3: Fix Coverity ID 1048, CHECKED_RETURN
This is a real bug: tevent_req_set_endtime already calls tevent_req_nomem.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 21 16:29:22 CET 2011 on sn-devel-104
2011-03-21 16:29:22 +01:00
Volker Lendecke
8dc93bed09 s3: Fix Coverity ID 770, REVERSE_INULL
We dereference "res" in various places, no point in checking. All current
callers send "res!=NULL".
2011-03-21 15:40:10 +01:00
Volker Lendecke
4828feddb7 s3: Fix early tldap_search cancels
A callback of tldap_search_send might not interested in the rest of the results
and could do a TALLOC_FREE of the search request. In this case, "subreq" is
already free'ed. So we have to set it to pending before the callback is called.
The TALLOC_FREE of the search request will set it to non-pending again via
tldap_msg_destructor.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 20 11:26:57 CET 2011 on sn-devel-104
2011-03-20 11:26:57 +01:00
Stefan Metzmacher
daddccb514 s3:smbd: remove uses of "./" in unlink_internals()
Commit 78b931ce6c840ade646c1c6030fa2d6acb77208b tried to do that,
but didn't have any effect.

metze
2011-03-19 10:10:25 +01:00
Christian Ambach
ed46dfc4f1 s3: use getgrset() when it is available
When getgrouplist() is not defined, use getgrset() if it is defined
instead of using the initgroups() + getgroups() combo

Major contributions from Yannick Bergeron <yaberger@ca.ibm.com>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 19 10:09:38 CET 2011 on sn-devel-104
2011-03-19 10:09:38 +01:00
Günther Deschner
33b8d0a6ff s3-waf: use HAVE_ADS env to decide whether to build libads.so
Guenther
2011-03-19 00:11:18 +01:00
Günther Deschner
c53e7f8d58 s3-build: use HAVE_ADS define in some more places.
Guenther
2011-03-19 00:11:18 +01:00
Jeremy Allison
89b6af0982 SMB2 renames return SHARING_VIOLATION if there is any existing oplock on a file.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 18 23:39:49 CET 2011 on sn-devel-104
2011-03-18 23:39:49 +01:00
Volker Lendecke
4b347a1b17 s3: Add "print notify backchannel" parameter to prevent us doing the reverse print notify connection.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 18 21:34:30 CET 2011 on sn-devel-104
2011-03-18 21:34:30 +01:00
Christian Ambach
8ae1f32229 s3:autorid make sure we set the mapping status correct on early exit
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 18 16:30:36 CET 2011 on sn-devel-104
2011-03-18 16:30:36 +01:00
Volker Lendecke
5006dcff4e idmap-autorid: Slightly simplify idmap_autorid_get_domainrange
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:37 +01:00
Volker Lendecke
3947845041 idmap-autorid: Slightly simplify idmap_autorid_get_domainrange
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:37 +01:00
Volker Lendecke
6e9fb07958 idmap-autorid: Remove an unused variable
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:37 +01:00
Volker Lendecke
10953c60bd idmap-autorid: Use talloc_tos() in idmap_autorid_id_to_sid
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
6ba85beeec idmap-autorid: Remove an else branch
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
6ab0d8b998 idmap-autorid: Remove an unused variable
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
d1970a8da9 idmap-autorid: Remove an unused parameter
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
f0abb3f3f8 idmap-autorid: Use talloc_tos() in idmap_autorid_sids_to_unixids
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
db3f8ae2bf idmap-autorid: Not necessary to talloc domaincfg
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
a94cc222bd idmap-autorid: Not necessary to talloc domainsid
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2011-03-18 15:46:36 +01:00
Volker Lendecke
3e4879f3bd s3: Cope with 192.168.1.1/24 in smbcontrol ip-dropped
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 18 14:56:38 CET 2011 on sn-devel-104
2011-03-18 14:56:38 +01:00
Günther Deschner
4e0521300f s3-waf: enable nss_winbind in make test for nss_wrapper.
Guenther
2011-03-18 13:22:07 +01:00
Günther Deschner
fa8471a616 s3-registry: remove some unused headers.
Guenther
2011-03-18 13:22:07 +01:00
Stefan Metzmacher
2f048e458b s3:locking: simplify the non cluster case of brl_get_locks_readonly()
Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 18 13:00:51 CET 2011 on sn-devel-104
2011-03-18 13:00:51 +01:00
Stefan Metzmacher
e8411d6f9f s3:locking: brl_get_locks_internal() should not expose a write lock if the caller wants read_only
This triggered deadlocks in the cluster case of brl_get_locks_readonly().

Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze
2011-03-18 07:51:46 +01:00
Günther Deschner
de5cec48a4 s4-smbtorture: add netsessiongetinfo() test.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 02:11:38 CET 2011 on sn-devel-104
2011-03-18 02:11:38 +01:00
Günther Deschner
9ef1a8cf4c s4-smbtorture: add test for rap_NetUserDelete().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
5def6f0eca s3-net: make sure we set correct default user flags in rap_user_add().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
249340c9c8 s4-smbtorture: add test for rap_NetUserAdd().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
faf8becf22 s3-utils: run minimal_includes.pl over utils/*.c
Guenther
2011-03-18 01:24:06 +01:00