1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-05 09:18:06 +03:00
Commit Graph

2682 Commits

Author SHA1 Message Date
Jeremy Allison
49b52ec16f Parameterize in local.h the MAX_RPC_DATA_SIZE, and ensure
that "offered" read from the rpc packet in spoolss is under
that size. Tidyup from analysis from Veracode.
Jeremy.
2009-02-13 16:06:17 -08:00
Günther Deschner
99b45f71cc s3-netlogon: implement _netr_ServerAuthenticate3.
Guenther
2009-02-13 01:47:58 +01:00
Günther Deschner
a4b0c5d871 s3-spoolss: use pidl for _spoolss_SetPrinterDataEx.
Guenther
2009-02-12 22:51:29 +01:00
Günther Deschner
97f15fcd68 s3-spoolss: use pidl for _spoolss_GetPrinterDataEx.
Guenther
2009-02-12 22:51:29 +01:00
Günther Deschner
2a311b1ea7 s3-spoolss: use SPOOLSS_PRINTER_CONTROL flags defined in IDL.
Guenther
2009-02-11 22:42:01 +01:00
Günther Deschner
75faf7765b s3-spoolss: Fix uninitialised variable warning.
Guenther
2009-02-11 22:36:33 +01:00
Günther Deschner
e32b26931f s3-spoolss: fix rpc_server stub names for opnum 0x42 and 0x43.
Guenther
2009-02-11 22:35:49 +01:00
Günther Deschner
aee462893b s3-spoolss: use rpccli_spoolss_ReplyOpenPrinter.
Guenther
2009-02-10 23:57:30 +01:00
Volker Lendecke
bbb665501a Add queueing to np_write 2009-02-10 18:29:34 +01:00
Volker Lendecke
f6e9f1e7ea Add queueing to np_read_state, simulate message-type named pipes.
The problem with msg-type pipes is that we have to return short reads when a
message ends before the read request. When reading from the unix domain socket,
the message limits are lost. So we would happily return more than a message,
which confuses for example the s4 rpc client horribly. I'd expect other np rpc
clients also to blow up over this.

The real solution is to properly implement a two-byte length field per message
on the unix domain socket, but this requires more changes there. And as we
right now only serve DCE/RPC over the named pipes, this implements a hack that
looks into the fragment headers to figure out hdr.frag_len.
2009-02-10 18:29:34 +01:00
Günther Deschner
96f05fcd1c s3-spoolss: use pidl for _spoolss_OpenPrinter.
Guenther
2009-02-10 11:26:58 +01:00
Günther Deschner
3d4221a9cb s3-spoolss: remove old spoolss_OpenPrinterEx.
Guenther
2009-02-10 11:26:52 +01:00
Günther Deschner
b4bda6da5a s3-spoolss: use pidl for _spoolss_OpenPrinterEx.
Guenther
2009-02-10 11:26:45 +01:00
Günther Deschner
e4b5e67566 s3-spoolss: use pidl for _spoolss_SetJob.
Guenther
2009-02-10 11:26:33 +01:00
Günther Deschner
0a34c140cc s3-spoolss: use pidl for _spoolss_StartDocPrinter.
Guenther
2009-02-10 11:26:19 +01:00
Günther Deschner
46200a7cd4 s3-spoolss: add temporary convert_devicemode_new function.
Guenther
2009-02-10 11:24:47 +01:00
Günther Deschner
ee469585eb s3-spoolss: use SPOOLSS_JOB_CONTROL bits defined in IDL.
Guenther
2009-02-10 11:09:51 +01:00
Tim Prouty
1d65b7a742 s3 spoolss: arch needs to be set before it's passed to get_version_id.
7717ad6880 left arch unitialized.

Guenther, please check.
2009-02-09 16:12:20 -08:00
Günther Deschner
0d281b76a9 s3-spoolss: use pidl for _spoolss_ScheduleJob.
Guenther
2009-02-09 22:48:14 +01:00
Günther Deschner
cb1ada9cc0 s3-spoolss: use pidl for _spoolss_AddJob.
Guenther
2009-02-09 22:47:57 +01:00
Günther Deschner
d2b8fb99ee s3-spoolss: use rpccli_spoolss_ReplyClosePrinter.
Guenther
2009-02-09 19:10:29 +01:00
Günther Deschner
a7cf846d1e s3-spoolss: use pidl for _spoolss_AddPrintProcessor.
Guenther
2009-02-09 19:09:00 +01:00
Günther Deschner
c94c777d9c s3-spoolss: use PRINTER_ENUM_NAME and remove double enum define.
Guenther
2009-02-09 15:59:04 +01:00
Günther Deschner
41c01930a3 s3-spoolss: use pidl for _spoolss_FindClosePrinterNotify.
Guenther
2009-02-09 13:03:07 +01:00
Günther Deschner
dfa559145c s3-spoolss: remove whitespace in printing code.
Guenther
2009-02-09 12:42:42 +01:00
Volker Lendecke
5bc97e0cf2 Fix count in _srvsvc_NetDiskEnum()
Without this, remotely adding a share via MMC fails
2009-02-09 12:36:49 +01:00
Günther Deschner
160e8c7a37 s3-spoolss: use pidl for _spoolss_DeletePrinterDriverEx.
Guenther
2009-02-09 12:34:03 +01:00
Günther Deschner
7717ad6880 s3-spools: use pidl for _spoolss_DeletePrinterDriver.
Guenther
2009-02-09 12:34:02 +01:00
Günther Deschner
1c0b19fef6 s3-spoolss: use pidl for _spoolss_DeletePrinterKey.
Guenther
2009-02-09 12:34:02 +01:00
Günther Deschner
27acd87445 s3-spoolss: use pidl for _spoolss_DeletePrinterData.
Guenther
2009-02-09 12:34:02 +01:00
Günther Deschner
ce5b25aaa4 s3-spoolss: use pidl for _spoolss_DeletePrinterDataEx.
Guenther
2009-02-09 12:34:01 +01:00
Günther Deschner
3c1d2f2a3a s3-spoolss: use pidl for _spoolss_GetForm.
Guenther
2009-02-09 10:43:08 +01:00
Günther Deschner
9232a5be20 s3-spoolss: add fill_form_info_1.
Guenther
2009-02-09 10:43:01 +01:00
Günther Deschner
894d05bc41 s3-spoolss: restore delete_a_form().
Guenther
2009-02-09 10:42:46 +01:00
Günther Deschner
9ef58a9196 s3-spoolss: use pidl for _spoolss_SetForm.
Guenther
2009-02-09 10:42:33 +01:00
Günther Deschner
3a1f9411e5 s3-spoolss: use pidl for spoolss_AddForm.
Guenther
2009-02-09 10:42:12 +01:00
Kai Blin
c3b9b6c8aa async_sock: Use unix errnos instead of NTSTATUS
This also switches wb_reqtrans to use wbcErr instead of NTSTATUS as it would
be pointless to convert to errno first and to wbcErr later.
2009-02-09 08:36:08 +01:00
Volker Lendecke
3a4c8cd492 Make prs_struct->out_data.current_pdu dynamically allocated
Another 4k per open pipe
2009-02-08 13:53:50 +01:00
Volker Lendecke
32a7529243 Most RPC requests do not need a full fragment, start smaller 2009-02-08 13:53:49 +01:00
Volker Lendecke
51dc7b9d82 Make current_in_pdu in pipes_struct allocated
This makes an open pipe about 4K cheaper
2009-02-07 19:25:34 +01:00
Volker Lendecke
c975ce15eb Fix resume handle for _samr_EnumDomainGroups 2009-02-07 19:25:34 +01:00
Günther Deschner
7f35c3be69 s3-spoolss: use pidl for _spoolss_WritePrinter.
Guenther
2009-02-07 10:20:56 +01:00
Günther Deschner
2038da6897 s3-spoolss: some cosmetics in debug statements.
Guenther
2009-02-07 10:20:56 +01:00
Günther Deschner
f5a24b71b9 s3-spoolss: use pidl for _spoolss_DeleteForm.
Guenther
2009-02-07 01:52:29 +01:00
Günther Deschner
714ac784e1 s3-spoolss: use pidl for _spoolss_EndDocPrinter.
Guenther
2009-02-06 21:41:09 +01:00
Günther Deschner
3fe9b2fb4f s3-spoolss: use pidl for _spoolss_AbortPrinter.
Guenther
2009-02-06 21:40:21 +01:00
Günther Deschner
7f5ff88520 s3-spoolss: use pidl for _spoolss_EndPagePrinter.
Guenther
2009-02-06 21:39:48 +01:00
Günther Deschner
246a1a1eac w 2009-02-06 21:38:43 +01:00
Günther Deschner
cb6ef25341 s3-spoolss: use pidl for _spoolss_StartPagePrinter.
Guenther
2009-02-06 21:37:55 +01:00
Günther Deschner
f968057cd2 s3-spoolss: use pidl for _spoolss_DeletePrinter.
Guenther
2009-02-06 21:30:39 +01:00
Günther Deschner
126d444367 s3-spoolss: call the correct get_pipe_fns function in proxy_spoolss_call().
Guenther
2009-02-06 19:23:55 +01:00
Günther Deschner
46903a0f90 s3-spoolss: use pidl for _spoolss_ClosePrinter.
Guenther
2009-02-06 18:55:46 +01:00
Günther Deschner
a45107abca s3-spoolss server: add _spoolss_ server stubs.
Guenther
2009-02-06 18:54:52 +01:00
Günther Deschner
e11fa4cc33 s3-spoolss: prepare to use generated spoolss.
Guenther
2009-02-06 18:54:51 +01:00
Günther Deschner
f289851d70 s3-eventlog: fix Coverity #877.
Guenther
2009-02-05 16:36:44 +01:00
Volker Lendecke
a66828a37f Don't use recvall in the proxied np_read_send
We don't know how much we will get. Resort to a single recv syscall
2009-02-05 11:16:03 +01:00
Günther Deschner
a63d4c5ed1 s3-eventlog: remove old eventlog server.
Guenther
2009-02-04 22:51:39 +01:00
Günther Deschner
d7e2384dba s3-eventlog: remove fixup_eventlog_entry.
Guenther
2009-02-04 22:51:31 +01:00
Günther Deschner
8b126e942d s3-eventlog: remove write_eventlog_tdb.
Guenther
2009-02-04 22:51:23 +01:00
Günther Deschner
abb4faf813 s3-eventlog: remove add_record_to_resp.
Guenther
2009-02-04 22:51:15 +01:00
Günther Deschner
96fd6b5a01 s3-eventlog: remove read_package_entry.
Guenther
2009-02-04 22:51:07 +01:00
Günther Deschner
58ded409ab s3-eventlog: remove get_eventlog_record.
Guenther
2009-02-04 22:50:59 +01:00
Günther Deschner
64e3a90530 s3-eventlog: make can_write_to_eventlog static.
Guenther
2009-02-04 22:49:51 +01:00
Volker Lendecke
94d1dbbaf0 Restore correct handling of "is_data_available" for the socket transport
This fixes a valgrind error reading an uninitialized variable
2009-02-04 22:36:43 +01:00
Günther Deschner
f24eecffde s3-eventlog: add my copyright.
Guenther
2009-02-04 22:05:02 +01:00
Günther Deschner
456bd5ad08 s3-eventlog: use pidl for _eventlog_ReadEventLogW.
Guenther
2009-02-04 22:04:52 +01:00
Günther Deschner
63a992168d s3-eventlog: add evlog_push_record function.
Guenther
2009-02-04 21:12:05 +01:00
Günther Deschner
1b71fa5c59 s3-eventlog: add evlog_pull_record function.
Guenther
2009-02-04 21:11:52 +01:00
Günther Deschner
65200328ee s3-eventlog: add evlog_tdb_entry_to_evt_entry.
Guenther
2009-02-04 18:39:20 +01:00
Günther Deschner
df5e231a6f s3-eventlog: add evlog_evt_entry_to_tdb_entry.
Guenther
2009-02-04 18:39:20 +01:00
Günther Deschner
de7f0a70c8 s3-eventlogadm: use struct eventlog_Record_tdb for storing entries in tdbs.
Guenther
2009-02-04 17:47:07 +01:00
Günther Deschner
16f83ae750 s3-eventlog: add fixup_eventlog_record_tdb.
Guenther
2009-02-04 17:47:06 +01:00
Günther Deschner
dd306249f2 s3-eventlog: add evlog_push_record_tdb function.
This is almost a copy of write_eventlog_tdb() and still needs to be modified
to use tdb transactions.

Guenther
2009-02-04 17:46:55 +01:00
Günther Deschner
cf3be5ce7a s3-eventlog: add evlog_pull_record_tdb function.
Guenther
2009-02-03 16:06:57 +01:00
Günther Deschner
b94946697d s3-eventlog: pass down talloc context to parse_logentry().
Guenther
2009-02-03 15:45:09 +01:00
Günther Deschner
4976777e3b s3-eventlog: make logname in elog_open_tdb const.
Guenther
2009-02-03 15:44:20 +01:00
Günther Deschner
8fb6b18bac s3-eventlog: allow to open eventlog tdbs readonly.
Guenther
2009-02-03 15:44:06 +01:00
Dan Sledz
d96248a9b4 Add two new parameters to control how we verify kerberos tickets. Removes lp_use_kerberos_keytab parameter.
The first is "kerberos method" and replaces the "use kerberos keytab"
with an enum.  Valid options are:
secrets only - use only the secrets for ticket verification (default)
system keytab - use only the system keytab for ticket verification
dedicated keytab - use a dedicated keytab for ticket verification.
secrets and keytab - use the secrets.tdb first, then the system keytab

For existing installs:
"use kerberos keytab = yes" corresponds to secrets and keytab
"use kerberos keytab = no" corresponds to secrets only

The major difference between "system keytab" and "dedicated keytab" is
that the latter method relies on kerberos to find the correct keytab
entry instead of filtering based on expected principals.

The second parameter is "dedicated keytab file", which is the keytab
to use when in "dedicated keytab" mode.  This keytab is only used in
ads_verify_ticket.
2009-02-01 20:23:31 -08:00
Volker Lendecke
c14b7e648b Split up async_req into a generic and a NTSTATUS specific part 2009-02-01 19:05:39 +01:00
Volker Lendecke
7967d8c779 Move rpc_pipe_open_internal to srv_pipe_hnd.c
This is a smbd-only function
2009-02-01 14:34:23 +01:00
Volker Lendecke
53394980ad Replace pipe names in pipes_struct by ndr_syntax_id
This was mainly used for debugging output
2009-02-01 14:34:23 +01:00
Volker Lendecke
99f021d0ef Fix the build on Solaris CC 2009-02-01 00:07:16 +01:00
Volker Lendecke
fa7ddc78b8 Remove unused np_read sync wrapper 2009-01-31 17:50:18 +01:00
Volker Lendecke
8b480b52ce Remove unused np_write sync wrapper 2009-01-31 17:50:18 +01:00
Volker Lendecke
e8b2b46cae Make-np_write-handle-0-byte-writes-as-NT_STATUS_OK 2009-01-31 17:50:18 +01:00
Volker Lendecke
b797c056a6 Add an async np_read wrapper 2009-01-31 17:50:18 +01:00
Volker Lendecke
e60d69d67d Add an async np_write wrapper 2009-01-31 17:50:18 +01:00
Stefan Metzmacher
f6d8d94510 s3:rpc_server: use get_client_fd() instead of smbd_server_fd()
Both are absolutely the same, but smbd_server_fd() is otherwise
only used in smbd/*.c and would like to remove smbd_server_fd() soon.

metze
2009-01-27 15:28:12 +01:00
Volker Lendecke
8b80407712 Fix a segfault in parse_logentry
entry->data_record.strings is type smb_ucs2, so the pointer arithmetic
increments by two :-)
2009-01-24 15:08:21 +01:00
Günther Deschner
9629897094 s3-eventlog: add missing _eventlog_ReportEventAndSourceW stub call.
Guenther
2009-01-24 03:33:22 +01:00
Günther Deschner
5bcd6d760b Revert "s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server."
This reverts commit c0f1309010.
2009-01-24 03:00:38 +01:00
Günther Deschner
dd2695fe52 s3-eventlog: fix various invalid memcpy in read_package_entry().
Guenther
2009-01-24 03:00:38 +01:00
todd stecher
989ad44d32 Memory leaks and other fixes found by Coverity 2009-01-21 17:13:03 -08:00
Volker Lendecke
520f88143b Remove some unused code 2009-01-20 16:41:32 +01:00
Volker Lendecke
b8b6cddb29 Remove some smb fsp knowledge from rpc_server/
np_open/read/write don't have to know about files_struct
2009-01-20 16:41:14 +01:00
Volker Lendecke
bd4718d281 Make use of TALLOC_FREE 2009-01-20 14:34:51 +01:00
Volker Lendecke
8b618d0ba9 Fix some real bugs found by "type-punned" gcc warnings
Type-casting does not the right thing if used the way it used to be. The
function arguments have not been uint32_t's, but the type cast made the calling
routine believe so. Not good...

The assignment xxx=account_policy_temp does however type-convert properly,
potentially cutting off the top-bits.
2009-01-18 13:26:21 +01:00
Günther Deschner
740c5ce081 s3-eventlog: fix _eventlog_CloseEventLog.
Guenther
2009-01-16 11:52:49 +01:00
Günther Deschner
0d2c0da7d2 s3-eventlog: remove whitespace.
Guenther
2009-01-16 00:28:45 +01:00
Günther Deschner
6dc18f2cab s3-eventlog: some minor code cleanup in eventlog server.
Guenther
2009-01-16 00:28:45 +01:00
Günther Deschner
990491d187 s3-eventlog: fix ps struct removal leftover.
Guenther
2009-01-14 10:53:04 +01:00
Günther Deschner
df8b724819 s3-eventlog: use main talloc context in eventlog read call.
Guenther
2009-01-14 10:18:14 +01:00
Volker Lendecke
964acde86e Remove the rpc_srv_register wrapper around rpc_pipe_register_commands 2009-01-09 23:17:57 +01:00
Volker Lendecke
2729c484fb Call rpc_srv_register instead of rpc_pipe_register_commands in eventlog and svcctl 2009-01-09 23:17:57 +01:00
Volker Lendecke
106e65a3b3 Fake up ndr_table_spoolss 2009-01-09 23:17:57 +01:00
Volker Lendecke
125696b73d Pass the full ndr_interface_table into the s3 rpcserver when registering 2009-01-09 23:17:57 +01:00
Volker Lendecke
c1a8e8adac Simplify find_pipe_fns_by_context slightly 2009-01-09 22:48:09 +01:00
Volker Lendecke
2714ac4d3a Fix some nonempty blank lines 2009-01-09 22:30:56 +01:00
Günther Deschner
22a96cbe31 s3-svcctl: remove last traces of hand-marshalled svcctl code.
Guenther
2009-01-09 17:08:19 +01:00
Günther Deschner
fa6053fe6d s3-svcctl: use pidl for _svcctl_EnumServicesStatusW.
Guenther
2009-01-09 17:08:18 +01:00
Volker Lendecke
84292022bf Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn 2009-01-08 22:29:54 +01:00
Volker Lendecke
825500f5da Use TALLOC for struct lsa_info 2009-01-08 22:29:54 +01:00
Volker Lendecke
e94d7f53f9 Make use of a talloc_destructor for free_printer_entry 2009-01-08 22:29:54 +01:00
Volker Lendecke
baa5c5eeb0 Make use of a talloc_destructor for free_eventlog_info() 2009-01-08 22:29:53 +01:00
Volker Lendecke
52b6756c4e Make samr_info a talloc context of its own 2009-01-08 22:29:53 +01:00
Volker Lendecke
5a4f71d40c Simplify init_pipe_handle_list a bit 2009-01-08 22:29:53 +01:00
Günther Deschner
252d271fe4 s3-eventlog: minor cosmetics.
Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
c0f1309010 s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server.
Jerry, please check.

Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
ca98357710 s3-svcctl: add copyright to svcctl rpc_server.
Guenther
2009-01-08 13:24:22 +01:00
Günther Deschner
cbc2c9059f s3-svcctl: remove some more redundant headers.
Guenther
2009-01-08 13:24:22 +01:00
Günther Deschner
3079e14f94 s3-svcctl: use pidl for _svcctl_QueryServiceConfig2W.
Guenther
2009-01-08 11:19:33 +01:00
Günther Deschner
5581637d22 s3-svcctl: fix return code for _svcctl_QueryServiceStatusEx.
Guenther
2009-01-08 11:19:33 +01:00
Günther Deschner
385316a09a s3-svcctl: remove old hand marshalling of svcctl_QueryServiceStatusEx.
Guenther
2009-01-08 11:19:33 +01:00
Günther Deschner
b42cb4944a s3-svcctl: use pidl for _svcctl_QueryServiceStatusEx.
Guenther
2009-01-08 11:19:32 +01:00
Günther Deschner
6eb507e30d s3-svcctl: use pidl's ndr opcodes for NDR_SVCCTL_QUERYSERVICECONFIGW.
Guenther
2009-01-08 11:19:31 +01:00
Günther Deschner
e2fa47a04c s3-lsa: avoid all init_lsa* functions.
Guenther
2009-01-06 16:02:13 +01:00
Günther Deschner
b0f7137883 s3-srvsvc: remove all init_srvsvc* functions.
Guenther
2009-01-06 16:02:12 +01:00
Günther Deschner
a94157c759 s3-srvsvc: avoid all init_srvsvc* functions.
Guenther
2009-01-06 16:02:12 +01:00
Günther Deschner
20ba0a947a s3-samr: avoid all init_samr_alias* functions.
Guenther
2009-01-06 16:02:12 +01:00
Günther Deschner
05784d0fa8 s3-samr: avoid all init_samr_group* functions.
Guenther
2009-01-06 16:02:11 +01:00
Günther Deschner
d2d8d7a087 s3-samr: avoid all init_samr_Domain* functions.
Guenther
2009-01-06 16:02:11 +01:00
Günther Deschner
46f55ef5bc s3-samr: avoid all init_samr_user* functions.
Guenther
2009-01-06 16:02:10 +01:00
Volker Lendecke
ef54ad52e0 Move the "rid_name" typedef to the only place where it might be used 2009-01-06 11:24:59 +01:00
Jelmer Vernooij
37e6849d45 Merge branch 'master' of ssh://git.samba.org/data/git/samba 2009-01-05 18:01:04 +01:00
Stefan Metzmacher
c34d5f445a s3:events: change event_add_timed() prototype to match samba4
metze
2009-01-05 15:07:35 +01:00
Jelmer Vernooij
af744e0954 Merge branch 'master' of ssh://git.samba.org/data/git/samba 2009-01-04 22:48:23 +01:00
Volker Lendecke
141b76d747 Remove unused argument "vuid" from make_internal_rpc_pipe_p 2009-01-03 15:25:00 +01:00
Jelmer Vernooij
08259c1c52 Add iconv_convenience argument to size functions. 2009-01-01 04:45:33 +01:00
Jeremy Allison
d0eeb9aa8d Fix more asprintf warnings and some error path errors.
Jeremy.
2008-12-23 12:11:12 -08:00
Günther Deschner
43d0a4813b s3-ntsvcs: remove last traces of hand-marshalled NTSVCS.
Guenther
2008-12-17 23:52:42 +01:00
Günther Deschner
5445ee2a55 s3-ntsvcs: use pidl for _PNP_GetDeviceList.
Guenther
2008-12-17 23:52:41 +01:00
Günther Deschner
076f15f54e s3: refactor _netr_LogonControl{2,2Ex} server side.
Guenther
2008-12-17 23:23:56 +01:00
Günther Deschner
3c66ba0b3c s3: fix netlogon rpc_server build after idl change.
Guenther
2008-12-13 00:28:00 +01:00
Jeremy Allison
d7d525bc9d Make the LookupRid access check match LookupName until
we know the correct bits to use here.
Jeremy.
2008-12-10 17:03:53 -08:00
Jeremy Allison
c4c6e1e463 Fix usrmgr opening a user object as non-root.
Jeremy.
2008-12-10 15:29:14 -08:00
Günther Deschner
b431406357 s3-netlogon: fix netlogon server build.
Guenther
2008-12-10 11:58:28 +01:00
Günther Deschner
8608fd87b0 s3-samr: a level 18 password set needs to set the pwdlastset as well.
Guenther
2008-12-09 13:20:36 +01:00
Günther Deschner
89e57a8fad s3-srvsvc: fix build warning.
Guenther
2008-12-09 12:41:00 +01:00
Todd Stecher
9985898e94 s3: Add support for access based share enumeration 2008-12-08 22:23:16 -08:00
Günther Deschner
3656cb2e57 s3-samr: fix samr_SetUserInfo level 18 server-side.
Guenther
2008-12-05 16:35:22 +01:00
Günther Deschner
b8204ffd03 s3-samr: fix samr callers of samr_UserInfo18.
Guenther
2008-12-05 14:27:03 +01:00
Günther Deschner
7423b6a4b8 s3-samr: fix SAMR_FIELD_PASSWORD callers.
Guenther
2008-12-05 14:27:03 +01:00
Günther Deschner
eb906e1d2d s3-samr: fix init_samr_user_info2{1,3,5} callers.
Guenther
2008-12-05 14:27:02 +01:00
Tim Prouty
5844012285 s3: Change SMB_VFS_CREATE_FILE to take a create_file_flags argument
This replaces the is_dos_path bool with a more future-proof argument.
The next step is to plumb INTERNAL_OPEN_ONLY through this flag instead
of overridding the oplock_request.
2008-12-03 17:51:44 -08:00
Tim Prouty
f995a7af2a s3: Add new "is_dos_path" argument to SMB_VFS_CREATE_FILE
Now unix paths can be differentiated from windows paths so the
underlying create_file implementations can convert paths correctly.
2008-12-03 17:50:37 -08:00
Tim Prouty
f38d7f20a8 s3: Add SMB_VFS_CREATE_FILE to the vfs layer
Modify all callers of create_file to go through SMB_VFS_CREATE_FILE
2008-12-03 17:50:17 -08:00
Günther Deschner
9ccd1174f7 s3-samr: simplify _samr_QueryUserInfo a lot and fix some few potential memleaks.
Guenther
2008-12-02 10:08:11 +01:00
Günther Deschner
8e5cd8f81c s3-samr: fix samr_SetUserInfo{2} level 23.
Do not just start decoding/setting passwords when fields_present
do not indicate there is a password to be set.

Guenther
2008-12-02 10:08:10 +01:00
Günther Deschner
931f16f622 s3-samr: _samr_EnumDomainUsers always returns a sam array (even w/o users).
Guenther
2008-12-02 00:53:27 +01:00
Günther Deschner
b07d3794d2 s3-samr: refuse do process UserSetInfo with 0 fields_present.
Guenther
2008-12-02 00:52:11 +01:00
Günther Deschner
798c4b3e6a s3-samr: use samr_DomainServerState in client tools.
Guenther
2008-12-02 00:37:39 +01:00
Günther Deschner
0b7430b054 s3-samr: fix various potential memleaks in samr_SetUserInfo.
Was there any reason why we did all these individual TALLOC_FREEs ?

Guenther
2008-12-01 22:30:17 +01:00
Günther Deschner
24fec0a8d7 s3-samr: avoid code duplication for identical code in _samr_Connect2, 4 and 5.
Guenther
2008-12-01 21:56:28 +01:00
Günther Deschner
c7c591c19f s3-samr: modify logging in _samr_Connect2 so that it can be called from other calls as well.
Guenther
2008-12-01 21:52:03 +01:00
Volker Lendecke
2bb90b7a88 Remove "conn" parameter from np_open, smb_request contains it 2008-11-28 10:06:32 +01:00
Günther Deschner
6a627b440e s3-samr: never allow to alter pwdlastset directly.
Guenther
2008-11-27 18:29:10 +01:00
Günther Deschner
257d99d0cd s3-samr: fix return code for invalid password sets in SetUserInfo.
Guenther
2008-11-27 18:28:59 +01:00
Günther Deschner
e398eed15a s3-samr: fix return code for invalid name in _samr_LookupDomain.
Guenther
2008-11-27 18:28:51 +01:00
Günther Deschner
d94f3e3db3 s3-samr: avoid enumeration and user creation on builtin domain handle.
Guenther
2008-11-27 18:28:43 +01:00
Günther Deschner
5f9524a956 s3-samr: support samr_CreateUser as well.
Guenther
2008-11-27 18:28:34 +01:00
Günther Deschner
9c2ed82d07 s3-samr: support samr_QueryUserInfo2 as well.
Guenther
2008-11-27 18:28:25 +01:00
Günther Deschner
bed91c0e46 s3-samr: add support for _samr_QueryUserInfo level 5.
Guenther
2008-11-27 18:27:36 +01:00
Günther Deschner
948218643a s3-samr: fix _samr_LookupNames return code.
Guenther
2008-11-25 15:39:51 +01:00
Volker Lendecke
907f126d3e Get rid of pipes_struct->pipe_user, we have server_info now --- YESSS! 2008-11-24 11:39:03 +01:00
Volker Lendecke
c25f5c778a Convert delete_driver_files to use create_conn_struct
Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
cb4f8573ba Convert get_correct_cversion to use create_conn_struct
Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
783ab0480b Convert move_driver_to_download_area to use create_conn_struct
This removes a use of struct current_user and the vuid

The become_user() here is unnecessary, within the spoolss handling code we have
switched to the authenticated pipe user anyway.

Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
ed27d91068 Add auth_serversupplied_info to create_conn_struct
srvsvc needs it, as will printing
2008-11-23 22:41:59 +01:00
Jeremy Allison
98bf3ee2f6 Second part of fix for bug #5891 - smbd crashed when viewing the eventlog exported by "eventlog list". Don't leak memory on error paths.
Jeremy.
2008-11-20 10:56:14 -08:00
Günther Deschner
f0e75484a7 s3-eventlog: remove trailing whitespace.
Guenther
2008-11-20 17:16:03 +01:00
Günther Deschner
70f55ddb70 s3-eventlog: avoid passing down full prs_struct in eventlog server.
Guenther
2008-11-20 17:15:38 +01:00
Michael Adam
172628dca2 eventlog: don't crash in sync_eventlog_params().
When freeing the talloc ctx at the end of the routine,
it must be a talloc ctx created inside. talloc_tos() needs
to be valid after the function finishes, since callers
(may) have data attached to it.

Michael

Signed-off-by: Günther Deschner <gd@samba.org>
2008-11-20 17:08:37 +01:00
Jeremy Allison
da683d6a73 This code mixes up int and uint32 when pulling out of a TDB. This is very bad. Fixing... May fix bug #5891, not sure.
Jeremy.
2008-11-19 16:49:03 -08:00
Günther Deschner
12fdb5eb46 s3-ntsvcs: use pidl for _PNP_GetDeviceRegProp.
Guenther
2008-11-19 23:25:25 +01:00
Tim Prouty
0b1015d73e Fix build warning introduced by making SERVICE_CONTROL an enum 2008-11-17 10:21:29 -08:00
Günther Deschner
caf0c17e24 s3-spoolss: fix enumports segfault (another malloc vs. talloc candidate).
Guenther
2008-11-15 02:25:17 +01:00
Günther Deschner
e76e77c32d s3-svctl-server: fix remote rpc service management (bug #5888).
Don't TALLOC_FREE a non-talloced [ref] pointer.

Guenther
2008-11-13 20:49:38 +01:00
Jeremy Allison
c62427c7fc Fix bug 5891] : smbd crashed when viewing the eventlog exported by "eventlog list"
Don't mix TALLOC and SAFE_FREE().
Jeremy.
2008-11-11 14:38:59 -08:00
Günther Deschner
a4c24b4d30 s3-samr-idl: cleanup.
Guenther
2008-11-10 21:46:25 +01:00
Volker Lendecke
ace87f16c0 For proxied named pipes, connect to np/<pipe_name> and send auth info
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2008-11-06 21:39:15 +01:00
Stefan Metzmacher
6815fd1730 s3: rpc: let serverinfo_to_SamInfo3() work with no pipe_session_key
metze
2008-11-06 21:39:14 +01:00
Volker Lendecke
63da08d00f Apply some const to np_write() 2008-11-01 19:41:07 +01:00
Jelmer Vernooij
ddcab787c4 Rename dos_errstr() to win_errstr() for consistency with Samba 4. 2008-11-01 17:19:26 +01:00
Günther Deschner
66993ab03a s3-samr: remove duplicate copies of Alias Object specific access rights.
Guenther
2008-10-31 21:14:27 +01:00
Günther Deschner
5e5edbe761 s3-samr: remove duplicate copies of Group Object specific access rights.
Guenther
2008-10-31 21:14:27 +01:00
Günther Deschner
f126371f17 s3-samr: remove duplicate copies of Domain Object specific access rights.
Guenther
2008-10-31 21:14:27 +01:00
Günther Deschner
29d27297d0 s3-samr: remove duplicate copies of SAM user specific access rights.
Guenther
2008-10-31 21:14:26 +01:00
Günther Deschner
700cece822 s3-samr: remove duplicate copies of SAM server specific access rights.
Guenther
2008-10-31 21:14:26 +01:00
Jeremy Allison
8344e94574 Unify se_access_check with the S4 code. Will make
calculation of SEC_FLAG_MAXIMUM_ALLOWED much easier
for files.
Jeremy.
2008-10-31 10:51:45 -07:00
Günther Deschner
f5269ff182 s3-netlogon: kill an fstring in rpc_server.
Guenther
2008-10-28 00:13:50 +01:00