1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-29 21:47:30 +03:00

26418 Commits

Author SHA1 Message Date
Matthias Dieter Wallnöfer
eade61ae03 s4:operational LDB module - fix attribute names to be right up/down-cased
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar  4 23:56:07 CET 2011 on sn-devel-104
2011-03-04 23:56:07 +01:00
Matthias Dieter Wallnöfer
5a722f187f s4:ldap.py - rootdse tests should search for the rootDSE not the default DN
Reviewed by: Tridge
2011-03-04 23:09:53 +01:00
Matthias Dieter Wallnöfer
71df279f92 s4:ldap.py - add a test in order to show the operational module fixed
Reviewed by: Tridge
2011-03-04 23:09:44 +01:00
Matthias Dieter Wallnöfer
05d1d0d8a6 s4:operational LDB module - fix display of some constructed attributes
"structuralObjectClass", "createTimestamp" and "modifyTimestamp" weren't
displayed anymore.

Reviewed by: Tridge
2011-03-04 23:09:35 +01:00
Matthias Dieter Wallnöfer
5a98979e0c s4:operational LDB module - add "groupToken" as unsigned int (uint32_t)
Reviewed by: Tridge
2011-03-04 23:09:27 +01:00
Matthias Dieter Wallnöfer
1ff28a2986 s4:operational LDB module - readd "structuralObjectClass" -> "objectClass" mapping
This has been removed accidentally by commit
a093e10896a4768dba0cd793a04b7d5d1366fee2.

Reviewed by: Tridge
2011-03-04 23:09:17 +01:00
Matthias Dieter Wallnöfer
75706a627d ldb:ldb_msg.c - use LDB result constants for checking return values
Reviewed by: Tridge

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar  4 22:51:57 CET 2011 on sn-devel-104
2011-03-04 22:51:57 +01:00
Matthias Dieter Wallnöfer
dabed32ffe s4:ldap.py - other important RDN check testcases
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
2275bfb82d s4:ldap.py - remove a debug output
This has only been needed for developing this testcase and has been
forgotten to be removed afterwards.

Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
736a462c3e ldb:rdn_name LDB module - more RDN constraint checks (from AD)
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
ea12adf544 s4/ldb - remove now superflous "ldb_dn_validate" checks
If we immediately afterwards perform an LDB base operation then we don't
need an explicit "ldb_dn_validate" check anymore (only OOM makes sense).

Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
349b9b72ec s4:dsdb - we don't need to check if a DN != NULL if we call "ldb_dn_validate"
"ldb_dn_validate" is NULL-safe and does the check implicitly.

Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
746194cfc4 Revert "s4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid"
This is not needed anymore with the new DN checking.

This reverts commit 5896b7299331aedd065397d2078c62d85bcf68f6.

Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
76fb23064e ldb:ldb_request - handle here the DN checks
This is a much better solution than we had before - so all important DN
checks are enforced for each type of LDB database (and not limited to DSDB).

Many "ldb_dn_validate" checks will now become obsolete.

Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
86707c7cc4 s4:objectclass LDB module - fix a comment
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Matthias Dieter Wallnöfer
e4b5bce151 s4:libnet/libnet_site.c - make use of LDB return constants
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Christian Ambach
23810dca45 s4:waf-build fix disable-shared build for smbtorture
building smbtorture4 with configure --disable-shared failed
with an error that ldb.h could not be found

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed by: Tridge
2011-03-04 22:07:24 +01:00
Stefan Metzmacher
4b86beb98b s4:selftest: test using the machine account of the rodc against itself
This should test the non proxy rodc kdc path.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar  4 22:06:10 CET 2011 on sn-devel-104
2011-03-04 22:06:10 +01:00
Stefan Metzmacher
8002406c51 s4:kdc: split the kdc_tcp_proxy() logic from the main kdc logic
By having kdc_tcp_proxy_send/recv(), which just asks any writeable
dc for a reponse blob, we simplify the interaction between
client-local and local-writeable sockets.

This allows us to make kdc_socket, kdc_process_fn_t, kdc_tcp_call and kdc_tcp_socket
private to kdc.c again.

metze
2011-03-04 21:19:05 +01:00
Stefan Metzmacher
e70b09e8f8 s4:kdc: split the kdc_udp_proxy() logic from the main kdc logic
By having kdc_udp_proxy_send/recv(), which just asks any writeable
dc for a reponse blob, we simplify the interaction between
client-local and local-writeable sockets.

This allows us to make kdc_udp_call and kdc_udp_socket private to
kdc.c again.

metze
2011-03-04 21:19:05 +01:00
Stefan Metzmacher
ad9ac99afd s4:kdc: add a kdc_proxy_unavailable_error() helper function
metze
2011-03-04 21:19:05 +01:00
Stefan Metzmacher
0c78640e67 s4:kdc: fix calculation of the rodc kvno
Bit shifting is non-trivial in C:-)

This

	int32_t a = 0x12340000;
	uint32_t b = (a >> 16);

results in 0x00001234, but this

	int32_t a = 0xEDCB0000;
	uint32_t b = (a >> 16);

results in 0xFFFFEDCB, while we expected 0x0000EDCB.

metze
2011-03-04 21:19:05 +01:00
Stefan Metzmacher
a511d37d83 HEIMDAL:kdc: correctly propagate HDB_ERR_NOT_FOUND_HERE to via tgs_parse_request() and _kdc_tgs_rep()
metze
2011-03-04 21:19:05 +01:00
Matthias Dieter Wallnöfer
b0c6899973 ldb:ldb tools - remove a superflous "return" (usage internally calls "exit")
Reviewed by: Tridge

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Mar  4 09:39:22 CET 2011 on sn-devel-104
2011-03-04 09:39:22 +01:00
Matthias Dieter Wallnöfer
b50ebc3228 ldb:ldb tools - return LDB_ERR_INVALID_DN_SYNTAX on wrong DN parameters
Not all LDB databases have further DN checks.

Reviewed by: Tridge
2011-03-04 08:51:57 +01:00
Matthias Dieter Wallnöfer
1b93173813 ldb:ldb tools - ldbtest - convert other result values to LDB codes as well
I've forgotten this in my first patchset.

Reviewed by: Tridge
2011-03-04 08:51:45 +01:00
Matthias Dieter Wallnöfer
1343c0723f s4:LDAP server - remove validation checks of input DNs
We should rather try to let the LDB modules perform these checks
otherwise different backends behaviour differently.

Reviewed by: Tridge
2011-03-04 08:51:38 +01:00
Matthias Dieter Wallnöfer
5896b72993 s4:objectclass LDB module - if we cannot find DN's parent then the DN itself is invalid
ERR_INVALID_DN_SYNTAX fits better than ERR_OPERATION_ERROR in this case. This
one gets triggered if we perform "add" requests without the LDAP server.

Reviewed by: Tridge
2011-03-04 08:51:29 +01:00
Günther Deschner
dc35442fb1 s4-nterr: move auth_nt_status_squash to nt_status_squash and move to nterr.c
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
9f4b3b103f s4-nterr: some minor cosmetic edits to further match s3 nterr.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
199809b3cc nterr: make sure both nt_err_desc structs are the same.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
45710a05c5 nterr: make sure both nt_errs structs are the same.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
648a9fbc03 s4-nterr: add _N macro handling as in s3-nterr.
Guenther
2011-03-04 01:18:42 +01:00
Günther Deschner
cb8c0e1776 nterr: remove space indents (use tabs instead), following coding standards.
Guenther
2011-03-04 01:18:41 +01:00
Günther Deschner
2f46942e08 nterr: remove trailing whitespace.
Guenther
2011-03-04 01:18:41 +01:00
Matthias Dieter Wallnöfer
a5aecdf361 s4:torture/rap/rap.c - remove unused variable "i"
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Mar  2 18:38:58 CET 2011 on sn-devel-104
2011-03-02 18:38:58 +01:00
Günther Deschner
bd675e0b15 s4-smbtorture: add netsessionenum rap torture test.
Guenther
2011-03-02 12:12:32 +01:00
Günther Deschner
c884e622fa s4-smbtorture: add smbcli_rap_netsessionenum().
Guenther
2011-03-02 12:12:32 +01:00
Andrew Bartlett
0a78c57be6 s4-dsdb: Ensure we permit multi-valued backlinks on single-valued attributes
This was already done in repl_meta_data, but it needs to be done here
as well to cope with Windows 2000 level links.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar  2 02:03:58 CET 2011 on sn-devel-104
2011-03-02 02:03:58 +01:00
Matthias Dieter Wallnöfer
80995fde5a s4:drsuapi RPC server - this resembles more "samdb_is_gc"
Reviewed by: Jelmer

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar  1 17:57:47 CET 2011 on sn-devel-104
2011-03-01 17:57:47 +01:00
Matthias Dieter Wallnöfer
0b5719f5fc s4:netlogon RPC server - "LogonGetDomainInfo" - check for NULL attributes
This is needed to complete the transition from "samdb_msg_add_string" to
"ldb_msg_add_string".
And this patch yields better NTSTATUS error results than before
(INVALID_PARAMETER rather than OUT_OF_MEMORY).

Reviewed-by: Jelmer

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar  1 14:42:15 CET 2011 on sn-devel-104
2011-03-01 14:42:15 +01:00
Matthias Dieter Wallnöfer
fecf925043 s4:drsuapi RPC server - check for the "SPN" attribute != NULL
The SPN attribute could derive from an untrusted source (client).

Reviewed-by: Jelmer
2011-03-01 13:55:45 +01:00
Matthias Dieter Wallnöfer
0e68867b26 s4:dsdb - always handle the attribute "options" as 32bit unsigned integer
It is defined as LDAP syntax 2.5.5.9 so no need at all to treat it as
64-bit integer.

Reviewed by: Kamenim and Metze

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar  1 12:46:15 CET 2011 on sn-devel-104
2011-03-01 12:46:15 +01:00
Matthias Dieter Wallnöfer
47369370a1 s4:dsdb/common/util.c - remove "samdb_find_or_add_value"
This isn't used anymore.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-03-01 06:29:03 +01:00
Matthias Dieter Wallnöfer
c807911bf7 s4:dsdb/common/util.c - fully remove "samdb_msg_add_string"
This isn't needed anymore and will be substituted by
"ldb_msg_add_string".

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-03-01 06:29:03 +01:00
Matthias Dieter Wallnöfer
cbef9c352a s4:libnet/libnet_samsync_ldb.c - add a "samdb_msg_add_string" wrapper
Add this in order to allow the "ADD_OR_DEL" macros to work.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-03-01 06:29:03 +01:00
Matthias Dieter Wallnöfer
c66780332b s4:remove many invocations of "samdb_msg_add_string"
This call can be substituted by "ldb_msg_add_string". We only need to be
careful on local objects or talloc'ed ones which live shorter than the message.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-03-01 06:29:03 +01:00
Andrew Bartlett
5f5ca913b7 lib/util: new merged debug system
This is the s3 debug system, with a number of changes to tidy it up
for common use.  The debug class system is simplified by the removal of the
ISSET table, the system no longer attempts to cope with assignment of
DEBUGLEVEL, and the full class table is always available (rather than
just DEBUGLEVEL_CLASS[DBCG_ALL]) from startup.  It is also no longer
confusingly described as a hack, but as the initial table.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar  1 04:32:12 CET 2011 on sn-devel-104
2011-03-01 04:32:12 +01:00
Andrew Bartlett
4acef317a0 lib/util move debug.[ch] out of the way
This will allow a modified version of the s3 debug system to be the
new common debug system.

Andrew Bartlett
2011-03-01 03:46:18 +01:00
Kamen Mazdrashki
b1f68b6871 s4-libnet_vampire: Ignore some attributes when building working schema cache
Working schema cache will be used to convert replicated Schema objects
again later, i.e. used as reference, so we don't need to resolve all
attribute OIDs for working Schema cache to be usable.

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Mar  1 03:45:16 CET 2011 on sn-devel-104
2011-03-01 03:45:16 +01:00