1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

32866 Commits

Author SHA1 Message Date
Volker Lendecke
dc443ee6e9 s3: Fix two uninitialized variables 2010-07-20 20:35:39 +02:00
Jeremy Allison
7d17bfcf51 Rename spnego_gen_negTokenTarg() -> spnego_gen_krb5_negTokenInit()
as this correctly describes what this function does.

Jeremy.
2010-07-20 11:14:49 -07:00
Jeremy Allison
8a882b645c Remove gen_negTokenTarg(), as it's not actually creating a TokenTarg frame, but a TokenInit one.
Move to using spnego_gen_negTokenInit() instead.

Jeremy
2010-07-20 11:04:19 -07:00
Jeremy Allison
668744964d Fixes pointed out by <david.kondrad@legrand.us>. Free memory if not being
returned to caller. Remove unneeded asn1_tag_remaining() calls.

Jeremy.
2010-07-20 09:51:48 -07:00
Jeremy Allison
f5def289d3 Fix warning - no return value for a non-void fn.
Jeremy.
2010-07-20 09:34:32 -07:00
Björn Jacke
c58aeaaf31 s3: also run the test prog from the explicit external lib bug check
on Linux linking already stops with a broken ld, on FreeBSD8 linking works but
the binary is broken, so we must check both.

this should be the final fix for bug #7561
2010-07-20 18:12:40 +02:00
Simo Sorce
b20e5eb3aa dcerpc: Clarify what the arguments of dcerpc_pull_auth_trailer() actually represent. 2010-07-20 08:28:19 -04:00
Björn Jacke
2a8399f7ce s3: check for explicit external lib bug in ld's as-needed code
Second part of fix for bug #7561

Based on test provided by Olaf Flebbe.
2010-07-20 13:46:42 +02:00
Björn Jacke
09944302a1 s3: add configure swtich to manually disable as-needed
first part fix for bug #7561

based on earlier patch from metze
2010-07-20 13:46:42 +02:00
Björn Jacke
fa4dec31cf Revert "s3: Don't use as-needed"
This reverts commit b9835a1f9d.
2010-07-20 13:46:42 +02:00
Simo Sorce
4581902553 s3-dcerpc: Unifiy cli_pipe_auth_data and pipe_auth_data
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-20 15:52:37 +10:00
Simo Sorce
a91727fc79 s3-auth: Add auth_ntlmssp wrapper for client side
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-20 15:52:34 +10:00
Simo Sorce
e958b39042 s3-auth: Move auth_ntlmssp wrappers in their own file
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-20 15:52:31 +10:00
Simo Sorce
a04bbd281c s3-auth: Refactor and rename auth_ntlmssp_server_info()
Rename it to auth_ntlmssp_steal_server_info() to make it clear that
the server_info struct is stolen from the auth_ntlmssp_state structure.
Use talloc_move instead of manual steal&clear
Add comments to explain what is going on.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-20 15:52:24 +10:00
Jeremy Allison
0bb8d133c9 Remove gen_negTokenInit() - change all callers to spnego_gen_negTokenInit().
We now have one function to do this in all calling code. More rationalization
to follow.

Jeremy.
2010-07-19 17:14:26 -07:00
Jeremy Allison
8cba4a0c96 Move the addition of the 16 byte guid out of spnego_gen_negTokenInit() and
into negprot_spnego() where it belongs (it's not an SPNEGO operation).
Add a TALLOC_CTX for callers of negprot_spnego(). Closer to unifying all
the gen_negTokenXXX calls.

Jeremy.
2010-07-19 16:45:16 -07:00
Jeremy Allison
625a511389 Remove parse_negTokenTarg(), as it's actually incorrect. We're processing
negTokenInit's here. Use common code in spnego_parse_negTokenInit().

Jeremy.
2010-07-19 15:41:45 -07:00
Jeremy Allison
962951e63d Fix [Bug 7577] SPNEGO auth fails when contacting Win7 system using Microsoft Live Sign-in Assistant
Based on code from <david.kondrad@legrand.us>. Cope with every NegTokenInit ::= SEQUENCE value.
Jeremy.
2010-07-19 14:21:01 -07:00
Volker Lendecke
6763730304 s3: Avoid pwrite calls for the 1-byte writes with zero content
When a write cache is empty and we write one 0, there is no point in actually
writing into the write cache, which would trigger a potentially superfluous
write cache flush. We can rely on posix semantics to give us 0's when
subsequent read calls want to read from file areas not written yet.

Jeremy, please check!
2010-07-19 22:06:28 +02:00
Simo Sorce
944494d350 s3-auth: Remove unused variable.
It was a spurious remnant after a rebase.
2010-07-19 13:53:34 -04:00
Andrew Tridgell
a709e423d2 waf-idl: put the gen_ndr/README file for source3 back
This was removed by 100d37fc46, probably
accidentially.
2010-07-19 22:17:17 +10:00
Andreas Schneider
5cefbfef26 s3-rpc_server: Added callbacks for init and shutdown of a rpc service.
This adds two callback function for each rpc service. One is for
initialisation and the other for shutdown. rpc_<service>_unregister()
needs to be called to execute the shutdown function.
2010-07-19 12:59:18 +02:00
Andreas Schneider
b91e5cf17d s3-rpc_server: Don't register the same rpc commands twice. 2010-07-19 12:59:18 +02:00
Simo Sorce
c09dcb903c s3-auth: Use talloc hierarchies to properly free auth_ntlmssp_state contexts
Turn auth_ntlmssp_end into a destructor and attach it to auth_ntlmssp_state.
Remote auth_ntlmssp_end and use TALLOC_FREE in the callers.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-19 14:20:04 +10:00
Simo Sorce
673fcfa377 s3-auth: auth_make ntlmssp_state the parent context
There is no need for a separate mem_ctx member.
Also make the ntlmssp_state a children of auth_ntlmssp_state
Also cleanup auth_ntlmssp_end to free only what is not automatically freed

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-19 14:20:02 +10:00
Simo Sorce
e60ed80754 s3-auth: Simplify how we free the auth_context
Turn the freeing function into a destructor and attach it to the
auth_context.
Make all callers TALLOC_FREE() the auth_context instead of calling
the free function.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-19 14:20:00 +10:00
Simo Sorce
e4bd6eb72f s3-auth: Cleanup and readability fixes
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-19 14:19:58 +10:00
Simo Sorce
cdcdaaa6dd s3-ntlmssp: Remove ntlmssp_end and let the talloc hierarchy handle it.
All the members are children of ntlmssp_state anyway.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-19 14:19:47 +10:00
Volker Lendecke
27aece7200 s3: Actually use the usecs in aio_fork_suspend
Jeremy, please check!
2010-07-18 21:22:41 +02:00
Volker Lendecke
1946beb679 s3: Fix an uninitialized variable 2010-07-18 21:22:41 +02:00
Volker Lendecke
55512f4791 s3: Work better without the aio sighandler
Refuse async I/O if we can't set up the signal handler
2010-07-18 21:22:41 +02:00
Volker Lendecke
b1717ac92e s3: Fix some nonempty blank lines 2010-07-18 21:22:41 +02:00
Volker Lendecke
7ac58281ae s3: Remove a direct use of procid_self() 2010-07-18 21:22:41 +02:00
Andreas Schneider
898fd584a4 s3-rpc_client: Fixed a segfault in rpccli_samr_chng_pswd_auth_crap().
This fixes the WINBIND-WBCLIENT test. The test set
old_lm_hash_enc_blob.length to 0 and we don't check the length here. So
the memcpy segfaulted.
2010-07-18 15:09:24 +02:00
Andreas Schneider
0d16a591f4 s3-waf: Fixed the build. 2010-07-18 12:30:21 +02:00
Volker Lendecke
b9835a1f9d s3: Don't use as-needed
This is just broken. RHEL5 can't deal with it, FreeBSD8 is broken with it, and
who knows what other platforms are broken. I can rather live with a system that
links in a bit too much than a system that does not work at all.
2010-07-18 12:13:52 +02:00
Simo Sorce
3c0e10d70c s3-dcerpc: Fix build and remove unneeded headers
Sorry, botched a rebase.
2010-07-17 15:44:19 -04:00
Simo Sorce
52f6bfea4b s3-dcerpc: Move mere processing functions from srv_pipe_hnd.c to srv_pipe.c 2010-07-17 15:37:24 -04:00
Simo Sorce
628b57ca37 s3-dcerpc: Move common cli/srv functions into a common file 2010-07-17 15:01:11 -04:00
Volker Lendecke
3925411de4 s3: Really fix the 64-bit warnings
Hmm. Forgot to git commit this piece, sorry :-(
2010-07-17 20:21:19 +02:00
Volker Lendecke
32fd6e3c25 s3: Fix some 64-bit warnings 2010-07-17 19:58:21 +02:00
Volker Lendecke
a7e6b2aeb4 s3: Right now we do not have includes in Makefile.in
Skip the expansion step on non-GNU-make systems
2010-07-17 19:58:21 +02:00
Günther Deschner
feb21905cb s3-build: add LIBNDR_XATTR_OBJ.
Guenther
2010-07-17 00:37:08 +02:00
Günther Deschner
c5e85a4987 s3-dcerpc: rename SCHANNEL_SIG_SIZE to NL_AUTH_SIGNATURE_SIZE and move to IDL.
Guenther
2010-07-16 23:09:54 +02:00
Simo Sorce
65116adceb s3-dcerpc: Fix ability to receive Big Endian PDUs 2010-07-16 16:02:39 -04:00
Jeremy Allison
e058de31e8 Make the "map to guest" parameter work correctly with NTLMSSP (spnego
and raw) under SMB2. Still need to investigate fixing this with krb5
auth (does this make sense ?).

Jeremy.
2010-07-16 11:05:34 -07:00
Günther Deschner
914fd13edd s3-registry: use some prs macros to the only place where they are used.
Guenther
2010-07-16 02:20:34 +02:00
Günther Deschner
196b4e8342 s3-waf: fix the build.
Guenther
2010-07-16 02:07:51 +02:00
Günther Deschner
7cf4797dd3 s3-dcerpc: fix c++ warning.
Guenther
2010-07-16 01:51:18 +02:00
Simo Sorce
f4c6c7e7b8 Move the remnants of rpc_parse code under registry/
The registry code is the only last user of this code.
Move everything under registry/ and hope someone will get rid od
it completely from there in the future.

Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:18 +02:00