1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

1014 Commits

Author SHA1 Message Date
Stefan Metzmacher
43dd033618 s3:torture/test_smb2: test a tree_connect during reauth
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Feb 28 06:58:44 CET 2012 on sn-devel-104
2012-02-28 06:58:44 +01:00
Stefan Metzmacher
c64a85ee19 s3:torture/test_smb2: check directory listing during reauth
metze
2012-02-28 05:22:50 +01:00
Michael Adam
727f3ee6ac s3:libsmb:smb2: pass previous session ID to session setup, not previous session
We only need the session, and under some circumstances, it might complicate
things for the caller to have to cope with the whole structure (talloc...).
2012-02-28 00:08:52 +01:00
Stefan Metzmacher
b8407c22d9 s3:torture/test_smb2: show that a session is not valid for path based calls during reauth
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb 27 16:29:02 CET 2012 on sn-devel-104
2012-02-27 16:29:02 +01:00
Stefan Metzmacher
f8cd6e8b59 s3:torture/test_smb2: show that a session is valid during a multi-leg reauth
metze
2012-02-27 14:55:15 +01:00
Stefan Metzmacher
1444d4900f s3:torture/test_smb2: fix missleading file name in reauth test
metze
2012-02-27 14:55:15 +01:00
Stefan Metzmacher
aa4331be9e libcli/smb/smbXcli: maintain smb2 channel_signing_key separate from the signing_key
The signing_key is fix across all channels and is used for session setups
on a channel binding.

Note:
 - the last session setup response is signed with the new channel signing key.
 - the reauth session setups are signed with the channel signing key.

It's also not needed to remember the main session key.

metze
2012-02-27 12:51:33 +01:00
Stefan Metzmacher
18cd0b789e s3:torture/test_smb2: remove explicit smb2_signing_check_pdu()
smb2cli_session_set_session_key() already checks the signature
and that function really knows the signing key.

metze
2012-02-27 12:51:33 +01:00
Stefan Metzmacher
c45cb3353b s3:torture/test_smb2: a reauth doesn't update the session/signing key
metze
2012-02-27 12:51:33 +01:00
Andrew Bartlett
f14dffa815 s3-selftest: Verify GK and GF flag behaviour
At least this ensures that the helper has not crashed, it will require
a little more to ensure that the values are correct.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 24 03:53:38 CET 2012 on sn-devel-104
2012-02-24 03:53:38 +01:00
Andrew Bartlett
b947d84c88 s3-selftest: run ntlm_auth against winbindd in make test 2012-02-24 12:12:48 +11:00
Volker Lendecke
e673afada1 s3-vfstest: Return an error code if cmd failed
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 22 23:56:18 CET 2012 on sn-devel-104
2012-02-22 23:56:17 +01:00
Volker Lendecke
ee2e3d56a2 s3-vfstest: Fake smb_requests
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 22 17:32:28 CET 2012 on sn-devel-104
2012-02-22 17:32:24 +01:00
Volker Lendecke
b0c21afffe s3-vfstest: Initialize some more 2012-02-22 15:48:06 +01:00
Volker Lendecke
e9b9ba14c0 s3-vfstest: Remove an unused variable
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Feb 20 17:01:11 CET 2012 on sn-devel-104
2012-02-20 17:01:11 +01:00
Volker Lendecke
8679dc711f s3: Fix some blank line endings 2012-02-19 21:36:33 +01:00
Volker Lendecke
810d2f55c1 s3-vfstest: Initialize some more 2012-02-19 21:36:33 +01:00
Christopher R. Hertel (crh)
b5b204184a Rename obscure defined constants.
Replaced the undescriptive SMB_PORT1 and SMB_PORT2 defined constants
with the slightly more descriptive names NBT_SMB_PORT and TCP_SMB_PORT.
Also replaced several hard-coded references to the well-known port
numbers (139 and 445, respectively) as appropriate.

Small changes to clarify some comments regarding the two transport
types.

Signed-off-by: Simo Sorce <idra@samba.org>

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Feb 16 08:29:41 CET 2012 on sn-devel-104
2012-02-16 08:29:41 +01:00
Volker Lendecke
a0e44c30e2 lib/util: Add hex_encode_buf
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Feb  6 09:15:33 CET 2012 on sn-devel-104
2012-02-06 09:15:32 +01:00
Volker Lendecke
b1a544fc80 s3-vfstest: Add removexattr 2012-02-02 20:35:27 +01:00
Volker Lendecke
dbe9ff2999 s3-vfstest: Add setxattr 2012-02-02 20:35:27 +01:00
Volker Lendecke
0a000f1ca7 s3-vfstest: Add listxattr 2012-02-02 20:35:27 +01:00
Volker Lendecke
7d72424f01 s3-vfstest: Add getxattr 2012-02-02 20:35:27 +01:00
Volker Lendecke
3bea5a147b s3-vfstest: Fix an uninitialized read in close
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Feb  2 18:00:58 CET 2012 on sn-devel-104
2012-02-02 18:00:58 +01:00
Volker Lendecke
25d3a2e83c s3-vfstest: Fix a double-free on closing a file
"mem_ctx" will be gone after we leave the routine
2012-02-02 16:26:16 +01:00
Volker Lendecke
207af5d9e3 s3-vfstest: Correctly initialize the connection path 2012-02-01 20:19:31 +01:00
Volker Lendecke
1bd7497a18 s3-vfstest: Fix some uninitialized vars 2012-02-01 20:19:31 +01:00
Volker Lendecke
3c6bd8c1ef s3-vfstest: Fix some pointless statics 2012-02-01 20:19:31 +01:00
Volker Lendecke
1168700d91 s3-vfstest: Fix a typo 2012-02-01 20:19:30 +01:00
Volker Lendecke
435f817329 s3-vfstest: Fix some nonblank line endings 2012-02-01 20:19:30 +01:00
Volker Lendecke
45e61fcf61 s3: Add a "lock_order" argument to db_open
This will be used to enforce a lock hierarchy between the databases. We have
seen deadlocks between locking.tdb, brlock.tdb, serverid.tdb and notify*.tdb.
These should be fixed by refusing a dbwrap_fetch_locked that does not follow a
defined lock hierarchy.
2012-01-18 14:48:04 +01:00
Günther Deschner
4c03f08c0d s3-pdbtest: only test trusted domains when pdb backends offers trusted domain support.
Guenther
2012-01-09 10:34:05 +01:00
Volker Lendecke
76ca46ecfe s3: Avoid a potential alignment requirement issue
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan  6 18:58:11 CET 2012 on sn-devel-104
2012-01-06 18:58:11 +01:00
Volker Lendecke
6529e520ee s3: Use DELETE_ON_CLOSE instead of unlink 2012-01-06 17:23:43 +01:00
Andrew Bartlett
662c557b36 s3-torture convert smb2 test to use auth_generic/gensec for NTLMSSP
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jan  6 12:09:12 CET 2012 on sn-devel-104
2012-01-06 12:09:12 +01:00
Stefan Metzmacher
893d7921a1 s3:SMB2-SESSION-RECONNECT: also expect NETWORK_NAME_DELETED is signing isn't used
metze
2012-01-06 08:31:16 +01:00
Volker Lendecke
f994f0a342 Fix the local-memcache test for 64-bit
The memcache test walks the purge functionality. The maximum memcache size also
takes all memcache internal headers into account. Those headers contain
pointers, so on 64-bit they take more space...

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jan  5 22:01:00 CET 2012 on sn-devel-104
2012-01-05 22:01:00 +01:00
Volker Lendecke
f97216eb4a s3: Add a test for proper brlock cleanup
We need to improve the server here.

Maybe we should validate the brlock entry whenever we detect a read/write being
blocked from locking? This is not our hot code path anyway, and it would gain
us significant robustness. The code might become quite a bit simpler as well.
2012-01-05 20:29:59 +01:00
Volker Lendecke
515dfe6c7f s3: Clarify what CLEANUP1 does 2012-01-05 20:29:59 +01:00
Volker Lendecke
0d0141893e s3: Add a test excercising the share mode cleanup routine 2012-01-05 13:09:36 +01:00
Volker Lendecke
cd3a935d0e s3: Fix a cut&paste error
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jan  3 16:57:44 CET 2012 on sn-devel-104
2012-01-03 16:57:44 +01:00
Volker Lendecke
0923e7fa39 s3: Fix a typo 2012-01-03 15:22:03 +01:00
Stefan Metzmacher
32317b0529 s3:torture/test_smb2: also try PROTOCOL_SMB2_24
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Dec 22 17:47:17 CET 2011 on sn-devel-104
2011-12-22 17:47:17 +01:00
Stefan Metzmacher
03455519e7 s3:smbd: pass smbd_server_connection and a snumused function pointer to reload_services()
metze
2011-12-15 11:11:24 +01:00
Stefan Metzmacher
daa685c008 s3:vfstest: reload_services() doesn't need a messaging_context
It's only used to get the global smbd_server_connection,
which is used in conn_snum_used() via lp_killunused().
But there we don't need it, as we don't have any tree connects
at startup time.

metze
2011-12-13 20:31:09 +01:00
Volker Lendecke
0f9d14820e s3: Remove a bunch of calls to procid_self()
All callers to messaging_[re]init only used procid_self()
2011-12-12 21:50:25 +01:00
Andrew Bartlett
c9d929af8b s4-lsarpc handle more info levels in SetInfoTrustedDomain calls
This uses the very helpful conversion functions written for the s3 lsa server
and places these in common.

Andrew Bartlett
2011-12-12 12:57:07 +01:00
Jeremy Allison
4e709dc42f Rename cli_open -> cli_openx. Prelude to replacing generic cli_open()
with a call that uses NTCreateX in preference to OpenAndX.
2011-12-03 21:13:08 -08:00
Stefan Metzmacher
bfbfcd1a51 s3:torture: test smb2cli_logoff and smb2cli_tdis
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 24 20:36:31 CET 2011 on sn-devel-104
2011-11-24 20:36:31 +01:00
Stefan Metzmacher
a5322366d8 s3:torture: add SMB2-SESSION-REAUTH
metze
2011-11-24 19:02:33 +01:00
Stefan Metzmacher
2a04959ba1 s3:torture: add SMB2-MULTI-CHANNEL test
metze
2011-11-24 19:02:33 +01:00
Michael Adam
4c29389c04 s3:torture: add a new test SMB2-TCON-DEPENDENCE
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-24 19:02:33 +01:00
Michael Adam
1fef161d2a s3:torture:smb2: add SMB2-SESSION-RECONNECT test
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-24 19:02:33 +01:00
Stefan Metzmacher
a312a8c788 s3:torture: use cli_tree_connect() instead of smb2cli_tcon()
metze
2011-11-24 19:02:33 +01:00
Stefan Metzmacher
2d9a8898f2 s3:torture: make use of cli_tree_connect()
metze
2011-11-24 19:02:32 +01:00
Stefan Metzmacher
5c97bbf3ef s3:torture: replace smb2cli_sesssetup_ntlmssp() with the more generic cli_session_setup()
metze
2011-11-24 19:02:32 +01:00
Stefan Metzmacher
773d0a6add s3:torture: add SMB2-NEGPROT test
metze
2011-11-24 19:02:32 +01:00
Stefan Metzmacher
628dd727cf s3:SMB2-BASIC: use smbXcli_negprot() directly
metze
2011-11-24 19:02:32 +01:00
Björn Baumbach
773abaa2ef s3-torture: remove all cli_nt_error() calls in torture
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-16 19:02:12 +01:00
Björn Baumbach
9430fbf922 s3-torture: replace cli_errstr() with nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-16 19:02:12 +01:00
Stefan Metzmacher
59dcdfd175 s3:torture: s/Undefined/SMB_SIGNING_DEFAULT/ s/Required/SMB_SIGNING_REQUIRED/
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
881feda353 s3:torture: let SMB2-BASICS work against w2k8r2 and win8pre0
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov  3 09:44:59 CET 2011 on sn-devel-104
2011-11-03 09:44:59 +01:00
Andrew Bartlett
f28fda7638 s3-torture Remove t_stringoverflow as fstrcpy now uses strlcpy
Because we no longer use safe_strcpy() internally, we no longer have a
mode where we write to the end of the buffer in developer mode, and so
there isn't anything for this test to test.

Andrew Bartlett
2011-10-28 13:10:28 +02:00
Andrew Bartlett
f31fd31b71 s3-torture run t_strappend tests as LOCAL-sprintf_append 2011-10-28 13:10:28 +02:00
Andrew Bartlett
4cc0552f6e s3-torture Run t_strappend test for less time 2011-10-28 13:10:28 +02:00
Andrew Bartlett
de148f748a s3-torture Fix t_strappend test 2011-10-28 13:10:27 +02:00
Andrew Bartlett
f54dcc86b8 s3-torture remove unused t_push_ucs2.c t_strcmp.c t_strstr.c
These tests were incorportated into
source4/scripting/python/samba/tests/strings.py with
fa3e2fc8bb.

Andrew Bartlett
2011-10-28 13:10:27 +02:00
Andrew Bartlett
961952ee64 s3-torture remove unused t_asn1.c
This test was incorportated into lib/util/test/asn1_test.c with
ede98c0e51

Andrew Bartlett
2011-10-28 13:10:27 +02:00
Andrew Bartlett
50e7a8767f torture: Remove unused smbiconv
smbiconv is not used in any test script, and has only had changes
since being introduced by Jelmer to keep it building.

It is also not installed on the system. I have also checked with
Jelmer, who approved the removal.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-10-25 17:58:33 +02:00
Stefan Metzmacher
7ebd4337ac libcli/smb: move source3/libsmb/read_smb.* to the toplevel
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 10:18:06 CEST 2011 on sn-devel-104
2011-10-24 10:18:06 +02:00
Stefan Metzmacher
99666e4a8d s3:torture: avoid using read_smb()
metze
2011-10-24 08:25:31 +02:00
David Disseldorp
d5ea379428 s3: Remove duplicate fsctl function definitions
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-10-19 15:44:29 +02:00
Michael Adam
658f72128f s3:dbwrap: change dbwrap_fetch_uint32() to NTSTATUS return type (instead of bool)
for consistency and better error propagation
2011-10-11 14:17:58 +02:00
Michael Adam
6fb5c47f21 s3:torture: convert torture.c to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
2011-10-11 14:17:58 +02:00
Michael Adam
7a72c84ee7 s3:dbwrap: move the db_open_rbt() prototype to a new header dbwrap_rbt.h 2011-10-11 14:17:55 +02:00
Richard Sharpe
e8f143a45c Add a torture test to test existing FSCTL responses 2011-10-01 07:02:19 -07:00
Stefan Metzmacher
e3e7869f61 s3:smb2cli: s/smb2cli_sesssetup/smb2cli_sesssetup_ntlmssp/
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Sep 18 21:43:26 CEST 2011 on sn-devel-104
2011-09-18 21:43:26 +02:00
Stefan Metzmacher
79043f84d1 s3:SMB2-BASIC: test smb2cli_flush()
metze
2011-09-18 05:33:10 +02:00
Stefan Metzmacher
3f00cce9b3 s3:libsmb: pass max_protocol to cli_negprot()
metze
2011-09-15 10:25:17 +02:00
Stefan Metzmacher
ff52be06e5 s3:libsmb: remove unused cli->is_samba
s3:libsmb: remove unused cli->is_samba

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
2011-09-14 13:12:52 -07:00
Stefan Metzmacher
e80f79a1fb s3:torture/run_oplock4: don't set cli->use_level_II_oplocks
Doing this after the session setup is pointless,
as that's the only place where we tell the server we support
level II oplocks.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 14 17:23:46 CEST 2011 on sn-devel-104
2011-09-14 17:23:46 +02:00
Stefan Metzmacher
eaccea9e29 s3:torture: there's no need to alter cli->max_xmit in order to test large writes
metze
2011-09-13 18:12:22 +02:00
Stefan Metzmacher
924b2d5b7f s3:torture: use CLI_BUFFER_SIZE instead of cli->max_xmit
The max_data parameter of trans2/nttrans calls are not bound
to cli->max_xmit. Even with cli->max_xmit, which means the max
size of the whole SMB pdu, we would get fragmented trans2/nttrans
replies. That's why we can also use our maximum, which is CLI_BUFFER_SIZE.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Sep 13 14:52:35 CEST 2011 on sn-devel-104
2011-09-13 14:52:35 +02:00
Sumit Bose
456aee80f5 s3-lsa: Add conversion for auth info structs
struct lsa_TrustDomainInfoAuthInfo and struct
trustAuthInOutBlob can store the same information for different usage. The added
routines can convert one struct into the other.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Sep 12 15:52:17 CEST 2011 on sn-devel-104
2011-09-12 15:52:17 +02:00
Stefan Metzmacher
fe11e9b2c6 s3:torture: make use of CLI_FULL_CONNECTION_DONT_SPNEGO
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep  8 19:23:32 CEST 2011 on sn-devel-104
2011-09-08 19:23:32 +02:00
Stefan Metzmacher
173e323cd9 s3:torture: make use of CLI_FULL_CONNECTION_FORCE_DOS_ERRORS
metze
2011-09-08 17:51:30 +02:00
Stefan Metzmacher
3e227d8544 s3:libsmb: pass CLI_FULL_CONNECTION_* flags via cli_connect_nb()
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep  8 10:21:50 CEST 2011 on sn-devel-104
2011-09-08 10:21:50 +02:00
Stefan Metzmacher
fcd0c0e19e s3:torture: relax TRANS2 midmight time checking
It's possible that the test runs on a full hour, e.g. Tue Sep  6 03:00:00 2011.

So better check that the a_time is different from the current time.

metze
2011-09-07 10:38:02 +02:00
Volker Lendecke
8fd5e0ff2e Replace calls to sid_equal with calls to dom_sid_equal 2011-08-17 12:30:08 +02:00
Simo Sorce
b120c5f288 torture: use tevent_ functions names instead of the legacy event_ ones 2011-08-13 09:54:15 -04:00
Stefan Metzmacher
0a9c30f509 Revert "s3:test_async_echo: unsure the desired smb message sequence"
This reverts commit 34faeb8bba.

This is not needed anymore.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Aug 10 09:54:24 CEST 2011 on sn-devel-104
2011-08-10 09:54:23 +02:00
Stefan Metzmacher
70c2bbecde s3:torture/*: use CLI_BUFFER_SIZE instead of cli->max_xmit
The max_data parameter of trans2/nttrans calls are not bound
to cli->max_xmit. Even with cli->max_xmit, which means the max
size of the whole SMB pdu, we would get fragmented trans2/nttrans
replies. That's why we can also use our maximum, which is CLI_BUFFER_SIZE.

metze
2011-08-09 15:30:04 +02:00
Volker Lendecke
c73890d230 s3: Fix "ISO C90 forbids mixed declarations and code"
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Aug  5 16:58:37 CEST 2011 on sn-devel-104
2011-08-05 16:58:37 +02:00
Volker Lendecke
2751ed6f45 s3: Fix some nonempty blank lines 2011-08-05 15:41:36 +02:00
Stefan Metzmacher
2abe723e60 s3:torture: make use of cli_set_timeout()
metze
2011-08-03 09:01:40 +02:00
Stefan Metzmacher
32a47730da s3:masktest: make use of cli_state_protocol()
metze
2011-08-02 04:54:29 +02:00
Stefan Metzmacher
a4d79a3799 s3:torture: make use of cli_state_capabilities()
metze
2011-08-02 04:54:28 +02:00
Michael Adam
0b5c4a601a s3:dbwrap: move all .c and .h files of dbwrap to lib/dbwrap/
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jul 29 13:34:22 CEST 2011 on sn-devel-104
2011-07-29 13:34:22 +02:00
Michael Adam
1abdd9b2bb s3:dbwrap: move db_open() to a file dbwrap_open.c of its own.
Also start new folder lib/dbwrap/ where dbwrap_open.c is stored and
make the fallbacke implementation functoins non-static and create a
dbwrap_private.h header file that contains their prototypes.
2011-07-29 12:23:13 +02:00
Volker Lendecke
553124a663 s3: In the async echo test, write 65k
This leads to the writev from echo responder child to parent to only deliver a
partial blob and thus excercises the retry code.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul 28 15:07:40 CEST 2011 on sn-devel-104
2011-07-28 15:07:40 +02:00
Michael Adam
7b7c6c85f1 s3:torture: use lp_load_global() in pdbtest - this does not need shares nor IPC$ 2011-07-28 11:17:42 +02:00
Michael Adam
ae752ec3a5 s3:smbtorture: use the lp_load_global() wrapper of lp_load() 2011-07-28 11:17:35 +02:00
Michael Adam
c32479f584 s3:torture: use lp_load_global() in the strstr test 2011-07-28 11:17:34 +02:00
Michael Adam
ecc487e026 s3:torture: use lp_load_global in the strcmp test 2011-07-28 11:17:34 +02:00
Michael Adam
426ae350ee s3:torture: use lp_load_global() in the push_ucs2 test 2011-07-28 11:17:33 +02:00
Michael Adam
bfde6fa535 s3:torture: use lp_load_global() in the msgtest 2011-07-28 11:17:33 +02:00
Michael Adam
d6b4c693be s3:torture: use lp_load_global() in the masktest 2011-07-28 11:17:33 +02:00
Michael Adam
ee495ab5c3 s3:torture: use lp_load_global() in locktest2 2011-07-28 11:17:32 +02:00
Michael Adam
407a514f8b s3:torture: use lp_load_global() in the locktest 2011-07-28 11:17:32 +02:00
Volker Lendecke
94a2328367 s3: Avoid calls to cli_dos/nt_error in torture
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul 27 23:07:51 CEST 2011 on sn-devel-104
2011-07-27 23:07:50 +02:00
Volker Lendecke
a7f8d9e798 s3: Fix formatting in check_error() 2011-07-27 21:55:21 +02:00
Stefan Metzmacher
34faeb8bba s3:test_async_echo: unsure the desired smb message sequence
We want to start sending echo requests once the rpc related
smb operation arrived the smb layer.

metze
2011-07-27 21:55:21 +02:00
Volker Lendecke
61d420e0d8 s3: cli_close_done->write_andx_done in test_async_echo
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul 27 02:03:49 CEST 2011 on sn-devel-104
2011-07-27 02:03:49 +02:00
Volker Lendecke
cdae9ef267 s3: Fix a debug message 2011-07-27 00:47:45 +02:00
Volker Lendecke
45ec7d6f24 s3: Fix formatting 2011-07-27 00:47:45 +02:00
Volker Lendecke
9f66e302b8 s3: Fix an error message 2011-07-27 00:47:45 +02:00
Björn Baumbach
6911b04606 s3-torture: run_nttrans_create(): replace cli_query_secdesc_old()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:57 +02:00
Björn Baumbach
768646c9a2 s3-libsmb: rename cli_query_secdesc() to cli_query_secdesc_old()
Will introduce new cli_query_secdesc() function

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:56 +02:00
Björn Baumbach
473b16dcbf s3-torture/nbio.c: replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:55 +02:00
Björn Baumbach
78333531de s3-torture/utable.c: replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:55 +02:00
Björn Baumbach
4b76c108ba s3-torture/denytest.c: replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:27 +02:00
Björn Baumbach
6d695749c7 s3-torture: run_oplock2(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:25 +02:00
Björn Baumbach
963aa9856c s3-torture: run_fdsesstest(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:25 +02:00
Björn Baumbach
995978ae96 s3-torture: run_fdpasstest(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:24 +02:00
Stefan Metzmacher
cfec548aa0 s3-torture: run_locktest7(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:20 +02:00
Stefan Metzmacher
4971a0a2bc s3-torture: run_locktest7(): goto fail on read error
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:10:09 +02:00
Björn Baumbach
a560b793ca s3-torture: run_locktest4(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-22 17:06:09 +02:00
Björn Baumbach
0986b0bed7 s3-torture: introduce test_cli_read()
test_cli_read calls cli_read and returns success or failure

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-22 17:06:08 +02:00
Stefan Metzmacher
cd71c5746b s3:torture: use cli_state_disconnect() to close the socket on SIGALRM
metze
2011-07-22 17:06:07 +02:00
Stefan Metzmacher
25447a528a s3:libsmb: move cli->vuid to cli->smb1.uid and hide it behind cli_state_[g|s]et_uid()
metze
2011-07-21 22:08:52 +02:00
Björn Baumbach
d622cadd34 s3-torture: run_simple_posix_open_test(): replace cli_read_old() with
cli_read()

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul 20 23:22:09 CEST 2011 on sn-devel-104
2011-07-20 23:22:09 +02:00
Björn Baumbach
c53e2ad4de s3-torture: rw_torture2(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-20 22:09:26 +02:00
Björn Baumbach
ea4c4480b4 s3-torture: rw_torture3(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-20 22:09:26 +02:00
Björn Baumbach
b10fa4bbcd s3-torture: rw_torture(): replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-20 22:09:26 +02:00
Björn Baumbach
9b168e128a s3-libsmb: replace cli_read() with cli_read_old()
Will introduce new cli_read() function.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-20 22:09:25 +02:00
Stefan Metzmacher
8f41e54d53 s3:libsmb: move cli->cnum to cli->smb1.tid and hide it behind cli_state_[g|s]et_tid()
metze
2011-07-20 15:56:27 +02:00
Stefan Metzmacher
1e3822115c s3:libsmb: move cli->pid to cli->smb1.pid and hide it behind cli_[g|s]etpid()
metze
2011-07-20 15:55:08 +02:00
Björn Baumbach
d29f8491bd s3-torture: run_locktest5(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-18 23:27:55 +02:00
Björn Baumbach
8f7b7d7aa2 s3-torture: run_locktest4(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-18 23:27:54 +02:00
Björn Baumbach
69ed3a780e s3-torture: run_oplock2(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-18 23:27:54 +02:00
Björn Baumbach
4dbdaa6608 s3-torture: run_locktest9(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-18 23:27:53 +02:00
Björn Baumbach
ae92edc46b s3-torture: run_locktest8(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-18 23:27:53 +02:00
Björn Baumbach
a5d5308073 s3-torture: run_locktest7(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-18 23:27:53 +02:00
Björn Baumbach
b0faf0bd26 s3-torture: run_locktest3(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-18 23:27:52 +02:00
Björn Baumbach
50e2785f5e s3-torture: run_locktest2(): replace check_error() with check_both_error()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-11 16:35:11 +02:00
Björn Baumbach
e14e6747ae s3-torture: run_locktest2(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-11 16:35:11 +02:00
Björn Baumbach
c9f604543b s3-torture: run_locktest1(): replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-11 16:35:10 +02:00
Björn Baumbach
23b417b4c0 s3-torture: locktest2: replace cli_lock() with cli_lock32()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-11 16:35:10 +02:00
Björn Baumbach
b6e9866c54 s3-torture: let wait_lock() use cli_lock32() instead of cli_lock()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-11 16:35:10 +02:00
Björn Baumbach
f2c5a0afd2 s3-libsmb: let cli_lock64 return NTSTATUS instead of bool
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul 11 12:48:38 CEST 2011 on sn-devel-104
2011-07-11 12:48:38 +02:00
Stefan Metzmacher
0342b69f36 s3:torture: use cli_is_nt/dos_error() in run_error_map_extract()
Callers should avoid using cli->inbuf directly!

metze
2011-07-08 14:09:09 +02:00
Stefan Metzmacher
67ac266ae8 s3:torture: add SMB2-BASIC
Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze
2011-07-08 01:22:22 +02:00
Björn Baumbach
98e0f9d1ed s3-torture: run_shortname_test: Remove uses of cli_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-07 19:16:28 +02:00
Björn Baumbach
684095b0a2 s3-torture: run_simple_posix_open_test: Remove uses of cli_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-07 19:16:28 +02:00
Stefan Metzmacher
840a1c7445 s3-torture: use nt_errstr() for cli_unlink() error handling
Use nt_errstr() instead of cli_errstr() for error handling on
cli_unlink() calls.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-07 19:16:28 +02:00
Björn Baumbach
60873a9e48 s3-torture: introduce check_both_error()
Check if the server produced the expected dos or nt error code like
check_error(), but without a cli_state struct.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-07 19:16:28 +02:00
Stefan Metzmacher
fc992e7029 s3:torture/scanner: use trans2_bytes_push_str() in scan_nttrans()
metze
2011-07-07 19:16:28 +02:00
Stefan Metzmacher
02171ee0f0 s3:torture/scanner: use trans2_bytes_push_str() in scan_trans2()
metze
2011-07-07 19:16:28 +02:00
Stefan Metzmacher
d921200e75 s3:libsmb: use clistr_pull_talloc() for short_name in interpret_long_filename()
metze
2011-07-07 19:16:27 +02:00
Volker Lendecke
eba5d0b641 s3: Remove a use of cli_errstr
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul  7 18:04:26 CEST 2011 on sn-devel-104
2011-07-07 18:04:26 +02:00
Stefan Metzmacher
8a2290667c s3:libsmb: use clistr_pull_talloc() in cli_qfilename()
metze
2011-07-06 17:18:14 +02:00
Stefan Metzmacher
a1df729f7b s3:libsmb: let cli_qfileinfo[_recv]() return recv_flags2
metze
2011-07-06 17:18:13 +02:00
Volker Lendecke
f0ff6f390a Use tevent_req_oom
This fixes a few Coverity errors
2011-06-20 12:33:24 +02:00
Rusty Russell
d925b327f4 tdb_compat: Higher level API fixes.
My previous patches fixed up all direct TDB callers, but there are a
few utility functions and the db_context functions which are still
using the old -1 / 0 return codes.

It's clearer to fix up all the callers of these too, so everywhere is
consistent: non-zero means an error.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
ca1936fbb2 tdb_compat: use tdb_open_compat.
This is a helper for the common case of opening a tdb with a logging
function, but it doesn't do all the work, since TDB1 and TDB2's log
functions are different types.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Volker Lendecke
763941f245 s3: Test nttrans_create
This is a test for the share security descriptor exception for nttrans_create
2011-06-19 11:30:02 +02:00
Sumit Bose
d5661467e1 s3-passdb: Implement new pdb trust calls for the default backend
Signed-off-by: Simo Sorce <idra@samba.org>

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Sun Jun 12 06:45:25 CEST 2011 on sn-devel-104
2011-06-12 06:45:25 +02:00
Andrew Bartlett
74eed8f3ed s3-param Remove special case for global_myname(), rename to lp_netbios_name()
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
ad0a07c531 s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
d5e6a47f06 s3-talloc Change TALLOC_P() to talloc()
Using the standard macro makes it easier to move code into common, as
TALLOC_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653 s3-talloc Change TALLOC_ARRAY() to talloc_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Jeremy Allison
c7d2f6d35a Remove the char * argument from the SMB_VFS_GETWD() call. Now always
returns malloc'ed memory.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jun  1 04:06:12 CEST 2011 on sn-devel-104
2011-06-01 04:06:12 +02:00
Andrew Bartlett
e5dd03d199 s3-globals Remove smbd_event_context() (use server_event_context())
This has been a wrapper around server_event_context() for some time
now, and removing this from dummmysmbd.c assists with library
dependencies.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Volker Lendecke
ef0260ddbc s3: Fix cli_bad_session_request
We expect a negative session response with a 0x82 error (called name not
present), not a 0x82 message
2011-05-29 21:10:26 +02:00
Volker Lendecke
97dcdcd5c2 s3: Simplify run_bad_nbt_session 2011-05-29 21:10:26 +02:00
Volker Lendecke
18a54fe4eb s3: Simplify cli_bad_session_request
For this purpose we don't need the full cli_state
2011-05-29 21:10:26 +02:00
Volker Lendecke
8a3199e00d s3: Use cli_connect_nb in smbtorture open_nbt_connection 2011-05-28 23:04:02 +02:00
Volker Lendecke
57ae32794f s3: Add called name_type param to cli_connect_nb 2011-05-28 20:50:09 +02:00
Volker Lendecke
649873bcf3 s3: Use cli_connect_nb in masktest 2011-05-28 20:50:09 +02:00
Volker Lendecke
1173a4f83d s3: Fix some nonemtpy blank lines 2011-05-28 20:50:09 +02:00
Volker Lendecke
5df87913d7 s3: Use cli_connect_nb in locktest
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 18:06:49 CEST 2011 on sn-devel-104
2011-05-28 18:06:49 +02:00
Volker Lendecke
ce9d63d161 s3: Remove the smbtorture3 OPLOCK3 test
This is the last user of cli_receive_smb. Oplocks are nowadays tested
in smbtorture4, this mainly has historic value
2011-05-22 21:07:40 +02:00
Volker Lendecke
9a787bbad1 s3: Convert the OPEN4 test to async oplock handling
This removes a caller of cli_receive_smb
2011-05-22 21:07:40 +02:00
Volker Lendecke
58b77f2267 s3: Remove a use of cli_send_smb
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 19 20:11:33 CEST 2011 on sn-devel-104
2011-05-19 20:11:33 +02:00
Andrew Bartlett
c615ebed6e s3-lib Replace StrCaseCmp() with strcasecmp_m()
strcasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Günther Deschner
d97faae7db s3-smbtorture: fix build warning (shadowed NTSTATUS variable).
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 18 14:17:13 CEST 2011 on sn-devel-104
2011-05-18 14:17:13 +02:00
Björn Baumbach
23e23d0836 s3-torture/nbio.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:55:52 +02:00
Björn Baumbach
310502a15a s3-torture/mangle_test.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:50:34 +02:00
Björn Baumbach
6fd0e062d3 s3-torture: torture.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:49:41 +02:00
Günther Deschner
675573d54b s3-includes: finally only include client.h when libsmb is used.
Guenther
2011-05-06 16:37:22 +02:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h
Guenther
2011-05-06 16:37:18 +02:00
Günther Deschner
d8cfca3a9b s3: only include tdb headers where needed.
Guenther
2011-05-06 10:48:10 +02:00
Andrew Bartlett
344eb08ee4 nterr: Add mem_ctx for return string from get_nt_error_c_code()
It is clearer to avoid the implicit return on talloc_tos()

Andrew Bartlett
2011-05-06 07:51:24 +02:00
Jeremy Allison
153a091d9c Fix const in smbtorture.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 02:45:00 CEST 2011 on sn-devel-104
2011-05-06 02:45:00 +02:00
Jeremy Allison
7d6ebe0de7 More const fixes. Remove CONST_DISCARD. 2011-05-06 01:44:07 +02:00
Jeremy Allison
8380835fc6 Fix warning messages caused by addition of null check in fstrcpy macro. 2011-05-04 12:12:15 -07:00
Jeremy Allison
017e0c8d95 Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1. 2011-05-04 12:12:13 -07:00
Volker Lendecke
deba880986 s3-torture: Add a test for notify upon read&x
This makes sure that when a file is brought online by a read call
we notify the client for FILE_NOTIFY_CHANGE_ATTRIBUTES.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 21:09:22 CEST 2011 on sn-devel-104
2011-05-04 21:09:22 +02:00
Jeremy Allison
de87f549b7 Add POSIX O_RDONLY test of a directory for bug #8112 - POSIX extension opens of a directory are denied with EISDIR.
Don't strip access bits from wire flags when opening a directory.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 02:21:24 CEST 2011 on sn-devel-104
2011-04-30 02:21:24 +02:00
Jeremy Allison
440d71f6c7 torture test for bug #8111 - CIFS VFS: unexpected error on SMB posix open.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 00:33:40 CEST 2011 on sn-devel-104
2011-04-30 00:33:39 +02:00