Günther Deschner
a72a52fca1
werror: replace WERR_UNKNOWN_LEVEL with WERR_INVALID_LEVEL in source3/lib/netapi/
...
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:34 +02:00
Günther Deschner
9bde08f153
werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in source3/lib/netapi/
...
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:22 +02:00
Günther Deschner
2324d9cd32
werror: replace WERR_GENERAL_FAILURE with WERR_GEN_FAILURE in source3/lib/netapi/
...
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:20 +02:00
Günther Deschner
db1c5d721b
werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/lib/netapi/
...
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:18 +02:00
Anoop C S
b0a9a69bcc
libnetapi: Fix 241166 Fixing logically dead code
...
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Mar 26 17:30:27 CET 2015 on sn-devel-104
2015-03-26 17:30:27 +01:00
Gabriel Buades
745a1c54b6
Change expired password flag indicator
...
Signed-off-by: Gabriel Buades <gbuades@soffid.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jim McDonough <jmcd@samba.org>
2014-11-03 23:46:04 +01:00
Jeremy Allison
f799f63e43
CVE-2013-4408:s3:Ensure LookupRids() replies arrays are range checked.
...
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Dec 9 09:00:41 CET 2013 on sn-devel-104
2013-12-09 09:00:41 +01:00
Jeremy Allison
0dc6181894
CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.
...
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
2013-12-09 07:05:46 +01:00
Günther Deschner
77f7f2a976
s3-libnetapi: pass down ndr_interface_table to libnetapi_open_pipe().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-08-05 10:29:59 +02:00
Andreas Schneider
96de3e7364
s3-netapi: Add missing break in NetUserSetInfo_r().
...
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-21 13:56:01 +01:00
Andreas Schneider
d020c51978
s3-netapi: Initialize group_handle of NetUserSetGroups_r.
...
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
2012-12-12 09:42:33 +01:00
Andrew Bartlett
5e26e94092
s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653
s3-talloc Change TALLOC_ARRAY() to talloc_array()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Günther Deschner
508e160776
s3: fix some -Wunused-but-set-variable build warnings.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon May 30 17:41:18 CEST 2011 on sn-devel-104
2011-05-30 17:41:18 +02:00
Jeremy Allison
e131c94ac1
More const fixes for compiler warnings from the waf build.
2011-05-05 23:56:07 +02:00
Stefan Metzmacher
f7bc84409a
s3:rpc_client: map fault codes to NTSTATUS with dcerpc_fault_to_nt_status()
...
Most fault codes have a NTSTATUS representation, so use that.
This brings the fault handling in common with the source4/librpc/rpc code,
which make it possible to share more highlevel code, between source3 and
source4 as the error checking can be the same now.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Apr 24 10:44:53 CEST 2011 on sn-devel-104
2011-04-24 10:44:53 +02:00
Günther Deschner
5779460f3f
s3-netapi: fix memoryleak while not using talloc_tos() in cli_get_session_key() usage.
...
Thanks Volker!
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 25 18:21:18 CET 2011 on sn-devel-104
2011-03-25 18:21:18 +01:00
Günther Deschner
63bb64d531
s3-netapi: use cli_get_session_key() in netapi.
...
Guenther
2011-03-24 23:08:22 +01:00
Günther Deschner
93db9489fd
s3-libds: use already existing ../libds/common/flag_mapping.h header.
...
Guenther
2011-03-02 22:17:17 +01:00
Günther Deschner
f9af242886
s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/user.c.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 1 13:41:42 CET 2011 on sn-devel-104
2011-02-01 13:41:42 +01:00
Stefan Metzmacher
f1d15ea54c
s3:lib/netapi: don't set SAMR_FIELD_FULL_NAME if we just want to set the account name (bug #7896 )
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Dec 30 18:09:13 CET 2010 on sn-devel-104
2010-12-30 18:09:13 +01:00
Andrew Bartlett
f768b32e37
libcli/security Provide a common, top level libcli/security/security.h
...
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.
This includes (along with other security headers) dom_sid.h and
security_token.h
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-12 05:54:10 +00:00
Volker Lendecke
13756d0e80
s3: Attempt to fix bug 7665
...
Quite a few of our internal routines put stuff on talloc_tos() these days.
In top-level netapi routines, properly allocate a stackframe and clean it
again. Also, don't leak memory in the rpccli_ callers onto the libnetapi
context.
2010-10-02 12:02:02 +02:00
Günther Deschner
102a70e809
s3-util: use shared dom_sid_dup.
...
Guenther
2010-09-20 14:05:07 -07:00
Günther Deschner
e978a3d3f4
s3-lsa: separate out init_lsa headers.
...
Guenther
2010-08-25 22:50:39 +02:00
Matthias Dieter Wallnöfer
915ddf0dc7
samr.idl:UserInfo structures - fix some names according to MS-SAMR documentation
...
See MS-SAMR section "FULL IDL"
2010-07-05 15:35:54 +02:00
Günther Deschner
dff7be8ccb
s3-libads: only include libds flags where needed.
...
Guenther
2010-07-01 23:20:40 +02:00
Günther Deschner
b6a2cea74d
s3-security: use shared "Standard access rights.".
...
Guenther
2010-06-03 11:00:26 +02:00
Andrew Bartlett
cba7f8b827
s3:dom_sid Global replace of DOM_SID with struct dom_sid
...
This matches the structure that new code is being written to,
and removes one more of the old-style named structures, and
the need to know that is is just an alias for struct dom_sid.
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-21 10:39:59 +02:00
Günther Deschner
8478770c35
s3-rpc_client: move protos to init_samr.h
...
Guenther
2010-05-18 21:42:57 +02:00
Günther Deschner
3d679a3b5f
s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
...
Guenther
2009-11-26 20:03:17 +01:00
Volker Lendecke
6a650d7d16
Revert "s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table"
...
This reverts commit 5fc9d93408
.
2009-11-08 19:43:46 +01:00
Volker Lendecke
5fc9d93408
s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table
2009-11-08 13:12:16 +01:00
Günther Deschner
a0d8698f65
s3-netapi: Fix Coverity #668 : FORWARD_NULL.
...
Guenther
2009-09-16 10:30:08 +02:00
Günther Deschner
de43e39487
s3-netapi: Fix Coverity #669 FORWARD_NULL.
...
Guenthe
2009-09-16 10:30:01 +02:00
Günther Deschner
828b9a48fd
s3-netapi: Fix Coverity #670 : FORWARD_NULL.
...
Guenther
2009-09-16 10:29:54 +02:00
Günther Deschner
05fbe0c7f7
libds: merge the UF<->ACB flag mapping functions.
...
Guenther
2009-07-13 15:36:07 +02:00
Volker Lendecke
382a937800
Fix some dead code warnings from SUN Studio
2009-06-26 17:45:16 +02:00
Günther Deschner
29b8e08b83
s3-netapi: Fix Bug #6451 : net/libnetapi user rename using wrong access bits.
...
Guenther
2009-06-16 15:00:20 +02:00
Jeremy Allison
d9804ae3cc
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
...
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
2009-04-15 15:40:00 -07:00
Günther Deschner
24d5229a81
s3-net: Fix Bug #6102 . NetQueryDisplayInformation could return wrong information.
...
Guenther
2009-03-26 10:29:57 +01:00
Günther Deschner
3a6133d702
s3-netapi: Fix Coverity #774 (REVERSE_INULL).
...
Guenther
2009-03-20 11:21:36 +01:00
Günther Deschner
f2243e8197
s3-netapi: Fix Coverity #775 (REVERSE_INULL).
...
Guenther
2009-03-20 11:19:59 +01:00
Günther Deschner
531af136f9
s3: remove POLICY_HND.
...
Guenther
2009-03-18 23:22:29 +01:00
Volker Lendecke
a9542ddcb7
libnetapi_open_pipe does not need to return cli_state
...
The user session key is also available in rpccli->auth->user_session_key
Guenther, please check!
Thanks,
Volker
2009-01-18 20:10:06 +01:00
Günther Deschner
46f55ef5bc
s3-samr: avoid all init_samr_user* functions.
...
Guenther
2009-01-06 16:02:10 +01:00
Günther Deschner
7423b6a4b8
s3-samr: fix SAMR_FIELD_PASSWORD callers.
...
Guenther
2008-12-05 14:27:03 +01:00
Günther Deschner
698b7fd436
netapi: fix access bits in netapi.
...
Guenther
2008-10-28 00:13:50 +01:00
Günther Deschner
b7c38abe27
netapi: fix add_GROUP_USERS_INFO_X_buffer.
...
Guenther
2008-10-23 11:46:18 +02:00
Günther Deschner
fafa608441
netapi: fix NetUserGetGroups_r returning partial results.
...
Guenther
2008-10-23 11:46:18 +02:00