Günther Deschner
fc5a7fe064
r14061: Some debugging for the new LOGON/ACB-flags.
...
Guenther
(This used to be commit 7616317f9f45dfbc453a7687e8b8b6ff57ddb0a3)
2007-10-10 11:11:09 -05:00
Günther Deschner
1b0211ca13
r14060: Only set the last rebind timestamp when we did rebind after a non-read
...
LDAP operation. That way we avoid the replication sleep after a simple
redirected search operation
Guenther
(This used to be commit d236caac211ff45a3e2da73a3b0316194740a722)
2007-10-10 11:11:09 -05:00
Lars Müller
16ea81ba7f
r14057: Remove generated script/gen-8bit-gap.sh while calling rule realclean.
...
Ignore script/gen-8bit-gap.sh in branches/SAMBA_3_0/source/script as we
already do in trunk.
(This used to be commit b974b1879c1bded616becb77fa34f071a5f43ecc)
2007-10-10 11:11:09 -05:00
Lars Müller
24decd1233
r14056: Also install the mount.smbfs sym link to rootsbindir. Therfore we have
...
to substitute rootsbindir in {,un}installbin.sh.in.
Pass $prefix as third arg to installbin/ uninstallbin as rootsbindir by
default is $prefix/sbin.
(This used to be commit 7773b8c9e0ad7bcff1312f28ca9cd17d7677e9bd)
2007-10-10 11:11:09 -05:00
Jim McDonough
924be04217
r14053: Implement Simo's suggestion: don't use /dev/null for a 'bad' path for
...
users/workstations
(This used to be commit 2690f015be1f7eb9802f652810e73ff5f5688304)
2007-10-10 11:11:08 -05:00
Lars Müller
f27228fc31
r14052: Remove BASEDIR use in the Makefile. BASEDIR=prefix=@prefix@ till now.
...
I suggest to stay with ^BASEDIR= @prefix@$ for at least the next release
to give external projects - like samba-vscan project - time to adopt
this change.
BASEDIR is non of the default autoconf variables. prefix is.
Jerry1: If possible please announce this with the next release. I'll
self reply to technical.
Jerry2: This does not break your makepkg stuff as you set BASEDIR
_not_ from the Makefile.
(This used to be commit 730d5ec22948c579a81137051134657043c34415)
2007-10-10 11:11:08 -05:00
Günther Deschner
763a2d7d8e
r14051: Add remaining (documented) userAccountControl bits, thanks to Luke
...
Howard for pointing this out.
Guenther
(This used to be commit 170038f4cdfa51ea31b2255a020740d28dfbfba2)
2007-10-10 11:11:08 -05:00
Günther Deschner
ca3df1d3f9
r14050: Add the ACB_PWEXPIRED bit abartlet has found.
...
Guenther
(This used to be commit 5fa3f26b4c39d612243319fc0729078c50439d6b)
2007-10-10 11:11:08 -05:00
Günther Deschner
06d6325da1
r14049: Found some more MSV1_0 bits and their behaviour;
...
just for documentation purpose.
Guenther
(This used to be commit 0b00424e07f3f9c815664c619e2d7a670a838b93)
2007-10-10 11:11:08 -05:00
Jeremy Allison
b05af76541
r14047: Coverity fix #17 . Ensure srv_name and info cannot
...
be zero before deref.
Jeremy.
(This used to be commit fbf9db6624d9584a26ae302df3c76555bbd2bb1e)
2007-10-10 11:11:08 -05:00
Jeremy Allison
d8ba987bfe
r14045: Coverity fix #14 . Ensure if len is set buf != NULL.
...
Jeremy.
(This used to be commit fb1a6073321840fecf22f3e0f7541f5ad87f5e49)
2007-10-10 11:11:07 -05:00
Jeremy Allison
8d1dd8bb96
r14043: After discussion with Jerry revert part of the
...
Coverity null-ref patch - put prs_rpcbuffer_p
back to the way it was (with an additional
coverity paranoia check) - move the real test
into rpcbuf_alloc_size instead.
Jeremy.
(This used to be commit f74993e65c01bc0ef73d3e8710bb2f840910161a)
2007-10-10 11:11:07 -05:00
Gerald Carter
29c8cef22d
r14042: check that create_local_nt_token() succeeds before dereferncing the NT_USER_TOKEN*
...
(This used to be commit 4e5df4cb643886144d0fff4cac303e493c825955)
2007-10-10 11:11:07 -05:00
Volker Lendecke
753dcde401
r14036: Ok, the last one generated a const warning. Also fix Coverity # 119.
...
net rpc vampire is ugly....
Volker
(This used to be commit c1ea48949d2692c839f6ced68165cabd76b580ea)
2007-10-10 11:11:07 -05:00
Volker Lendecke
3cc8b8125a
r14035: Fix Coverity bug # 124
...
(This used to be commit 9fe21fd0326e67a4b1006d2b4a24e39e2d57d796)
2007-10-10 11:11:07 -05:00
Volker Lendecke
991fd6c28e
r14034: Fix Coverity id # 125.
...
Jeremy, you might want to take a look here.
Volker
(This used to be commit e6e29937e8ccfc84afca0ee440bd3f10a7d10e8a)
2007-10-10 11:11:07 -05:00
Volker Lendecke
4479d1b061
r14033: Fix Coverity bug # 126
...
(This used to be commit bb6d678575faac050376607a5c778b8a10805061)
2007-10-10 11:11:06 -05:00
Jeremy Allison
77709e58ad
r14031: Coverity bug CID #110 . Free all resources correctly
...
on pipe initialization failure.
Jeremy.
(This used to be commit daa919a94b3d81401654004bc0f32c45451203c1)
2007-10-10 11:11:06 -05:00
Jeremy Allison
8f0bdb9c4e
r14030: Fix resource leak in error codepath. Coverity CID #64 .
...
Jeremy.
(This used to be commit b51edde4d63e9b2f241f41b6780b026487890a7f)
2007-10-10 11:11:06 -05:00
Jeremy Allison
6b591819dd
r14026: Fix resource leak on error exit. Coverity CID #65 .
...
Jeremy.
(This used to be commit 3a1c4cb93dc262028ffbebd9ebeed69f4816cf09)
2007-10-10 11:11:06 -05:00
Volker Lendecke
874a9d02de
r14025: Remove unused code. When we want to export samsync, we better first port
...
pidl...
Fix Coverity # 15.
Volker
(This used to be commit 29b4b986cc225a98d263c883fd52e8b210099b9e)
2007-10-10 11:11:06 -05:00
Jeremy Allison
82ab2bce5a
r14023: My last bug fix still left a potential null deref.
...
C- "must try harder" :-).
Jeremy.
(This used to be commit 9c55bf74ca28530045c5cb3cbfffad242039ca75)
2007-10-10 11:11:06 -05:00
Volker Lendecke
6491aed1ac
r14022: Fix Coverity bug # 92
...
(This used to be commit b824245c4e04353f0d3fd0ccf6bc5776a601daed)
2007-10-10 11:11:06 -05:00
Jeremy Allison
43ad653211
r14020: Coverity bug CID #66 . Missing free on error exit.
...
Jeremy.
(This used to be commit b9980bddf5ee74b2887196d6d1a0cf393720ba3a)
2007-10-10 11:11:05 -05:00
Jeremy Allison
f635dcb5f3
r14018: Coverity error CID #27 . Missing return -1 on error condition.
...
Jeremy.
(This used to be commit 94e869d9c6d1a1c1df0d072530bf8d4452bd10bb)
2007-10-10 11:11:05 -05:00
Volker Lendecke
c7c3b98d4b
r14017: Okay, okay, I have turned a double-free into dead code :-)
...
Fix Coverity # 214.
Volker
(This used to be commit 4a75edf9deca2be18670d7f9f2e383ed0898512c)
2007-10-10 11:11:05 -05:00
Jeremy Allison
a3586ff60c
r14014: Coverity paranoia. Shut it up by making the guarentee
...
in the code explicit - but this was a false positive (CID #16 ).
Jeremy.
(This used to be commit 43a0e869f2aee9b4e22d0d7fc92051e82f7536ad)
2007-10-10 11:11:05 -05:00
Jeremy Allison
9e65a2cb98
r14009: Remove last const warning (have to use CONST_DISCARD).
...
Jeremy.
(This used to be commit af0ade470f2fac3509a44207b4572e279ba30e34)
2007-10-10 11:11:05 -05:00
Jeremy Allison
6b35642037
r14007: Coverity bug CID #197 . Don't compare against 0, we
...
mean the ttl instead.
Jeremy.
(This used to be commit ccb2a52e29de7e2847ccd93aa99236f63202a4af)
2007-10-10 11:11:04 -05:00
Jeremy Allison
26c95f3545
r14006: Fix a couple of irritating warnings.
...
Jeremy.
(This used to be commit ead13ca522d7b8cbb47d660d3cb73c3582088985)
2007-10-10 11:11:04 -05:00
Jeremy Allison
3527b5cc25
r14003: Clarify code that lead to Coverity report #13 .
...
Not a bug, but better to remove false positives.
Jeremy.
(This used to be commit f9a75d76546bc4618736f0d48646e77d7572db25)
2007-10-10 11:11:04 -05:00
Jeremy Allison
dbbc06db65
r14002: Quick fix for Coverity CID #12 .
...
Jeremy
(This used to be commit 7c6e274cd578521192a0b0c4e6a4fb5dc7d722ac)
2007-10-10 11:11:04 -05:00
Jeremy Allison
1eea156f57
r13999: Quick fix for Coverity bug #11 .
...
Jeremy.
(This used to be commit b9de6c926953b3321fa3850d501c807c6eabf230)
2007-10-10 11:11:04 -05:00
Lars Müller
ef5b36ca8d
r13997: Prefix $prefix by default even to rootsbindir as we else run in trouble
...
if we use ./configure --prefix=dir && make install
Vendors might use ./configure --with-rootsbindir=/sbin && make
DESTDIR=/var/tmp/samba/ install if they use a buildroot.
Thanks to Björn Jacke for pointing me at the stderr output of the build
farm.
(This used to be commit 75c95d149a22eba4a5afedcec7ba5e2a28cccf01)
2007-10-10 11:11:04 -05:00
Jeremy Allison
f7bf439030
r13994: Belt and braces - ensure RPC_BUFFER is valid.
...
Jeremy.
(This used to be commit d993797191865878ebfd2ff9028d341017605cd6)
2007-10-10 11:11:03 -05:00
Volker Lendecke
eae063e965
r13991: Fix Coverity bug # 69
...
(This used to be commit 6dc79e6b12e221e9af85a1edf487b5fb5aae222b)
2007-10-10 11:11:03 -05:00
Jeremy Allison
cd49e2546e
r13989: Fix for Coverity bug #45 and associated spoolss RPC_BUFFER
...
problems. Ensure that if the parse succeeds on UNMARSHALL
we have a valid (although possibly empty) RPC_BUFFER returned.
Jeremy.
(This used to be commit d319cc9c08bfa865a6431a8631a9c609f589be1f)
2007-10-10 11:11:03 -05:00
Volker Lendecke
03b32953cf
r13987: Fix Coverity bug # 74. This tool is good...
...
Thanks,
Volker
(This used to be commit 86f62484dd7db43e036d9edf29e459b8bd0e5fbe)
2007-10-10 11:11:03 -05:00
Volker Lendecke
a78d2a85fb
r13984: Fix Coverity bug # 98
...
(This used to be commit 0a2aa3a48bd5fd7e5a9aa06068ddd621b19c1dbe)
2007-10-10 11:11:03 -05:00
Volker Lendecke
dece1a2db2
r13983: Fix Coverity bug # 111
...
(This used to be commit 08d7fd31ab250bc6ba3922b36aa7b0cfef1e5bf1)
2007-10-10 11:11:03 -05:00
Volker Lendecke
5f76ee419e
r13981: Fix Coverity bug # 138
...
(This used to be commit 303067ba3bdf34ab501f0d99e386cfdb6ab10233)
2007-10-10 11:11:03 -05:00
Volker Lendecke
33c9fbab12
r13980: Fix Coverity bug # 63. Jeremy, could you take a look at this?
...
Thanks,
Volker
(This used to be commit 49043a756dfa6a973d5605f42068df351a4a9ab5)
2007-10-10 11:11:02 -05:00
Volker Lendecke
4357ef3bd6
r13979: We've dereferenced my_methods already, so there's no point in checking for
...
!= NULL. Coverity #149 .
Volker
(This used to be commit d38e05329a77650d8fbb8611ca148964f62c9ba4)
2007-10-10 11:11:02 -05:00
Jeremy Allison
2615b079f0
r13978: Here is why it's essential to use SAFE_FREE instead of free.
...
If we use free(data.dptr) and then the subsequent tdb_open
fails in _reg_perfcount_get_counter_data() then data.dptr
is left as a non-zero pointer that has been freed. This would
cause it to be reused later on. Coverity bug #162 .
Jeremy.
(This used to be commit 053efc20981e0280c6af0ebb9e17cea07da85fe8)
2007-10-10 11:11:02 -05:00
Jeremy Allison
71272fc441
r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistent
...
between Realloc and realloc_array.
Jeremy.
(This used to be commit 841c9b1847ae12656b827e3d35b8bf0c3f68b8b4)
2007-10-10 11:11:02 -05:00
Jeremy Allison
a31c931804
r13971: Fix Coverity bugs #209 - #213 - it detected mistakes
...
in the pointer aliasing once realloc could change
a pointer. This was in the bugzilla.samba.org database
as #687 but we never figured out what it was !
Jeremy.
(This used to be commit 8d183441403524fe39e79af843d6cfe65898f7d3)
2007-10-10 11:11:02 -05:00
Jim McDonough
247bacf19b
r13968: fix typo, caught by Guenther
...
(This used to be commit 217d3fbe7923115ae610a39e586ceb93df7683f5)
2007-10-10 11:11:02 -05:00
Günther Deschner
3432273ab0
r13965: Make sure we always reset the userAccountControl bits when re-joining
...
with an existing account.
Guenther
(This used to be commit e4c12ab167ee83772a2bdd1946b8d73613fc0d7e)
2007-10-10 11:11:01 -05:00
Volker Lendecke
bd8e1b442d
r13958: Fix Coverity Bug # 141
...
(This used to be commit 598513d1d3e23cc71ea0fd53230d393b6724b534)
2007-10-10 11:11:01 -05:00
Jim McDonough
9bc20e14db
r13957: Based on patch from Richard Renard <richard.renard@idealx.com>:
...
Fix machine accounts (should not have valid shells) and users with no
home directory (were getting previous user's directory).
(This used to be commit f629f8a7b972f09fe959c68843b9cd5a03abfc76)
2007-10-10 11:11:01 -05:00