Jeremy Allison
496d147dc4
Revert "Ensure every return path initializes presult as NULL."
...
Vl is correct, this is the wrong way to fix this.
This reverts commit 83c2c177a5
.
2009-11-12 13:57:13 -08:00
Jeremy Allison
5363d6e62c
Ensure all callers to the rpc_client/cli_pipe functions correctly
...
initialize return variables.
Jeremy.
2009-11-12 13:56:33 -08:00
Jeremy Allison
6747a91ca0
Fix bug 6891 - using windows explorer to change ownership on a folder fails with Bad File Descriptor.
...
Jeremy.
2009-11-12 13:08:04 -08:00
Jeremy Allison
83c2c177a5
Ensure every return path initializes presult as NULL.
...
Ensures no crashes in calling code that forgets to
init return as null.
Jeremy.
2009-11-12 11:49:54 -08:00
Stefan Metzmacher
21644c5fed
s4:heimdal_build: allow flex-2.5.35 with bison-2.3
...
metze
2009-11-12 18:51:21 +01:00
Günther Deschner
61f0b24763
s3-kerberos: remove smb_krb5_get_tkt_from_creds().
...
Now that cli_krb5_get_ticket() already handles S4U2SELF impersonation, remove
smb_krb5_get_tkt_from_creds() which is not required anymore.
Guenther
2009-11-12 15:50:38 +01:00
Günther Deschner
0f8bf47d94
s3-kerberos: avoid using ERROR_TABLE_BASE_krb5 without checking.
...
Guenther
2009-11-12 15:50:37 +01:00
Andrew Bartlett
0d6c3058b2
s4:dsdb Make callbacks in extended_dn_out clearer to follow
2009-11-12 22:23:23 +11:00
Andrew Bartlett
5740648279
s4:selftest Mark the RPC-DSSYNC test as knownfail for now
...
We need to work on the provision or LDB modules to avoid DN attributes
without GUIDs (caused because the target does not exist at creation
time).
Andrew Bartlett
2009-11-12 22:23:22 +11:00
Andrew Bartlett
68639bfd64
s4:libcli/ldap Add 'relax' OID to known network representations
...
This patch, inspired by a patche by Endi S. Dewata
<edewata@redhat.com>, allows this control to be passed to the LDAP
backend.
Andrew Bartlett
2009-11-12 22:23:22 +11:00
Endi S. Dewata
f3bc54a8f1
s4:provision - Added LDBBackend and ExistingBackend.
2009-11-12 22:23:22 +11:00
Endi S. Dewata
55bb60a5db
s4:provision - Added constructors for FDSBackend and OpenLDAPBackend.
2009-11-12 22:23:22 +11:00
Endi S. Dewata
1564067fbc
s4:provision - Added setup() method in LDAPBackend.
2009-11-12 22:23:21 +11:00
Endi S. Dewata
ba12eb99a0
s4:provision - Moved provision_xxx_backend() into backend-specific provision() method.
2009-11-12 22:23:21 +11:00
Endi S. Dewata
be766a3841
s4:provision - Added start() method in LDAPBackend.
2009-11-12 22:23:21 +11:00
Endi S. Dewata
fbc5696e38
s4:provision - Added initial implementation of FDSBackend and OpenLDAPBackend.
2009-11-12 22:23:21 +11:00
Volker Lendecke
8006e0e634
s3: Fix debug messages in check_reduced_name
2009-11-12 11:20:22 +01:00
Günther Deschner
b29eed492f
cifs.upcall: Fix Bug #6868 : support building with Heimdal we well as with MIT.
...
Guenther
2009-11-12 10:22:39 +01:00
Günther Deschner
b4e40958b7
s3-kerberos: add smb_krb5_principal_get_realm().
...
Guenther
2009-11-12 10:22:39 +01:00
Andrew Bartlett
bbe4a9cf0f
s4:repl_meta_data Parse linked attributes with schema syntaxes
...
The bug here was that by assuming all linked attributes were 'normal
DNs', we would miss the binary portion of DN+Binary.
This patch then has us reparse the string to determine it's GUID, for
the GUID lookup, but maintains the binary porition into the on-disk
format.
Andrew Bartlett
2009-11-12 16:34:44 +11:00
Andrew Bartlett
a9f6a56227
s4:dsdb/schema Add more unit tests for DN+Binary syntaxes
2009-11-12 16:34:43 +11:00
Andrew Bartlett
95a12cdf21
s4:torture Use (some) torture_assert() calls in RPC-DSSYNC test
2009-11-12 16:34:23 +11:00
Andrew Bartlett
693ddf5ba0
s4:dsdb Improve debug message in extended_dn_out
2009-11-12 16:34:18 +11:00
Andrew Bartlett
06b234e811
s4:torture Remove _drs_util_verify_attids() from RPC-DSSYNC
...
I'm satisfied that the task this test does is already done by the time
we map the incoming schema, and process the objects. If we have the
OID mapping wrong or incomplete, we will get any errors this test
found errors there.
(And this dramaticly reduces the test time, so we can now add
RPC-DSSYNC to 'make test').
Andrew Bartlett
2009-11-12 16:34:18 +11:00
Andrew Bartlett
6d1e60987b
s4:torture/dsdb Add verification of the push-to-LDB functions in RPC-DSSYNC
...
This is done by comparing the values against the remote host's LDAP
server.
Andrew Bartlett
2009-11-12 16:34:17 +11:00
Andrew Bartlett
30a08005ca
s4:torture Add const
2009-11-12 16:34:16 +11:00
Andrew Bartlett
ae72153daa
s4:ldb Allow ldb_msg_canonicalize to handle empty elements
...
(These are deliberately there in DRS replication).
Andrew Bartlett
2009-11-12 16:34:15 +11:00
Andrew Bartlett
081d57345f
s4:dsdb/schema Allow a schema set when bound against a remote LDAP server
2009-11-12 16:34:15 +11:00
Andrew Bartlett
5940ca60e2
s4:ldb Don't segfault if we somehow get an unknown extended dn element
2009-11-12 16:34:14 +11:00
Andrew Bartlett
716bba5457
s4:ldb Change ldb_request_add_control to the normal 'for loop' pattern
2009-11-12 16:34:14 +11:00
Andrew Bartlett
87e984f0bd
s4:torture Convert RPC-DSSYNC test to use LDB rather than raw LDAP
...
(This should make it easier to do more 'compare DRS with LDAP'
operations, as LDB is an easier interface to program.)
Andrew Bartlett
2009-11-12 16:34:13 +11:00
Stefan Metzmacher
1012b806a7
NET-API-BECOME-DC: resolve the host name to an address before calling
...
libnet_BecomeDC and libnet_UnbecomeDC()
We're supposed to pass in source_dsa_address...
metze
2009-11-12 16:34:12 +11:00
Andrew Bartlett
2a601719f2
s4:dsdb Add expected value tests for most DRS syntax conversions
...
I've left out those for which I could not find an expected value in my
default Windows 2003 server's database, and the values that rely on
the current prefix map at the time.
Andrew Bartlett
2009-11-12 16:34:12 +11:00
Andrew Bartlett
9ba1870fb9
s4:Fix regression in dsdb_dn code - all parses of the DN would be rejected
...
This is most likely the cause of the DRS replication failures I
observed with my changes.
Andrew Bartlett
2009-11-12 16:34:11 +11:00
Andrew Bartlett
6b0b3fed31
s4:provision Add C binding to get at the generate schema
...
This will allow us to do local tests against that schema
2009-11-12 16:34:11 +11:00
Andrew Bartlett
6437c38aeb
s4:provision Remove unused 'sambadn' parameter
2009-11-12 16:34:10 +11:00
Andrew Bartlett
df7546ac16
s4:dsdb/repl Split the 'convert' or 'commit' stages in the DRS import
...
This will allow us in future to do tests on the LDB values we generate
from the DRS replication.
Andrew Bartlett
2009-11-12 16:34:10 +11:00
Andrew Bartlett
d6563801d1
s4:dsdb/schema Simplify schema loading from ldb messages
...
It turns out that we always add the class/attribute to the schema.
2009-11-12 16:34:09 +11:00
Andrew Bartlett
d053584443
s4:vampire Print error message when we fail on the CLDAP ping
...
Andrew Bartlett
2009-11-12 16:34:08 +11:00
Andrew Bartlett
6fd6dc1089
s4:dsdb Cosmetic fixes found by metze in review of dsdb_dn changes
...
These changes include reworking the code to call ldb_module_get_ctx()
less often (avoid the function calls, particularly during the step
into a complex function).
Andrew Bartlett
2009-11-12 16:34:07 +11:00
Andrew Bartlett
4e2b4be9d3
s4:dsdb Ensure we allow 'odd' lengths for DN+String
...
(Found in a code review by metze)
Andrew Bartlett
2009-11-12 16:34:07 +11:00
Andrew Bartlett
d6d0c23d49
s4:ldb Add Well Known GUID (WKGUID) tests to ldap.py
2009-11-12 16:34:06 +11:00
Andrew Bartlett
da1ac55bc1
s4:dsdb Add extensive tests for the behaviour of dsdb_dn
2009-11-12 16:34:06 +11:00
Andrew Bartlett
f5890ddd83
s4:ldb Remove DN+Binary code from the core ldb_dn
...
This is now in dsdb_dn. Removing this to a specific wrapper avoids a
number of bugs where Binary DNs were being handled incorrectly.
This reverts much of tridge's commit
fd22e03047
Andrew Bartlett
2009-11-12 16:34:05 +11:00
Andrew Bartlett
f0d43e9e56
s4:dsdb Use new dsdb_dn code in LDB modules and Samba4 schema
...
This converts the code from using the binary DN code in ldb_dn to
using a special Samba-specfic wrapper around ldb_dn.
We also use the dsdb_dn code for DN+Binary and DN+String comparisons
(changed from treating them as Binary blobs)
Andrew Bartlett
2009-11-12 16:34:04 +11:00
Andrew Bartlett
973197cd9d
s4:ldb-samba Use new ldb_any_comparison helper function in ldb-samba
2009-11-12 16:34:04 +11:00
Andrew Bartlett
390ac7d306
s4:dsdb Add new dsdb_dn to handle DN+Binary and DN+String
...
This aims to replace (and is based on) the code in ldb_dn.c. It is
however much stricter in the DNs it will accept.
Andrew Bartlett
2009-11-12 16:34:03 +11:00
Andrew Bartlett
3abc3e7a3a
s4:ldb Add a helper function for 'canonicalise' both strings base compares
...
This will help simplify boilerplate comparison functions where we
don't have a shortcut way to compare.
Andrew Bartlett
2009-11-12 16:34:02 +11:00
Andrew Bartlett
fd5174e88c
lib/util Split data_blob_hex_string() into upper and lower
...
Rather than have a repeat of the bugs we found at the plugfest where
hexidecimal strings must be in upper or lower case in particular
places, ensure that each caller chooses which case they want.
This reverts most of the callers back to upper case, as things were
before tridge's patch. The critical call in the extended DN code is
of course handled in lower case.
Andrew Bartlett
2009-11-12 16:34:01 +11:00
Jeremy Allison
a8769e6675
Second part of bugfix for 6865 - acl_xattr module: Has dependency that inherit acls = yes or xattrs are removed.
...
We also need dos filemode = true set as well.
Jeremy.
2009-11-11 18:35:18 -08:00