1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-19 10:03:58 +03:00

31182 Commits

Author SHA1 Message Date
Lars Müller
f9f1db1883 s3: normalize "Changing password for" msg IDs and STRs
An additional space at the end of the "Changing password for" msgid lead
to untranslated pam_winnind messages.
2010-02-05 17:38:04 +01:00
Jeremy Allison
d899032636 Fix bug 7075 - bug in vfs_scannedonly rmdir implementation.
Check for NULL on opendir, correctly call next rmdir.

Jeremy.
2010-02-04 16:23:32 -08:00
Stefan Metzmacher
0c93aa3cd5 s3:passdb: fix a type Domain Users has RID -513
metze
2010-02-04 15:19:50 +01:00
Stefan Metzmacher
c2e4746fa9 s3:libsmb: don't reuse the callers stype variable in cli_NetServerEnum()
When we need to do more than one network operation to get the
browse list we need to use the same 'stype' value each time.

metze
2010-02-04 14:27:12 +01:00
Björn Jacke
55d65ba721 s3:nsswitch: also use pthread CFLAGS for the nsswitch modules that might require it 2010-02-04 11:03:55 +01:00
Björn Jacke
acedd1c832 s3: fix build on Tru64 after it broke with deactivating pthread pool support 2010-02-04 10:37:17 +01:00
Björn Jacke
ae95e8028c s3:vfs_scannedonly: fix build on HP-UX 2010-02-04 10:37:17 +01:00
Volker Lendecke
e00e6a2c96 s3: Simplify the code a bit: Catch (len==0) early 2010-02-03 12:34:25 -08:00
Jeremy Allison
de24209f0a Fix bug 7081 - vfs_expand_msdfs doesn't work correctly (with fix identified)
Fix inspired by idea from Eric Horst <erich@cac.washington.edu>.

Jeremy.
2010-02-02 16:43:41 -08:00
Jeremy Allison
110a6f29f0 Fix bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core dumps.
Reported and found by Martin Hochreiter <linuxbox@wavenet.at>.
Ensure we copy the right amount of registry data into the outgoing
buffer.

Jeremy.
2010-02-02 16:32:51 -08:00
Björn Jacke
27920f4f90 s3:configure: check complete set of EA functions only when we found at least one
this saves us some time in configure
2010-02-02 18:35:59 +01:00
Matt Kraai
a47b6ebb30 Change uint_t to unsigned int in source3
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2010-02-02 07:18:18 +01:00
Jeremy Allison
86bf5eac67 Add debug to make it clear when EA dosmode set is invoked.
Jeremy.
2010-02-01 19:21:35 -08:00
Jeremy Allison
f3ee1516e6 Fix bug #7084 - Create time on directories not stored properly in an EA in new create time code.
Remove erroneous optimisation that caused no EA to be set
if calculated btime matched st_ex btime, and calculated DOS
attribute matched existing file attribute.

Jeremy.
2010-02-01 18:50:43 -08:00
Jeremy Allison
a35be8c0c2 Torture test for bug 7084 - Create time on directories not stored properly in an EA in new create time code.
Ensure new files in a directory don't reset the create time.

Jeremy.
2010-02-01 18:49:50 -08:00
Jeremy Allison
4e08d0d0d6 Arg. Got the sense of the test reversed to fix bug #7080 - Quota only shown when logged as root.. Doh !
Jeremy.
2010-02-01 15:57:16 -08:00
Jeremy Allison
b3009819c5 Fix bug #7080 - Quota only shown when logged as root.
conn->server_info->utok.uid == 0

isn't the correct check to see if we're root anymore. As rpc_samr_nt.c does,
the correct check is :

geteuid() == sec_initial_uid()

Jeremy.
2010-02-01 15:55:55 -08:00
Volker Lendecke
0beac794b6 s3: Fix some DEBUG messages 2010-01-31 15:40:59 +01:00
Jeremy Allison
687e4eba3c Fix bug #7079 - cliconnect gets realm wrong with trusted domains.
Passing NULL as dest_realm for cli_session_setup_spnego() was
always using our own realm (as for a NetBIOS name). Change this
to look for the mapped realm using krb5_get_host_realm() if
the destination machine name is a DNS name (contains a '.').
Could get fancier with DNS name detection (length, etc.) but
this will do for now.

Jeremy.
2010-01-30 19:24:28 -08:00
Steven Danneman
f42971c520 s3/smbd: Fix string buffer overflow causing heap corruption
The destname malloc size was not taking into account the 1 extra byte
needed if a string without a leading '/' was passed in and that slash
was added.

This would cause the '\0' byte to be written past the end of the
malloced destname string and corrupt whatever heap memory was there.

This problem would be hit if a share name was given in smb.conf without
a leading '/' and if it was the exact size of the allocated STRDUP memory
which in some implementations of malloc is a power of 2.
2010-01-30 13:38:31 -08:00
Jeremy Allison
1876b5a7e3 Fix a really interesting problem found by Volker's conversion of sessionsetup SPNEGO to asynchronous code.
Normally clistr_push_fn() can depend upon cli->outbuf being
initialized by negprot and sessionsetup packets, and cli->outbuf[smb_flgs2] being
correctly set with FLAGS2_UNICODE_STRINGS when cli_setup_packet() is called. When
all the sessionsetups are async, then cli_setup_packet() is never called, the async
code uses cli_setup_packet_buf() - which initializes the allocated async buffer,
not the cli->outbuf one. So the first time clistr_push_fn() is called is from
libsmb/clidfs.c:cli_dfs_get_referral(), just after the connection and tconX.
In this case cli->outbuf has never been initialized, and cli->outbuf[smb_flgs2] = 0
so the DFS query pushes ASCII on the wire, which is not what we want :-).

Remove the dependency on cli->outbuf[smb_flgs2] in clistr_push_fn(), and
fake up a SVAL(cli->outbuf, smb_flg2) value using cli_ucs2(cli) function
instead, which has been initialized. We only care about the FLAGS2_UNICODE_STRINGS
bit anyway.

I don't think this is an issue for 3.5.0 as the sessionsetup is still
synchronous there, but Volker PLEASE CHECK !

Jeremy.
2010-01-29 16:41:53 -08:00
Björn Jacke
a20b43f23f s3: link thread objects in libsmbclient only and adjust linker flags 2010-01-29 15:26:36 +01:00
olivier
e95e3270d1 AIX doesn't have MSG_DONTWAIT 2010-01-29 15:26:36 +01:00
Björn Jacke
118725c892 s3: by default don't use pthread pool support 2010-01-29 12:43:13 +01:00
Jeremy Allison
f387ed88e8 Fix bug #7069 - smbget does not return an error status after some errors
A combination patch from Johannes Poehlmann <johannes@lst.de> and
Jeremy. Fix the return codes from smb_download_file() and smb_download_dir().

Jeremy.
2010-01-28 10:38:24 -08:00
Karolin Seeger
1396345638 s3/winbind_ccache: Fix typo in debug message.
Karolin
2010-01-28 15:10:54 +01:00
Jeremy Allison
69fd8461b8 Second part of fix for bug #7072 - Accounts can't be unlocked from ldap.
Missed read of entry_timestamp (was entry->entry_timestamp).

Jeremy.
2010-01-27 16:52:40 -08:00
Jeremy Allison
627fb85092 Fix bug #7072 - Accounts can't be unlocked from ldap.
Fix suggested by Andy Hanton <andyhanton@gmail.com>. The LOGIN_CACHE
struct contains two time_t entries, but was being written to and
read from via tdb_pack/tdb_unpack functions using explicit 32-bit int specifiers.
This would break on machines with a 64-bit time_t. Use correct int
sizes for tdb_pack/tdb_unpack.

We have to fix this properly before 2037 :-).

Jeremy.
2010-01-27 16:42:06 -08:00
Björn Jacke
1f7e97a8a2 s3: syntax fix 2010-01-27 23:45:14 +01:00
Lars Müller
2f9eb6bff5 s3: Install and uninstall the static version of libwbclient
This requires to call configure with --enable-static which isn't the case
by default.
2010-01-27 22:40:19 +01:00
Björn Jacke
6bade10a1e s3: get pthread detection also on HP-UX right 2010-01-27 18:59:16 +01:00
Günther Deschner
1ead83947f s3-selftest: try to get RPC-SPOOLSS-NOTIFY running during make test on the buildfarm.
Guenther
2010-01-27 13:40:16 +01:00
Jeremy Allison
899bd0005f Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond to a read or write.
Only works on Linux kernels 2.6.26 and above. Grants CAP_KILL capability
to allow Linux threads under different euids to send signals to each other.

Jeremy.
2010-01-26 16:51:57 -08:00
Lars Müller
2dd301e5cd Add dependency of bin/smbfilter to libwbclient. 2010-01-26 22:54:15 +01:00
Volker Lendecke
08fa57335a s3: Enable use of ccache by default for libsmbclient
Disable this by setting the environment variable LIBSMBCLIENT_NO_CCACHE, which
has the advantage over an smb.conf option to be easily settable per
application.
2010-01-26 11:45:56 +01:00
Jeremy Allison
1e2e92f54d Correct fix for unused variable return from ndr_decode. Use it :-).
Jeremy.
2010-01-25 17:38:55 -08:00
Jeremy Allison
2fff1e13f1 Revert "s3: remove unused Variable"
This reverts commit 9536d94d5478b63fc05047964b40d8786a7246c4.

Bjorn, your change removed the ndr_decoding of the dos attribute.
Not a good idea :-).

Jeremy.
2010-01-25 17:06:54 -08:00
Björn Jacke
5439e1a03f s3: fix detection and flags for using pthread
I hope this fixes the build on Tru64, IRIX and maybe bug #6983
2010-01-26 00:19:10 +01:00
Björn Jacke
60a3086d78 s3: remove unused variable 2010-01-26 00:19:10 +01:00
Björn Jacke
38be40f63c s3:async_smb: remove unused variable 2010-01-26 00:19:10 +01:00
Björn Jacke
9536d94d54 s3: remove unused Variable
Jeremy, please check!
2010-01-26 00:19:10 +01:00
Björn Jacke
55d448254a s3:netapi: remove unused variable 2010-01-26 00:19:09 +01:00
Karolin Seeger
9ce9fdd9f4 s3/registry: Fix typo in comment.
Karolin
2010-01-25 19:50:21 +01:00
Volker Lendecke
2024d4fb27 Revert "s3: Make string_to_sid a wrapper around dom_sid_parse"
This reverts commit dff03b61fd5d923562711b38cc7dbe996dc07283.
2010-01-25 12:41:48 +01:00
Volker Lendecke
4eb1523d87 s3-libsmbclient: Add smbc_setOptionUseCCache()
Can we enable this by default? This would be a change in behaviour, but this
feature is just too cool for everyone to catch up in the apps.

The patch would be
2010-01-24 20:32:17 +01:00
Volker Lendecke
dc1bcec73c s3: Add --use-ccache to net 2010-01-24 20:32:17 +01:00
Volker Lendecke
aa837d4aee s3: add libnetapi_set_use_ccache() 2010-01-24 20:32:17 +01:00
Volker Lendecke
bff48738a8 s3: Fix a bug in net's use of popt
In order to add --use-ccache to net, I added another "bool opt_ccache;" to
struct net_context. popt did not like this, it took a while to figure out why.
Popt has the lines

    /* XXX Check alignment, may fail on funky platforms. */
    if (arg == NULL || (((unsigned long)arg) & (sizeof(*arg)-1)))
        return POPT_ERROR_NULLARG;

The "bool opt_ccache;" was not aligned anymore...
2010-01-24 20:32:17 +01:00
Volker Lendecke
b8996baba6 s3: Enable -C in rpcclient 2010-01-24 20:32:17 +01:00
Volker Lendecke
ca48d6ab77 s3: Add CLI_FULL_CONNECTION_USE_CCACHE 2010-01-24 20:32:17 +01:00