209 Commits

Author	SHA1	Message	Date
Jeremy Allison	dbe6ad014a	Changed ASSERT macros to SMB_ASSERT macros as some systems already ... have an ASSERT macro defined. Jeremy.	-
Andrew Tridgell	e6ce1c5b5a	added ASSERT() and ASSERT_ARRAY() macros and sprinkled them liberally ... in the rpc code.	-
Andrew Tridgell	c7ee025ead	this is the bug change to using connection_struct* instead of cnum. ... Connections[] is now a local array in server.c I might have broken something with this change. In particular the oplock code is suspect and some .dll files aren't being oplocked when I expected them to be. I'll look at it after I've got some sleep.	-
Jeremy Allison	3b8f5aef57	passdb.c ... server.c: Moved generate_machine_sid() into passdb.c for Jean-Francois (who might want an LDAP version). Changed locking to free exclusive lock as soon as possible to prevent contention. lib/rpc/parse/parse_samr.c lib/rpc/server/srv_samr.c: Changed last SID-as-string manipulation function to use DOM_SID structure. Jeremy.	-
Jeremy Allison	134d6fa79c	chgpasswd.c: Added comments to #ifdefs ... ipc.c: Caused samba password changing not to be done if UNIX password changing requested and not successful. util.c: Added string_to_sid() and sid_to_string() functions. lib/rpc/client/cli_samr.c: lib/rpc/include/rpc_misc.h: lib/rpc/parse/parse_lsa.c: lib/rpc/parse/parse_misc.c: lib/rpc/parse/parse_net.c: lib/rpc/parse/parse_samr.c: lib/rpc/server/srv_lsa.c: lib/rpc/server/srv_lsa_hnd.c: lib/rpc/server/srv_netlog.c: lib/rpc/server/srv_samr.c: lib/rpc/server/srv_util.c: Changes so that instead of passing SIDs around as char *, they are converted to DOM_SID at the earliest opportunity, and passed around as that. Also added dynamic memory allocation of group sids. Preparing to auto-generate machine sid. Jeremy.	-
Andrew Tridgell	6074d09dbf	initialise some variables (stops warning)	-
Luke Leighton	da11063cbd	function comments wrong	-
Jeremy Allison	2d77445400	This is a security audit change of the main source. ... It removed all ocurrences of the following functions : sprintf strcpy strcat The replacements are slprintf, safe_strcpy and safe_strcat. It should not be possible to use code in Samba that uses sprintf, strcpy or strcat, only the safe_equivalents. Once Andrew has fixed the slprintf implementation then this code will be moved back to the 1.9.18 code stream. Jeremy.	-
Jeremy Allison	118ba4d77a	"For I have laboured mightily on Luke's code, and hath broken ... all I saw" - the book of Jeremy, chapter 1 :-). So here is the mega-merge of the NTDOM branch server code. It doesn't include the new client side pieces, we'll look at that later. This should give the same functionality, server wise, as the NTDOM branch does, only merged into the main branch. Any fixes to domain controler functionality should be added to the main branch, not the NTDOM branch. This code compiles without warnings on gcc2.8, but will need further testing before we are sure all the working functionality of the NTDOM server branch has been correctly carried over. I hereby declare the server side of the NTDOM branch dead (and all who sail in her :-). Jeremy.	-